GNU bug report logs -
#44134
28.0.50; epa-list-keys failing with ‘wrong type argument: interger-or-marker-p, nil’
Previous Next
Reported by: Pankaj Jangid <pankaj.jangid <at> codeisgreat.com>
Date: Thu, 22 Oct 2020 07:30:02 UTC
Severity: normal
Tags: fixed
Found in version 28.0.50
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44134 in the body.
You can then email your comments to 44134 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 07:30:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Pankaj Jangid <pankaj.jangid <at> codeisgreat.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Thu, 22 Oct 2020 07:30:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Steps:
1. M-x epa-list-keys RET
⇒ (lists keys)
2. q
3. M-x epa-list-keys RET
⇒ Wrong type argument: interger-or-marker-p, nil
In GNU Emacs 28.0.50 (build 6, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.7 (Build 19H2))
of 2020-10-22 built on mb2.local
Repository revision: 8dc8ab6b42b021f9796e59cfdb758b48aaf55ffc
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description: Mac OS X 10.15.7
Configured using:
'configure LDFLAGS=-L/usr/local/opt/ruby/lib
CPPFLAGS=-I/usr/local/opt/ruby/include
PKG_CONFIG_PATH=:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/libffi/lib/pkgconfig:/usr/local/opt/ruby/lib/pkgconfig'
Configured features:
JPEG TIFF GIF PNG RSVG DBUS GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2
Important settings:
value of $LC_CTYPE: UTF-8
value of $LANG: en_IN.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr iso-transl emacsbug message rmc puny dired
dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config
gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map text-property-search
time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)
Memory information:
((conses 16 54732 6788)
(symbols 48 6814 1)
(strings 32 18175 3060)
(string-bytes 1 608370)
(vectors 16 12578)
(vector-slots 8 169348 12299)
(floats 8 21 47)
(intervals 56 213 0)
(buffers 992 11))
--
Pankaj
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 08:24:01 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
>>>>> Pankaj Jangid <pankaj.jangid <at> codeisgreat.com> writes:
> Steps: 1. M-x epa-list-keys RET ⇒ (lists keys) 2. q 3. M-x
> epa-list-keys RET ⇒ Wrong type argument: interger-or-marker-p, nil
Works for me using emacs-28.0.50 and emacs-27.1.
Best wishes
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 08:50:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 44134 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Thu, 22 Oct 2020 09:23:35 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>>>>>> Pankaj Jangid <pankaj.jangid <at> codeisgreat.com> writes:
>
> > Steps: 1. M-x epa-list-keys RET ⇒ (lists keys) 2. q 3. M-x
> > epa-list-keys RET ⇒ Wrong type argument: interger-or-marker-p, nil
>
> Works for me using emacs-28.0.50 and emacs-27.1.
It works in emacs-27 but AFAICT it cannot work with emacs -Q from
master. If you did use -Q with emacs-28, did you perhaps kill the
buffer is step 2 instead of typing `q'?
Here's a patch for master, but someone who knows epa.el well should
verify it:
[Message part 2 (text/x-patch, inline)]
diff --git a/lisp/epa.el b/lisp/epa.el
index 25e055c201..74a72ee6f8 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -360,8 +360,8 @@ epa--list-keys
;; Find the end of the documentation text at the start.
;; Set POINT to where it ends, or nil if ends at eob.
- (unless (get-text-property point 'epa-list-keys)
- (setq point (next-single-property-change point 'epa-list-keys)))
+ (unless (get-text-property point 'epa-key)
+ (setq point (next-single-property-change point 'epa-key)))
;; If caller specified documentation text for that, replace the old
;; documentation text (if any) with what was specified.
@@ -375,7 +375,7 @@ epa--list-keys
;; Now delete the key description text, if any.
(when point
(delete-region point
- (or (next-single-property-change point 'epa-list-keys)
+ (or (next-single-property-change point 'epa-key)
(point-max)))
(goto-char point))
[Message part 3 (text/plain, inline)]
Steve Berman
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 11:06:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Hello Stephen,
>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
> On Thu, 22 Oct 2020 09:23:35 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>>>>>>> Pankaj Jangid <pankaj.jangid <at> codeisgreat.com> writes:
>>
>> > Steps: 1. M-x epa-list-keys RET ⇒ (lists keys) 2. q 3. M-x >
>> epa-list-keys RET ⇒ Wrong type argument: interger-or-marker-p,
>> nil
>>
>> Works for me using emacs-28.0.50 and emacs-27.1.
> It works in emacs-27 but AFAICT it cannot work with emacs -Q from
> master.
I'm afraid emacs -Q does work for me on master. However, there is a
subtlety in that if M-x epa-list-keys <RET> is entered first, the public
keys are listed, but if entered a second time (after first entering 'q'
to remove the keys buffer) the error message
epa-list-keys: Wrong type argument: integer-or-marker-p, nil
is obtained.
Do you want me to apply your patch to see if it makes any difference?
Best wishes,
Colin Baxter.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 11:36:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 44134 <at> debbugs.gnu.org (full text, mbox):
On Thu, 22 Oct 2020 12:05:31 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
> Hello Stephen,
>>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
> > On Thu, 22 Oct 2020 09:23:35 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
> >>>>>>> Pankaj Jangid <pankaj.jangid <at> codeisgreat.com> writes:
> >>
> >> > Steps: 1. M-x epa-list-keys RET ⇒ (lists keys) 2. q 3. M-x >
> >> epa-list-keys RET ⇒ Wrong type argument: interger-or-marker-p,
> >> nil
> >>
> >> Works for me using emacs-28.0.50 and emacs-27.1.
>
> > It works in emacs-27 but AFAICT it cannot work with emacs -Q from
> > master.
>
> I'm afraid emacs -Q does work for me on master. However, there is a
> subtlety in that if M-x epa-list-keys <RET> is entered first, the public
> keys are listed, but if entered a second time (after first entering 'q'
> to remove the keys buffer) the error message
>
> epa-list-keys: Wrong type argument: integer-or-marker-p, nil
>
> is obtained.
That's precisely the bug, look closely at the above recipe again!
> Do you want me to apply your patch to see if it makes any difference?
Yes, please do.
Steve Berman
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 14:23:02 GMT)
Full text and
rfc822 format available.
Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):
>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
> On Thu, 22 Oct 2020 12:05:31 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>> Hello Stephen,
>>>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
>>
>> > On Thu, 22 Oct 2020 09:23:35 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>> >>>>>>> Pankaj Jangid <pankaj.jangid <at> codeisgreat.com> writes:
>> >>
>> >> > Steps: 1. M-x epa-list-keys RET ⇒ (lists keys) 2. q 3. M-x >
>> >> epa-list-keys RET ⇒ Wrong type argument: interger-or-marker-p,
>> >> nil
>> >>
>> >> Works for me using emacs-28.0.50 and emacs-27.1.
>>
>> > It works in emacs-27 but AFAICT it cannot work with emacs -Q
>> from > master.
>>
>> I'm afraid emacs -Q does work for me on master. However, there is
>> a subtlety in that if M-x epa-list-keys <RET> is entered first,
>> the public keys are listed, but if entered a second time (after
>> first entering 'q' to remove the keys buffer) the error message
>>
>> epa-list-keys: Wrong type argument: integer-or-marker-p, nil
>>
>> is obtained.
> That's precisely the bug, look closely at the above recipe again!
>> Do you want me to apply your patch to see if it makes any
>> difference?
> Yes, please do.
Ok, patch applied to my setup and it appears to work.
emacs -Q <RET>
M-x epa-list-keys <RET> --> keys listed
q
M-x epa-list-keys <RET> --> keys listed
repeated 2 more times> --> same outcome
repeated 2 more times using epa-list-secret-keys --> keys listed
Would it be possible to use 'q' to kill the keys-buffer rather than hide
it? That way, the buffer will not display an old duplicate listing.
Colin Baxter.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 16:02:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 44134 <at> debbugs.gnu.org (full text, mbox):
On Thu, 22 Oct 2020 15:21:54 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
[...]
> >> Do you want me to apply your patch to see if it makes any
> >> difference?
>
> > Yes, please do.
>
> Ok, patch applied to my setup and it appears to work.
Thanks for testing.
> emacs -Q <RET>
> M-x epa-list-keys <RET> --> keys listed
> q
> M-x epa-list-keys <RET> --> keys listed
> repeated 2 more times> --> same outcome
> repeated 2 more times using epa-list-secret-keys --> keys listed
>
> Would it be possible to use 'q' to kill the keys-buffer rather than hide
> it? That way, the buffer will not display an old duplicate listing.
Well, since `q' in epa-key-list-mode is bound to epa-exit-buffer, which
funcalls epa-exit-buffer-function, which is set by default to
quit-window, and the latter kills the buffer if called with a prefix
argument, you could just type `C-u q' instead of `q'. Or if you want
`q' by itself to kill the buffer, putting either of the following sexps
into your init file should do the trick.
(with-eval-after-load "epa"
(setq epa-exit-buffer-function
(lambda () (interactive) (quit-window t))))
(with-eval-after-load "epa"
(define-key epa-key-list-mode-map "q"
(lambda () (interactive) (quit-window t))))
The latter affects only epa-key-list-mode, while the former has wider
scope, since epa-exit-buffer-function is used in several places in
epa.el.
Steve Berman
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Thu, 22 Oct 2020 17:30:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 44134 <at> debbugs.gnu.org (full text, mbox):
>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
> On Thu, 22 Oct 2020 15:21:54 +0100 Colin Baxter <m43cap <at> yandex.com> wrote:
>>>>>>> Stephen Berman <stephen.berman <at> gmx.net> writes:
----------- cut ----------------
> Well, since `q' in epa-key-list-mode is bound to epa-exit-buffer,
> which funcalls epa-exit-buffer-function, which is set by default
> to quit-window, and the latter kills the buffer if called with a
> prefix argument, you could just type `C-u q' instead of `q'. Or
I had forgotten about C-u - that's the one for me.
Best wishes
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Sun, 22 Nov 2020 06:39:01 GMT)
Full text and
rfc822 format available.
Message #29 received at 44134 <at> debbugs.gnu.org (full text, mbox):
I see that the patch is working fine. But not sure what is the final
conclusion on this bug.
Once a user presses `q'. The emacs session becomes unrecoverable for
epa- afterwards. May I know what is the workaround, without quitting
emacs? I have a habbit of pressing `q' to quit all transient windows.
Regards.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Sun, 22 Nov 2020 10:18:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 44134 <at> debbugs.gnu.org (full text, mbox):
On Sun, 22 Nov 2020 12:08:24 +0530 Pankaj Jangid <pankaj <at> codeisgreat.org> wrote:
> I see that the patch is working fine. But not sure what is the final
> conclusion on this bug.
Perhaps it fell under the radar? Since I'm not familiar with epa, I
don't want to push my patch without approval from someone who is or from
an Emacs maintainer.
Steve Berman
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Mon, 23 Nov 2020 19:23:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Stephen Berman <stephen.berman <at> gmx.net> writes:
> On Sun, 22 Nov 2020 12:08:24 +0530 Pankaj Jangid <pankaj <at> codeisgreat.org> wrote:
>
>> I see that the patch is working fine. But not sure what is the final
>> conclusion on this bug.
>
> Perhaps it fell under the radar? Since I'm not familiar with epa, I
> don't want to push my patch without approval from someone who is or from
> an Emacs maintainer.
I think the problem is due to [1: 517285f7cae] (Ccing Lars who who wrote
that commit) which dropped the epa-list-keys text property from
epa--insert-keys. So it would be safer to restore that property rather
than switching to detect the epa-key property as in your patch.
[1: 517285f7cae]: 2020-08-24 21:54:56 +0200
Rewrite the epa key interface to use buttons instead of widgets
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=517285f7caed462c822c779efe14033645dccba0
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Tue, 24 Nov 2020 06:30:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Noam Postavsky <npostavs <at> gmail.com> writes:
> I think the problem is due to [1: 517285f7cae] (Ccing Lars who who wrote
> that commit) which dropped the epa-list-keys text property from
> epa--insert-keys. So it would be safer to restore that property rather
> than switching to detect the epa-key property as in your patch.
Yes, I think the property was dropped by mistake in my patch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Sat, 16 Jan 2021 07:47:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>> I think the problem is due to [1: 517285f7cae] (Ccing Lars who who wrote
>> that commit) which dropped the epa-list-keys text property from
>> epa--insert-keys. So it would be safer to restore that property rather
>> than switching to detect the epa-key property as in your patch.
>
> Yes, I think the property was dropped by mistake in my patch.
Lars, I am not sure if you have restored the changes. If you have
already done then this bug was not due to that.
I am still seeing issue. i.e. after quiting the buffer with ‘q‘ key, I
cannot list the keys with ‘M-x epa-list-keys‘ again. Same behaviour as
in my original bug-report.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Mon, 18 Jan 2021 16:32:02 GMT)
Full text and
rfc822 format available.
Message #44 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Pankaj Jangid <pankaj <at> codeisgreat.org> writes:
>>> I think the problem is due to [1: 517285f7cae] (Ccing Lars who who wrote
>>> that commit) which dropped the epa-list-keys text property from
>>> epa--insert-keys. So it would be safer to restore that property rather
>>> than switching to detect the epa-key property as in your patch.
>>
>> Yes, I think the property was dropped by mistake in my patch.
>
> Lars, I am not sure if you have restored the changes. If you have
> already done then this bug was not due to that.
No, I thought Stephen was going to apply his patch. :-) I've now
pushed it.
There's other problems here, though... you get more (repeated) keys
every time you `M-x epa-list-keys', which must be a bug. I'll look into
it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Mon, 18 Jan 2021 16:37:02 GMT)
Full text and
rfc822 format available.
Message #47 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> There's other problems here, though... you get more (repeated) keys
> every time you `M-x epa-list-keys', which must be a bug. I'll look into
> it.
Done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Mon, 18 Jan 2021 16:37:02 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to
44134 <at> debbugs.gnu.org and Pankaj Jangid <pankaj.jangid <at> codeisgreat.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Mon, 18 Jan 2021 16:37:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#44134
; Package
emacs
.
(Tue, 19 Jan 2021 04:08:02 GMT)
Full text and
rfc822 format available.
Message #54 received at 44134 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> No, I thought Stephen was going to apply his patch. :-) I've now
> pushed it.
>
> There's other problems here, though... you get more (repeated) keys
> every time you `M-x epa-list-keys', which must be a bug. I'll look into
> it.
Thanks a lot. It is working perfectly fine now. :-)
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 16 Feb 2021 12:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 122 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.