GNU bug report logs - #44129
Patch to improve valac version detection

Previous Next

Package: automake;

Reported by: Reuben Thomas <rrt <at> sc3d.org>

Date: Wed, 21 Oct 2020 22:39:02 UTC

Severity: normal

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44129: closed (Patch to improve valac version detection)
Date: Fri, 23 Oct 2020 21:42:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 23 Oct 2020 15:40:58 -0600
with message-id <202010232140.09NLewFp002843 <at> freefriends.org>
and subject line Re: bug#44129: Patch to improve valac version detection
has caused the debbugs.gnu.org bug report #44129,
regarding Patch to improve valac version detection
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44129: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44129
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-automake <bug-automake <at> gnu.org>
Subject: Patch to improve valac version detection
Date: Wed, 21 Oct 2020 23:37:51 +0100
[Message part 3 (text/plain, inline)]
Attached, a patch to improve valac version detection. The vala compiler,
valac, can report the API version it supports. For releases, this is the
same as the major & minor version of the compiler, so for example:

$ valac --version
Vala 0.48.11
$ valac --api-version
0.48

The advantage of using the API version is that it's semantically
meaningful. It's also simpler to parse! It can be to allow a 3rd-party,
patched, or unreleased compiler to be used more easily.

(For example, the current Vala git master compiler reports:

$ valac-0.52 --version
Vala 0.50.1.19-135c0
$ valac-0.52 --api-version
0.52

)

-- 
https://rrt.sc3d.org
[Message part 4 (text/html, inline)]
[0001-Improve-Vala-compiler-detection-use-API-version-not-.patch (text/x-patch, attachment)]
[Message part 6 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: rrt <at> sc3d.org
Cc: 44129 <at> debbugs.gnu.org
Subject: Re: bug#44129: Patch to improve valac version detection
Date: Fri, 23 Oct 2020 15:40:58 -0600
    I simply failed to update the test; 

I'm glad it was simple.

All the tests pass for me now, and I pushed your patch, and am closing
this bug. Thanks!


This bug report was last modified 4 years and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.