From unknown Fri Aug 15 02:05:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44129 <44129@debbugs.gnu.org> To: bug#44129 <44129@debbugs.gnu.org> Subject: Status: Patch to improve valac version detection Reply-To: bug#44129 <44129@debbugs.gnu.org> Date: Fri, 15 Aug 2025 09:05:01 +0000 retitle 44129 Patch to improve valac version detection reassign 44129 automake submitter 44129 Reuben Thomas severity 44129 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 18:38:10 2020 Received: (at submit) by debbugs.gnu.org; 21 Oct 2020 22:38:11 +0000 Received: from localhost ([127.0.0.1]:50845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVMkE-0007VS-GT for submit@debbugs.gnu.org; Wed, 21 Oct 2020 18:38:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:34772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVMkD-0007VL-2G for submit@debbugs.gnu.org; Wed, 21 Oct 2020 18:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVMkC-0007zo-0t for bug-automake@gnu.org; Wed, 21 Oct 2020 18:38:08 -0400 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:43356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVMk9-0002SQ-4X for bug-automake@gnu.org; Wed, 21 Oct 2020 18:38:07 -0400 Received: by mail-ot1-x336.google.com with SMTP id k68so3361165otk.10 for ; Wed, 21 Oct 2020 15:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=V8F2ZOeRUyFI//4IpAuwB6r3Ghr78MhvuvbCg+gT6IQ=; b=XLAsgNl08Y5M58LyQWYKhr7DUE2R225DjOEr2bdSQQNFBEXkH9xoYO0FNbLloPmO9G lUKzrs4GyjfvxgRDmYYb/+6q9S8QRGoYPM7UUEWYPkejRxfxCyjee3vrjm77vWipTvCo 3tqFy2zE0RXEDHjsICdw3o5EBNQvCbvfgxRZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=V8F2ZOeRUyFI//4IpAuwB6r3Ghr78MhvuvbCg+gT6IQ=; b=F7qnhp+6hiZJl7ZUKkZHzVuxKd80TwNuoQZOjy1eYVAsxVtM+8ErJB4BTYN+T1paGS griS78QOMZx2TfOhnLe7KCnyX3npUMh/rb6HlO7BVuK+dnozVY9uEvkr1SRGEYvOw9WB rjZJGcvzpTO6edHuNIkFRRqUTyajcP4Z29JHXUD9u0Wbx+75/PG7Gj4pQQ5FVPWXNlsG J4jSVgGSpA702JiQU47/6NcptYvMWvj1aMKGex1oMOr+6fJoQPcUCYmoPClcP5Joe0Hg 9grIe6IdLU7+vXCcSUyT+jL7iM4f4ePrTlFXbFaP1OiRLazO5vSdo6iOJlVcRv22Pd4E Rkxw== X-Gm-Message-State: AOAM531TBvOWz3H1IumA1jA6OYJRZijve/9fi97vZo5ndRm2ztL4QLlR CGvlQceEQfwuxg0v6pCVjwv6m4aL10r8g4lO/CQOfTJUA8yhBA== X-Google-Smtp-Source: ABdhPJxYgGd54GLciOxp+QJnoEiVUqk/vhQ1A45C0z1cIxFgNBB3IBbo5pWHL7lmkXDcMcPqSGrwSDCqQYUlkRr+SSw= X-Received: by 2002:a05:6830:19e1:: with SMTP id t1mr4236998ott.120.1603319882820; Wed, 21 Oct 2020 15:38:02 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Wed, 21 Oct 2020 23:37:51 +0100 Message-ID: Subject: Patch to improve valac version detection To: bug-automake Content-Type: multipart/mixed; boundary="00000000000013d82805b2360061" Received-SPF: pass client-ip=2607:f8b0:4864:20::336; envelope-from=rrt@sc3d.org; helo=mail-ot1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --00000000000013d82805b2360061 Content-Type: multipart/alternative; boundary="00000000000013d82505b236005f" --00000000000013d82505b236005f Content-Type: text/plain; charset="UTF-8" Attached, a patch to improve valac version detection. The vala compiler, valac, can report the API version it supports. For releases, this is the same as the major & minor version of the compiler, so for example: $ valac --version Vala 0.48.11 $ valac --api-version 0.48 The advantage of using the API version is that it's semantically meaningful. It's also simpler to parse! It can be to allow a 3rd-party, patched, or unreleased compiler to be used more easily. (For example, the current Vala git master compiler reports: $ valac-0.52 --version Vala 0.50.1.19-135c0 $ valac-0.52 --api-version 0.52 ) -- https://rrt.sc3d.org --00000000000013d82505b236005f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Attached, a patch to improve valac vers= ion detection. The vala compiler, valac, can report the API version it supp= orts. For releases, this is the same as the major & minor version of th= e compiler, so for example:

$ valac --version
Vala 0.48.11
$ valac --api-version
0.48

The advantage of using the API versi= on is that it's semantically meaningful. It's also simpler to pars= e! It can be to allow a 3rd-party, patched, or unreleased compiler to be us= ed more easily.

(For e= xample, the current Vala git master compiler reports:

$ valac-0.52 --version
Vala 0.50.1.19-13= 5c0
$ valac-0.52 --api-version
0.52

)
--
=
--00000000000013d82505b236005f-- --00000000000013d82805b2360061 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improve-Vala-compiler-detection-use-API-version-not-.patch" Content-Disposition: attachment; filename="0001-Improve-Vala-compiler-detection-use-API-version-not-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgjz91t50 RnJvbSAzY2I0MjUyZGQ4ZTE4MmJhYjVmNDg0ZDNhOGRkN2E5NmY2ZGEyMTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjEgT2N0IDIwMjAgMjM6MzE6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSBJbXByb3ZlIFZh bGEgY29tcGlsZXIgZGV0ZWN0aW9uOiB1c2UgQVBJIHZlcnNpb24sIG5vdAogY29tcGlsZXIgdmVy c2lvbgoKKiBtNC92YWxhLm00OiBjaGVjayBgdmFsYWMgLS1hcGktdmVyc2lvbicsIG5vdCBgdmFs YWMgLS12ZXJzaW9uJy4KKiBkb2MvYXV0b21ha2UudGV4aTogdXBkYXRlIGRvY3VtZW50YXRpb24u Ci0tLQogZG9jL2F1dG9tYWtlLnRleGkgfCAxNSArKysrKysrKystLS0tLS0KIG00L3ZhbGEubTQg ICAgICAgIHwgMjggKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAyNCBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvYXV0 b21ha2UudGV4aSBiL2RvYy9hdXRvbWFrZS50ZXhpCmluZGV4IDkxZTFkNjc5YS4uZGJlYWYwMWY1 IDEwMDY0NAotLS0gYS9kb2MvYXV0b21ha2UudGV4aQorKysgYi9kb2MvYXV0b21ha2UudGV4aQpA QCAtNjk2OSwxMiArNjk2OSwxNSBAQCBudW1iZXIuCiBTZWFyY2ggZm9yIGEgVmFsYSBjb21waWxl ciBpbiBAZW52e1BBVEh9LiAgSWYgaXQgaXMgZm91bmQsIHRoZSB2YXJpYWJsZQogQGNvZGV7VkFM QUN9IGlzIHNldCB0byBwb2ludCB0byBpdCAoc2VlIGJlbG93IGZvciBtb3JlIGRldGFpbHMpLiAg VGhpcwogbWFjcm8gdGFrZXMgdGhyZWUgb3B0aW9uYWwgYXJndW1lbnRzLiAgVGhlIGZpcnN0IGFy Z3VtZW50LCBpZiBwcmVzZW50LAotaXMgdGhlIG1pbmltdW0gdmVyc2lvbiBvZiB0aGUgVmFsYSBj b21waWxlciByZXF1aXJlZCB0byBjb21waWxlIHRoaXMKLXBhY2thZ2UuICBJZiBhIGNvbXBpbGVy IGlzIGZvdW5kIGFuZCBzYXRpc2ZpZXMgQHZhcnttaW5pbXVtLXZlcnNpb259LAotdGhlbiBAdmFy e2FjdGlvbi1pZi1mb3VuZH0gaXMgcnVuICh0aGlzIGRlZmF1bHRzIHRvIGRvIG5vdGhpbmcpLgot T3RoZXJ3aXNlLCBAdmFye2FjdGlvbi1pZi1ub3QtZm91bmR9IGlzIHJ1bi4gIElmIEB2YXJ7YWN0 aW9uLWlmLW5vdC1mb3VuZH0KLWlzIG5vdCBzcGVjaWZpZWQsIHRoZSBkZWZhdWx0IHZhbHVlIGlz IHRvIHByaW50IGEgd2FybmluZyBpbiBjYXNlIG5vCi1jb21waWxlciBpcyBmb3VuZCwgb3IgaWYg YSB0b28tb2xkIHZlcnNpb24gb2YgdGhlIGNvbXBpbGVyIGlzIGZvdW5kLgoraXMgdGhlIG1pbmlt dW0gdmVyc2lvbiBvZiB0aGUgVmFsYSBBUEkgcmVxdWlyZWQgdG8gY29tcGlsZSB0aGlzIHBhY2th Z2UuCitGb3IgVmFsYSByZWxlYXNlcywgdGhpcyBpcyB0aGUgc2FtZSBhcyB0aGUgbWFqb3IgYW5k IG1pbm9yIHJlbGVhc2UKK251bWJlcjsgZS5nLiwgd2hlbiBAY29kZXt2YWxhYyAtLXZlcnNpb259 IHJlcG9ydHMgQGNvZGV7MC40OC43fSwKK0Bjb2Rle3ZhbGFjIC0tYXBpLXZlcnNpb259IHJlcG9y dHMgQGNvZGV7MC40OH0uICBJZiBhIGNvbXBpbGVyIGlzIGZvdW5kCithbmQgc2F0aXNmaWVzIEB2 YXJ7bWluaW11bS12ZXJzaW9ufSwgdGhlbiBAdmFye2FjdGlvbi1pZi1mb3VuZH0gaXMgcnVuCiso dGhpcyBkZWZhdWx0cyB0byBkbyBub3RoaW5nKS4gIE90aGVyd2lzZSwgQHZhcnthY3Rpb24taWYt bm90LWZvdW5kfSBpcworcnVuLiAgSWYgQHZhcnthY3Rpb24taWYtbm90LWZvdW5kfSBpcyBub3Qg c3BlY2lmaWVkLCB0aGUgZGVmYXVsdCB2YWx1ZQoraXMgdG8gcHJpbnQgYSB3YXJuaW5nIGluIGNh c2Ugbm8gY29tcGlsZXIgaXMgZm91bmQsIG9yIGlmIGEgdG9vLW9sZAordmVyc2lvbiBvZiB0aGUg Y29tcGlsZXIgaXMgZm91bmQuCiBAZW5kIGRlZm1hYwogCiBUaGVyZSBhcmUgYSBmZXcgdmFyaWFi bGVzIHRoYXQgYXJlIHVzZWQgd2hlbiBjb21waWxpbmcgVmFsYSBzb3VyY2VzOgpkaWZmIC0tZ2l0 IGEvbTQvdmFsYS5tNCBiL200L3ZhbGEubTQKaW5kZXggNzU5MDYxZGMwLi41MDk5MDRiMTEgMTAw NjQ0Ci0tLSBhL200L3ZhbGEubTQKKysrIGIvbTQvdmFsYS5tNApAQCAtNiwyMyArNiwyNSBAQAog IyBnaXZlcyB1bmxpbWl0ZWQgcGVybWlzc2lvbiB0byBjb3B5IGFuZC9vciBkaXN0cmlidXRlIGl0 LAogIyB3aXRoIG9yIHdpdGhvdXQgbW9kaWZpY2F0aW9ucywgYXMgbG9uZyBhcyB0aGlzIG5vdGlj ZSBpcyBwcmVzZXJ2ZWQuCiAKLSMgQ2hlY2sgd2hldGhlciB0aGUgVmFsYSBjb21waWxlciBleGlz dHMgaW4gJFBBVEguICBJZiBpdCBpcyBmb3VuZCwgdGhlCi0jIHZhcmlhYmxlIFZBTEFDIGlzIHNl dCBwb2ludGluZyB0byBpdHMgYWJzb2x1dGUgcGF0aC4gIE90aGVyd2lzZSwgaXQgaXMKLSMgc2lt cGx5IHNldCB0byAndmFsYWMnLgotIyBPcHRpb25hbGx5IGEgbWluaW11bSByZWxlYXNlIG51bWJl ciBvZiB0aGUgY29tcGlsZXIgY2FuIGJlIHJlcXVlc3RlZC4KLSMgSWYgdGhlIEFDVElPTi1JRi1G T1VORCBwYXJhbWV0ZXIgaXMgZ2l2ZW4sIGl0IHdpbGwgYmUgcnVuIGlmIGEgcHJvcGVyCi0jIFZh bGEgY29tcGlsZXIgaXMgZm91bmQuCi0jIFNpbWlsYXJseSwgaWYgdGhlIEFDVElPTi1JRi1GT1VO RCBpcyBnaXZlbiwgaXQgd2lsbCBiZSBydW4gaWYgbm8gcHJvcGVyCi0jIFZhbGEgY29tcGlsZXIg aXMgZm91bmQuICBJdCBkZWZhdWx0cyB0byBzaW1wbHkgcHJpbnQgYSB3YXJuaW5nIGFib3V0IHRo ZQotIyBzaXR1YXRpb24sIGJ1dCBvdGhlcndpc2UgcHJvY2VlZGluZyB3aXRoIHRoZSBjb25maWd1 cmF0aW9uLgorIyBTZWFyY2ggZm9yIGEgVmFsYSBjb21waWxlciBpbiBQQVRILiAgSWYgaXQgaXMg Zm91bmQsIHRoZSB2YXJpYWJsZSBWQUxBQyBpcworIyBzZXQgdG8gcG9pbnQgdG8gaXQuICBPdGhl cndpc2UsIGl0IGlzIHNpbXBseSBzZXQgdG8gJ3ZhbGFjJy4gIFRoaXMgbWFjcm8KKyMgdGFrZXMg dGhyZWUgb3B0aW9uYWwgYXJndW1lbnRzLiAgVGhlIGZpcnN0IGFyZ3VtZW50LCBpZiBwcmVzZW50 LCBpcyB0aGUKKyMgbWluaW11bSB2ZXJzaW9uIG9mIHRoZSBWYWxhIEFQSSByZXF1aXJlZCB0byBj b21waWxlIHRoaXMgcGFja2FnZS4gIEZvciBWYWxhCisjIHJlbGVhc2VzLCB0aGlzIGlzIHRoZSBz YW1lIGFzIHRoZSBtYWpvciBhbmQgbWlub3IgcmVsZWFzZSBudW1iZXI7IGUuZy4sIHdoZW4KKyMg YHZhbGFjIC0tdmVyc2lvbicgcmVwb3J0cyAwLjQ4LjcsIGB2YWxhYyAtLWFwaS12ZXJzaW9uJyBy ZXBvcnRzIDAuNDguICBJZiBhCisjIGNvbXBpbGVyIGlzIGZvdW5kIGFuZCBzYXRpc2ZpZXMgTUlO SU1VTS1WRVJTSU9OLCB0aGVuIEFDVElPTi1JRi1GT1VORCBpcyBydW4KKyMgKHRoaXMgZGVmYXVs dHMgdG8gZG8gbm90aGluZykuICBPdGhlcndpc2UsIEFDVElPTi1JRi1OT1QtRk9VTkQgaXMgcnVu LiAgSWYKKyMgQUNUSU9OLUlGLU5PVC1GT1VORCBpcyBub3Qgc3BlY2lmaWVkLCB0aGUgZGVmYXVs dCB2YWx1ZSBpcyB0byBwcmludCBhCisjIHdhcm5pbmcgaW4gY2FzZSBubyBjb21waWxlciBpcyBm b3VuZCwgb3IgaWYgYSB0b28tb2xkIHZlcnNpb24gb2YgdGhlCisjIGNvbXBpbGVyIGlzIGZvdW5k LgogIwogIyBBTV9QUk9HX1ZBTEFDKFtNSU5JTVVNLVZFUlNJT05dLCBbQUNUSU9OLUlGLUZPVU5E XSwgW0FDVElPTi1JRi1OT1QtRk9VTkRdKQogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogQUNfREVGVU4o W0FNX1BST0dfVkFMQUNdLAogICBbQUNfUEFUSF9QUk9HKFtWQUxBQ10sIFt2YWxhY10sIFt2YWxh Y10pCiAgICBBU19JRihbdGVzdCAiJFZBTEFDIiAhPSB2YWxhYyAmJiB0ZXN0IC1uICIkMSJdLAot ICAgICAgW0FDX01TR19DSEVDS0lORyhbd2hldGhlciAkVkFMQUMgaXMgYXQgbGVhc3QgdmVyc2lv biAkMV0pCi0gICAgICAgYW1fX3ZhbGFfdmVyc2lvbj1gJFZBTEFDIC0tdmVyc2lvbiB8IHNlZCAn cy9WYWxhICAqLy8nYAorICAgICAgW0FDX01TR19DSEVDS0lORyhbd2hldGhlciAkVkFMQUMgc3Vw cG9ydHMgYXQgbGVhc3QgQVBJIHZlcnNpb24gJDFdKQorICAgICAgIGFtX192YWxhX3ZlcnNpb249 YCRWQUxBQyAtLWFwaS12ZXJzaW9uYAogICAgICAgIEFTX1ZFUlNJT05fQ09NUEFSRShbJDFdLCBb IiRhbV9fdmFsYV92ZXJzaW9uIl0sCiAgICAgICAgICBbQUNfTVNHX1JFU1VMVChbeWVzXSldLAog ICAgICAgICAgW0FDX01TR19SRVNVTFQoW3llc10pXSwKQEAgLTMwLDggKzMyLDggQEAgQUNfREVG VU4oW0FNX1BST0dfVkFMQUNdLAogICAgICAgICAgIFZBTEFDPXZhbGFjXSldKQogICAgIGlmIHRl c3QgIiRWQUxBQyIgPSB2YWxhYzsgdGhlbgogICAgICAgbTRfZGVmYXVsdChbJDNdLAotICAgICAg ICBbQUNfTVNHX1dBUk4oW25vIHByb3BlciB2YWxhIGNvbXBpbGVyIGZvdW5kXSkKLSAgICAgICAg IEFDX01TR19XQVJOKFt5b3Ugd2lsbCBub3QgYmUgYWJsZSB0byBjb21waWxlIHZhbGEgc291cmNl IGZpbGVzXSldKQorICAgICAgICBbQUNfTVNHX1dBUk4oW1ZhbGEgY29tcGlsZXIgbm90IGZvdW5k IG9yIHRvbyBvbGRdKQorICAgICAgICAgQUNfTVNHX1dBUk4oW3lvdSB3aWxsIG5vdCBiZSBhYmxl IHRvIGNvbXBpbGUgVmFsYSBzb3VyY2UgZmlsZXNdKV0pCiAgICAgZWxzZQogICAgICAgbTRfZGVm YXVsdChbJDJdLCBbOl0pCiAgICAgZmldKQotLSAKMi4yNS4xCgo= --00000000000013d82805b2360061-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 09:51:35 2020 Received: (at 44129) by debbugs.gnu.org; 23 Oct 2020 13:51:35 +0000 Received: from localhost ([127.0.0.1]:56380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVxTj-0006qA-Bo for submit@debbugs.gnu.org; Fri, 23 Oct 2020 09:51:35 -0400 Received: from freefriends.org ([96.88.95.60]:41634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVxTg-0006q0-0F for 44129@debbugs.gnu.org; Fri, 23 Oct 2020 09:51:33 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 09NDpUbv004692 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Oct 2020 07:51:31 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 09NDpU8o004691; Fri, 23 Oct 2020 07:51:30 -0600 Date: Fri, 23 Oct 2020 07:51:30 -0600 Message-Id: <202010231351.09NDpU8o004691@freefriends.org> From: Karl Berry To: rrt@sc3d.org Subject: Re: bug#44129: Patch to improve valac version detection In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44129 Cc: 44129@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) $ valac --api-version 0.48 Thanks Reuben. Unfortunately, when I install this patch, the t/vala-configure.sh test fails for me with: configure: WARNING: Vala compiler not found or too old configure: WARNING: you will not be able to compile Vala source files I'm using CentOS 7, which reports: $ vala --version Vala 0.40.8 $ valac --api-version 0.40 In any event, the test should not fail. It passed for me before the patch. I hope you can look into this (and that it's easy)? --thanks, karl. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 12:53:33 2020 Received: (at 44129) by debbugs.gnu.org; 23 Oct 2020 16:53:33 +0000 Received: from localhost ([127.0.0.1]:58102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW0Jo-0007k8-VF for submit@debbugs.gnu.org; Fri, 23 Oct 2020 12:53:33 -0400 Received: from mail-ot1-f46.google.com ([209.85.210.46]:46008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW0Jk-0007js-B1 for 44129@debbugs.gnu.org; Fri, 23 Oct 2020 12:53:31 -0400 Received: by mail-ot1-f46.google.com with SMTP id f37so1940783otf.12 for <44129@debbugs.gnu.org>; Fri, 23 Oct 2020 09:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rJ+0zKCmN5QhD69j6M+1Zgnf1StSFqAJiLQo+i16Y5Q=; b=Od0TL6zJmOPXbsaQvJQW7/fB36hNJVgQDAJxD/mtCwprQuEVvVjmWMzpjutpNnGoqE X8TW1OHiAuTOj3tfhq9Z9O/HPiQLsYuRSO2Av+GUYAQ7OU9rbrBgo/dVwDnx8UVAUpfx yJh/OJAnJXh3e5fk59FmLNcTURHaCWaoKGhQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rJ+0zKCmN5QhD69j6M+1Zgnf1StSFqAJiLQo+i16Y5Q=; b=SRbAlwx8Z3eV9Wd1Vd4mRjgUem0Tr3AjCkBOYwqiRFKYJrfScfNiT/D/BQsMERhKDG VVwFN7fCnaNmdYVyFd7Hwb8ClBppbNfGxIZUmYW8NbqToo8cn8hgDbje8ubAH0i2J7W5 C+eHg5qVwoJnt8bRo7xunvoYFJ3nFBraI54gqwmZlH+usAVAVo5o2sL8fVEzO1Pzq8lr N3y1E4Ou7XEc8/YUPg3+rfk9k7rOvw14XBu/8qQ8JwuiYx9T6aUoDuuhl1rI5g3Fs9d2 3F0m3YXpKteWbA/jPDfj6UsIpvq7eGKYBhkjP77+GTReB0hvlcS5Lyb+cMl8VL51TPd/ qsGQ== X-Gm-Message-State: AOAM533bt+ARSlJXosBBPPcyIxhk/fdoLMqGhOFNHfrB1Okx/uNkUk+p NqA1ifhjJh4u5KRUfXAvGVz8+SW9eQV/BpjerEeKZQ== X-Google-Smtp-Source: ABdhPJwVevZY3CzvAWpftR0zD3Jrk+QYtCQl5NhVYAxohQPUmR724uwfd5UCQDPO9PU/PG0/dBNc89WwZ3/wetNo7as= X-Received: by 2002:a05:6830:2255:: with SMTP id t21mr2447485otd.120.1603472002470; Fri, 23 Oct 2020 09:53:22 -0700 (PDT) MIME-Version: 1.0 References: <202010231351.09NDpU8o004691@freefriends.org> In-Reply-To: <202010231351.09NDpU8o004691@freefriends.org> From: Reuben Thomas Date: Fri, 23 Oct 2020 17:53:11 +0100 Message-ID: Subject: Re: bug#44129: Patch to improve valac version detection To: Karl Berry Content-Type: multipart/mixed; boundary="0000000000001d88b205b2596ba2" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44129 Cc: 44129@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001d88b205b2596ba2 Content-Type: multipart/alternative; boundary="0000000000001d88b005b2596ba0" --0000000000001d88b005b2596ba0 Content-Type: text/plain; charset="UTF-8" Sorry, I simply failed to update the test; I noticed a failure message, and didn't understand it. Simply lack of effort on my part, apologies. I attach an updated patch, which now also patches the test to account for the new mode of operation (checking --api-version not --version) and updated error message in case of failure. --0000000000001d88b005b2596ba0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I simply failed to update t= he test; I noticed a failure message, and didn't understand it. Simply = lack of effort on my part, apologies.

I attach an updated patch, which now also patches the test = to account for the new mode of operation (checking --api-version not --vers= ion) and updated error message in case of failure.

--0000000000001d88b005b2596ba0-- --0000000000001d88b205b2596ba2 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Improve-Vala-compiler-detection-use-API-version-not-.patch" Content-Disposition: attachment; filename="0001-Improve-Vala-compiler-detection-use-API-version-not-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgmhti100 RnJvbSAwYjZmZWNmMzE2YjcyOTNiN2VhNjZmYmNkZWI5ZjcxM2RjZGFiNGUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFdl ZCwgMjEgT2N0IDIwMjAgMjM6MzE6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSBJbXByb3ZlIFZh bGEgY29tcGlsZXIgZGV0ZWN0aW9uOiB1c2UgQVBJIHZlcnNpb24sIG5vdAogY29tcGlsZXIgdmVy c2lvbgoKKiBtNC92YWxhLm00OiBjaGVjayBgdmFsYWMgLS1hcGktdmVyc2lvbicsIG5vdCBgdmFs YWMgLS12ZXJzaW9uJy4KKiBkb2MvYXV0b21ha2UudGV4aTogdXBkYXRlIGRvY3VtZW50YXRpb24u Ci0tLQogZG9jL2F1dG9tYWtlLnRleGkgICB8IDE1ICsrKysrKysrKy0tLS0tLQogbTQvdmFsYS5t NCAgICAgICAgICB8IDI4ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIHQvdmFsYS1jb25m aWd1cmUuc2ggfCAxMCArKysrKysrKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMo KyksIDIxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9hdXRvbWFrZS50ZXhpIGIvZG9j L2F1dG9tYWtlLnRleGkKaW5kZXggOTFlMWQ2NzlhLi5kYmVhZjAxZjUgMTAwNjQ0Ci0tLSBhL2Rv Yy9hdXRvbWFrZS50ZXhpCisrKyBiL2RvYy9hdXRvbWFrZS50ZXhpCkBAIC02OTY5LDEyICs2OTY5 LDE1IEBAIG51bWJlci4KIFNlYXJjaCBmb3IgYSBWYWxhIGNvbXBpbGVyIGluIEBlbnZ7UEFUSH0u ICBJZiBpdCBpcyBmb3VuZCwgdGhlIHZhcmlhYmxlCiBAY29kZXtWQUxBQ30gaXMgc2V0IHRvIHBv aW50IHRvIGl0IChzZWUgYmVsb3cgZm9yIG1vcmUgZGV0YWlscykuICBUaGlzCiBtYWNybyB0YWtl cyB0aHJlZSBvcHRpb25hbCBhcmd1bWVudHMuICBUaGUgZmlyc3QgYXJndW1lbnQsIGlmIHByZXNl bnQsCi1pcyB0aGUgbWluaW11bSB2ZXJzaW9uIG9mIHRoZSBWYWxhIGNvbXBpbGVyIHJlcXVpcmVk IHRvIGNvbXBpbGUgdGhpcwotcGFja2FnZS4gIElmIGEgY29tcGlsZXIgaXMgZm91bmQgYW5kIHNh dGlzZmllcyBAdmFye21pbmltdW0tdmVyc2lvbn0sCi10aGVuIEB2YXJ7YWN0aW9uLWlmLWZvdW5k fSBpcyBydW4gKHRoaXMgZGVmYXVsdHMgdG8gZG8gbm90aGluZykuCi1PdGhlcndpc2UsIEB2YXJ7 YWN0aW9uLWlmLW5vdC1mb3VuZH0gaXMgcnVuLiAgSWYgQHZhcnthY3Rpb24taWYtbm90LWZvdW5k fQotaXMgbm90IHNwZWNpZmllZCwgdGhlIGRlZmF1bHQgdmFsdWUgaXMgdG8gcHJpbnQgYSB3YXJu aW5nIGluIGNhc2Ugbm8KLWNvbXBpbGVyIGlzIGZvdW5kLCBvciBpZiBhIHRvby1vbGQgdmVyc2lv biBvZiB0aGUgY29tcGlsZXIgaXMgZm91bmQuCitpcyB0aGUgbWluaW11bSB2ZXJzaW9uIG9mIHRo ZSBWYWxhIEFQSSByZXF1aXJlZCB0byBjb21waWxlIHRoaXMgcGFja2FnZS4KK0ZvciBWYWxhIHJl bGVhc2VzLCB0aGlzIGlzIHRoZSBzYW1lIGFzIHRoZSBtYWpvciBhbmQgbWlub3IgcmVsZWFzZQor bnVtYmVyOyBlLmcuLCB3aGVuIEBjb2Rle3ZhbGFjIC0tdmVyc2lvbn0gcmVwb3J0cyBAY29kZXsw LjQ4Ljd9LAorQGNvZGV7dmFsYWMgLS1hcGktdmVyc2lvbn0gcmVwb3J0cyBAY29kZXswLjQ4fS4g IElmIGEgY29tcGlsZXIgaXMgZm91bmQKK2FuZCBzYXRpc2ZpZXMgQHZhcnttaW5pbXVtLXZlcnNp b259LCB0aGVuIEB2YXJ7YWN0aW9uLWlmLWZvdW5kfSBpcyBydW4KKyh0aGlzIGRlZmF1bHRzIHRv IGRvIG5vdGhpbmcpLiAgT3RoZXJ3aXNlLCBAdmFye2FjdGlvbi1pZi1ub3QtZm91bmR9IGlzCity dW4uICBJZiBAdmFye2FjdGlvbi1pZi1ub3QtZm91bmR9IGlzIG5vdCBzcGVjaWZpZWQsIHRoZSBk ZWZhdWx0IHZhbHVlCitpcyB0byBwcmludCBhIHdhcm5pbmcgaW4gY2FzZSBubyBjb21waWxlciBp cyBmb3VuZCwgb3IgaWYgYSB0b28tb2xkCit2ZXJzaW9uIG9mIHRoZSBjb21waWxlciBpcyBmb3Vu ZC4KIEBlbmQgZGVmbWFjCiAKIFRoZXJlIGFyZSBhIGZldyB2YXJpYWJsZXMgdGhhdCBhcmUgdXNl ZCB3aGVuIGNvbXBpbGluZyBWYWxhIHNvdXJjZXM6CmRpZmYgLS1naXQgYS9tNC92YWxhLm00IGIv bTQvdmFsYS5tNAppbmRleCA3NTkwNjFkYzAuLjUwOTkwNGIxMSAxMDA2NDQKLS0tIGEvbTQvdmFs YS5tNAorKysgYi9tNC92YWxhLm00CkBAIC02LDIzICs2LDI1IEBACiAjIGdpdmVzIHVubGltaXRl ZCBwZXJtaXNzaW9uIHRvIGNvcHkgYW5kL29yIGRpc3RyaWJ1dGUgaXQsCiAjIHdpdGggb3Igd2l0 aG91dCBtb2RpZmljYXRpb25zLCBhcyBsb25nIGFzIHRoaXMgbm90aWNlIGlzIHByZXNlcnZlZC4K IAotIyBDaGVjayB3aGV0aGVyIHRoZSBWYWxhIGNvbXBpbGVyIGV4aXN0cyBpbiAkUEFUSC4gIElm IGl0IGlzIGZvdW5kLCB0aGUKLSMgdmFyaWFibGUgVkFMQUMgaXMgc2V0IHBvaW50aW5nIHRvIGl0 cyBhYnNvbHV0ZSBwYXRoLiAgT3RoZXJ3aXNlLCBpdCBpcwotIyBzaW1wbHkgc2V0IHRvICd2YWxh YycuCi0jIE9wdGlvbmFsbHkgYSBtaW5pbXVtIHJlbGVhc2UgbnVtYmVyIG9mIHRoZSBjb21waWxl ciBjYW4gYmUgcmVxdWVzdGVkLgotIyBJZiB0aGUgQUNUSU9OLUlGLUZPVU5EIHBhcmFtZXRlciBp cyBnaXZlbiwgaXQgd2lsbCBiZSBydW4gaWYgYSBwcm9wZXIKLSMgVmFsYSBjb21waWxlciBpcyBm b3VuZC4KLSMgU2ltaWxhcmx5LCBpZiB0aGUgQUNUSU9OLUlGLUZPVU5EIGlzIGdpdmVuLCBpdCB3 aWxsIGJlIHJ1biBpZiBubyBwcm9wZXIKLSMgVmFsYSBjb21waWxlciBpcyBmb3VuZC4gIEl0IGRl ZmF1bHRzIHRvIHNpbXBseSBwcmludCBhIHdhcm5pbmcgYWJvdXQgdGhlCi0jIHNpdHVhdGlvbiwg YnV0IG90aGVyd2lzZSBwcm9jZWVkaW5nIHdpdGggdGhlIGNvbmZpZ3VyYXRpb24uCisjIFNlYXJj aCBmb3IgYSBWYWxhIGNvbXBpbGVyIGluIFBBVEguICBJZiBpdCBpcyBmb3VuZCwgdGhlIHZhcmlh YmxlIFZBTEFDIGlzCisjIHNldCB0byBwb2ludCB0byBpdC4gIE90aGVyd2lzZSwgaXQgaXMgc2lt cGx5IHNldCB0byAndmFsYWMnLiAgVGhpcyBtYWNybworIyB0YWtlcyB0aHJlZSBvcHRpb25hbCBh cmd1bWVudHMuICBUaGUgZmlyc3QgYXJndW1lbnQsIGlmIHByZXNlbnQsIGlzIHRoZQorIyBtaW5p bXVtIHZlcnNpb24gb2YgdGhlIFZhbGEgQVBJIHJlcXVpcmVkIHRvIGNvbXBpbGUgdGhpcyBwYWNr YWdlLiAgRm9yIFZhbGEKKyMgcmVsZWFzZXMsIHRoaXMgaXMgdGhlIHNhbWUgYXMgdGhlIG1ham9y IGFuZCBtaW5vciByZWxlYXNlIG51bWJlcjsgZS5nLiwgd2hlbgorIyBgdmFsYWMgLS12ZXJzaW9u JyByZXBvcnRzIDAuNDguNywgYHZhbGFjIC0tYXBpLXZlcnNpb24nIHJlcG9ydHMgMC40OC4gIElm IGEKKyMgY29tcGlsZXIgaXMgZm91bmQgYW5kIHNhdGlzZmllcyBNSU5JTVVNLVZFUlNJT04sIHRo ZW4gQUNUSU9OLUlGLUZPVU5EIGlzIHJ1bgorIyAodGhpcyBkZWZhdWx0cyB0byBkbyBub3RoaW5n KS4gIE90aGVyd2lzZSwgQUNUSU9OLUlGLU5PVC1GT1VORCBpcyBydW4uICBJZgorIyBBQ1RJT04t SUYtTk9ULUZPVU5EIGlzIG5vdCBzcGVjaWZpZWQsIHRoZSBkZWZhdWx0IHZhbHVlIGlzIHRvIHBy aW50IGEKKyMgd2FybmluZyBpbiBjYXNlIG5vIGNvbXBpbGVyIGlzIGZvdW5kLCBvciBpZiBhIHRv by1vbGQgdmVyc2lvbiBvZiB0aGUKKyMgY29tcGlsZXIgaXMgZm91bmQuCiAjCiAjIEFNX1BST0df VkFMQUMoW01JTklNVU0tVkVSU0lPTl0sIFtBQ1RJT04tSUYtRk9VTkRdLCBbQUNUSU9OLUlGLU5P VC1GT1VORF0pCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiBBQ19ERUZVTihbQU1fUFJPR19WQUxBQ10s CiAgIFtBQ19QQVRIX1BST0coW1ZBTEFDXSwgW3ZhbGFjXSwgW3ZhbGFjXSkKICAgIEFTX0lGKFt0 ZXN0ICIkVkFMQUMiICE9IHZhbGFjICYmIHRlc3QgLW4gIiQxIl0sCi0gICAgICBbQUNfTVNHX0NI RUNLSU5HKFt3aGV0aGVyICRWQUxBQyBpcyBhdCBsZWFzdCB2ZXJzaW9uICQxXSkKLSAgICAgICBh bV9fdmFsYV92ZXJzaW9uPWAkVkFMQUMgLS12ZXJzaW9uIHwgc2VkICdzL1ZhbGEgICovLydgCisg ICAgICBbQUNfTVNHX0NIRUNLSU5HKFt3aGV0aGVyICRWQUxBQyBzdXBwb3J0cyBhdCBsZWFzdCBB UEkgdmVyc2lvbiAkMV0pCisgICAgICAgYW1fX3ZhbGFfdmVyc2lvbj1gJFZBTEFDIC0tYXBpLXZl cnNpb25gCiAgICAgICAgQVNfVkVSU0lPTl9DT01QQVJFKFskMV0sIFsiJGFtX192YWxhX3ZlcnNp b24iXSwKICAgICAgICAgIFtBQ19NU0dfUkVTVUxUKFt5ZXNdKV0sCiAgICAgICAgICBbQUNfTVNH X1JFU1VMVChbeWVzXSldLApAQCAtMzAsOCArMzIsOCBAQCBBQ19ERUZVTihbQU1fUFJPR19WQUxB Q10sCiAgICAgICAgICAgVkFMQUM9dmFsYWNdKV0pCiAgICAgaWYgdGVzdCAiJFZBTEFDIiA9IHZh bGFjOyB0aGVuCiAgICAgICBtNF9kZWZhdWx0KFskM10sCi0gICAgICAgIFtBQ19NU0dfV0FSTihb bm8gcHJvcGVyIHZhbGEgY29tcGlsZXIgZm91bmRdKQotICAgICAgICAgQUNfTVNHX1dBUk4oW3lv dSB3aWxsIG5vdCBiZSBhYmxlIHRvIGNvbXBpbGUgdmFsYSBzb3VyY2UgZmlsZXNdKV0pCisgICAg ICAgIFtBQ19NU0dfV0FSTihbVmFsYSBjb21waWxlciBub3QgZm91bmQgb3IgdG9vIG9sZF0pCisg ICAgICAgICBBQ19NU0dfV0FSTihbeW91IHdpbGwgbm90IGJlIGFibGUgdG8gY29tcGlsZSBWYWxh IHNvdXJjZSBmaWxlc10pXSkKICAgICBlbHNlCiAgICAgICBtNF9kZWZhdWx0KFskMl0sIFs6XSkK ICAgICBmaV0pCmRpZmYgLS1naXQgYS90L3ZhbGEtY29uZmlndXJlLnNoIGIvdC92YWxhLWNvbmZp Z3VyZS5zaAppbmRleCAxMWJjY2Q1ZjMuLmVhNDZhY2M4NCAxMDA2NDQKLS0tIGEvdC92YWxhLWNv bmZpZ3VyZS5zaAorKysgYi90L3ZhbGEtY29uZmlndXJlLnNoCkBAIC0zNyw2ICszNyw5IEBAIGNh dCA+IGJpbi92YWxhYyA8PCAnRU5EJwogaWYgdGVzdCAieCQxIiA9IHgtLXZlcnNpb247IHRoZW4K ICAgZWNobyAiJHt2YWxhX3ZlcnNpb24tMS4yLjN9IgogZmkKK2lmIHRlc3QgIngkMSIgPSB4LS1h cGktdmVyc2lvbjsgdGhlbgorICBlY2hvICIke3ZhbGFfdmVyc2lvbi0xLjIuM30iCitmaQogZXhp dCAwCiBFTkQKIGNobW9kICt4IGJpbi92YWxhYwpAQCAtNDYsNiArNDksOSBAQCBjYXQgPiBiaW4v dmFsYWMub2xkIDw8ICdFTkQnCiBpZiB0ZXN0ICJ4JDEiID0geC0tdmVyc2lvbjsgdGhlbgogICBl Y2hvIDAuMQogZmkKK2lmIHRlc3QgIngkMSIgPSB4LS1hcGktdmVyc2lvbjsgdGhlbgorICBlY2hv IDAuMQorZmkKIGV4aXQgMAogRU5ECiBjaG1vZCAreCBiaW4vdmFsYWMub2xkCkBAIC03NCwxMyAr ODAsMTMgQEAgJE1BS0UgaGFzLXZhbGFjCiBzdD0wOyB2YWxhX3ZlcnNpb249MC4xLjIgLi9jb25m aWd1cmUgMj5zdGRlcnIgfHwgc3Q9JD8KIGNhdCBzdGRlcnIgPiYyCiB0ZXN0ICRzdCAtZXEgMAot Z3JlcCAnXmNvbmZpZ3VyZTogV0FSTklORzogbm8gcHJvcGVyIHZhbGEgY29tcGlsZXIgZm91bmQn IHN0ZGVycgorZ3JlcCAnXmNvbmZpZ3VyZTogV0FSTklORzogVmFsYSBjb21waWxlciBub3QgZm91 bmQgb3IgdG9vIG9sZCcgc3RkZXJyCiAkTUFLRSBuby12YWxhYwogCiBzdD0wOyAuL2NvbmZpZ3Vy ZSBWQUxBQz0iJChwd2QpL2Jpbi92YWxhYy5vbGQiIDI+c3RkZXJyIHx8IHN0PSQ/CiBjYXQgc3Rk ZXJyID4mMgogdGVzdCAkc3QgLWVxIDAgfHwgZXhpdCAxCi1ncmVwICdeY29uZmlndXJlOiBXQVJO SU5HOiBubyBwcm9wZXIgdmFsYSBjb21waWxlciBmb3VuZCcgc3RkZXJyCitncmVwICdeY29uZmln dXJlOiBXQVJOSU5HOiBWYWxhIGNvbXBpbGVyIG5vdCBmb3VuZCBvciB0b28gb2xkJyBzdGRlcnIK ICRNQUtFIG5vLXZhbGFjCiAKIHNlZCAncy9eXChBTV9QUk9HX1ZBTEFDXCkuKi9cMShbMV0sIFs6 ID4gb2tdLCBbOiA+IGtvXSkvJyA8Y29uZmlndXJlLmFjID50Ci0tIAoyLjI1LjEKCg== --0000000000001d88b205b2596ba2-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 17:41:03 2020 Received: (at 44129) by debbugs.gnu.org; 23 Oct 2020 21:41:03 +0000 Received: from localhost ([127.0.0.1]:58582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW4o3-0000Ry-44 for submit@debbugs.gnu.org; Fri, 23 Oct 2020 17:41:03 -0400 Received: from freefriends.org ([96.88.95.60]:47240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW4o0-0000RB-H1; Fri, 23 Oct 2020 17:41:00 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 09NLew5h002844 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Oct 2020 15:40:59 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 09NLewFp002843; Fri, 23 Oct 2020 15:40:58 -0600 Date: Fri, 23 Oct 2020 15:40:58 -0600 Message-Id: <202010232140.09NLewFp002843@freefriends.org> From: Karl Berry To: rrt@sc3d.org Subject: Re: bug#44129: Patch to improve valac version detection In-Reply-To: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44129 Cc: 44129@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I simply failed to update the test; I'm glad it was simple. All the tests pass for me now, and I pushed your patch, and am closing this bug. Thanks! From unknown Fri Aug 15 02:05:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Nov 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator