GNU bug report logs - #44100
26.3; ERC: Make IBuffer custom display work again

Previous Next

Package: emacs;

Reported by: Olivier Certner <ocert.dev <at> free.fr>

Date: Tue, 20 Oct 2020 16:49:01 UTC

Severity: normal

Tags: patch

Found in version 26.3

Done: Amin Bandali <bandali <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Amin Bandali <bandali <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44100: closed (26.3; ERC: Make IBuffer custom display work again)
Date: Tue, 03 Aug 2021 02:53:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 02 Aug 2021 22:52:29 -0400
with message-id <87k0l3jl3m.fsf <at> gnu.org>
and subject line Re: bug#44100: 26.3; ERC: Make IBuffer custom display work again
has caused the debbugs.gnu.org bug report #44100,
regarding 26.3; ERC: Make IBuffer custom display work again
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44100: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44100
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Olivier Certner <ocert.dev <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; ERC: Make IBuffer custom display work again
Date: Tue, 20 Oct 2020 18:39:15 +0200
Applies to 26.3, but also all more recent versions as well.

Bug trigger:
1. Load ERC (e.g., open some IRC connection).
2. Launch ibuffer (e.g., type "M-x ibuffer").
3. Switch formats three times (e.g., type "`" three times).
4. You get this error: (wrong-type-argument listp erc-notice-face) and
the buffer is only partly filled, and then cannot be updated.

Root cause:
erc-ibuffer assumes (in (define-ibuffer-column erc-modified ...) form)
that erc-modified-channels-alist is an alist whose values are proper
lists, whereas they are dotted lists.

Patch:
To be attached shortly after bug creation.

-- 
Olivier Certner




[Message part 3 (message/rfc822, inline)]
From: Amin Bandali <bandali <at> gnu.org>
To: Olivier Certner <olce.emacs <at> certner.fr>, 44100-done <at> debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, emacs-erc <at> gnu.org
Subject: Re: bug#44100: 26.3; ERC: Make IBuffer custom display work again
Date: Mon, 02 Aug 2021 22:52:29 -0400
Hi Olivier, all,

Olivier Certner writes:

> Hi,
>
> I've updated the patches for all these so that they cleanly apply on 28.0.50 
> (68276f6d30bbdc09). I've tested them again with a fresh build and everything 
> seems OK.
>
> Don't hesitate to poke me if you have additional questions or comments.
>
> Regards.

I hope you are all well, and my apologies for the long delay on this.

I went ahead and applied your updated patch to 'emacs-27' with a small
wording tweak and merged that into 'master' as well.  I'll also get to
your other patches over the next few days.

Thanks again,
amin


This bug report was last modified 3 years and 297 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.