From unknown Mon Jun 23 07:46:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44100 <44100@debbugs.gnu.org> To: bug#44100 <44100@debbugs.gnu.org> Subject: Status: 26.3; ERC: Make IBuffer custom display work again Reply-To: bug#44100 <44100@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:46:49 +0000 retitle 44100 26.3; ERC: Make IBuffer custom display work again reassign 44100 emacs submitter 44100 Olivier Certner severity 44100 normal tag 44100 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 12:48:07 2020 Received: (at submit) by debbugs.gnu.org; 20 Oct 2020 16:48:07 +0000 Received: from localhost ([127.0.0.1]:46589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUunv-0000ZV-25 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 12:48:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:59132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUufT-0006gx-S9 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 12:39:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUufT-0000g3-J6 for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2020 12:39:23 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:57700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUufR-0001DF-NR for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2020 12:39:23 -0400 Received: from ravel.localnet (unknown [2.15.200.177]) (Authenticated sender: ocert.dev@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 85F21200430 for ; Tue, 20 Oct 2020 18:39:16 +0200 (CEST) From: Olivier Certner To: bug-gnu-emacs@gnu.org Subject: 26.3; ERC: Make IBuffer custom display work again Date: Tue, 20 Oct 2020 18:39:15 +0200 Message-ID: <4578382.cRamKGfW39@ravel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a01:e0c:1:1599::11; envelope-from=ocert.dev@free.fr; helo=smtp2-g21.free.fr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, SPOOFED_FREEMAIL=1.987 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 20 Oct 2020 12:48:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Applies to 26.3, but also all more recent versions as well. Bug trigger: 1. Load ERC (e.g., open some IRC connection). 2. Launch ibuffer (e.g., type "M-x ibuffer"). 3. Switch formats three times (e.g., type "`" three times). 4. You get this error: (wrong-type-argument listp erc-notice-face) and the buffer is only partly filled, and then cannot be updated. Root cause: erc-ibuffer assumes (in (define-ibuffer-column erc-modified ...) form) that erc-modified-channels-alist is an alist whose values are proper lists, whereas they are dotted lists. Patch: To be attached shortly after bug creation. -- Olivier Certner From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 07:37:04 2020 Received: (at 44100) by debbugs.gnu.org; 21 Oct 2020 11:37:04 +0000 Received: from localhost ([127.0.0.1]:48173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVCQR-0002fI-VV for submit@debbugs.gnu.org; Wed, 21 Oct 2020 07:37:04 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:31117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVB34-0006Xh-Ss for 44100@debbugs.gnu.org; Wed, 21 Oct 2020 06:08:51 -0400 Received: from ravel.localnet (unknown [2.15.200.177]) (Authenticated sender: ocert.dev@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 92E1D200348 for <44100@debbugs.gnu.org>; Wed, 21 Oct 2020 12:08:48 +0200 (CEST) From: Olivier Certner To: 44100@debbugs.gnu.org Subject: Patch Date: Wed, 21 Oct 2020 12:08:47 +0200 Message-ID: <21986473.sr7ieKrsik@ravel> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart3302483.j5jfTYeP2b" Content-Transfer-Encoding: 7Bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In attachment. -- Olivier Certner From 33586f449fdf646fbfb1aa6bd5ef6ca4c4848761 Mon Sep 17 00:00:00 2001 From: Olivier Certner Date: Tue, 20 Oct 2020 18:36:25 +0200 Subject: [PATCH] ERC: Make IBuffer ERC's custom [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.27.42.2 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.27.42.2 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ocert.dev[at]free.fr) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: 44100 X-Mailman-Approved-At: Wed, 21 Oct 2020 07:37:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart3302483.j5jfTYeP2b Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" In attachment. -- Olivier Certner --nextPart3302483.j5jfTYeP2b Content-Disposition: attachment; filename="0001-ERC-Make-IBuffer-ERC-s-custom-displays-work-again.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-ERC-Make-IBuffer-ERC-s-custom-displays-work-again.patch" >From 33586f449fdf646fbfb1aa6bd5ef6ca4c4848761 Mon Sep 17 00:00:00 2001 From: Olivier Certner Date: Tue, 20 Oct 2020 18:36:25 +0200 Subject: [PATCH] ERC: Make IBuffer ERC's custom displays work again * lisp/erc/erc-ibuffer.el (erc-modified): Don't use `length' on dotted lists (and not even to test if there is more than one element, for that matter). Use `cdr' instead. --- ChangeLog.3 | 8 ++++++++ lisp/erc/erc-ibuffer.el | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog.3 b/ChangeLog.3 index ec2d3f8d46..86579b3913 100644 --- a/ChangeLog.3 +++ b/ChangeLog.3 @@ -1,3 +1,11 @@ +2020-10-20 Olivier Certner + + ERC: Make IBuffer ERC's custom displays work again + + * lisp/erc/erc-ibuffer.el (erc-modified): Don't use `length' on + dotted lists (and not even to test if there is more than one + element, for that matter). Use `cdr' instead. + 2020-08-03 Phil Sainty lisp/so-long.el: Improve support for major mode hooks diff --git a/lisp/erc/erc-ibuffer.el b/lisp/erc/erc-ibuffer.el index 7aee7705ff..955b022177 100644 --- a/lisp/erc/erc-ibuffer.el +++ b/lisp/erc/erc-ibuffer.el @@ -77,7 +77,7 @@ erc-track-mode) (let ((entry (assq (current-buffer) erc-modified-channels-alist))) (if entry - (if (> (length entry) 1) + (if (cdr entry) (cond ((eq 'pal (nth 1 entry)) (string erc-ibuffer-pal-char)) ((eq 'fool (nth 1 entry)) -- 2.24.1 --nextPart3302483.j5jfTYeP2b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 11:54:34 2020 Received: (at 44100) by debbugs.gnu.org; 21 Oct 2020 15:54:34 +0000 Received: from localhost ([127.0.0.1]:50310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVGRe-0005Qc-0L for submit@debbugs.gnu.org; Wed, 21 Oct 2020 11:54:34 -0400 Received: from mail-ej1-f49.google.com ([209.85.218.49]:42387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVGRc-0005QN-CB for 44100@debbugs.gnu.org; Wed, 21 Oct 2020 11:54:33 -0400 Received: by mail-ej1-f49.google.com with SMTP id h24so3955421ejg.9 for <44100@debbugs.gnu.org>; Wed, 21 Oct 2020 08:54:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ub5mAh9AF81O7cMRBpV/XL6R89/UY+GsOPWUrZ56FwE=; b=MG3V7VM6A0BjGbC5xBz6uD1d++/idJHHie01U4PKP9Kic1aaWGk5D8L0bWNFlfLqZj CmyxdLmP4Byo93u38+fQsP0CBnk8yl7WOGUpOT7aMm+XENAGzQHpNlAxTa+UddqKRs3U 0GeEouN2FY/qkOsR+LUGV5Amxm5Wc/ofS1tYZbnHvehn5pMLi0GeqXq1SLHdMHroZIrL 73P5bXsFZFNPATCj9XCJxp/eGd6XJf6MHhZw1aNVQX6caztUBPys7mBXfPl7MCMKHxMf N/xyL2ukQo0X0ja7E/9rqJ5sWo7lKf8Z2dJSmnKiJuvXL210l7vkvI4jlz/Pz0B654OG Ul6w== X-Gm-Message-State: AOAM532nfj6RhoGi4ALKUlFUeTdrRm4IfOzND22dSo+B9DOZB/zWzI08 rR/flc1L4iVu+RQGvg2u+g7IZZr7ho/1yNHmT/k= X-Google-Smtp-Source: ABdhPJy7QT7uGxwftLqS7xCZBEljsmDdPO3u3BChCwE68JwA5AUZpCsL5k86m5rUXFQYaLjdYcn1CbPS0Mvqg+IQYzY= X-Received: by 2002:a17:906:489b:: with SMTP id v27mr4360200ejq.315.1603295665379; Wed, 21 Oct 2020 08:54:25 -0700 (PDT) MIME-Version: 1.0 References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> In-Reply-To: <21986473.sr7ieKrsik@ravel> From: Corwin Brust Date: Wed, 21 Oct 2020 10:54:13 -0500 Message-ID: Subject: Re: bug#44100: Patch To: Olivier Certner , Amin Bandali Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Thank you, Olivier! On Wed, Oct 21, 2020 at 6:42 AM Olivier Certner wrote: > > In attachment. > > -- > Olivier Certner This looks fine to me. Adding Amin and CC to the erc mailing list. TIA for review and comments! Regards, Corwin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 22 12:00:45 2020 Received: (at control) by debbugs.gnu.org; 22 Oct 2020 16:00:45 +0000 Received: from localhost ([127.0.0.1]:53628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVd1B-00061t-52 for submit@debbugs.gnu.org; Thu, 22 Oct 2020 12:00:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVd15-00061Y-44 for control@debbugs.gnu.org; Thu, 22 Oct 2020 12:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nA75upKF7J30LXqPzd+99D/t3Nz+ogr0OkT5rrFxEQw=; b=ZKjl8w+oSjFZ74Bf1dgzAbBzut EU3Hdhz8kk8BOEc6bBjX8J9bSgjeFYCE3jNwQHzdB8EGBibZzBaPgArp39OWl8Ur3qKJY004pRhpH fGooPMMjXxMhlYtOfRE00si3DGXY+TPj5V7X8rBM9X/os3LmpP6IVPd6xnjS5RVZnAf0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVd0x-0005y0-8p for control@debbugs.gnu.org; Thu, 22 Oct 2020 18:00:33 +0200 Date: Thu, 22 Oct 2020 18:00:30 +0200 Message-Id: <87tuumi735.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44100 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44100 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44100 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 31 15:54:24 2020 Received: (at 44100) by debbugs.gnu.org; 31 Oct 2020 19:54:24 +0000 Received: from localhost ([127.0.0.1]:34597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYwxE-0004oe-1A for submit@debbugs.gnu.org; Sat, 31 Oct 2020 15:54:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYwxB-0004oO-G1 for 44100@debbugs.gnu.org; Sat, 31 Oct 2020 15:54:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42638) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYwx4-00045R-WD; Sat, 31 Oct 2020 15:54:15 -0400 Received: from [2607:fea8:3fdf:f688:6557:fc41:50c6:42] (port=39010 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYwx4-00067h-KT; Sat, 31 Oct 2020 15:54:14 -0400 From: Amin Bandali To: Corwin Brust Subject: Re: bug#44100: Patch Organization: GNU References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> Date: Sat, 31 Oct 2020 15:54:12 -0400 In-Reply-To: Message-ID: <87imaquq6z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello Olivier, Corwin, Corwin Brust writes: > Thank you, Olivier! > > On Wed, Oct 21, 2020 at 6:42 AM Olivier Certner wrote: >> >> In attachment. >> >> -- >> Olivier Certner > > This looks fine to me. Adding Amin and CC to the erc mailing list. > TIA for review and comments! > > Regards, > Corwin Thanks for your Patch, Olivier; and thanks for the ping, Corwin. I tried, but could not reproduce the error on Emacs trunk (from latest git `master'). I will try with earlier versions, but it may be another couple of days before I get to it. Corwin, were you able to reproduce this? Also, according to CONTRIBUTE [0] the ChangeLog files should not be edited manually, and instead changes should be announced in the etc/NEWS file, under the relevant section. [0]: https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl+dwOQQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8kEeD/9C/copUhEIJG4ptRSfMCwdrCkI/UXTVLfS G2JM2pEATdyvgNkZ0t8xFfQ2X0PpAN9PFbsO5eGI9TKr/NjCMZQH1YxgDday6HNt Ro4B0VLxZk4shAwbRPeIeNGOXL845agpZE+tpL5B444yZ3TGEYwQ15TLQeoQs58t v/6XXfbN7sv8+dSb3iKdq42IzeGQB/w2sDYqag6cOTnuXxG1Lq9SqHudTXLSeTdC C2378bysF0TC9Zbrod48DjVqxNdbtUUpM0gpo4oZtCsTCiugz8Hl4qmREu+rLK58 Wm/RQipGxTnl00cwbh0t1hikDnGG0V5Og75FvI9XGz0egmun02IhsCYfYBc2NZ+U 5eApEfJv8W353fO2DOAAUlReBeK9AzZPr+rVM5HMRfAzup0JvK8AQw9B29cy2ntG Bbs9TBUbs3H2ZPuZk8vkp781izT3150EhsyYRkGlCyeO49NnQ/r47xGofrdey3Ch Coi7YMuU6pwTea7ry75DEQ9Z5WO13Vs4C9Xc8QoqkaqbpNe66sUgHPvHgw1oXkTW W+2aOHPyBUhGg0ncBQP+UdOutIpbvLU/BTt33SdLNRTo9oT5Y0PJNRC9s28sR4jc p1UfQSCNr9V2rMRMEIq42vauVB+IE3uO4g/1Ze9RwjxIAY1cJigl9gSbH7iJlIqh xY0gsrhubg== =I04W -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 31 22:17:06 2020 Received: (at 44100) by debbugs.gnu.org; 1 Nov 2020 02:17:06 +0000 Received: from localhost ([127.0.0.1]:35167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ2va-0008Kv-1j for submit@debbugs.gnu.org; Sat, 31 Oct 2020 22:17:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ2vW-0008KL-IT for 44100@debbugs.gnu.org; Sat, 31 Oct 2020 22:17:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47003) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZ2vQ-0005nZ-CY; Sat, 31 Oct 2020 22:16:56 -0400 Received: from [2607:fea8:3fdf:f688:6557:fc41:50c6:42] (port=40338 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZ2vP-0001PG-Tm; Sat, 31 Oct 2020 22:16:56 -0400 From: Amin Bandali To: Corwin Brust Subject: Re: bug#44100: Patch Organization: GNU References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> <87imaquq6z.fsf@gnu.org> Date: Sat, 31 Oct 2020 22:16:54 -0400 In-Reply-To: <87imaquq6z.fsf@gnu.org> Message-ID: <875z6pu8h5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello again, I did some more investigation, and was able to reproduce the issue. However, I came up with a potentially more proper different fix: I think the presence of the dotted pair with a non-nil cdr is the main problem, since it means `erc-modified-channels-alist' does not fully adhere to the documented structure in its docstring. So I addressed the issue in `erc-track-modified-channels' by wrapping up single faces in lists too, ensuring that `erc-modified-channels-alist' never ends in a non-nil cdr. Something along the lines of the following patch. Thoughts? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Maintain-the-documented-structure-for-erc-modified-c.patch Content-Transfer-Encoding: quoted-printable From=209cccb6b00fea837c9d28305db30b21353134b990 Mon Sep 17 00:00:00 2001 From: Amin Bandali Date: Sat, 31 Oct 2020 21:41:38 -0400 Subject: [PATCH] Maintain the documented structure for 'erc-modified-channels-alist' * lisp/erc/erc-track.el (erc-track-modified-channels): Wrap the single face in a list to avoid a non-nil final cdr in `erc-modified-channels-alist', making its value adhere more closely to its stated structure in its docstring. Also unbreaks erc-ibuffer. * lisp/erc/erc-status-sidebar.el (erc-status-sidebar-default-chan-format): Account for the change in structure of `erc-modified-channels-alist' due to this fix. =2D-- lisp/erc/erc-status-sidebar.el | 2 +- lisp/erc/erc-track.el | 18 ++++++++++++------ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/lisp/erc/erc-status-sidebar.el b/lisp/erc/erc-status-sidebar.el index 08dc8d6015..4fc9b4fc30 100644 =2D-- a/lisp/erc/erc-status-sidebar.el +++ b/lisp/erc/erc-status-sidebar.el @@ -191,7 +191,7 @@ erc-status-sidebar-default-chan-format (setq channame (format "%s [%d]" channame num-messages))) (when erc-face (put-text-property 0 (length channame) 'face erc-face channame) =2D (when (eq erc-face 'erc-default-face) + (when (eq (car erc-face) 'erc-default-face) (add-face-text-property 0 (length channame) 'bold t channame))) channame) =20 diff --git a/lisp/erc/erc-track.el b/lisp/erc/erc-track.el index 60f0cfa942..3618df6568 100644 =2D-- a/lisp/erc/erc-track.el +++ b/lisp/erc/erc-track.el @@ -815,10 +815,13 @@ erc-track-modified-channels (throw 'found t)))))) (if (not (assq (current-buffer) erc-modified-channels-alist)) ;; Add buffer, faces and counts =2D (setq erc-modified-channels-alist =2D (cons (cons (current-buffer) =2D (cons 1 (erc-track-find-face faces))) =2D erc-modified-channels-alist)) + (let ((new-face (erc-track-find-face faces))) + (setq erc-modified-channels-alist + (cons (cons (current-buffer) + (cons 1 (if (listp new-face) + new-face + (list new-face)))) + erc-modified-channels-alist))) ;; Else modify the face for the buffer, if necessary. (when faces (let* ((cell (assq (current-buffer) @@ -828,7 +831,10 @@ erc-track-modified-channels (if old-face (cons old-face faces) faces)))) =2D (setcdr cell (cons (1+ (cadr cell)) new-face))))) + (setcdr cell (cons (1+ (cadr cell)) + (if (listp new-face) + new-face + (list new-face))))))) ;; And display it (erc-modified-channels-display))) ;; Else if the active buffer is the current buffer, remove it @@ -863,7 +869,7 @@ erc-track-last-non-erc-buffer `erc-track-switch-buffer'.") =20 (defun erc-track-sort-by-activest () =2D "Sort erc-modified-channels-alist by activity. + "Sort `erc-modified-channels-alist' by activity. That means the number of unseen messages in a channel." (setq erc-modified-channels-alist (sort erc-modified-channels-alist =2D-=20 2.17.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl+eGpYQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8nt0D/wIAUelkBs1ph894KrnvO9zT8NP0Z0/qDEP xl6y3fcSTnfSNZgjAhqlwBkbUsLDQjHKIfV5FgHdulW/75YcGdLrKzqOl3UmO5hR xZIjRgSAdkPPY3+oyDreItumS9iK0hOz0xGE78JWGWUvU4JtbD8xECygXSabSn/k GZcpPeoSdQKUFRJggtsqxvLu6fIWBz35Sb44Uh5xJYZ42CIXce8U4KhiLNuwOWMD Hp1HCKtAfxPubzVB0R682xdlcNy34r+8VipqgwWlnnl33TJHk+IFP0wCLL0hs03B 6Y8hHCNewpIH6lSEZVIlpBYDHt7MathjrotJp5ayNkloSFG4lLsXZcmBL3RcoY8c IqR1whWtWT6O1zqmqjvmY/3v1jZPFQX0ri6X/a4599vwyrL6qeyhpZ5uNAmgxN7K Wdj0cQz0RPNe5PMyOaFfJcE7lhLvPkA6I058hT+1cfbRXPYYTitZbqtWgRRgxGiZ Y3c6b7aKjdX1ciUPnugooeX3rZ0ViMsLeA4RPYYh19K2N7H6qfArb9WrP9xmp4U7 tXlKseT+8YJh2Nnq7sjLhlNPWKKmyz36enxMbCApQR0u/Ja0n1/ZIi3De8hZmTF0 EpYumv83LO36pPcolkIN3f+/ESRsZcOJ3glOWq2L2YcggBjsdxjMFjWTZEsHMRVi aBhqHq1CIw== =zaE8 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 01 08:10:09 2020 Received: (at 44100) by debbugs.gnu.org; 1 Nov 2020 13:10:09 +0000 Received: from localhost ([127.0.0.1]:35933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZD7Z-0006B4-Ae for submit@debbugs.gnu.org; Sun, 01 Nov 2020 08:10:09 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZD7Y-0006Am-0T for 44100@debbugs.gnu.org; Sun, 01 Nov 2020 08:10:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vrLTv7WugCZ5l4TSheD1yiOB3yVjbSEXCVUbgpEYXqM=; b=siGGfp9k87cBj093t55VdVF9Wx HchhjGxkekCfTTXCg1NQT1mvRqD4YBT9nAyFBTNYMZRVSNFac/7v6J27OXkoSDwMWIGRpgC+Xj9Ek BCUgtF29nM0nDKtEvcWty5e7aCo2hTszLlNkvSFqS5t3dBAUpNhsDL8GQONXg2EX14Bg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZD7L-0000Hu-GS; Sun, 01 Nov 2020 14:10:01 +0100 From: Lars Ingebrigtsen To: Amin Bandali Subject: Re: bug#44100: Patch References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> <87imaquq6z.fsf@gnu.org> <875z6pu8h5.fsf@gnu.org> X-Now-Playing: A Certain Ratio's _Loco_: "What's Wrong" Date: Sun, 01 Nov 2020 14:09:54 +0100 In-Reply-To: <875z6pu8h5.fsf@gnu.org> (Amin Bandali's message of "Sat, 31 Oct 2020 22:16:54 -0400") Message-ID: <87mu01cjfh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Amin Bandali writes: > However, I came up with a potentially more proper different fix: I think > the presence of the dotted pair with a non-nil cdr is the main problem, > since it means `erc-modified-channels-alist' does [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44100 Cc: Corwin Brust , emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Amin Bandali writes: > However, I came up with a potentially more proper different fix: I think > the presence of the dotted pair with a non-nil cdr is the main problem, > since it means `erc-modified-channels-alist' does not fully adhere to > the documented structure in its docstring. So I addressed the issue in > `erc-track-modified-channels' by wrapping up single faces in lists too, > ensuring that `erc-modified-channels-alist' never ends in a non-nil cdr. > > Something along the lines of the following patch. Thoughts? [...] > (when erc-face > (put-text-property 0 (length channame) 'face erc-face channame) > - (when (eq erc-face 'erc-default-face) > + (when (eq (car erc-face) 'erc-default-face) > (add-face-text-property 0 (length channame) 'bold t channame))) > channame) Normalising to having a list of faces here sounds like a good idea, if I'm skimming the code correctly, but it would probably help comprehension a bit here if you renamed the parameter from `erc-face' to something like `face-list'. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 02 21:38:31 2020 Received: (at 44100) by debbugs.gnu.org; 3 Nov 2020 02:38:31 +0000 Received: from localhost ([127.0.0.1]:43048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZmDO-0006oT-Od for submit@debbugs.gnu.org; Mon, 02 Nov 2020 21:38:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZmDN-0006oH-GU for 44100@debbugs.gnu.org; Mon, 02 Nov 2020 21:38:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34968) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZmDH-00071n-Cz; Mon, 02 Nov 2020 21:38:23 -0500 Received: from [2607:fea8:3fdf:f688:6557:fc41:50c6:42] (port=45128 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZmDH-0000Rk-4U; Mon, 02 Nov 2020 21:38:23 -0500 From: Amin Bandali To: Lars Ingebrigtsen Subject: Re: bug#44100: Patch Organization: GNU References: <4578382.cRamKGfW39@ravel> <21986473.sr7ieKrsik@ravel> <87imaquq6z.fsf@gnu.org> <875z6pu8h5.fsf@gnu.org> <87mu01cjfh.fsf@gnus.org> Date: Mon, 02 Nov 2020 21:38:21 -0500 In-Reply-To: <87mu01cjfh.fsf@gnus.org> Message-ID: <87lffjf9lu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: [...] > > Normalising to having a list of faces here sounds like a good idea, if > I'm skimming the code correctly, but it would probably help > comprehension a bit here if you renamed the parameter from `erc-face' to > something like `face-list'. Thanks. However, after staring at C-h f erc-track-find-face RET for a good while and experimenting in Edebug a fair bit, I have noticed that my change to C-h f erc-track-modified-channels RET for normalizing to always have a list breaks erc-track-find-face's algorithm in a non-trivial way, due its dependence on the structure of the two C-h v erc-track-faces-priority-list RET and C-h v erc-track-faces-normal-list RET lists. Since for the time being I don't have the time or energy to rethink those two functions' algorithms to work with a normalized list of lists for those two variables, I have decided to keep things as they are, and do the less evasive change in erc-ibuffer as suggested by Olivier to fix erc-ibuffer. I will commit that change over the few days, and will also try to clarify the docstring for C-h v erc-modified-channels-alist RET some more to more accurately describe its structure. I welcome anyone who would like to volunteer to send a patch for updating those functions to work with a normalized list of lists for those two variables, granted they can provide a convincing argument that their change is correct and does not break the current behaviour, does not dramatically further increase the complexity of the algorithms, and is ideally backward compatible with the current non-normalized structure of those two variables as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl+gwp0QHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8mO2D/9HzX0K9Xx3iBY0WcrbTtSpzs8TjRDfzSrO QipBEAhNVtCkNM7OxuyCHHYtXBnHPXOerXW2RtAyrsHsmLWXYh3I1M7ksbD4wSC6 Ng5dS9zAC7ddtU8a6QjMXsQ1UBC+1EeqOd1ysPpY4lOR+TdZppFaeutYb2CX4JaA tXJRQItDMdKtEoq2mNZ+meM43rvXjf3JiqgpP6cxbsmuwJsZym45kQ5iWq5pF+v/ IorxvuVTvXUPNw3GyZNSRzzLJRayu/QZhXJ3SGKUadNlW4ldzXLTiZ7oi8W1rLRm sacspokIUENzCq1Yj1u36nJBS0aTjq94YgvPid91vk9pSRSxeUOPhhuOY5eU6wSq KJ2O1igXCXA9VsXLISqjdL2QQW9n9+1yDdyjn/x8hqQn15b3AMeFoNtMpIcqewyf 3N/MgMtOiXPuqMeeixC3JMrm/CEw4YlgU/OhiMMIcyxCmWwm4vYMz76ENAuoe/sH Ke06hDC3s5LR4f9v+VsdxuG6drhEy4btpb2FfdEmdevv6sKGAhIbZtj4CEq6V2Cw uBACYIUt4OsEyfR3gCqO5ECIfQt5vHbnJxUyfedyf2q8yJoGsWoqZBkJRl7bMlCD Sh6tluZic0B5FxfFapUOEjGVOvfN0HGZ1RNxs6/wc6Zl6T1pVQ2Z7036cVqK9BnT OuS3b1o2kA== =F3ns -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 05 11:38:29 2020 Received: (at submit) by debbugs.gnu.org; 5 Nov 2020 16:38:29 +0000 Received: from localhost ([127.0.0.1]:53965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaiHN-0008BZ-04 for submit@debbugs.gnu.org; Thu, 05 Nov 2020 11:38:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:44516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaiHL-0008BR-Pe for submit@debbugs.gnu.org; Thu, 05 Nov 2020 11:38:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaiHL-0005RX-AQ; Thu, 05 Nov 2020 11:38:27 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:13168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaiHJ-00083x-IU; Thu, 05 Nov 2020 11:38:26 -0500 Received: from ravel.localnet (unknown [90.116.215.212]) (Authenticated sender: ocert.dev@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 4687019F61D; Thu, 5 Nov 2020 17:38:12 +0100 (CET) From: Olivier Certner To: Lars Ingebrigtsen , Amin Bandali Subject: Re: bug#44100: Patch Date: Thu, 05 Nov 2020 17:38:11 +0100 Message-ID: <1779714.fmOJIAR8ZY@ravel> In-Reply-To: <87lffjf9lu.fsf@gnu.org> References: <4578382.cRamKGfW39@ravel> <87mu01cjfh.fsf@gnus.org> <87lffjf9lu.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=212.27.42.4; envelope-from=ocert.dev@free.fr; helo=smtp4-g21.free.fr X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 11:38:21 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org, 44100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Amin, Sorry for the late reply, I missed these mails in a flood of other mails. And sorry as well for the ChangeLog entry, I had read CONTRIBUTE, but mixed things up (there is a section explaining how to generate change log entries in Emacs afterwards, and I forgot the earlier advice). > [...] > > I welcome anyone who would like to volunteer to send a patch for > updating those functions to work with a normalized list of lists for > those two variables, granted they can provide a convincing argument that > their change is correct and does not break the current behaviour, does > not dramatically further increase the complexity of the algorithms, and > is ideally backward compatible with the current non-normalized structure > of those two variables as well. I'll have a look at this next week. Thanks and regards. -- Olivier Certner From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 09:54:17 2020 Received: (at submit) by debbugs.gnu.org; 7 Nov 2020 14:54:17 +0000 Received: from localhost ([127.0.0.1]:58171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbPbd-0007rE-0C for submit@debbugs.gnu.org; Sat, 07 Nov 2020 09:54:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:56550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbPbb-0007r5-IF for submit@debbugs.gnu.org; Sat, 07 Nov 2020 09:54:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbPbb-0004Na-69; Sat, 07 Nov 2020 09:54:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59575) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbPba-0004O5-Pv; Sat, 07 Nov 2020 09:54:14 -0500 Received: from [2607:fea8:3fdf:f688:5945:45b3:f494:d1c7] (port=56120 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbPba-0005Ps-DK; Sat, 07 Nov 2020 09:54:14 -0500 From: Amin Bandali To: Olivier Certner Subject: Re: bug#44100: Patch Organization: GNU References: <4578382.cRamKGfW39@ravel> <87mu01cjfh.fsf@gnus.org> <87lffjf9lu.fsf@gnu.org> <1779714.fmOJIAR8ZY@ravel> Date: Sat, 07 Nov 2020 09:54:13 -0500 In-Reply-To: <1779714.fmOJIAR8ZY@ravel> Message-ID: <87pn4pusiy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , emacs-erc@gnu.org, bug-gnu-emacs@gnu.org, 44100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi Olivier, Olivier Certner writes: > Hello Amin, > > Sorry for the late reply, I missed these mails in a flood of other mails. > No problem! > > And sorry as well for the ChangeLog entry, I had read CONTRIBUTE, but > mixed things up (there is a section explaining how to generate change > log entries in Emacs afterwards, and I forgot the earlier advice). > Ah :-). No worries; I thought I'd point out CONTRIBUTE just in case you'd missed it. > >> [...] >> >> I welcome anyone who would like to volunteer to send a patch for >> updating those functions to work with a normalized list of lists for >> those two variables, granted they can provide a convincing argument that >> their change is correct and does not break the current behaviour, does >> not dramatically further increase the complexity of the algorithms, and >> is ideally backward compatible with the current non-normalized structure >> of those two variables as well. > > I'll have a look at this next week. > > Thanks and regards. Sounds good, thanks! Please keep us updated on how it goes. Also, since implementing this will likely cross the ~15 line triviality threshold, I sent you a copy of the copyright assignment request form off-list, which you would fill out and send to the copyright clerk to start the process of assigning the copyright for your changes to Emacs to the FSF. Thanks, amin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCgAuFiEEObM8jZRIDS3cwqSYi0Sgzce5VvIFAl+mtRUQHGJhbmRhbGlA Z251Lm9yZwAKCRCLRKDNx7lW8gdHEACOJC22JvbSu6tfKbgYRrLWyKDQxBTmiVKD rJ5fc2mS2Z97rPfpl4Dz/jyCtH3290p7h7akl7sGDv9Xz49Bidgsp8flHwliE8fa RhsJmJAczHFas7O/ffSOsj1kreS0+VjSgVtbWfs9gWVsaw9IDDG6NqgTD8Xu2CKI J+tYTQBd1xJGxR4P1Q5FEEW6iLE+4egLsf43IB4lcEgqxagy2gRBN497ZI7ir7gE qMGuTvkOEaaEnNxuHL8o1v/ye3CtyUmtYDRPL7iHGSSIVX7CdhxwNi9TUnrCccRm 8VDuN4U+c5DvESWgqS5YWPKycOk0QVUOyqv6+LckAZ5CQgr55N9V1JZwD602F8JK Q1DpTanxeA3RrV5kzxNmyYE434Vop346lVZmzh+D/F+6b+eJMIgjy3/gbOi5nLdU sEwm8vX53m7w1iAKh/GHPDaQ6jNaEyKxtHyFDGz0X8zQiNi8imr6TT9b2vcK3mXc baNAHtYDGVLmUIa3eJ3XXPEsvsM53NRC7aNpL6drQ1qz8wH5vmsWQoJuOlhb8olL KZ2mGQfQaeDoML6s0hmUvHwhyLeB742ux3lq5AIvXMBcn2jHGQ552EMPPC9vj424 HrvQ0VbvWk5FjB8B5ErWNfv3MCorbq/Nq1iPDEPOI8ML+4jhB/MF/piC/k29tZZ0 wgBEiFJl4Q== =aniV -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 04 06:08:05 2021 Received: (at 44100) by debbugs.gnu.org; 4 Jun 2021 10:08:05 +0000 Received: from localhost ([127.0.0.1]:45457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6kG-0004Vn-Se for submit@debbugs.gnu.org; Fri, 04 Jun 2021 06:08:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp6kE-0004VH-G0 for 44100@debbugs.gnu.org; Fri, 04 Jun 2021 06:08:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2/tU2GIXbV+GfHoWZYGcyxemvHQvQ7+ir9Wzh/rZQnc=; b=dbpz6fC0iQgkAiR43/T+MOkvzV 2LiUl9aE89cD1tquqbpJCjCD4HkXr8sUyR35hpUPSJaWYx0qk4aAIvpOcbpNMQUV9xm5eS7Q7JKjg vpjnbQYfFiFiAfoWiFYGfm8dWG7eSv2vOfekLQXEma0nHfvVrXRNzNA8WAY5JmcbXX8s=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp6k4-0004CN-7H; Fri, 04 Jun 2021 12:07:56 +0200 From: Lars Ingebrigtsen To: Amin Bandali Subject: Re: bug#44100: 26.3; ERC: Make IBuffer custom display work again References: <4578382.cRamKGfW39@ravel> <87mu01cjfh.fsf@gnus.org> <87lffjf9lu.fsf@gnu.org> <1779714.fmOJIAR8ZY@ravel> <87pn4pusiy.fsf@gnu.org> X-Now-Playing: Frank Chickens's _Make More Noise (3)_: "We Are Ninja" Date: Fri, 04 Jun 2021 12:07:51 +0200 In-Reply-To: <87pn4pusiy.fsf@gnu.org> (Amin Bandali's message of "Sat, 07 Nov 2020 09:54:13 -0500") Message-ID: <87v96ux7rc.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Amin Bandali writes: > Also, since implementing this will likely cross the ~15 line triviality > threshold, I sent you a copy of the copyright assignment request form > off-list, which you would fill out and send to the c [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Amin Bandali writes: > Also, since implementing this will likely cross the ~15 line triviality > threshold, I sent you a copy of the copyright assignment request form > off-list, which you would fill out and send to the copyright clerk to > start the process of assigning the copyright for your changes to Emacs > to the FSF. Amin, Olivier's paperwork is now complete, so could you look at the following four patches from Olivier and review (and possibly apply)? 46777 normal,pat Olivier Certner 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications 46775 normal,pat Olivier Certner 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes 44140 normal,pat Olivier Certner 26.3; ERC stamps: Really use latest buffer's window's width prior to `fill-column' 44100 normal,pat Olivier Certner 26.3; ERC: Make IBuffer custom display work again -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 04 15:59:00 2021 Received: (at 44100) by debbugs.gnu.org; 4 Jun 2021 19:59:00 +0000 Received: from localhost ([127.0.0.1]:47918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpFy7-0008Dm-NT for submit@debbugs.gnu.org; Fri, 04 Jun 2021 15:58:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpFy4-0008DU-FF for 44100@debbugs.gnu.org; Fri, 04 Jun 2021 15:58:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49512) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpFxy-0005XF-7g; Fri, 04 Jun 2021 15:58:50 -0400 Received: from [2607:fea8:3fdf:eb8d:289b:d6fd:e283:3706] (port=42408 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpFxx-0003XD-LU; Fri, 04 Jun 2021 15:58:49 -0400 From: bandali@gnu.org To: Lars Ingebrigtsen Subject: Re: bug#44100: 26.3; ERC: Make IBuffer custom display work again References: <4578382.cRamKGfW39@ravel> <87mu01cjfh.fsf@gnus.org> <87lffjf9lu.fsf@gnu.org> <1779714.fmOJIAR8ZY@ravel> <87pn4pusiy.fsf@gnu.org> <87v96ux7rc.fsf_-_@gnus.org> Date: Fri, 04 Jun 2021 15:58:48 -0400 In-Reply-To: <87v96ux7rc.fsf_-_@gnus.org> Message-ID: <87h7idqu4n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44100 Cc: emacs-erc@gnu.org, 44100@debbugs.gnu.org, Olivier Certner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Amin Bandali writes: > >> Also, since implementing this will likely cross the ~15 line triviality >> threshold, I sent you a copy of the copyright assignment request form >> off-list, which you would fill out and send to the copyright clerk to >> start the process of assigning the copyright for your changes to Emacs >> to the FSF. > > Amin, Olivier's paperwork is now complete, so could you look at the > following four patches from Olivier and review (and possibly apply)? > > 46777 normal,pat Olivier Certner 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications > 46775 normal,pat Olivier Certner 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes > 44140 normal,pat Olivier Certner 26.3; ERC stamps: Really use latest buffer's window's width prior to `fill-column' > 44100 normal,pat Olivier Certner 26.3; ERC: Make IBuffer custom display work again Thanks, Lars. I will indeed be reviewing/applying Olivier's patches over the next couple of days. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 10:58:39 2021 Received: (at 44100) by debbugs.gnu.org; 6 Jul 2021 14:58:39 +0000 Received: from localhost ([127.0.0.1]:49669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mX0-0006x8-Jd for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:58:39 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:48004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0jqV-0008O7-6P for 44100@debbugs.gnu.org; Tue, 06 Jul 2021 08:06:36 -0400 Received: from ravel.localnet (unknown [2.15.208.149]) (Authenticated sender: ocert.dev@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id D28625FF9A for <44100@debbugs.gnu.org>; Tue, 6 Jul 2021 14:06:32 +0200 (CEST) From: Olivier Certner To: 44100@debbugs.gnu.org Subject: Updated patch Date: Tue, 06 Jul 2021 14:06:32 +0200 Message-ID: <3008082.TtUXfVIq0z@ravel> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart16120163.Vh8gfE0j03" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 44100 X-Mailman-Approved-At: Tue, 06 Jul 2021 10:58:37 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) This is a multi-part message in MIME format. --nextPart16120163.Vh8gfE0j03 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Patch slightly edited (commit message) and rebased on top of a recent 'master'. Ready to apply. Easy to backport to 27 as well. -- Olivier Certner --nextPart16120163.Vh8gfE0j03 Content-Disposition: attachment; filename="0001-ERC-Unbreak-ERC-s-IBuffer-s-custom-displays-Bug-4410.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-ERC-Unbreak-ERC-s-IBuffer-s-custom-displays-Bug-4410.patch" >From c21f772f35fad8f80d951048ff134387e30ca076 Mon Sep 17 00:00:00 2001 From: Olivier Certner Date: Tue, 6 Jul 2021 10:51:57 +0200 Subject: [PATCH] ERC: Unbreak ERC's IBuffer's custom displays (Bug#44100) * lisp/erc/erc-ibuffer.el (erc-modified): Don't use `length' on dotted lists (and not even to test if there is more than one element, for that matter). Use `cdr' instead. --- lisp/erc/erc-ibuffer.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc-ibuffer.el b/lisp/erc/erc-ibuffer.el index 22336ede21..31e59a6d3e 100644 --- a/lisp/erc/erc-ibuffer.el +++ b/lisp/erc/erc-ibuffer.el @@ -73,7 +73,7 @@ erc-modified erc-track-mode) (let ((entry (assq (current-buffer) erc-modified-channels-alist))) (if entry - (if (> (length entry) 1) + (if (cdr entry) (cond ((eq 'pal (nth 1 entry)) (string erc-ibuffer-pal-char)) ((eq 'fool (nth 1 entry)) -- 2.30.0 --nextPart16120163.Vh8gfE0j03-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 10:58:40 2021 Received: (at 44100) by debbugs.gnu.org; 6 Jul 2021 14:58:40 +0000 Received: from localhost ([127.0.0.1]:49675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mX2-0006xT-F2 for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:58:40 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:34384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0m56-000418-Bx for 44100@debbugs.gnu.org; Tue, 06 Jul 2021 10:30:03 -0400 Received: from ravel.localnet (unknown [2.15.208.149]) (Authenticated sender: ocert.dev@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 76DF660FEF; Tue, 6 Jul 2021 16:29:43 +0200 (CEST) From: Olivier Certner To: 44100@debbugs.gnu.org Subject: On Amin's proposed change Date: Tue, 06 Jul 2021 16:29:43 +0200 Message-ID: <3590251.0TOR21KIAd@ravel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44100 X-Mailman-Approved-At: Tue, 06 Jul 2021 10:58:37 -0400 Cc: Amin Bandali X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) For the record, an extract of a private exchange with Amin on the change he proposed earlier in this bug (Bug#44100). > > Sounds good, thanks! Instrumenting the function(s), > > putting breakpoints, and playing around with them should > > hopefully help develop some intuition around them. > > As I was suspecting, your patch didn't work just because you did not convert > the calls to `erc-track-find-face' correctly with respect to the change you > wanted to make. > > I'm not particularly keen on changing `erc-modified-channels-alist' format, > I just find it OK as it is (more compact), and chose to change its > documentation instead. Now, if you really insist on the other way, it's > quick to do as well, and I'll send you the corresponding proposal. > > I've also spent a while figuring out what `erc-track-find-face' does, and > I've decided to rewrite it for clarification (without changing the > behavior). It then appeared to me that its interface and call sites were > doing something I also suspected to be wrong, for which I did apply another > correction. > > And I also updated the documentation of some vars/funs involved in tracking, > to make things a bit easier to understand and cross-link better between > them. > > I'm currently testing the changes, and everything seems fine so far. I'll > make the changes publicly available tomorrow for you to see, so we can > start discussing them. I made these changes public a while ago in Bug#46775. -- Olivier Certner From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 02 22:52:41 2021 Received: (at 44100-done) by debbugs.gnu.org; 3 Aug 2021 02:52:41 +0000 Received: from localhost ([127.0.0.1]:39575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAkXo-0008WI-RL for submit@debbugs.gnu.org; Mon, 02 Aug 2021 22:52:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAkXm-0008W4-Cs for 44100-done@debbugs.gnu.org; Mon, 02 Aug 2021 22:52:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38108) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAkXf-0000JJ-0v; Mon, 02 Aug 2021 22:52:31 -0400 Received: from [2607:fea8:3fdf:f2d9:95:40e3:4c6f:107e] (port=37790 helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAkXe-0007ad-Se; Mon, 02 Aug 2021 22:52:30 -0400 From: Amin Bandali To: Olivier Certner , 44100-done@debbugs.gnu.org Subject: Re: bug#44100: 26.3; ERC: Make IBuffer custom display work again References: <4578382.cRamKGfW39@ravel> <87pn4pusiy.fsf@gnu.org> <87v96ux7rc.fsf_-_@gnus.org> <1946874.pO33bOzxCm@ravel> Date: Mon, 02 Aug 2021 22:52:29 -0400 In-Reply-To: <1946874.pO33bOzxCm@ravel> Message-ID: <87k0l3jl3m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44100-done Cc: Lars Ingebrigtsen , emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Olivier, all, Olivier Certner writes: > Hi, > > I've updated the patches for all these so that they cleanly apply on 28.0.50 > (68276f6d30bbdc09). I've tested them again with a fresh build and everything > seems OK. > > Don't hesitate to poke me if you have additional questions or comments. > > Regards. I hope you are all well, and my apologies for the long delay on this. I went ahead and applied your updated patch to 'emacs-27' with a small wording tweak and merged that into 'master' as well. I'll also get to your other patches over the next few days. Thanks again, amin From unknown Mon Jun 23 07:46:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 31 Aug 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator