From unknown Tue Jun 17 22:00:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44093 <44093@debbugs.gnu.org> To: bug#44093 <44093@debbugs.gnu.org> Subject: Status: [PATCH] some patches for lisp/mpc.el Reply-To: bug#44093 <44093@debbugs.gnu.org> Date: Wed, 18 Jun 2025 05:00:28 +0000 retitle 44093 [PATCH] some patches for lisp/mpc.el reassign 44093 emacs submitter 44093 tsuucat severity 44093 normal tag 44093 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 03:32:39 2020 Received: (at submit) by debbugs.gnu.org; 20 Oct 2020 07:32:39 +0000 Received: from localhost ([127.0.0.1]:43221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUm8M-0004AD-VP for submit@debbugs.gnu.org; Tue, 20 Oct 2020 03:32:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:56410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUm8K-0004A4-QO for submit@debbugs.gnu.org; Tue, 20 Oct 2020 03:32:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUm8K-0006bO-JJ for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2020 03:32:36 -0400 Received: from pv50p00im-zteg10011501.me.com ([17.58.6.42]:47955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUm8G-0004Hu-8r for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2020 03:32:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1603179149; bh=fyrIKoH5g9JfJIBkwImiprWYN6vCYJEr10GmNxx2p8w=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=PxSSzSOq2qI/9C0oo9woR15vU0OdvMcPz3s1lrdtqG3coX0ZqsaFDO87oGlXxdF0k OuSlRJJHKwOr+Jpcyah+rNIO+qfmkleXNJ71UEV15LIIAMGjN8BgBTtTgGnYX17/1u EYDuYhr9uPhC7BiDHIFJk7Xr0F2DrzZTbARX9loKqTuo/8dbfYnJru4Dp7DJK3mpvj lbSDXQMJiAh4mVNHrBNIDn72891aSVazZA4XV4fee+hffLCorRc8r3UU+J087QZkfx 3IM6ROHfP5SaD15AIzwpPl3DfxAeziCiYmC5g9my5jyjpQBtZ/r8RJAgUQni663boU /qCgYN8dhS+AQ== Received: from [192.168.96.166] (hlla-gw.hlla.is.tsukuba.ac.jp [130.158.83.243]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id 018D9B003B4 for ; Tue, 20 Oct 2020 07:32:28 +0000 (UTC) From: tsuucat Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: [PATCH] some patches for lisp/mpc.el Message-Id: <312AE1F0-BCAD-43C2-B078-507549FA400E@icloud.com> Date: Tue, 20 Oct 2020 16:32:26 +0900 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-20_03:2020-10-16, 2020-10-20 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2010200049 Received-SPF: pass client-ip=17.58.6.42; envelope-from=tsuucat@icloud.com; helo=pv50p00im-zteg10011501.me.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 03:32:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I made three small patches for lisp/mpc.el. 1. I noticed M-x mpc-playlist-delete always messages =E2=80=9CDeleted 1 = songs=E2=80=9D even if playlist queue has more than one songs. This is because mpc-cmd-delete=E2=80=99s sort modifies songs-poss by = side effect. Using copy-sequence fixes this. (also fix mpc-cmd-move for same reason) diff --git a/lisp/mpc.el b/lisp/mpc.el index d22b7ab450..e5f5984a33 100644 --- a/lisp/mpc.el +++ b/lisp/mpc.el @@ -849,7 +849,7 @@ mpc-cmd-delete ;; Sort them from last to first, so the = renumbering ;; caused by the earlier deletions don't = affect ;; later ones. - (sort song-poss '>)))) + (sort (copy-sequence song-poss) '>)))) (if (stringp playlist) (puthash (cons 'Playlist playlist) nil mpc--find-memoize))) @@ -873,7 +873,7 @@ mpc-cmd-move ;; Sort them from last to first, so the renumbering ;; caused by the earlier deletions affect ;; later ones a bit less. - (sort song-poss '>)))) + (sort (copy-sequence song-poss) '>)))) (if (stringp playlist) (puthash (cons 'Playlist playlist) nil mpc--find-memoize)))) 2. M-x mpc-songs-jump-to doesn=E2=80=99t update *MPC-Status* buffer. Use mpc-cmd-play. diff --git a/lisp/mpc.el b/lisp/mpc.el index d22b7ab450..a0f79e0492 100644 --- a/lisp/mpc.el +++ b/lisp/mpc.el @@ -819,8 +819,8 @@ mpc-cmd-pause (defun mpc-cmd-status () (mpc-proc-cmd-to-alist "status")) -(defun mpc-cmd-play () - (mpc-proc-cmd "play") +(defun mpc-cmd-play (&optional sn) + (mpc-proc-cmd (if sn (list "play" sn) "play")) (mpc-status-refresh)) (defun mpc-cmd-seekcur (time) @@ -2089,7 +2089,7 @@ mpc-songs-jump-to ((null (with-current-buffer plbuf (re-search-forward re nil t))) ;; song-file only appears once in the playlist: no ambiguity, ;; we're good to go! - (mpc-proc-cmd (list "play" sn))) + (mpc-cmd-play sn)) (t ;; The song appears multiple times in the playlist. If the = current ;; buffer holds not only the destination song but also the = current @@ -2125,7 +2125,7 @@ mpc-songs-jump-to 3. M-x mpc-stop clears playlist queue. So updating *MPC-Songs* buffer is useful. diff --git a/lisp/mpc.el b/lisp/mpc.el index d22b7ab450..405e669660 100644 --- a/lisp/mpc.el +++ b/lisp/mpc.el @@ -2391,6 +2391,7 @@ mpc-stop (interactive) (mpc-cmd-stop) (mpc-cmd-clear) + (mpc-songs-refresh) (mpc-status-refresh)) (defun mpc-pause () Please review these patches. Do I have to squash these patches to one commit? -- tsuucat= From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 07:22:16 2020 Received: (at 44093) by debbugs.gnu.org; 20 Oct 2020 11:22:16 +0000 Received: from localhost ([127.0.0.1]:43762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUpiZ-0008KI-VZ for submit@debbugs.gnu.org; Tue, 20 Oct 2020 07:22:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUpiX-0008K1-Q8 for 44093@debbugs.gnu.org; Tue, 20 Oct 2020 07:22:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w2ly1dU0xgECpDtyK89sUt2gi4mB9jNMfKuYvZ0bVV8=; b=bKq6xzboySbjCMSt7enYPyBzRK rzAuzUgdFDTR6uXlusHrQ7HXBQKmDiymgeBEHnX/srN8I024oDGSydDGjteiYZpMOjnuSw3Dc+qCr N1X/98LNayRE0OZEWs4Aj7iDn0S3Ljm+83WsqlM25nQkuHKQgwkDQN7dTFge4YqxLT/o=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUpiO-00079y-Qk; Tue, 20 Oct 2020 13:22:07 +0200 From: Lars Ingebrigtsen To: tsuucat Subject: Re: bug#44093: [PATCH] some patches for lisp/mpc.el References: <312AE1F0-BCAD-43C2-B078-507549FA400E@icloud.com> X-Now-Playing: Christoph de Babalon's _Hectic Shakes_: "Endless Inside" Date: Tue, 20 Oct 2020 13:22:03 +0200 In-Reply-To: <312AE1F0-BCAD-43C2-B078-507549FA400E@icloud.com> (tsuucat@icloud.com's message of "Tue, 20 Oct 2020 16:32:26 +0900") Message-ID: <871rhti1lw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tsuucat writes: > I made three small patches for lisp/mpc.el. Thanks; looks good to me, so I've applied them to Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tsuucat writes: > I made three small patches for lisp/mpc.el. Thanks; looks good to me, so I've applied them to Emacs 28. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [95.216.78.240 listed in list.dnswl.org] 2.0 PDS_TONAME_EQ_TOLOCAL_SHORT Short body with To: name matches everything in local email X-Debbugs-Envelope-To: 44093 Cc: 44093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tsuucat writes: > I made three small patches for lisp/mpc.el. Thanks; looks good to me, so I've applied them to Emacs 28. In the future, though, sending multiple small changes like this in a single patch would be preferred, and if the patch could be accompanied with a ChangeLog-style commit message, that would be nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 07:22:20 2020 Received: (at control) by debbugs.gnu.org; 20 Oct 2020 11:22:20 +0000 Received: from localhost ([127.0.0.1]:43765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUpie-0008Kc-8T for submit@debbugs.gnu.org; Tue, 20 Oct 2020 07:22:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUpic-0008KA-Jv for control@debbugs.gnu.org; Tue, 20 Oct 2020 07:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mo7tugMJsJA0f8Mfo385Troni3XbjDEs1MbXApeAArI=; b=KyPd0NZa+Inf55yNqWnGwf55NR 4zWjDOyKxr/vpFopSZbbKd1No4w9XvD08JW8yGQ7eklDAnFYwdVyQ9UPEIggHmtQQQEyaXJagPN/I VaDEfPRwqpTyK9688EqT7YJEBX/nsp2Ah0GFXurZC61ndNCg50wCiUn72EP12EIokBpk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUpiU-0007A9-VM for control@debbugs.gnu.org; Tue, 20 Oct 2020 13:22:13 +0200 Date: Tue, 20 Oct 2020 13:22:09 +0200 Message-Id: <87zh4hgn1a.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44093 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44093 fixed close 44093 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44093 fixed close 44093 28.1 quit From unknown Tue Jun 17 22:00:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Nov 2020 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator