From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 14:39:37 2020 Received: (at submit) by debbugs.gnu.org; 19 Oct 2020 18:39:37 +0000 Received: from localhost ([127.0.0.1]:42347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUa4G-0005R7-Nj for submit@debbugs.gnu.org; Mon, 19 Oct 2020 14:39:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:34502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUa4E-0005Qz-Oj for submit@debbugs.gnu.org; Mon, 19 Oct 2020 14:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUa4D-0001hR-Uq for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 14:39:34 -0400 Received: from mout02.posteo.de ([185.67.36.66]:36103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUa4A-0005w1-Co for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 14:39:33 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BC5BD240106 for ; Mon, 19 Oct 2020 20:39:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603132766; bh=7w9D0e5QilinzcG0jrVsmNA8Y2JQhS+zIgHZR79qf4c=; h=To:Subject:From:Date:From; b=S8kfDj/oXnN35XbuJvFOjJT1bU8mH4eQbDS6XhCN8JGPPJ6tjjOuoJ3123Hyec9sv EpwhfSL4yuvbD/+EbPp3hU1m363jh3q8JaaxTGHeDngEsywYZyZ3nnePakOZs4f1bG d+VxCWvOMAiPnW34zJhcTESPwm1PUFb7mBNY+8WjbY82nkOhLdSHeQdQULBySnVr5N cxv4F9u6Jpzf+k7QpjrMvybEl1XqM384XhkkcJtP3Ynfzmhp3z8lL1jslzgf7WPHJ2 52hilh3gDPbSRzNb7usvCc14RvMOPiBkJlslpAYYbF0ETgyINIyrpXMcfaldB+n3bp HKwAIhOx76fhQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CFQX367BJz6tmq for ; Mon, 19 Oct 2020 20:39:15 +0200 (CEST) To: bug-gnu-emacs@gnu.org Subject: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames From: Clemens Message-ID: Date: Mon, 19 Oct 2020 20:39:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=clemens.radermacher@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 10:31:58 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, there seems to be display bug when using `after-string` to display text in resizable minibuffer frames. To reproduce: 1. `emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil)))"` 2. `eval-buffer` with following code: ```elisp (setq resize-mini-frames t) (defvar ov (make-overlay (point-min) (point-min) nil t t)) (minibuffer-with-setup-hook (lambda () (move-overlay ov (point-max) (point-max) (current-buffer)) ;; Note the initial newline... (overlay-put ov 'after-string "\nHey there, I'm hidden initially and will hide again after any space in the input")) (read-string "Hi? ")) ``` 3. Start typing As stated in the after-string text, it is initially hidden, shows when you input some text and gets hidden again every time you type a space. -- In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-08-20 built on clemera Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.5 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. user-error: Beginning of history; no preceding item Configured using: 'configure --with-modules --with-json --with-cairo' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: de_DE.UTF-8 value of $LC_NUMERIC: de_DE.UTF-8 value of $LC_TIME: de_DE.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 43837 7270) (symbols 48 6003 1) (strings 32 15436 1428) (string-bytes 1 506267) (vectors 16 9260) (vector-slots 8 124508 9186) (floats 8 19 43) (intervals 56 184 0) (buffers 1000 11)) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:43:43 2020 Received: (at 44080) by debbugs.gnu.org; 19 Oct 2020 19:43:43 +0000 Received: from localhost ([127.0.0.1]:42518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUb4I-0000my-W8 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:43:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUb4G-0000mg-L8 for 44080@debbugs.gnu.org; Mon, 19 Oct 2020 15:43:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40645) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUb4A-0006Ec-Pj; Mon, 19 Oct 2020 15:43:34 -0400 Received: from [176.228.60.248] (port=4073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUb4A-0006iT-97; Mon, 19 Oct 2020 15:43:34 -0400 Date: Mon, 19 Oct 2020 22:43:41 +0300 Message-Id: <83v9f6ngr6.fsf@gnu.org> From: Eli Zaretskii To: Clemens , martin rudalics In-Reply-To: (message from Clemens on Mon, 19 Oct 2020 20:39:15 +0200) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Clemens > Date: Mon, 19 Oct 2020 20:39:15 +0200 > > 1. `emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil)))"` > 2. `eval-buffer` with following code: > > ```elisp > (setq resize-mini-frames t) > > (defvar ov (make-overlay (point-min) (point-min) nil t t)) > > (minibuffer-with-setup-hook > (lambda () > (move-overlay ov > (point-max) > (point-max) > (current-buffer)) > ;; Note the initial newline... > (overlay-put ov 'after-string "\nHey there, I'm hidden initially > and will hide again after any space in the input")) > (read-string "Hi? ")) > ``` > > 3. Start typing > > As stated in the after-string text, it is initially hidden, shows when > you input some text and gets hidden again every time you type a space. It looks like the problem is in fit-frame-to-buffer: it is not prepared to handle after-string at the end of the prompt. Specifically, the fact that the 2nd and the 3rd args of the call to window-text-pixel-size are both t causes the function to return the value which doesn't account for the after-string. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 03:21:46 2020 Received: (at 44080) by debbugs.gnu.org; 20 Oct 2020 07:21:47 +0000 Received: from localhost ([127.0.0.1]:43212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUlxq-0003qe-IL for submit@debbugs.gnu.org; Tue, 20 Oct 2020 03:21:46 -0400 Received: from mout.gmx.net ([212.227.15.19]:39019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUlxo-0003qO-B4 for 44080@debbugs.gnu.org; Tue, 20 Oct 2020 03:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603178498; bh=mKZBz8HS6d6uGj3lP0RGIGHWOWOdNj/7Ur9/1VY1MZw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Slc2jo7jXY3T8KEuZ/0xgcPML18yBBzGJHMwkkY0RrIFsMUlS/w6qwNlE/tLy/AQj i+NNaxh+dX4/3n/zrTSEd8dDGwDwKV2fdFxgEuEylp1/Dz3ATBzY09S5O4U7ha91lb pH9R21O4Ub9FEEbXEibchyaq5w13WxIqOtKV6x2I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.7.240]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9Wuk-1kY3ks09jA-005Vmo; Tue, 20 Oct 2020 09:21:38 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Eli Zaretskii , Clemens References: <83v9f6ngr6.fsf@gnu.org> From: martin rudalics Message-ID: <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> Date: Tue, 20 Oct 2020 09:21:36 +0200 MIME-Version: 1.0 In-Reply-To: <83v9f6ngr6.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:yGD/9R3rXYeKBBQ+wkvOK4xf8bi95wR1OA6BjdHoYVYAc1Ge8vx 0qUgZA13dB9SfZ1n9cmkBlh8tLSmk4BF0mLkXMS3yui4+UuR3+WJGZSB+54EUPttzvaMa6q EGCCEZL5JZhIu48/xh75tvmyan2FHrZLeqze4k6dRRJ5CfzwbipWHjZyD9qrgAjlwK8COHd k/fHpD0M/ICT7L0dwTK6g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UuJ+CeIHZjE=:kBwD1RqYcjO61Xk0SSOgif QYR5Nb+2koHOmzRsMfGvvkGxjp5qIXHdTdaDDKM1NFWOfboormpSwoMA2R+31nidRTkc++oyv J1kReqX/CZCPULyfXwolgcprzUnGtDHx62gGIQejwEEiTtWml+VC1EDZKB2ic522o98SC/IvL g/tadaaK6dYkD7TuyhnRYsiN8P7xjmKptzXvoUBrbEJrtxIBVovMmmOfFXmrUkDbw0vDH5Dhr r7IqmMvcMSOmXIwrDTTkaMBcqSRw1FymkUlGkz2n27kR47YTdJUX42aq9Xgo34cNsv5D2aQW5 L8tmTOuQsFDd/4UD/6Mumz30k7vDU3Ow7W9a4EAVy9WvvD7dVh1APdlnYkUJG2GMl3s3kdkJf y8ycSw35k3+aYi1MAspUdzT9HXqRZglONiGys1Kw+iJA/41IfaAoGFyrtLFFlZugpdQf/HMhX TbN74lbDpXStZvydqpPYFBbSFbEHRNWjis8Ww6XecwUXaixEyf0VFAAeTQdOAWGN+Fa2zU+gc BEXp7mpzpVO02rmCgvdFRk0lVRM8GiZOs6wfygdfFUUDCSFrFhLeY73KOGeWg98hfSE8gtc++ hizuvQjWl0AI9CDt5U6HJF+5r08lJPWNy8MSY+sXkpOT79Jz8IDLhR/Y5+tE4ZbZ+x3QnwQAl 6weSKT8HFTnt3fdj6ua8xCnWjNOsfsAklofgRo+r519Xjdpe7fDY22HLnnnru8u4E3rYIAmfx 7vBUu86HX2lOg9nK+htlA3rx4tX3OvtqNDaYWepwY0mrXeFokxXNtIQ/kuusoxDx2oJuJw6CK XlUZSUb3aMdK4huFnUuP7yCAXPcg1qhm0oh3bAl86ABsdWNtt7vvh/Y5PQ0/dtKMthCCrpZ6L XyK5ATBAuEusZwKPW2+w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > It looks like the problem is in fit-frame-to-buffer: it is not > prepared to handle after-string at the end of the prompt. > Specifically, the fact that the 2nd and the 3rd args of the call to > window-text-pixel-size are both t causes the function to return the > value which doesn't account for the after-string. Indeed. 'fit-frame-to-buffer' strips empty spaces at the beginning and end of the buffer - it's aim is to make the frame occupy as little of screen space as possible. If 'resize-mini-frames' should handle peculiarities as such display strings, it's probably better to write a tailored function that handles them by calling 'window-text-pixel-size' with the appropriate arguments. But we can change the default behavior as well, or provide an appropriate option. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 05:27:26 2020 Received: (at 44080) by debbugs.gnu.org; 20 Oct 2020 09:27:27 +0000 Received: from localhost ([127.0.0.1]:43565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUnvS-0000wY-M4 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 05:27:26 -0400 Received: from mout01.posteo.de ([185.67.36.65]:41969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUnvR-0000wK-7L for 44080@debbugs.gnu.org; Tue, 20 Oct 2020 05:27:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 0AD80160061 for <44080@debbugs.gnu.org>; Tue, 20 Oct 2020 11:27:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603186039; bh=HfH0BMJ6EnNQ1JuII5SEbC0DeH9hy86cOMDGhhZNZlI=; h=Subject:To:Cc:From:Date:From; b=odkMXeCGrHZiURjfsooR4lDyEUVP/eBN1uppU91HfagjRCrIXxUtXqYV8dtH2+cUm pUhPcC3Le9HEmXl+KMNXX6oM+x5E/Zkx/DlHO20TW2Tg+VQ4GwoOztb73rufmEow4L UDk9hACtU35rv3oSH35ZPQvB5O/tV+3e/55E7rp6yzf7tDpwZYXWDBi33AvaT2QMiO BA/SOVpFfOVRnQK8EnNWafea2f/urD3gXh6Peq+gzZziV/CCiMBpRJsfmKCTDUy7Gg Ad/b5Ex43Rd2XIAxNBfWE6wiy8xqwD3662zQAIJ7NuWD32P63VUpsxWPLBxEq7Gzeq DZO4rfb8DK1UQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CFpDk3RFmz9rxQ; Tue, 20 Oct 2020 11:27:18 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> From: Clemens Message-ID: Date: Tue, 20 Oct 2020 11:27:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Indeed.  'fit-frame-to-buffer' strips empty spaces at the beginning and > end of the buffer - it's aim is to make the frame occupy as little of > screen space as possible.  If 'resize-mini-frames' should handle > peculiarities as such display strings, it's probably better to write a > tailored function that handles them by calling 'window-text-pixel-size' > with the appropriate arguments. > > But we can change the default behavior as well, or provide an appropriate > option. To give some context, the current behavior is a problem for completion frameworks which want to display a vertical list of candidates in the minibuffer. They need to use an overlay so the candidates aren't considered part of the minibuffer-contents which is expected to only contain the current user input. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 10:40:11 2020 Received: (at 44080) by debbugs.gnu.org; 20 Oct 2020 14:40:11 +0000 Received: from localhost ([127.0.0.1]:46282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUso7-0001OZ-7Z for submit@debbugs.gnu.org; Tue, 20 Oct 2020 10:40:11 -0400 Received: from mout.gmx.net ([212.227.17.21]:50447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUso5-0001OF-25 for 44080@debbugs.gnu.org; Tue, 20 Oct 2020 10:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603204802; bh=C0BLG50RaXeXsETMFeHbi6jedAfJOwhZBT8grZ1g0ts=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=kALEW6SnRZHDz7HFbKX1H7ev5pyXqXD0g6sBbe/9IEb6FqOIXyVS781b8eWB08KGb J1Eg/TiI1HDPQoqIzI4ImdkVZp96IHO/6mnIIHNIAOzVrCxrNZqbXDwIzkRll8eASJ fChtHo9kSQF8fVzG6sAIbOih3CGxLbTENOS8Atbg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.112]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MqJqN-1k8Q2D1Z91-00nU0d; Tue, 20 Oct 2020 16:40:02 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> From: martin rudalics Message-ID: <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> Date: Tue, 20 Oct 2020 16:40:00 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:sIPG4jmwoG/ErPWwvZhDV6pgQSjmfRf+SIKeHowILYy/DIAg5r3 /4TYNJZo/4duT6oygg8YhkDFZllJ10CtScU0rZRKOHOxFFZOTRjueCX0LPOY0IaDV6RACwd mArbv2LBBzF6a7uHrt3ATMIqxbYZseqhKNoNc9PMLi0JoBBlb8ZAB+NYOYpM3rmtWs/0bPk tu8JfedEcD+7pM3SSlanw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:LV//Vtqa9Zw=:2raAT3KXYanDYmj3u4cbn/ q7EbB0/tLSMc87RNJlj/KnxrVVVxQQo8GWIlA/M/pcsJfLORcaEpL+LPcBUl2TOwWAgkjYQx4 SzuNnyP6rLYyuxprSPZp39Htzd+ibY0Km0ZZKPlkBR/4V4l2kN0y5DNmMkUMcxCyc9b2MuYRI 27oh60WDxBDq5S9VS+gm+bAPEaUdyNz2Tm8oJwBmLd0BV4L35GO4AYVlkwhZXI2DO3MiS3bmC bnLkUzUXa+PeqjvTy7iUxY1zm7xnWtg0NpMt7dJ4l8pw6j7sZKXCH/dpCrETLejJek7MHTQMN v262gD7ZIq63z2WxCPyuTorysWN60gQqHHIc2i46ERyNM9r8eYftKrvRJBFiYy1fnkyYGjHMj 5Huk6OyQ+pwPfvfIfzFCpLJGlR2xb3lpRS+ppXuIYARng4i4zCyZ4hUVnFZ3PwqpUAoicEVOu 3DIcE8hM2Fyflbnq4GDJgA8cBKqfATCjhSdl/SE0Q8YgXsykMOhuq8mI+8lBjVX3KjSURK4HG JzXPfjo7dvLGmD0bkjx6gUJWXiNqGEWdb+1kT7gJDb9sQp3iSUTJ9ZAxkTseerNYvEvssDJcF RfUKinlfgpC9XVrk18wynKp5ThU3I69EoIzoDSkdFEbrqrd7iK/UmoOhDTz01i3NPrzSiHG+n Oi7HEESSNPzpbTqGZDjt/if3Uh0TfLPmEFH9TuZA0Wg572zzH3xzxhwB8G393zUklmOPWacZX 6mEH4CeaG6Jbn7aGJKe/6nnnjZXUSFHjIsCiwyKrJ3wPzbfXHg++K0cL+hvX2DSyBQ85nkKWm iCLxoEpvbtgzgF7QR9do2B/sFafStv1SjYMKmVFhUp1SMa8PLfxXD3oXx14wHZQXa4rLNma50 VKTt3xhHiSOKEokkzSsQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > To give some context, the current behavior is a problem for completion > frameworks which want to display a vertical list of candidates in the > minibuffer. They need to use an overlay so the candidates aren't > considered part of the minibuffer-contents which is expected to only > contain the current user input. I've never used such completion frameworks and thus I've not seen this problem so far. Yet I'm using a separate minibuffer child frame which I resize by calling 'window-text-pixel-size' with both, second and third argument, nil. We could do the same in 'fit-frame-to-buffer' but this would be an incompatible change for the latter. Can you nevertheless try running with such a change so we can tell whether it fixes the problem? If it does fix it, we can either provide a separate 'fit-mini-frame-to-buffer' function or a further option to set the function 'fit-frame-to-buffer' calls to get the size of the frame's root window. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 11:19:32 2020 Received: (at 44080) by debbugs.gnu.org; 20 Oct 2020 15:19:32 +0000 Received: from localhost ([127.0.0.1]:46394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUtQB-0002Rs-UH for submit@debbugs.gnu.org; Tue, 20 Oct 2020 11:19:32 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUtQA-0002Re-JY for 44080@debbugs.gnu.org; Tue, 20 Oct 2020 11:19:31 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 2B8FC160062 for <44080@debbugs.gnu.org>; Tue, 20 Oct 2020 17:19:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603207164; bh=Sc/THT9nT1awpeB/cckLyaw4nsoui/d3WnGNne0UBDA=; h=Subject:To:Cc:From:Date:From; b=EgWzTO0NCgIZKxoAukkfpoKxmcJwkzb0KeU3A0dgAdf1VliaCOL7SSCnzuIGQKekS RqQ7hkkaDKb0zpPdiTsxzQhUirVyzZEu8C+4bWjhkV2nP4aflKsiAA9opTLnhp5V4A osBlTQaWUFA07vH+PlXZJ1onj0ojfYhqtBFVU9WJPGCuaKBVZJorvzHRQxPjUZn5lY OYM++9zNcvoTRZ1ymPKvXbHxUm8g+Qlj09/qGCDNoP/l8O7llKcuYkp+tGRnWR6nlB PoorzE7oAhmjGVVEXBCSafSwTheuZA2AoDDh8XZ0iid4cYkdfc08A17cekSx6sgACM gOCLsbLCK1k2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CFy2z3HNDz6tmV; Tue, 20 Oct 2020 17:19:23 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> From: Clemens Message-ID: Date: Tue, 20 Oct 2020 17:19:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > We could do the same in 'fit-frame-to-buffer' but this would be an > incompatible change for the latter.  Can you nevertheless try running > with such a change so we can tell whether it fixes the problem?  If it > does fix it, we can either provide a separate 'fit-mini-frame-to-buffer' > function or a further option to set the function 'fit-frame-to-buffer' > calls to get the size of the frame's root window. Setting the third argument of `window-text-pixel-size` to `nil` fixes it. Thank you both for the quick response and your help finding the cause of this! Having a size function sounds good to me, ideally it would already default to avoid skipping whitespace in minibuffers if your think that is reasonable. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 13:02:11 2020 Received: (at 44080) by debbugs.gnu.org; 20 Oct 2020 17:02:11 +0000 Received: from localhost ([127.0.0.1]:46616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUv1X-0002mV-Bp for submit@debbugs.gnu.org; Tue, 20 Oct 2020 13:02:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUv1U-0002fj-Ty for 44080@debbugs.gnu.org; Tue, 20 Oct 2020 13:02:09 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 0F81116005F for <44080@debbugs.gnu.org>; Tue, 20 Oct 2020 19:02:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603213322; bh=dnvMDnZKtxgm6BEeXD2pD9SeLhOmeOzpwnlX+6q16/U=; h=Subject:To:Cc:From:Date:From; b=QCZHzfMA0/9DGZgd4edKMl7CT9qPFCYxUEpNKvYrCFBUm/v4b6zW8Ijl0dhkRufCK o0shpL7Y7/DBlxCK9pAAsuT/YfDniCB7hitYhDdwdUCsJhq22xsSdk1yhumL0QZkQ2 60C6UeIthnffiOJE5NJMFxiJdkADv5nDyrsA4ejWPyvhVjCgT/t9oCoUPxBGDt+rJh GjV4+xZKoUrt9Qh4PtrVTlPH4X5XA5MFEVQkyoxOlHzAp3uhVTx9BZSG4r/PKGeDpY 3uezBl1CYv7Lm5zbu2+LyniVM8ZlBUfoDViiYOi8X+7le5ME/FdgDYUJ81QQaA3ZcC Li9JMlY//L0iA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CG0KP2skxz9rxh; Tue, 20 Oct 2020 19:02:01 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> From: Clemens Message-ID: Date: Tue, 20 Oct 2020 19:02:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On the other hand if you think it is reasonable to do this in minibuffer frames by default you could also change the current behavior in place to avoid adding another option. I can't imagine a scenario this would break some other use case but who knows...For now I will recommend users to use the following workaround: (define-advice fit-frame-to-buffer (:around (f &rest args) dont-skip-ws-for-mini-frame) (cl-letf (((symbol-function #'window-text-pixel-size) (lambda (win from to &rest args) (apply #'window-text-pixel-size (append (list win from (if (and (window-minibuffer-p win) (eq t to)) nil to) args)))))) (apply f args))) BTW, the completion frameworks I was referring to are called selectrum and icomplete-vertical in case you were interested. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 05:11:44 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 09:11:44 +0000 Received: from localhost ([127.0.0.1]:47935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVA9o-00055M-Fc for submit@debbugs.gnu.org; Wed, 21 Oct 2020 05:11:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]:46443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVA9n-000558-AK for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 05:11:43 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D3F6F240100 for <44080@debbugs.gnu.org>; Wed, 21 Oct 2020 11:11:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603271496; bh=i5c0IVmRmSvQ7Z4rdn+rbG6LZEscunqvffkqnhmzTYQ=; h=Subject:From:To:Cc:Date:From; b=mXpkOvAeJhyFzzH/f7dje3kFIJ43lJZi9wJjEE5yQC7OZXvbnvDiUzvKY1R20YBK4 QGsE06PaGbNAvLr7Q58gCnC+uUz+BpmNV9aHkCPa1Kx9CFgCmQhyjLGLVxRBRm0qSZ bCGTRKGxiA9Bbv0ue4K3Wci1FsUj8Gu+kknbiz9YHipJ+6XuMlvmHsQ7g3cEwA4FMT wEL4NdAsVS9oSWjXn83nTJUKW/0k8JBHzm5Swwf5YW5yQHUXaSPCKKYu0J4b3EP5hb rG3igIYVHv0e0cWUVDmvNyFkXyk1tl6fUsUCCB0+6/1DJMHyB741O47Qv9l4+LrEoG 8MjIuOabhPipA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CGPr80x0cz6tmt; Wed, 21 Oct 2020 11:11:35 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames From: Clemens To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> Message-ID: <10267321-400d-5d36-1558-070a24476a03@posteo.de> Date: Wed, 21 Oct 2020 11:11:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 20.10.20 19:02, Clemens wrote: > For now I will recommend users to > use the following workaround: > > (define-advice fit-frame-to-buffer (:around (f &rest args) > dont-skip-ws-for-mini-frame) >   (cl-letf (((symbol-function #'window-text-pixel-size) >              (lambda (win from to &rest args) >                (apply #'window-text-pixel-size >                       (append (list win from (if (and > (window-minibuffer-p win) (eq t to)) nil to) args)))))) >     (apply f args))) > The version above invokes infinite recursion so I would rather recommend something like the following for affected users (to avoid spamming this bug report with other versions here is the link to the corresponding issue on selectrums side: https://github.com/raxod502/selectrum/issues/169 (define-advice fit-frame-to-buffer (:around (f &rest args) dont-skip-ws-for-mini-frame) (cl-letf* ((orig (symbol-function #'window-text-pixel-size)) ((symbol-function #'window-text-pixel-size) (lambda (win from to &rest args) (apply orig (append (list win from (if (and (window-minibuffer-p win) (frame-root-window-p win) (eq t to)) nil to) args)))))) (apply f args))) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 09:49:11 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 13:49:11 +0000 Received: from localhost ([127.0.0.1]:48284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVEUJ-00084b-1G for submit@debbugs.gnu.org; Wed, 21 Oct 2020 09:49:11 -0400 Received: from mout.gmx.net ([212.227.17.20]:44259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVEUH-00084L-5z for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 09:49:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603288141; bh=rXYGJyMSa9FLga3FXbq7IaVLpgFkeJedlakH3EsLzTo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=U5Z1XTdbO86GTWpXsJXto4zq9A46P4L/QILxH27elnENthpo1gNABtpC96WHAmvJp zpJpkleRT4vQQMH3PRmrkce1I5zZk5OKSPSBWgJP1aVCJYuhQ86vqvFapRf+KQFsJA 3lePe04A5UsjT/EdBLEatCuPQCCoy/hZnI5b6UD8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.31]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDou-1kBcAf2l4q-00xaOy; Wed, 21 Oct 2020 15:49:01 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> From: martin rudalics Message-ID: <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> Date: Wed, 21 Oct 2020 15:49:00 +0200 MIME-Version: 1.0 In-Reply-To: <10267321-400d-5d36-1558-070a24476a03@posteo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:c64DaJkGDSUUXjGoacJmO41N98e+1TukqmrLOGWhMYEtqt6NdgG MWPMqcExX7LybFsqPL9QneZdJIcJDj+4zy0CXrwqiA/03ed6Xmhys2g0uIGfSOUvaFdtLT5 O1vUjAxw4OD7H5taJynT1u5O0aN/6UVUSu/iRuHovP6AMqFFppRpQ/IFQnxM3HKXHJ2j5z7 LWuJAJYvLbm5iH/pPscLQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:hQNxuJaPOTw=:yRaicER5mAejTrpv3zEZ8/ ibHjifd7+n5jNGDo4/8wzqdAKDTMO7hKEosnY7sdYCnwt11im6Suiu+VfYGg/7usNYZWwgGhA xzWa9xmbbDx9+x1RG2fk/1BeJHjrGtmhvExwlgR7ao2wSYcfGZBd+PoCC7lfLPgj/aGj/iNJZ 98zRG1JpY4j7iRn7BZpohQcsYL/vN40OtBrcl+7LsOtoTA9wefv4i3dKkzvy6/aZY/x5jYfLW LT57tI7qyEVgIjAUw0ik6MsM9GSOB+c2XGwJrZxePNoq/1wBfBSRrsWtOLwQme3BhQUbYgS8e ful3llS7QsyKq54M1GPkRarP6bZ4wAVx48shGkFwItBa1nncltYOhNpG0lQLVpFrZcELJpPmQ lz1mGj3fWq6J+ufTYZpkn8uDejBSyROrShodNsulMkn3vFSFZ3yyamw9SoA7SaITBQtRm4Osa CDCUwq2atE2BvDtAbsm3g7ja2R/thYrIy+yqK0jk/I2W6oBbK45ncqkWZk9ErfQspTsI5g//U TNzQA+VH2xqAVF0Rb9iSLN99ZZqwUFAmWEOTg0A1W1zvM39jm0nRzgyRznlog95ZCeI4FBLWL 3zKRGVn5YePARk8V0oHc3UPOJ3ASVeOkwtZqRYXMzdmDR+Lsv4ekjP4Xc2TlcKDVh2Av/rJ3/ FQOwTp85OTG78xmxb/PcDGi2PRtD9b3iDlgGFZspt6DKWPjXiOTtKLVTyUclF6xekW9R5IhrH 5GsfMgRWqPirIQ6RgID1kV+zGrx8HxSrdn6iwQhMMXp1hUr6YQQh8tLMVw9z4ItWZj75EppuE YO04yQNEnzWTx4bn8uAQ3pwsOJvcEnw254dFbWKwFCEXh9xcLiqde5UxqggXFERdkBuxqLPaA 5bBMdHyxrzrOtBSnLXlw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The version above invokes infinite recursion so I would rather recommend > something like the following for affected users ... IMO advices are much too complicated to handle this issue. I'd proceed in the traditional way: (1) Rename 'fit-frame-to-buffer' to say 'fit-frame-to-buffer-1' and give that function two new arguments FROM and TO. In its 'window-text-pixel-size' call, replace the "t t" with "from to". (2) Provide a new function 'fit-frame-to-buffer' with the same singature as the old 'fit-frame-to-buffer' that calls `fit-frame-to-buffer-1' with FROM and TO t. (3) Provide a new function 'fit-mini-frame-to-buffer' that calls 'fit-frame-to-buffer-1' with FROM and TO nil. Offer that function as first choice when customizing 'resize-mini-frames' and call it in 'window--resize-mini-frame' when 'resize-mini-frames' is nil. If 'fit-frame-to-buffer' has additional defects when used for resizing mini frames, we could try to fix them in 'fit-mini-frame-to-buffer' as well. WDYT? martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 10:13:40 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 14:13:40 +0000 Received: from localhost ([127.0.0.1]:50113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVEs0-0000ha-BL for submit@debbugs.gnu.org; Wed, 21 Oct 2020 10:13:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVEry-0000hN-MC for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 10:13:39 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id B45222400FB for <44080@debbugs.gnu.org>; Wed, 21 Oct 2020 16:13:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603289611; bh=Kc9C/4TBnYXsQW2zZaQMuGJC31iEoFPV9MpPlUkTZ8g=; h=Subject:To:Cc:From:Date:From; b=MzdS9bJLGPD7lXBLznaKwXBRAyrJlRAHvhjmI8wR/DncB4Q8HDWiiOqUwXjGDGLYT hwN9AeC5NF1hCghI2MnvPVo1J3urrR8mhMS5X1m0YlnhRt0PZK1gaS7dDVj4/ax7xp j27EIt/1ymIoiZeRUxnZ1MfeoDf3TFjXu3k52cMzDQpi/YuJfiXoLTAEmYDuEh05fP 1exUfjnt2CMFXhWy/xKflwEQ+lDoKrx1+AdNulLIvCjpV/lgsYi709iR7c73e+KzAB Nc7Tk6bZKGgjsqCk6IOFilvoScVES7eRMSjue023TAo0AAsr2iik3vnpJukQDlx/yG nAHVcmGZnndpA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CGXXW0Y8Tz9rxX; Wed, 21 Oct 2020 16:13:30 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> From: Clemens Message-ID: Date: Wed, 21 Oct 2020 16:13:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > IMO advices are much too complicated to handle this issue.  I'd proceed > in the traditional way: Oh I did not mean to propose that as a solution on the Emacs side, sorry if that wasn't clear. It was meant as a temporary workaround for affected users before an official solution lands. > (1) Rename 'fit-frame-to-buffer' to say 'fit-frame-to-buffer-1' and give > that function two new arguments FROM and TO.  In its > 'window-text-pixel-size' call, replace the "t t" with "from to". > > (2) Provide a new function 'fit-frame-to-buffer' with the same singature > as the old 'fit-frame-to-buffer' that calls `fit-frame-to-buffer-1' with > FROM and TO t. > > (3) Provide a new function 'fit-mini-frame-to-buffer' that calls > 'fit-frame-to-buffer-1' with FROM and TO nil.  Offer that function as > first choice when customizing 'resize-mini-frames' and call it in > 'window--resize-mini-frame' when 'resize-mini-frames' is nil. I did not know `resize-mini-frames` is already allowed to be a function, I don't use that feature at all so I'm a bit clueless about possible settings. It doesn't look like `window--resize-mini-frame` is called anywhere? Is that function meant for users? > If 'fit-frame-to-buffer' has additional defects when used for resizing > mini frames, we could try to fix them in 'fit-mini-frame-to-buffer' as > well.  WDYT? Sounds like a good approach to me. Thanks for thinking it through! From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 11:00:39 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 15:00:39 +0000 Received: from localhost ([127.0.0.1]:50202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVFbS-00040q-Sz for submit@debbugs.gnu.org; Wed, 21 Oct 2020 11:00:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVFbR-00040e-U2 for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 11:00:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50521) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVFbL-0008NS-GB; Wed, 21 Oct 2020 11:00:31 -0400 Received: from [176.228.60.248] (port=3995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVFbK-00089F-GC; Wed, 21 Oct 2020 11:00:31 -0400 Date: Wed, 21 Oct 2020 18:00:41 +0300 Message-Id: <83pn5bmxnq.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> (message from martin rudalics on Wed, 21 Oct 2020 15:49:00 +0200) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: clemens.radermacher@posteo.de, 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 44080@debbugs.gnu.org > From: martin rudalics > Date: Wed, 21 Oct 2020 15:49:00 +0200 > > (1) Rename 'fit-frame-to-buffer' to say 'fit-frame-to-buffer-1' and give > that function two new arguments FROM and TO. In its > 'window-text-pixel-size' call, replace the "t t" with "from to". > > (2) Provide a new function 'fit-frame-to-buffer' with the same singature > as the old 'fit-frame-to-buffer' that calls `fit-frame-to-buffer-1' with > FROM and TO t. > > (3) Provide a new function 'fit-mini-frame-to-buffer' that calls > 'fit-frame-to-buffer-1' with FROM and TO nil. Offer that function as > first choice when customizing 'resize-mini-frames' and call it in > 'window--resize-mini-frame' when 'resize-mini-frames' is nil. > > If 'fit-frame-to-buffer' has additional defects when used for resizing > mini frames, we could try to fix them in 'fit-mini-frame-to-buffer' as > well. WDYT? SGTM, if this fixes the original problem (as I think it will). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 12:05:55 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 16:05:55 +0000 Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVGcd-0005kV-4C for submit@debbugs.gnu.org; Wed, 21 Oct 2020 12:05:55 -0400 Received: from mout.gmx.net ([212.227.15.15]:51397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVGcb-0005kI-7O for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 12:05:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603296336; bh=coOxT++3Bia4jq/38gsg3tZ51s7uhyUCwDGWTlmP4MA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=jG7TDjrI1Uu1BLGE91PEd6AtAhQ4PLzMLwBJzcQPOEw+pL3QKr/CbALZzL15L2LjT vDamQsO7pvKiAaO+JIYU5dgMYC3kBEHBXprVWm1Pv6KluD2jJvWS5qTvLv2+pwyM58 v0pWXC0nmXvjvzRN/8q8xjl82iduXvHtbAy8/hBY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.31]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MG9gE-1kcyGC2xYa-00GdQc; Wed, 21 Oct 2020 18:05:36 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> From: martin rudalics Message-ID: Date: Wed, 21 Oct 2020 18:05:34 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zgYsf0f0njyqGy2QvJ6K0mZ3gV41N/4TcnoPKLW6afbbNUuH1dP V63R7rbppSIH7DMQzTudUzI9ELFLQZGo+JPu+sdbjuo7c+AS5DTGWnmm4YomFMGsE3+F5xt lkX98IxWQ/j4EGcefmllRv89gal0gD3hflG5vjCZutqludw7AbJ4freQzM6LWYDqhN7Ub7B aYCLfWox/ZIU25Lcj3i7A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:rvWxMVUO8pY=:kzxeD9A4uNvNIWz8uQpXZG SzAqbFxP+b+fhXTJHFJkJDHd1kp7ybVb/K0YT62KCRtl2LQ5Rx1HE/capDgJxzYF+AJIqx6bM ZVMRm0EGHhipi2sr0Mi9f1gzDUWZl06C5GHREa482+2qEVDTRGJTa568hOsxKo65BJ6ddEhFH ENQlVg+eTct2EAiU96cyWMyWuYelZV1AioWqqITj8C9+qaGUlzlPLk1Q2g3vWcdO4yGsCgKpx pcblkCWEi35lH47pHT4OEPwjPBy+L7PA6Yvj2x0HfJb1JiJRap0IUmdSd5Ikwqf2QHLlRYVZS W6E+cqnQoNw6vmqcyKBzvRU1KD5Mxvg//lt9k5/so17L+BXKih8b6OGAj1iZ7hXCbou1Akq/I cwOUHUHML5q9UyWOns2i1w0agc861oriADJUbIITm10+AcHK22Vm3fmjF43jrmPzUg6+B5s4y ahEjIoqhAIYRGBNVpUZY29VmtfQcSB5R5AXCokpc47w5+0q0M1FMa8reTBPyhokCJDsnF27BA 2SJIEHK2ulkUU2t0L6lVz1t5sb1ocLmu/5a/hgr1R7l+6K0/iaGZA4ovuZi4jjc1/jbogjbYu GyqrbeH3KiVRVNkb+mX+tDSvdCG9YR4TpVD8BYmnglrPr+2t2iNeA85CdUMK1MJkI1zJntCxL VBG+5lPM1p3YxoHFSRVzLubFfVOxzA7V17COwpmQ9C/DgnPU5BYBRKIFX+/iuraOjCEYCrq10 +C0GKx6Koyazkoppu49eCdMHQqUbcwOlO34+MLFLaswxZvgsO4gAroqHXxMkCbHOpa8xBrXr5 ExRN9Nfnp+vZaZBifjy448MJ+yqUw6rIqzYECzJz2vNDYfJa5DHGaNaA9ipr8GULSYHBIKBHG u6q23e57Pgby36GIjGvQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I did not know `resize-mini-frames` is already allowed to be a > function, I don't use that feature at all so I'm a bit clueless about > possible settings. It doesn't look like `window--resize-mini-frame` is= > called anywhere? Is that function meant for users? Yes. For example with my Emacs 27 it's documented as resize-mini-frames is a variable defined in =E2=80=98C source code=E2=80=99= =2E Its value is =E2=80=98pop-up-mini-resize-mini-frame=E2=80=99 Original value was nil You can customize this variable. This variable was introduced, or its default value was changed, in version 27.1 of Emacs. Documentation: Non-nil means resize minibuffer-only frames automatically. If this is nil, do not resize minibuffer-only frames automatically. If this is a function, call that function with the minibuffer-only frame that shall be resized as sole argument. The buffer of the root window of that frame is the buffer whose text will be eventually shown in the minibuffer window. Any other non-nil value means to resize minibuffer-only frames by calling =E2=80=98fit-frame-to-buffer=E2=80=99. >> If 'fit-frame-to-buffer' has additional defects when used for resizin= g >> mini frames, we could try to fix them in 'fit-mini-frame-to-buffer' a= s >> well. WDYT? > > Sounds like a good approach to me. Thanks for thinking it through! Could you try coding it? It's straightforward and you could test it immediately and possibly discuss it with the 'mini-frame-mode' people. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 13:20:15 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 17:20:15 +0000 Received: from localhost ([127.0.0.1]:50437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVHmY-0007lR-T5 for submit@debbugs.gnu.org; Wed, 21 Oct 2020 13:20:15 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVHmX-0007lF-VN for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 13:20:14 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 44065160062 for <44080@debbugs.gnu.org>; Wed, 21 Oct 2020 19:20:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603300808; bh=d+aedShX1XzF6WWzBFthZrWKlWkr2U4MdWhUPtX6QQg=; h=Subject:To:Cc:From:Date:From; b=ef7FtSoazW7yPG+V58oJ8ScDGjNKfhyJcQF55gZ5epoCOz4iH8GNNvRFBQDWYCei8 cXpr8/wNK7ymGdxD3vDgzu0xYwsLp6smtrZ6jptvOLXQkIgPuoecMHEXuHolju6AN0 50vdRIID1kVECO9setaXwT4Qgeltb//BacEBLo8Uj8otCReoRqif7nyMLNTt6xQPwS KimJ+naTBQ7PZr7YrpEj1JmpA507I0hU2DvIv0l8xv4QgRnDysEAVeVUIyxip31vl/ dh5BEAnjja3OgyygNlxkXUrjxYP8+UGOsHvElCyzIywqu5NaeugA56YunHQiLkpOw/ fIXxPNGMnjBpA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CGcgp6dXkz9rxx; Wed, 21 Oct 2020 19:20:06 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> From: Clemens Message-ID: <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> Date: Wed, 21 Oct 2020 19:20:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I did not know `resize-mini-frames` is already allowed to be a > > function, I don't use that feature at all so I'm a bit clueless about > > possible settings. It doesn't look like `window--resize-mini-frame` is > > called anywhere? Is that function meant for users? > > Yes.  For example with my Emacs 27 it's documented as I was referring to the `window--resize-mini-frame` which I couldn't find any calls for. > Could you try coding it?  It's straightforward and you could test it > immediately and possibly discuss it with the 'mini-frame-mode' people. I can do it but I'm not so familiar with the Emacs development workflow myself. In this case I would clone the latest Emacs and then export my changes as a patch and send them here right? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 13:25:36 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 17:25:36 +0000 Received: from localhost ([127.0.0.1]:50444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVHrj-0007uH-U7 for submit@debbugs.gnu.org; Wed, 21 Oct 2020 13:25:36 -0400 Received: from mout.gmx.net ([212.227.17.20]:57121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVHrh-0007u3-CB for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 13:25:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603301126; bh=eN4tNJ/cIQBp5OyCDCRbeqtgNSUuxY+O9fbP5UcdTM8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=In9uhL3IOb8GcG2Dk0+usakwav6m5oee25jyWah/037gpv793TmDJPwZdHgj/HdKF ESe4ZFVD1QLgL4yTqoqOjQVBgMx30YIazmYzbFuQVIcYg0tM+EZJ6b5NAB+SYnT9Sb TnKrKb+YQAwK9JBmHzKUjypp9vTFRP9AWRjdLayg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.31]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5VHG-1kKsbE1QyI-016tyC; Wed, 21 Oct 2020 19:25:26 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> From: martin rudalics Message-ID: Date: Wed, 21 Oct 2020 19:25:25 +0200 MIME-Version: 1.0 In-Reply-To: <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:hl5csotjtZlxFJAhqOM13dIjqvKEMKEiXj2I2Pw1qgZgt2vtjoo Hivijw6XPLvNdKGUXgGKoB3We9bymYvzmWyayyVVcRXksW48kygnIZvC1KDAljsxMAnrHNi dcdAXTZKXNmxwW/9OwiEORqBLFUMLkwnS987Mwj2+yb2DcaEHK1cIJP8UtyDFq6d4LCrBQC 0mHDntcmutpNwjyO8rm8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wIuMwyyrzzo=:lh6t5FHi12Fre7wOt8aP2s xYsUwPnJMvJwfl8CodbAHAUHkEWuCGymb9Jlm/jhH3UGq6+yb9BQWOQ61oM9vAY7wZNETPkU9 l3sFD1gqK8LQSKWfuF1H8pu2sjElxIfcKRlilQkHLugohemeEjg3SSgRdamv3KA+INisRpEaK w5j62F+P24ylKPc44rIPE6eqGU+UMPMgPOWO/aUGsR2ovMimlAJZZe46ieN7eGlLww5PB/Z2a xtZnJBepizKwCTOR8uBLaeW0f7uEvlmMvjHivP2l0Lr+WaIWHG7M0q7Fgf8Sw1wt8BpWMvckg yqw5LHbEHzd1Ck9dqQklThN/SfGuOyO5rvrlw/vxP46+lz7ciJemfhcijb8AXqdOW1TMudV4Q 7YUjfhUa3B4iYFabi3iEEAPNHYgGZIva9VLB+b+WJkdBNWnC4RsJwpDHh5I86fjKy0q9n8EkD SMBBnfN0jREfOyRKgO86B42MqVHyGZ9CJVPTY/UkjhN1x6+6xo0Of5YDkXArBFCh8G4nzcIhS BOjbIqiqKMdkXjxYj5uGeFZmskNj2MTNIseLNZyHY0EjiolLMca9HkNUDXTJrDJmKMNW01zKQ IuMVxnbhHVbqnfY5uZlcd0xBsNzCCLJ3DWjja6N1/RLArgdz5uxlQosoVoCyd1PZhD+89CZ9B ytdRmU6lmkM57paDy/hx/yzSey8RMJjulXt9sCvA+d7novkGLaFcT5txShEam2zNyFBeUTM4w K5WPlEggZeQAbB3+M5Zr2WvRMzWnD5KGCG/PtZADwB4yaUDhd+4rEhiDb4CL1zODbnZ4bGSF6 IhhDN/aEgJx440vyREn1KWhfj5TnLMsuUKxXTvAzKuw1Q25bBVrijGIryPoDMadKpfFbmMo5H vKxMoKxqLDL4h63PA7KA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I was referring to the `window--resize-mini-frame` which I couldn't find > any calls for. It's called from xdisp.c as if (FRAME_MINIBUF_ONLY_P (f)) { if (!NILP (resize_mini_frames)) safe_call1 (Qwindow__resize_mini_frame, WINDOW_FRAME (w)); } which represents one of our ways to call a Lisp function from C. > I can do it but I'm not so familiar with the Emacs development > workflow myself. In this case I would clone the latest Emacs and then > export my changes as a patch and send them here right? Right. And if you have any questions, ask here immediately. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 15:45:22 2020 Received: (at 44080) by debbugs.gnu.org; 21 Oct 2020 19:45:22 +0000 Received: from localhost ([127.0.0.1]:50628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVK30-0000yf-9q for submit@debbugs.gnu.org; Wed, 21 Oct 2020 15:45:22 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:44110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVK2y-0000yP-Ih for 44080@debbugs.gnu.org; Wed, 21 Oct 2020 15:45:21 -0400 Received: by mail-lf1-f41.google.com with SMTP id b1so4562394lfp.11 for <44080@debbugs.gnu.org>; Wed, 21 Oct 2020 12:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=L3Cyy/UfxjX+pmnCqOlGSkB48K7Sg4mgGPsk4VWM9Rc=; b=IJVszRAeUJPFhXPR6a39p1olot5hF6l+dPKgKuyDrZ60denTPyktd/vNEfaZL7JWpW KuYWU+QGUzCi7o3zZHxdcADSEhSDGDkdOb3rsuP8Zwwa0kqtJknXCga4VGQgusVfAFr7 bsQNjUzES5ScwF38yV1djvl0smHsiDtHCxXnR8WKodElHD/hlYP3y7PQ5ntIAkTwe2ZJ 5Mp7NuDHsxOUIPfM49ete6sI7+euVHB1Xzj01YvmAzA+/9g11Ns23EZbIO4v+tU82FUx AnWhR31/bqh5uCAXItnvlkkHFPxfURVXisRZGIExy3+f1EOknu4VZI/c6XD0WKJtcPqz 1M3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=L3Cyy/UfxjX+pmnCqOlGSkB48K7Sg4mgGPsk4VWM9Rc=; b=gfihCoJZND6hb3rbhME7Z8gvxwcy0V0B6x4495prIglZrLyXgZfRPbhJ4tMPZt8wff pHgsC4SZ68F4KVya0kM+6lDBx2tMBVi8qkBXwIvjC9CHHIbIzhAsldkh2imC33ASK+Uu LWBIMnzM9KJgPKZ4uEz4iVu8uZxbMfiFLgK7Gb3hMRp2QIz2DmoKU7r5WimG9Yjga7xV BCKGlsnEDwDLLlsaa4c0FfzaDrQDKBKZJgDfe1rubvUmXIjb/d/B6h6tg3z33h6wTZNM 4xkE3Nfa+65JJo32Ru688DJBLnuCCMuLohNe9Vzivcnt925IrTYpcBNT0YybkC0xaAHt 9UxQ== X-Gm-Message-State: AOAM531+o0p5aXfTcIRRt89RNKrvT/vf1zNwqeWffIQj2sdkL6sRGI3G Z0A7ZpMZtDZ7evdbO7D+2Yey+Mzc9Fw= X-Google-Smtp-Source: ABdhPJyQ04UcS+sZGaWbB0wU+yHgqUkvKYc/MESOWqXjCiCe3gE88fKBtaaji2Ax70WULMbOswJjmw== X-Received: by 2002:ac2:4e90:: with SMTP id o16mr1939182lfr.251.1603309513992; Wed, 21 Oct 2020 12:45:13 -0700 (PDT) Received: from muffinmac ([91.206.110.168]) by smtp.gmail.com with ESMTPSA id 76sm538997lfn.128.2020.10.21.12.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 12:45:12 -0700 (PDT) From: Andrii Kolomoiets To: Clemens Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> Date: Wed, 21 Oct 2020 22:45:11 +0300 In-Reply-To: <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> (Clemens's message of "Wed, 21 Oct 2020 19:20:05 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44080 Cc: martin rudalics , Eli Zaretskii , 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Clemens writes: >> > I did not know `resize-mini-frames` is already allowed to be a >> > function, I don't use that feature at all so I'm a bit clueless about >> > possible settings. It doesn't look like `window--resize-mini-frame` is >> > called anywhere? Is that function meant for users? >> Yes.=C2=A0 For example with my Emacs 27 it's documented as > > I was referring to the `window--resize-mini-frame` which I couldn't find > any calls for. > >> Could you try coding it?=C2=A0 It's straightforward and you could test it >> immediately and possibly discuss it with the 'mini-frame-mode' people. > > I can do it but I'm not so familiar with the Emacs development > workflow myself. In this case I would clone the latest Emacs and then > export my changes as a patch and send them here right? Clemens, if you'll keep the name 'fit-mini-frame-to-buffer' for the new function, I (as the 'mini-frame-mode' people :)) can replace the call to 'fit-frame-to-buffer' with it in the 'mini-frame-mode' right now. So you'll be able to test the new function once you implement it. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 22 08:40:05 2020 Received: (at 44080) by debbugs.gnu.org; 22 Oct 2020 12:40:05 +0000 Received: from localhost ([127.0.0.1]:51704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVZsy-0004R2-Sz for submit@debbugs.gnu.org; Thu, 22 Oct 2020 08:40:05 -0400 Received: from mout01.posteo.de ([185.67.36.65]:51682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVZsw-0004QP-PZ for 44080@debbugs.gnu.org; Thu, 22 Oct 2020 08:40:03 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8E68716005F for <44080@debbugs.gnu.org>; Thu, 22 Oct 2020 14:39:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603370396; bh=zjug8bFVoDkp6c0XwFGU0yJRwZY9Y6KcLVR4QGlYGiU=; h=Subject:To:Cc:From:Date:From; b=Sqf1nKs5prAanM+79jr+Ndp0rEHB29pahcM/ew/jlcv+KX75GzVPkQFdQvckk7ykn zjbrueaSGW6SZyeDoFO7GwQNAOhiNmEYgtH35v01oniDbVovL2jGO6qg0gCHD6Ixe+ V4gBeeaZKhh5QHHV5uiKZEI4CKmBuFbIDTktiPhv7pC3ZRvgFpkCsY67Vtw1Blgjtz /NWvJhDLURe+6gfDSUp9ULD78c057Xd2n/71EQroXA8Hjmcrf/a83YDtm7YXlbxFlw e8afMhuHQcy2qbxkSMOf2/MeTcUw4+snyKm8TjAkwcd7iOMtm6TX2OSRHp2Nzza4Cm P8CCpPGYjKD6A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CH6Q36CXPz9rxr; Thu, 22 Oct 2020 14:39:55 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> From: Clemens Message-ID: <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> Date: Thu, 22 Oct 2020 14:39:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------DD2D6A4F10C55E96A22B0CF0" Content-Language: en-US X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) This is a multi-part message in MIME format. --------------DD2D6A4F10C55E96A22B0CF0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit > It's called from xdisp.c as > > >   if (FRAME_MINIBUF_ONLY_P (f)) >     { >       if (!NILP (resize_mini_frames)) >     safe_call1 (Qwindow__resize_mini_frame, WINDOW_FRAME (w)); >     } > > > which represents one of our ways to call a Lisp function from C. Thanks, for some reason `debug-on-entry` did not invoke the debugger when I tested it. > Right.  And if you have any questions, ask here immediately. I never dealt with the C side of Emacs and you suggested to offer the new function as first customization choice for `resize-mini-frames`. I guess this needs to be done on the C side as the variable is defined there? I have attached the patch I have worked on. Let me know how to proceed and thanks for your help! --------------DD2D6A4F10C55E96A22B0CF0 Content-Type: text/x-patch; charset=UTF-8; name="mini-frame.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mini-frame.patch" diff --git a/lisp/window.el b/lisp/window.el index 1fcfffcb53..b7d4b4d26f 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -3432,7 +3432,7 @@ (defun window--resize-mini-frame (frame) "Resize minibuffer-only frame FRAME." (if (functionp resize-mini-frames) (funcall resize-mini-frames frame) - (fit-frame-to-buffer frame))) + (fit-mini-frame-to-buffer frame))) (defun window--sanitize-window-sizes (horizontal) "Assert that all windows on selected frame are large enough. @@ -8925,8 +8925,17 @@ (defun window--sanitize-margin (margin left right) (declare-function tool-bar-height "xdisp.c" (&optional frame pixelwise)) +(defun fit-mini-frame-to-buffer (frame) + "Adjust size of minibuffer FRAME to display its contents. +Unlike `fit-frame-to-buffer' FRAME will fit to the contents with +any leading or trailing empty lines included." + (fit-frame-to-buffer-1 frame)) + (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min-width only) "Adjust size of FRAME to display the contents of its buffer exactly. +Any leading or trailing empty lines of the buffers content are +not considered. + FRAME can be any live frame and defaults to the selected one. Fit only if FRAME's root window is live. @@ -8945,6 +8954,12 @@ (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min- `fit-frame-to-buffer-margins' or setting the corresponding parameters of FRAME." (interactive) + (fit-frame-to-buffer-1 frame max-height min-height max-width min-width only t t)) + +(defun fit-frame-to-buffer-1 (&optional frame max-height min-height max-width min-width only from to) + "Helper function for `fit-frame-to-buffer'. +FROM and TO are the buffer positions to determine the size to fit +to, see `window-text-pixel-size'." (unless (fboundp 'display-monitor-attributes-list) (user-error "Cannot resize frame in non-graphic Emacs")) (setq frame (window-normalize-frame frame)) @@ -9079,7 +9094,7 @@ (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min- ;; Note: Currently, for a new frame the sizes of the header ;; and mode line may be estimated incorrectly (size - (window-text-pixel-size window t t max-width max-height)) + (window-text-pixel-size window from to max-width max-height)) (width (max (car size) min-width)) (height (max (cdr size) min-height))) ;; Don't change height or width when the window's size is fixed --------------DD2D6A4F10C55E96A22B0CF0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 22 12:27:02 2020 Received: (at 44080) by debbugs.gnu.org; 22 Oct 2020 16:27:02 +0000 Received: from localhost ([127.0.0.1]:53671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVdQb-0000PK-W8 for submit@debbugs.gnu.org; Thu, 22 Oct 2020 12:27:02 -0400 Received: from mout.gmx.net ([212.227.17.22]:60421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVdQa-0000Oo-6l for 44080@debbugs.gnu.org; Thu, 22 Oct 2020 12:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603384013; bh=tWw0kdBlaCBjuwfGZUhl68mAfVo1W9juieDZNJcUwxU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iTbYb24gFunj1bFX+H5SOSWU+UFkhbHy3deFA5/AtgF58IHOIVqt6kLeQeSbMHZ6i 3pkjVlHscFI9EKPq4yPJ2BsOPlxBYHNbd8KxKrOKPfloLoD8j5AVhch187poCF4k7W 1N0u2yC4i0+qoDCKAsEiR+3tlHzjzkrObEPHlZr8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.160]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1kONqt0KIw-011OF7; Thu, 22 Oct 2020 18:26:53 +0200 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> From: martin rudalics Message-ID: <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> Date: Thu, 22 Oct 2020 18:26:51 +0200 MIME-Version: 1.0 In-Reply-To: <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:SvsooS6EZqaB5kO2wA73slmNp3n6WpUEhby8euRRtbjCUu2NfR7 H9TKA+7aomXPCIfgmxQCwgjttsr+TQkSvVkyadq0qPaFgKke/vanp5LkMd3kTXmujbtVFYh WGyMMWmFAc2GJZ5AucQ5gS9lP8G/BIKaSxyLIHdab0sIgDk4U5LCq9ZVRwzRs3eTPqNWhDR GGWdRyb4rQh5mZIao6S+A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:DX84/eHZsP4=:OLsKbdenhqeyu/6WIUAPKY WX4voPhDnYJdwXoXjgyP+Esmpog5Yn1k8V/Nuxt6AkjridXHR7eRJDaM4KlbLUyDXfKmqKDxt 1aSWYIiWxJtOenbPEfQzz6EFlijdWS2S1IZgXRiulk1udxX4ODRNTZ2QsUojYbV6RZq1kURLW GH5D8JDS40YCn8+B8HDoeYVK8rz1YzFVaBJ9KlKofMn20H6dlfQA9BC0yw2O/qe7yxHuxOjO8 rsj+shTm0KimcYzoGC26bn6Ze6m9lCk222QNl2h14gi18sKtgOEGPcNKPHarfi+wj+8toKqfj r57nntLzS7icrTxakXjrLpkYyAE3MAFowZx0iHRRfTx9kRAV02CNwQMBoOC0RemPeZSxE1K7l TjVncW/lJNwu2Gze8TzpEK9RJPCR6Q5jP2qt0q0rYhgyPgFcP8kS/KM/IufkGF62VarRAuTFJ LWBmbqdh4ZqTb7O7adT+K/FiOqlkP8F0ZdBOuXjiFKTMP2UZVWdYl4AzFtk8+tQoSnsS3hw5n y+JWulOQGrq5jS7iRDVawYEoJMGfdIYEDwPh1r+UozsiF5OoPXTyIyu83sLuZA9I0F8iA/hYa H0A70Ds8KcG9R1IDJxswYJp5MJ3oCH8jeYz7CogoWvwg+AEWCppgKCyi91J48PEC/7XOTKsOc tQM4S7AeGBDj5i3auTV1GkRa+kx7QNtWQOC+U/QhMDE95MmEqMHaJtknZSeIAw0cm+FZ060Ms hjWJMfsCo5JKL2JicSM/kK8pTz6ipnplKu6ukwN0MAywhgY8zKyUcVRRCkC3GojIEQ/VM1Ulw 37qwi7sxfiYcQVefXZrJsMFl/y9NZb2wDwAoYdNuTdf4hYowgwnpEitXGemBTpC+ZzvQGaL4W x4w8hBYdG2vwgftNDKuw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I never dealt with the C side of Emacs and you suggested to offer the > new function as first customization choice for `resize-mini-frames`. > I guess this needs to be done on the C side as the variable is defined > there? The customization is done here in cus-start.el (resize-mini-frames frames (choice (const :tag "Never" nil) (const :tag "Fit frame to buffer" t) (function :tag "User-defined function")) "27.1") and the only things to change are to put a "mini" between "Fit" and "frame" and update the tag to hmmm ... I meanwhile think we should put that change into Emacs 27.2 provided Eli doesn't object. And the only C-side change is to change the doc-string of 'resize-mini-frames' (in frame.c) where we say Any other non-nil value means to resize minibuffer-only frames by calling `fit-frame-to-buffer'. */); to Any other non-nil value means to resize minibuffer-only frames by calling `fit-mini-frame-to-buffer'. */); > I have attached the patch I have worked on. Let me know how to proceed > and thanks for your help! The patch looks fine to me. I'd change the following: (1) Make the FRAME argument of 'fit-mini-frame-to-buffer' optional so we retain a certain consistency wrt 'fit-frame-to-buffer'. (2) The "Any leading or trailing empty lines of the buffers content are not considered." should be moved towards the end of its doc-string or at least after the "FRAME can be any live frame and defaults to the selected one." (3) The doc-string of 'fit-frame-to-buffer-1' should be amended with something like "The remaining arguments are as for `fit-frame-to-buffer'. In the Elisp manual in the description of 'resize-mini-frames' we should replace the Any other non-@code{nil} value means to resize minibuffer-only frames by calling @code{fit-frame-to-buffer} (@pxref{Resizing Windows}). with something like Any other non-@code{nil} value means to resize minibuffer-only frames by calling @code{fit-mini-frame-to-buffer}, a function that behaves like @code{fit-frame-to-buffer} (@pxref{Resizing Windows}) but does not strip leading or trailing empty lines from the buffer text. In addition we need to call out the change in NEWS and write a ChangeLog entry. Many thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 24 09:08:29 2020 Received: (at 44080) by debbugs.gnu.org; 24 Oct 2020 13:08:29 +0000 Received: from localhost ([127.0.0.1]:32941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJHY-0006jI-PH for submit@debbugs.gnu.org; Sat, 24 Oct 2020 09:08:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJHX-0006j5-2Z for 44080@debbugs.gnu.org; Sat, 24 Oct 2020 09:08:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E32EF160063 for <44080@debbugs.gnu.org>; Sat, 24 Oct 2020 15:08:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603544900; bh=DJFn/JIXfM+36PXQKIxGFPzxHBucJBeZwlULdGwenrE=; h=Subject:To:Cc:From:Date:From; b=fqWWrBGTjhjTwdaPL+yLhs3LME9zqoxVi6SRQVpe6iDcxH9s8Llws/NdqfmxaQuO9 hhylpTr0kO9AcLdafJIxO8gnNaIWIhmhLhAgW1QPdxz8K2n895n+atu/RSdhcQm6Qf BwxZHokFfHNDjYt5fUCMoDygqkaXkogiXTtfFCXs7J9dRSuNuiL4I7hGTxNScX0Go/ QjW6iqRhzxoFFRFyMz4gMOq/eD7DWyAZtR9XRHRZaPX3dGPk8MuQG0vVoF77/gUQmH DzRsLjQYmmYMvNqooRSfVljc59rp9pDJjJ5rKLg7Z/TfHxTiCNLzhSaDp9SULqUa2C I3Lreky11XO3g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CJLxw1cmpz9ry3; Sat, 24 Oct 2020 15:08:20 +0200 (CEST) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> From: Clemens Message-ID: <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> Date: Sat, 24 Oct 2020 15:08:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> Content-Type: multipart/mixed; boundary="------------C0E7B90D880376334E552209" Content-Language: en-US X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) This is a multi-part message in MIME format. --------------C0E7B90D880376334E552209 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > The customization is done here in cus-start.el > > (resize-mini-frames > frames (choice > (const :tag "Never" nil) > (const :tag "Fit frame to buffer" t) > (function :tag "User-defined function")) > "27.1") Thanks, now I know how that is done, I should have grepped for it. I have attached an updated patch where I implemented your suggestions. For now I updated the tag to 27.2. Let me know if anything else could be improved and thanks for giving me the opportunity to contribute a little to my favorite software :) --------------C0E7B90D880376334E552209 Content-Type: text/x-patch; charset=UTF-8; name="0001-Don-t-skip-empty-lines-when-fitting-mini-frame-to-bu.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Don-t-skip-empty-lines-when-fitting-mini-frame-to-bu.pa"; filename*1="tch" >From fa40d19d2eb6339a30d396e51201781fc8a639ca Mon Sep 17 00:00:00 2001 From: Clemens Radermacher Date: Sat, 24 Oct 2020 14:49:45 +0200 Subject: [PATCH] Don't skip empty lines when fitting mini frame to buffer (bug#44080) * lisp/window.el: (fit-mini-frame-to-buffer, window--resize-mini-frame, fit-frame-to-buffer, fit-frame-to-buffer-1): Fit to mini frames without skipping leading or trailing empty lines. * src/frame.c: (resize-mini-frames): Update docstring. * lisp/cus-start.el: Update for customize. * doc/lispref/minibuf.texi: (resize-mini-frames) Update description. --- doc/lispref/minibuf.texi | 6 ++++-- etc/NEWS | 6 ++++++ lisp/cus-start.el | 4 ++-- lisp/window.el | 24 +++++++++++++++++++++--- src/frame.c | 2 +- 5 files changed, 34 insertions(+), 8 deletions(-) diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi index d00acd0ded..e5a0233b3c 100644 --- a/doc/lispref/minibuf.texi +++ b/doc/lispref/minibuf.texi @@ -2501,8 +2501,10 @@ frame is the buffer whose contents will be shown the next time that window is redisplayed. The function is expected to fit the frame to the buffer in some appropriate way. -Any other non-@code{nil} value means to resize minibuffer-only frames -by calling @code{fit-frame-to-buffer} (@pxref{Resizing Windows}). +Any other non-@code{nil} value means to resize minibuffer-only frames by +calling @code{fit-mini-frame-to-buffer}, a function that behaves like +@code{fit-frame-to-buffer} (@pxref{Resizing Windows}) but does not strip +leading or trailing empty lines from the buffer text. @end defopt diff --git a/etc/NEWS b/etc/NEWS index 2aed575159..861ce6ff6f 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -274,6 +274,12 @@ of the next command to be displayed in a new window. It's bound to the command 'other-frame-prefix' that requests the buffer of the next command to be displayed in a new frame. ++++ +*** Change behavior of user option 'resize-mini-frames'. +If set to non-nil resize the mini frame using the new function +'fit-mini-frame-to-buffer' which won't skip leading or trailing empty +lines of the buffer. + ** Tab Bars *** The key prefix 'C-x t t' displays next command buffer in a new tab. diff --git a/lisp/cus-start.el b/lisp/cus-start.el index 3fd6ac031c..6927b6df6b 100644 --- a/lisp/cus-start.el +++ b/lisp/cus-start.el @@ -324,9 +324,9 @@ (default-frame-alist frames (resize-mini-frames frames (choice (const :tag "Never" nil) - (const :tag "Fit frame to buffer" t) + (const :tag "Fit mini frame to buffer" t) (function :tag "User-defined function")) - "27.1") + "27.2") (menu-bar-mode frames boolean nil ;; FIXME? ;; :initialize custom-initialize-default diff --git a/lisp/window.el b/lisp/window.el index 1fcfffcb53..865f6fdd5c 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -3432,7 +3432,7 @@ (defun window--resize-mini-frame (frame) "Resize minibuffer-only frame FRAME." (if (functionp resize-mini-frames) (funcall resize-mini-frames frame) - (fit-frame-to-buffer frame))) + (fit-mini-frame-to-buffer frame))) (defun window--sanitize-window-sizes (horizontal) "Assert that all windows on selected frame are large enough. @@ -8925,6 +8925,14 @@ (defun window--sanitize-margin (margin left right) (declare-function tool-bar-height "xdisp.c" (&optional frame pixelwise)) +(defun fit-mini-frame-to-buffer (&optional frame) + "Adjust size of minibuffer FRAME to display its contents. +FRAME should be a minibuffer-only frame and defaults to the +selected one. Unlike `fit-frame-to-buffer' FRAME will fit to the +contents of its buffer with any leading or trailing empty lines +included." + (fit-frame-to-buffer-1 frame)) + (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min-width only) "Adjust size of FRAME to display the contents of its buffer exactly. FRAME can be any live frame and defaults to the selected one. @@ -8943,8 +8951,18 @@ (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min- The new position and size of FRAME can be additionally determined by customizing the options `fit-frame-to-buffer-sizes' and `fit-frame-to-buffer-margins' or setting the corresponding -parameters of FRAME." +parameters of FRAME. + +Any leading or trailing empty lines of the buffer content are not +considered." (interactive) + (fit-frame-to-buffer-1 frame max-height min-height max-width min-width only t t)) + +(defun fit-frame-to-buffer-1 (&optional frame max-height min-height max-width min-width only from to) + "Helper function for `fit-frame-to-buffer'. +FROM and TO are the buffer positions to determine the size to fit +to, see `window-text-pixel-size'. The remaining arguments are as +for `fit-frame-to-buffer'." (unless (fboundp 'display-monitor-attributes-list) (user-error "Cannot resize frame in non-graphic Emacs")) (setq frame (window-normalize-frame frame)) @@ -9079,7 +9097,7 @@ (defun fit-frame-to-buffer (&optional frame max-height min-height max-width min- ;; Note: Currently, for a new frame the sizes of the header ;; and mode line may be estimated incorrectly (size - (window-text-pixel-size window t t max-width max-height)) + (window-text-pixel-size window from to max-width max-height)) (width (max (car size) min-width)) (height (max (cdr size) min-height))) ;; Don't change height or width when the window's size is fixed diff --git a/src/frame.c b/src/frame.c index 0b707c2af8..797d885d43 100644 --- a/src/frame.c +++ b/src/frame.c @@ -6182,7 +6182,7 @@ window of that frame is the buffer whose text will be eventually shown in the minibuffer window. Any other non-nil value means to resize minibuffer-only frames by -calling `fit-frame-to-buffer'. */); +calling `fit-mini-frame-to-buffer'. */); resize_mini_frames = Qnil; DEFVAR_LISP ("focus-follows-mouse", focus_follows_mouse, -- 2.17.1 --------------C0E7B90D880376334E552209-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 24 09:40:06 2020 Received: (at 44080) by debbugs.gnu.org; 24 Oct 2020 13:40:06 +0000 Received: from localhost ([127.0.0.1]:32970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJmA-0007eO-5O for submit@debbugs.gnu.org; Sat, 24 Oct 2020 09:40:06 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWJm8-0007dj-63 for 44080@debbugs.gnu.org; Sat, 24 Oct 2020 09:40:05 -0400 Received: by mail-wr1-f45.google.com with SMTP id n18so5981499wrs.5 for <44080@debbugs.gnu.org>; Sat, 24 Oct 2020 06:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=GOVQyvwwMLn+OO9t+cI+APyH3N2DdQVCBISYmLhdE4g=; b=CuI3E8IBXj5vrQfkP2aAgQkCsF+eeajNtWKomEQ5pQQW60joFYyRGwgIKdipGKJnIY miqfxrxee73/X4ciaoCJNrbWM5HJLAF37y3QKuyHlkRFNu2SxxNTdQBNlnYEZ4lRhwO2 SNsNRUjDkFguefF9wTMyH9ZEJX7E08TfWkiTSGdiWUV/3W+z8geUZCBLdYOeB7MAAOI8 rn2pNQYZgNXCy2BUeUpJrvsF367oSu+1A7gY3JrLC3swWYjV1lSttHBej3tTbJnnDt/V oSoZXHtJJMsz3Vy3gyoNiba2dj6/x/o16KjnSPy+I/eYv38FBuUfeWkXoVMSSjfA9GgE H8hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=GOVQyvwwMLn+OO9t+cI+APyH3N2DdQVCBISYmLhdE4g=; b=LjYHZtQ2DcrjFmmvPEL8WxmUq3aOyUvfq4L+K3b+jS8esN/3ZRXS0shRstZbDXtXr9 T2H3T8mU0itQoMLsFpGPrJQpDpyWNvJy9/PYff81OzmDvdTd1fr1dv2eT0DFQdwCkA1V Hcq0nUJQ3V56yol5P0B8BliJvortHTB9WNZmi+MryhfXuqueWIj0NiMWx5CfyiseAFTo j+Rioq8XGoA8TIN8W7YBHnvd7ja58zzaHuDyPxjwvITf2ECzFFsDx97JJEMTFq2CPgVQ 4563nl1jJkxF00cHJwdD/GhdlKExgxVatTrWqcAkYZyM26+WFZLlMnx6a7aAmJRFMw24 dzTA== X-Gm-Message-State: AOAM533pDRu8sO53lEWmjs0NFh18J8qjg+1sHp1396K2tSBwtnsEDdjM syG+2zaXle4DiBz+6Y3KveUp7bE70aw= X-Google-Smtp-Source: ABdhPJwk6RdYzd9I41w9MXT4NFzK7ScRTOTBMhKhpQNh6d/hUjO4xSGq49HrG+QZH86QN+bOlxa5+Q== X-Received: by 2002:adf:edcf:: with SMTP id v15mr7234945wro.291.1603546798107; Sat, 24 Oct 2020 06:39:58 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:8d6e:d31:eb45:4a86]) by smtp.gmail.com with ESMTPSA id p21sm10191811wmc.28.2020.10.24.06.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 06:39:57 -0700 (PDT) From: Robert Pluim To: Clemens Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> Date: Sat, 24 Oct 2020 15:39:56 +0200 In-Reply-To: <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> (Clemens's message of "Sat, 24 Oct 2020 15:08:19 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44080 Cc: martin rudalics , Eli Zaretskii , 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 24 Oct 2020 15:08:19 +0200, Clemens said: >> The customization is done here in cus-start.el >> >> (resize-mini-frames >> frames (choice >> (const :tag "Never" nil) >> (const :tag "Fit frame to buffer" t) >> (function :tag "User-defined function")) >> "27.1") Clemens> Thanks, now I know how that is done, I should have grepped for it. The process is described here: (info "(elisp) Writing Emacs Primitives") (or C-h i m elisp RET i defining custom RET) Robert -- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 14:24:11 2020 Received: (at 44080) by debbugs.gnu.org; 26 Oct 2020 18:24:11 +0000 Received: from localhost ([127.0.0.1]:41292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX7AB-00048d-GG for submit@debbugs.gnu.org; Mon, 26 Oct 2020 14:24:11 -0400 Received: from mout.gmx.net ([212.227.15.18]:40143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX7A9-00048P-E2 for 44080@debbugs.gnu.org; Mon, 26 Oct 2020 14:24:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603736642; bh=CMO2EqiZVRrEcZf/8ExX6Yr+aPcjRKYD/5pk5LmQbiU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=D8+9fLOfJifwuLdNe2Hi7aQLH1DPAFGfKGaTpKh+1PS4afoGwps/fqy9rL+3GmnLH UM24sxx2R+GKLK+pyptIpe7bJ5Qmim/1tDXIm+2lOJtFBZDMPaPevLKX6to00CXUTK LgxSsKq9lYccXkh3IX7meWUqAJ1G7YRSwFUYOTlQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.219]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M7sHo-1kS9Ls1uDK-0054cN; Mon, 26 Oct 2020 19:24:02 +0100 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> From: martin rudalics Message-ID: <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> Date: Mon, 26 Oct 2020 19:24:00 +0100 MIME-Version: 1.0 In-Reply-To: <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:OvpVRHeGisrinTtz/viAzgIc3bENVJnqTQgI2pcDb2+qNQDmq8b otBe82yunsEifak3/lhDmAuOCNVrnAJGi2hpUpYeYQnQjvnzaw+2XjkzdmZn3HLMdBCwnYc MRDO2wI0AiJy34UBTJavPY0iBHQ6+GdEXKJYoYFGhJJfgjq4ynviBjUzhWlneV0u3ez29Om qD3R+VNVt8jGEPQyfD9hw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YAJMJgcuKkY=:xG83cVEsvsSG2nIGZCReAB mE3sRQOSxB3jrAePMPJneo/iIcwWX7qMrdR+CsJmoG6x04hiR4IslNMk0pf2zmRDNIms7YFw+ e29aQ1aKC5LLcZlQVTHywSaKG5H2fD2kCfdI084Cr4L5o87tdbQBMMFPeinlHXUGX2wCWyI6L PvowBkz5Vfkd7xKB+K4O2c5F054kdqkMYcJu8XQE51cnjL2syQFb2nX3sramfqThWdeb5dSXt LcbFd8/4h410LHzE8rTLAV2jdHolocPYCAFf43aNgpfPpUhIaLW6T4/Igs59jiNjTZxktb/GR zKll48Cc2phRTpAfPFdw6qtZfkFyHs2ftTRtZSeIsYDyVMDRp21LBmBG+GtsroyEiFTXb6t8s G09vDtKpapTupFrxETv+/rxTsfHWPEbhDs0+76mguaA4LOlgLqZDQW7+ByxGDcsEeiyC4qgTX sxDdDAaiUrFPNHnekOy4tkJz131ZjEdnIy72lKhqajt2QgiIJh4pEtq9hKIfcQBmgRVgBd1yR 0TR0kQ+1iX+JZY511h24A1Q0sukandk3Sv3yFp2wBaRA3uo+2RAYNPOpgjmrtJYKogzrhc6a/ eDJ6FitCGVxaLW7bqyzdZyiN783Z8vVjh/7CdJElbAmdY6FWBVVOiSeWABure6fGKDoW3Wez5 4snLJYqCjZWBMJSVEBf9EHlQmAGXcLB1GOdRMWZa61h4RnX0Be4AJd2k7ULzeAWsuQ2W6EKGe 7Jt9v5E5Imz12uFijm+OF076oNFVVZMruClK/oH2NJsl2371YR7CYa+wzvVbsPP+XwmokxHyq B5yhx1z4oC3MpygcUn0rVfBioX0X+zCRmq+NoA+9jHxSJ0/oDvz0Gn76TuqnnaMwoXZ06rWEy qF+boppjrTrI70n/MQag== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > For now I updated the tag to 27.2. Let me know if anything else could > be improved and thanks for giving me the opportunity to contribute a > little to my favorite software :) I think it's good to be installed now. Eli, two questions: - Is it OK to install this on Emacs 27? I don't know how popular these minibuffers with leading or trailing overlays become, but if they do, it might be good to be prepared. - Can we accept Clemens' patch without paperwork? Many of its parts are slightly amended doc-strings. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 14:32:23 2020 Received: (at 44080) by debbugs.gnu.org; 26 Oct 2020 18:32:23 +0000 Received: from localhost ([127.0.0.1]:41337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX7I6-0006Jm-US for submit@debbugs.gnu.org; Mon, 26 Oct 2020 14:32:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX7I5-0006FJ-QQ for 44080@debbugs.gnu.org; Mon, 26 Oct 2020 14:32:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60263) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX7I0-0001m0-FD; Mon, 26 Oct 2020 14:32:16 -0400 Received: from [176.228.60.248] (port=1980 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kX7Hz-0005tI-8B; Mon, 26 Oct 2020 14:32:15 -0400 Date: Mon, 26 Oct 2020 20:32:09 +0200 Message-Id: <83wnzcet3q.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> (message from martin rudalics on Mon, 26 Oct 2020 19:24:00 +0100) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080 Cc: clemens.radermacher@posteo.de, 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 44080@debbugs.gnu.org > From: martin rudalics > Date: Mon, 26 Oct 2020 19:24:00 +0100 > > I think it's good to be installed now. Eli, two questions: > > - Is it OK to install this on Emacs 27? I don't know how popular these > minibuffers with leading or trailing overlays become, but if they do, > it might be good to be prepared. > > - Can we accept Clemens' patch without paperwork? Many of its parts are > slightly amended doc-strings. Yes to both questions. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 16:53:22 2020 Received: (at 44080) by debbugs.gnu.org; 26 Oct 2020 20:53:22 +0000 Received: from localhost ([127.0.0.1]:41610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9UX-0007yx-TI for submit@debbugs.gnu.org; Mon, 26 Oct 2020 16:53:22 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9UX-0007yl-0O for 44080@debbugs.gnu.org; Mon, 26 Oct 2020 16:53:21 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A477A2400FC for <44080@debbugs.gnu.org>; Mon, 26 Oct 2020 21:53:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603745594; bh=EWo9AVjQFDnwb1XQNnYcpsc46ToDDOlNn7I1XF3dEuk=; h=Subject:To:Cc:From:Date:From; b=U+EQsp101o9EN+XVP27cdql43aIU8ytdndBrsSvEJbHQynVaY67fD4SVOvMB9IvmT 8jcMDJ12Twf7F2IKUme1LmQTT23mdZI4rUlb02Q8qVRVchIbKTB0jjKwRR1aD2D466 MrwBIcCNtlJHHT7DWRgma8IQ2ChWVKTeJs8u91DDomm9EARhamRPPr3rfbgWnaWBy2 sB0SbbzZngxz6PLU986d2SJyjDr9zgXFbrJ1NvjXFHdBT6ZnzJgXbWm5lsv6ZlWrqr wqE0sa/cIkGM0LuAsPoiPdQxHIFytDhyNP+csHrXyAG1x/Lh3dypE/TBrUaC04yT1j 77WP92tfyODjg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CKn9P73bkz6tmd; Mon, 26 Oct 2020 21:53:13 +0100 (CET) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> From: Clemens Message-ID: Date: Mon, 26 Oct 2020 21:53:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > - Can we accept Clemens' patch without paperwork?  Many of its parts are >   slightly amended doc-strings. I have done the paperwork already so this is nothing to worry about. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 05:08:40 2020 Received: (at 44080) by debbugs.gnu.org; 27 Oct 2020 09:08:41 +0000 Received: from localhost ([127.0.0.1]:42844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXKy8-0003oa-MW for submit@debbugs.gnu.org; Tue, 27 Oct 2020 05:08:40 -0400 Received: from mout.gmx.net ([212.227.17.21]:46779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXKy5-0003nK-JI for 44080@debbugs.gnu.org; Tue, 27 Oct 2020 05:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603789711; bh=T6LNkTmx1k1B7Z9CvKqTkUZt+6VTCrAuNS6HJ/sewGg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=PcaXKnePhmgQV5EhA5GXqvyOy3hHCbvzKa0FlpcL3MJ/ydukCpYZXNYUK5zo8NC7H sV9a6ruA55B33+NjbPKPygNZBrGBZmRVvk8pEcDidOqvJV9G0Iwe4gTb0S0vn1z01M P+Cq8dQrBu55/5VIoRcQQeJCD8H2IHOxh5JeY1As= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.107]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M2f9b-1kXcbw0etT-004CfC; Tue, 27 Oct 2020 10:08:31 +0100 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> From: martin rudalics Message-ID: <055a4dc1-6dcf-bf29-0ef9-1fd9145203bf@gmx.at> Date: Tue, 27 Oct 2020 10:08:29 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Br9htBm7pDL3izcYf98dHnEIKh6YCpNcg2cIZaJcSN24IRzd1Ga O2CJZ2FDhZtVVyuwdXTOjlL2d2LM/wA++osDvTcvlHhKlHDqMlnVuTleslsQu+8mpt9iv6Z +LVjRSffsfc7/61L6zqeHtrhtKORROZW9kiUGb9v2sgGfklmOFnalNBrd1SQ0LUazkXp9su AHDCoMaXVwBdQVfJot0HA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tuk7Y6IrMO0=:3nnp469EHBMRRjFxAQFeZU LY7iGp++nmrbvR3WCy55NNsUYKD53cAYu7z7/JhNkOx9GFPbfv9JYq9cMut2rSAV1R965oHMt VyRVQ0TlVs3bCg2tUMkqGkCBE41XQrhOQS17sXKbBaYIDAnemQcksCm3GFwDKoys4VHcplEDt P7nbPP3Chy9gVE2fLufCh8HmkJkGC0mbthcUjdgJanANuPHlFD5rL0q5a8bxe9BbCgcMhpXmY 5lgas5+zY/5vDbWmvwMc5AMhWRmMIcmfnXAsCl19nuAhlX7f053iAaYwFl5fHY8bD/HsIcofc lYhrm1InUo4hNGBX9qDRNAtwiWI9ulgGb60Lfi8f8ENF7k0W6Osyuu7NgDXiciEr9qOk8vYDF ahNBWDYNle0ZQ4pc+y8zKyTbU6d6rTFGx49bWxgMt1p9x0dmotZ0MSxDFTJZuwRgJxpLXJWPO jswqv92iil3K7f11QK1sV3DOSaL/3WW9+9E//mHHDVS+ivqrPlc0m1Mfs8k9nqZTOkPS62nBt ano4R+F7qKtz6stLxLR5gxBg5khK3mTpoe3i27y8XKnXM5REsnT/NFMcYgqzxiE9I8Apng7fb yxVwjvqHyiE4RxwZ5YPtmMMg8qBuH6aEb4alC0AUjJjEXKCSDTZ0GffyZCzHUipoYX42+Dhzb /Gxg4UPkN/t9864HsuNvg+y1mcw5nBqEStG0gd/r5ZyodWqbtEJqwzsnEuRHT+FC0E4nzHe1d u51v4m84rq6LrJc3yyxvqiTib2hgSX3IfvGhT9a6y1fvpehZffP1iOzFyGaYczK1iJ9FMAv5F CDKbNDuLcMwTkKMlmEcyCpm8pwNhjwDL2bMwogUn/yTrUkGprxXRlvmrIhjpKJTfx9UeKfHRB Vfkc3G+hlaAG5GOnRT0w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> - Can we accept Clemens' patch without paperwork? Many of its parts are >> slightly amended doc-strings. > > I have done the paperwork already so this is nothing to worry about. Fine. I've pushed your changes now as commit e0de9f3295b4c46cb7198ec0b9634809d7b7a36d. Please have a look and close the bug if everything is OK. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 08:10:39 2020 Received: (at 44080) by debbugs.gnu.org; 27 Oct 2020 12:10:39 +0000 Received: from localhost ([127.0.0.1]:43182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXNoF-0006MS-70 for submit@debbugs.gnu.org; Tue, 27 Oct 2020 08:10:39 -0400 Received: from mout01.posteo.de ([185.67.36.65]:48840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXNoD-0006MF-Rr for 44080@debbugs.gnu.org; Tue, 27 Oct 2020 08:10:38 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AE5D616005F for <44080@debbugs.gnu.org>; Tue, 27 Oct 2020 13:10:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603800631; bh=jzPgO//Dlm+cBc8Vncyqx0ZGhjN2jGj0NG63iOhGouI=; h=Subject:To:Cc:From:Date:From; b=a4NqnTeSgJ1xB2m7jMzU2kdaYY1EWuL/b0Lota8K8207trXOeyiTXFjFDQUjlvph8 We3Vr1J5l2vo8fCzc75HDl3LBdG8wB9+V894pfvlIkzntM0e+dEFwbGny+NvVaKf/j q5lyGDtbAbDmvqpZI08M8/lbcyDvLu9bKpMv5/Pd5pFEe3eIPzUr0v4m2v8l2HSU4F L0i9Ns9Y05oIa0ntOb2ItSDj1Hnk8fs3Q2bmu3uEZYQhi+JNf5lMH1lvES9vOxhU9+ DtZ/edAX5kdmP3cXItIY50qZCfqmmjPuc5er30eq43TmwsM9j5KAW0VbBX91qD5dvO Cuin6YyPT9rOQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CL9Wp5z6Rz6tmH; Tue, 27 Oct 2020 13:10:30 +0100 (CET) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> <055a4dc1-6dcf-bf29-0ef9-1fd9145203bf@gmx.at> From: Clemens Message-ID: Date: Tue, 27 Oct 2020 13:10:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <055a4dc1-6dcf-bf29-0ef9-1fd9145203bf@gmx.at> Content-Type: multipart/mixed; boundary="------------1B7D8DA00876883FAFBD5DE6" Content-Language: en-US X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) This is a multi-part message in MIME format. --------------1B7D8DA00876883FAFBD5DE6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit > Fine.  I've pushed your changes now as commit > e0de9f3295b4c46cb7198ec0b9634809d7b7a36d.  Please have a look and close > the bug if everything is OK. Looks good to me except the NEWS entry which on second look wasn't precise enough. I have attached a patch which aims to fix it. Thanks for all your help! --------------1B7D8DA00876883FAFBD5DE6 Content-Type: text/x-patch; charset=UTF-8; name="news.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="news.patch" diff --git a/etc/NEWS b/etc/NEWS index f0b5dd088a..61f9c0e1fe 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -35,10 +35,10 @@ This is a bug-fix release with no new features. * Lisp Changes in Emacs 27.2 -*** The behavior of the user option 'resize-mini-frames' has changed. -If set to non-nil, resize the mini frame using the new function -'fit-mini-frame-to-buffer' which won't skip leading or trailing empty -lines of the buffer. +** The behavior of the user option 'resize-mini-frames' has changed. +If set to a non-nil value which isn't a function, resize the mini +frame using the new function 'fit-mini-frame-to-buffer' which won't +skip leading or trailing empty lines of the buffer. * Editing Changes in Emacs 27.2 --------------1B7D8DA00876883FAFBD5DE6-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 14:02:42 2020 Received: (at 44080) by debbugs.gnu.org; 27 Oct 2020 18:02:43 +0000 Received: from localhost ([127.0.0.1]:45737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTIw-0003Ep-O4 for submit@debbugs.gnu.org; Tue, 27 Oct 2020 14:02:42 -0400 Received: from mout.gmx.net ([212.227.17.20]:48731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTIv-0003Ed-H7 for 44080@debbugs.gnu.org; Tue, 27 Oct 2020 14:02:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603821754; bh=aFLoAFCtLAPqJ2tnu8lSWQdrpcQPi6kUjVhsxquu2b4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=EJYf4n5WpHvsFhw24O3xj7DgaaoXuth8edrQNSpRnQmEFGwjYKBzgZW3u8F5dSgaY NzzRhduiEjaR7h5NCx2Y6gfdQKrAA15mnz5e+tR80olIqxtil32a6PsB9kFZ0lwfJH 3Afm8AcxzTyYvr+pyATTqTk6/mwOSZjOlhJ9TH3o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.139]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McpJq-1jyxlQ2426-00Zwy2; Tue, 27 Oct 2020 19:02:34 +0100 Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Clemens , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> <055a4dc1-6dcf-bf29-0ef9-1fd9145203bf@gmx.at> From: martin rudalics Message-ID: <4b20bc4b-590a-f7b9-c055-2205fda5051f@gmx.at> Date: Tue, 27 Oct 2020 19:02:33 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:WhCfeP92OJN6KKNXmdWtiQdVFxliDJM0O2caVG96gHosqnyN/Ii Oq0nijZREpintNdHSKDMh4qYw3T8UNXcQJju87OghmSOXMQ914T8T0zG+EeDnfbQOAEVHJh k/V4mDT/bSqnGp7wYzuyOyCzW8qMNx5pTroVnp2A6SVPDxA4f0CCY70sCuveIksd8eUqfBF f6iKNCQ+3ZB50K5sjILpg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:80LZ2VZRmXs=:SBeGlOlGqeHMb8zzcU2jd1 YGbiAFeHJXd1iINupH/Q7xmTYP7Hptt0ZXECUStDU+5Ix9IFEZM+SHYSvVJGIWPA4tBxeBGhy Jfa3Tl+F4dgsAa80ll3tQAWvP5/qyp+I38n54GDUvNlktOPJXuGPJG6nkhB/0v1laQWspMuEh uG23et1uZL0qAvF06WNsIfqxjweqsgU2QnGQ7Ty12sZbrvn/q+wfgGFH0X334BuTCMWCYjwav wY6xPVFY3gGzu0g/f7dcw5LluPISwXhxRw8GXlSB0shl/RA9nQxc7lOnPIy58RmmQRSiRRyVq MZCBBhCzFfQ0Co2WQUGLkNHjeb6JJ+5dryjsGqjhH2rDMPJG0pkidWuVIPh94YrH+pqB5nW1s NKlFcpL1Oa9pVy6J9D7xGW7xPYMrzTfi1I2sM4zg9P2Uz6YcVmVbjoKKqtXXK+y8VlIUqaPee Gr31SqIQOj5mjjsCva8tkXKZNnC9yH+h9qwqZbOuRlV8UAJadMKKTQTeEE+Eh/wKW6+ud0Jmc d9FctblwGoHLfNo8Ogi3ayLGXUUI1RhmdHHZDPAMW0JCNEVj3ZX+AVbybWzINxXbLBQfFJEcR vzaeKfHZWkTResvCu5HjE6XHmoXx0nrFZ/hZwYQq7lDT9psR2agIbkTUbvMNsHp9Y9RSRTvhF OZY3SHY+tajS1RFmR1DEhUZPBd2jOAkqI3Z2LFdL4acaApLET6XaHbetcnRbkSMMzuNdeoPdn 7mFVJdzwz2T0BneCU+OUXlK6/62OMVuSzGUmCz0hNxCEzHE2J7PvfeXer3iUI2kvJpEN/5Tks bcLzFwqbWLMMIBcy0W4lESB/imzmlsDiJH1NbP1v48vURmIzZZtOZQtWZCl9pyiC2yRmRLrSz am2djY/NJ6o8gvxL7l8Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Looks good to me except the NEWS entry which on second look wasn't precise enough. I have attached a patch which aims to fix it. Thanks for all your help! Pushed now. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 14:15:42 2020 Received: (at 44080) by debbugs.gnu.org; 27 Oct 2020 18:15:42 +0000 Received: from localhost ([127.0.0.1]:45774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTVW-0004DT-5y for submit@debbugs.gnu.org; Tue, 27 Oct 2020 14:15:42 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTVV-00046m-3b for 44080@debbugs.gnu.org; Tue, 27 Oct 2020 14:15:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B305C160063 for <44080@debbugs.gnu.org>; Tue, 27 Oct 2020 19:15:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603822534; bh=IaF8SB71UJ5iIthT+ndpXMSCKYIxXd3RJFhH18F5IEA=; h=Subject:To:Cc:From:Date:From; b=rHbEyYMETNo/xEJN+XBiIpsLLDAKan6GOCoIaQ4tCIlPp0z6jlHe/r0+2n27dMONg a/1KYAa9Y/AQO60tnNpISvllV4oXXN3gVVzDJSgF5XTRiH8ntlibaVUM8B1N3VJPBY p5jvrgTKsibD2N7fpCRZP0HjQuy8SFkAW6ym/bZ/Ad8jWa/ox6DriM2SbPyUAWhCsc EYlQxBeK+KZAQQq7px1oUOxWuWT8MoPsp6e4nZRfWyYZU5R+hI61A1Vz7Mc4hxvtJY +IE0sN/vu0g2hMgMYLvH89yXBB/rlLjpYDQDc2TPoWTQ9bQf4JhlgjtEUDbe56JyHX AwGzpPPpvq1QA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CLKd02gzpz6tmF; Tue, 27 Oct 2020 19:15:32 +0100 (CET) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: Robert Pluim References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> From: Clemens Message-ID: Date: Tue, 27 Oct 2020 19:15:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 44080 Cc: martin rudalics , Eli Zaretskii , 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > The process is described here: (info "(elisp) Writing Emacs Primitives") > (or C-h i m elisp RET i defining custom RET) Thanks! From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 14:23:43 2020 Received: (at 44080-done) by debbugs.gnu.org; 27 Oct 2020 18:23:43 +0000 Received: from localhost ([127.0.0.1]:45791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTdG-0005sO-RL for submit@debbugs.gnu.org; Tue, 27 Oct 2020 14:23:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]:45671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTdE-0005s8-8y for 44080-done@debbugs.gnu.org; Tue, 27 Oct 2020 14:23:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D5FB92400FC for <44080-done@debbugs.gnu.org>; Tue, 27 Oct 2020 19:23:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603823013; bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; h=To:From:Subject:Date:From; b=cLu6aEcRsWqtlsKYMp/1Uz5G0HwRdrhSlYwywKUOibRp+4NqAeoqofmXznHD7NiQd oIc69x0sovJ3kr3iGrHnlrGxv7Z3jQt5bcEDQkLJswBomsY9MAF8fFX2P0Ih63kR8s tY5jgiHD2LECQjoY8CnYttvVeet/+kw2IIz170dwEzTrVrQiXSZkz3QECMcOUg/4Mz u0/KN/bw57lwJ8+G7zw5hHP1oa67pcBEdwPyw4fl+K48+PVM/i1pRo4I8gEaHkmITW PPbwaUaV8hMCwSlOiFq29dAKfodUo9K1mqCvgajzkfuFtOyesAuEsWQn3GMgWdxVMX DDxnhYvq3uJpQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CLKpF33Tgz6tmN for <44080-done@debbugs.gnu.org>; Tue, 27 Oct 2020 19:23:33 +0100 (CET) To: 44080-done@debbugs.gnu.org From: Clemens Subject: Fixed for Emacs 27.2 Message-ID: Date: Tue, 27 Oct 2020 19:23:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44080-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 14:30:00 2020 Received: (at 44080) by debbugs.gnu.org; 27 Oct 2020 18:30:00 +0000 Received: from localhost ([127.0.0.1]:45808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTjM-000627-7z for submit@debbugs.gnu.org; Tue, 27 Oct 2020 14:30:00 -0400 Received: from mout01.posteo.de ([185.67.36.65]:55093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXTjL-00061s-9I for 44080@debbugs.gnu.org; Tue, 27 Oct 2020 14:29:59 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E7C7716005C for <44080@debbugs.gnu.org>; Tue, 27 Oct 2020 19:29:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1603823392; bh=c3Z/3Ut+vpGbHSgiyE+5myzSYKZindTFODFMrQdH3wY=; h=Subject:To:Cc:From:Date:From; b=RufctfdaOhG5kpcrzq8b+CG0K3b0tMg9p1B+4S9wwU85vv9UJFm+4/vksKsD7ULhB Gonv2EYYrDqAgj0zofKHP/cNsdXh9JJKdobMI4Bj2bTC5Y/nR0xQMpdZ1KX8u0rcw/ GYQptDDsMMLOEUa+lCQ97cq6M1Azt9V2C+R69knMcI0CkegGeZ3yRJRnLq7qt/sitA WAOY1HeW/SIqFFR3Oc7D20TfV5vpCi2RKrFiQH1G7axgyJw35AeoDwkSD9hALSLWjt nLjMs6OR3n0sEwUKnHaFYRZALAVWjS1NkDl/2do+BD/Dts2czgFy1MHEnsvioSGSLU EZV1BJT5lnQiw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CLKxX1YXQz6tmg; Tue, 27 Oct 2020 19:29:52 +0100 (CET) Subject: Re: bug#44080: 27.1; Display behavior of overlays `after-string` in resizable minibuffer frames To: martin rudalics , Eli Zaretskii References: <83v9f6ngr6.fsf@gnu.org> <9a624e83-8d12-7597-2421-8c8ac9415ef9@gmx.at> <62b3f36b-c352-6004-7a59-e95ffe1ce408@gmx.at> <10267321-400d-5d36-1558-070a24476a03@posteo.de> <82e8f1b4-c3cb-6aec-45d3-e413da4a1b58@gmx.at> <052c2d28-c565-4038-92b1-38057bfe654b@posteo.de> <0a222f7d-6d3f-4c7c-548f-09f4af82ae6e@posteo.de> <632cd636-2821-10c7-da7c-66fa74b2558e@gmx.at> <1c3e6434-fc1b-ad72-f775-266e14facdcf@posteo.de> <97b3062e-b5e1-1ccf-deca-b8436f5ec8b9@gmx.at> <055a4dc1-6dcf-bf29-0ef9-1fd9145203bf@gmx.at> <4b20bc4b-590a-f7b9-c055-2205fda5051f@gmx.at> From: Clemens Message-ID: <4fca1457-0032-e3d2-5e6d-b203e3d94611@posteo.de> Date: Tue, 27 Oct 2020 19:29:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4b20bc4b-590a-f7b9-c055-2205fda5051f@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 44080 Cc: 44080@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > Pushed now. > > Thanks, martin Thanks! From unknown Sat Jun 21 12:20:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Nov 2020 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator