GNU bug report logs - #44077
[PATCH 0/2] gnu: poetry: Update to 1.1.3.

Previous Next

Full log

Message #14 received at 44077 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tanguy Le Carrour <tanguy <at> bioneland.org>
Cc: 44077 <at> debbugs.gnu.org
Subject: Re: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core.
Date: Tue, 20 Oct 2020 13:51:40 +0200

Hello,

Tanguy Le Carrour <tanguy <at> bioneland.org> writes:

> * gnu/packages/python-xyz.scm (python-poetry-core): New variable.

Thank you.

> +(define-public python-poetry-core
> +  (package
> +    (name "python-poetry-core")
> +    (version "1.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "poetry-core" version))
> +        (sha256
> +          (base32
> +            "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka"))))

Nitpick: move the string on the same line as `base32'.

> +    (build-system python-build-system)
> +    (home-page "https://github.com/python-poetry/poetry-core")
> +    (synopsis "Poetry PEP 517 Build Backend")

Nitpick: I would avoid unnecessary capitalization: 


  Poetry PEP 517 build back-end

> +    (description
> +     "A PEP 517 build backend implementation developed for Poetry.  This project
> +is intended to be a light weight, fully compliant, self-contained package allowing
> +PEP 517 compatible build frontends to build Poetry managed projects.")

The first sentence should be complete, i.e., with a subject and a verb.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.