Subject: Re: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core.

From: Tanguy Le Carrour <[email-masked]>
Date: Tue, 20 Oct 2020 17:30:36 +0200

Hi,

Le 10/20, Nicolas Goaziou a écrit :
> Tanguy Le Carrour <[email-masked]> writes:
> > +(define-public python-poetry-core
> > +  (package
> > +    (name "python-poetry-core")
> > +    (version "1.0.0")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (pypi-uri "poetry-core" version))
> > +        (sha256
> > +          (base32
> > +            "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka"))))
> 
> Nitpick: move the string on the same line as `base32'.

I have no clue what the rule is, but… most (but not all!?) packages in
`gnu/packages/python-xyz.scm` have the string on a new line.
I'll leave it on a new line if it's OK with you.

> > +    (build-system python-build-system)
> > +    (home-page "https://github.com/python-poetry/poetry-core")
> > +    (synopsis "Poetry PEP 517 Build Backend")
> 
> Nitpick: I would avoid unnecessary capitalization: 
>   Poetry PEP 517 build back-end

Done!

> > +    (description
> > +     "A PEP 517 build backend implementation developed for Poetry.  This project
> > +is intended to be a light weight, fully compliant, self-contained package allowing
> > +PEP 517 compatible build frontends to build Poetry managed projects.")
> 
> The first sentence should be complete, i.e., with a subject and a verb.

My bad! Updated!

Thanks again for your time!

-- 
Tanguy