GNU bug report logs - #44073
cperl-mode: Cleanup - Delete a misleading comment [PATCH]

Previous Next

Package: emacs;

Reported by: Harald Jörg <haj <at> posteo.de>

Date: Sun, 18 Oct 2020 23:56:02 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44073 in the body.
You can then email your comments to 44073 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44073; Package emacs. (Sun, 18 Oct 2020 23:56:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Harald Jörg <haj <at> posteo.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 18 Oct 2020 23:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Harald Jörg <haj <at> posteo.de>
To: bug-gnu-emacs <at> gnu.org
Subject: cperl-mode: Cleanup - Delete a misleading comment [PATCH]
Date: Mon, 19 Oct 2020 01:55:48 +0200

[Message part 1 (text/plain, inline)]
Severity: minor

With this patch, cperl-mode.el no longer informs the user about "Font
lock bugs" which have been fixed - or worked around - long ago: Some of
Perl's punctuation variables contain string delimiters ($`, $' and $")
but they don't start strings.  Fontification handles this correctly.

The patch eliminates the comment, and it comes with a test to verify
that cperl-mode gets it right in all cases which were listed in the
comment, plus some more.


[0001-cperl-mode-Delete-a-misleading-comment-add-tests-for.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44073; Package emacs. (Mon, 19 Oct 2020 08:59:01 GMT) Full text and rfc822 format available.

Message #8 received at 44073 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Harald Jörg <haj <at> posteo.de>
Cc: 44073 <at> debbugs.gnu.org
Subject: Re: bug#44073: cperl-mode: Cleanup - Delete a misleading comment
 [PATCH]
Date: Mon, 19 Oct 2020 10:58:17 +0200

Harald Jörg <haj <at> posteo.de> writes:

>
> With this patch, cperl-mode.el no longer informs the user about "Font
> lock bugs" which have been fixed - or worked around - long ago: Some of
> Perl's punctuation variables contain string delimiters ($`, $' and $")
> but they don't start strings.  Fontification handles this correctly.
>
> The patch eliminates the comment, and it comes with a test to verify
> that cperl-mode gets it right in all cases which were listed in the
> comment, plus some more.

Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 19 Oct 2020 08:59:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 44073 <at> debbugs.gnu.org and Harald Jörg <haj <at> posteo.de> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 19 Oct 2020 08:59:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 16 Nov 2020 12:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 213 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.