GNU bug report logs - #44070
28.0.50; Minibuffer display "jumps" upon minor edit

Previous Next

Full log

Message #17 received at 44070 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 44070 <at> debbugs.gnu.org
Subject: Re: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit
Date: Sat, 31 Oct 2020 09:12:16 -0400

>> That was my initial thought as well, but when I tried to implement it,
>> it quickly turned into a scavenge hunt trying to find all the places
>> where it needs to be set (and re-set after a kill-all-local-variables).
> That's strange: don't we have a single place where we create the
> minibuffer?

Yes, but the problem is that we reuse the minibuffers and that we need
to re-set the var after killing local vars, so the only sane place to
change this would be in `reset_buffer_local_variables`.

>> How 'bout the patch below, then?
> LGTM, modulo the NEWS and ELisp manual updates.

OK, thanks.  Done and pushed.

>> +  DEFVAR_BOOL ("minibuffer-scroll-conservatively",
>> +               minibuffer_scroll_conservatively,
>> +               doc: /* Non-nil means scroll conservatively in minibuffer windows.
>> +When the value is nil, scrolling in minibuffer windows obeys the
>> +settings of `scroll-conservatively'.  */);
>
> I'd say "behaves as if scroll-conservatively were set" instead of
> "obeys the setting of scroll-conservatively", because the latter can
> be interpreted as meaning one actually needs to set
> scroll-conservatively.

That's indeed what it means since it describes the behavior when the var
is nil (which is the old behavior).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.