GNU bug report logs - #44068
28.0.50; Faulty uses of tabulated-list-format

Previous Next

Full log

Message #65 received at 44068 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 44068 <at> debbugs.gnu.org
Subject: Re: bug#44068: 28.0.50; Faulty uses of tabulated-list-format
Date: Mon, 02 Nov 2020 00:07:34 +0100

On Fri, 30 Oct 2020 23:51:21 +0000 Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> It seems to.  I did experiment a bit with the width when I made the
>> patch just for the selected column and thought the length I used there
>> gave the best results, but maybe that was too cautious.  Does this patch
>> give better results (it differs from the previous one only in the
>> lengths checked and used for truncating):
>
> I think this looks very good, yes.  It works fully as I would expect, at
> least: it seems to always correctly show the sorting indicator and the
> ellipsis.
>
> (I tested using list-buffers, list-bookmarks, list-packages,
> list-processes, list-dynamic-libraries, org-lint and
> flymake-diagnostics-buffer-mode.)

Thanks for testing.

> Perhaps we could just go over the list above as you did in your first
> patch and make sure that there is enough space for all of these to show
> a sorting indicator without it touching the next column label.

I'll try to do that soon, but feel free to beat me to it ;-)

As an aside, do you think that use of the :right-align :pad-right
properties in timer-list-mode in my first patch is a good change?

>> It might be better to take more width parameters into account, as
>> tabulated-list-print-col does, but that seems rather more complicated
>> and I currently don't have time to pursue it.
>
> I imagine we can come back to and improve on this later.

Sure.

>> I wish I had more time for it but at the moment I don't.
>
> What you have here is already a big improvement, thank you.
>
> I would recommend to push this to master.

Thanks.  Eli, is that ok with you?

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.