GNU bug report logs -
#44068
28.0.50; Faulty uses of tabulated-list-format
Previous Next
Reported by: Stephen Berman <stephen.berman <at> gmx.net>
Date: Sun, 18 Oct 2020 20:01:01 UTC
Severity: minor
Merged with 41861
Found in versions 27.0.91, 28.0.50
Done: Stephen Berman <stephen.berman <at> gmx.net>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#44068: 28.0.50; Faulty uses of tabulated-list-format
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 44068 <at> debbugs.gnu.org.
--
44068: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44068
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
On Thu, 12 Nov 2020 11:38:04 -0500 Stefan Kangas <stefankangas <at> gmail.com> wrote:
> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>>> BTW, does it work better with narrowing the column, too? We seem to
>>> have some issues with that currently.
>>
>> Do you mean that truncation happens even though there is still enough
>> space to display the data or header? I see that both with hard spaces
>> and with the :right-align property. I haven't tried to figure out why
>> that's happening, but seems to be separate from above change.
>
> Indeed, it is a separate issue. I have opened Bug#44594 to track it.
Thanks.
>> Given that, and also Eli's approval of the tabulated-list-init-header
>> patch, I've gone ahead and committed these changes. I didn't make any
>> of the column width changes I proposed in my first patch, since with the
>> tabulated-list-init-header patch they don't seem to be needed.
>
> Thank you! I guess this bug should therefore be closed as fixed?
Yeah, I forgot to do that after committing the patch, done now.
Steve Berman
[Message part 3 (message/rfc822, inline)]
[Message part 4 (text/plain, inline)]
On trying out the new tabulated-list implementation of the bookmarks
list I noticed that, when clicking on the File header, the sort
indicator is not displayed, unlike with the Bookmark header. Then I
noticed that the same thing happens in the tabulated buffer list (C-x
C-b). Then I grepped for all uses of tabulated-list-format in the Emacs
sources and found the same problem in most of them. The reason is that
in these modes the width of at least one of the columns is too narrow,
so that tabulated-list-init-header omits the indicator. In most cases
the problematic column is the final one, but in a couple of cases there
are also non-final too narrow columns. And I think these bugs are due
to a misleading description in tabulated-list-format's doc string. The
attached patch corrects the doc string and the problematic uses of
tabulated-list-format. The patch also fixes a typo and tries to improve
column alignment in timer-list-mode: this is one of the few modes
derived from tabulated-list-mode whose column widths didn't need to be
corrected, but the alignment seemed suboptimal; however, when the header
line uses a variable-pitch face, the alignment is still suboptimal even
with the patch, and I don't know how to fix that.
In GNU Emacs 28.0.50 (build 34, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3)
of 2020-10-18 built on strobe-jhalfs
Repository revision: b7dfae3a8168977013e8de1df0916c51e76e7326
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Linux From Scratch SVN-20200401
2020-10-18 Stephen Berman <stephen.berman <at> gmx.net>
Fix uses of tabulated-list-format
* lisp/emacs-lisp/tabulated-list.el (tabulated-list-format):
Correct the documentation of the WIDTH element.
* lisp/bookmark.el (bookmark-bmenu-mode):
* lisp/buff-menu.el (list-buffers--refresh):
* lisp/emacs-lisp/package.el (package-menu-mode)
(package-archive-column-width):
* lisp/misc.el (list-dynamic-libraries--refresh):
* lisp/org/org-lint.el (org-lint--report-mode):
* lisp/progmodes/flymake.el (flymake-diagnostics-buffer-mode):
* lisp/simple.el (process-menu-mode): Increase column width in
order to display sort indicator.
* lisp/emacs-lisp/timer-list.el (timer-list-mode): Improve column
alignment.
(timer-list--function-predicate): Correct typo in doc string.
[Message part 5 (text/x-patch, attachment)]
This bug report was last modified 4 years and 270 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.