GNU bug report logs - #44049
[PATCH] build-system/haskell: Disable parallel builds.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44049 in the body.
You can then email your comments to 44049 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>, marius <at> gnu.org
Subject: [PATCH] build-system/haskell: Disable parallel builds.
Date: Sun, 18 Oct 2020 00:10:06 +0200

Fixes <https://bugs.gnu.org/43843>.

PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
leads to unreproducibility.  Instead of reverting, default is set to #false
which allows user to locally build with parallelism.

* guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
default.
---
 guix/build-system/haskell.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/haskell.scm b/guix/build-system/haskell.scm
index 8304e3b222..87085a50b0 100644
--- a/guix/build-system/haskell.scm
+++ b/guix/build-system/haskell.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Federico Beffa <beffa <at> fbengineering.ch>
 ;;; Copyright © 2020 Timothy Sample <samplet <at> ngyro.com>
+;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -115,13 +116,17 @@ version REVISION."
                                (cons name propagated-names))))))
                        extra-directories))))))))
 
+;;; PARALLEL-BUILD? introduced by commit
+;;; 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2 leads to unreproducibility.
+;;; Instead of reverting, default is set to #false which allows user to
+;;; locally build with parallelism. See <http://issues.guix.gnu.org/43843#3>.
 (define* (haskell-build store name inputs
                         #:key source
                         (haddock? #t)
                         (haddock-flags ''())
                         (tests? #t)
                         (test-target "test")
-                        (parallel-build? #t)
+                        (parallel-build? #f)
                         (configure-flags ''())
                         (extra-directories ''())
                         (phases '(@ (guix build haskell-build-system)

base-commit: d14221bf65cfbe7f8f5b7cac44132087cab70bf5
-- 
2.28.0

Message #10 received at 44049-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>, 44049-done <at> debbugs.gnu.org
Cc: 43843-done <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [PATCH] build-system/haskell: Disable parallel builds.
Date: Mon, 19 Oct 2020 00:11:30 +0200

[Message part 1 (text/plain, inline)]

zimoun <zimon.toutoune <at> gmail.com> writes:

> Fixes <https://bugs.gnu.org/43843>.
>
> PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
> leads to unreproducibility.  Instead of reverting, default is set to #false
> which allows user to locally build with parallelism.
>
> * guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
> default.

Thanks!  I shortened the comment a little and pushed to staging in
19d42e0e23a7f90ac2dcc1c279bd23a967ff0314.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.