From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 04:03:29 2020 Received: (at submit) by debbugs.gnu.org; 16 Oct 2020 08:03:29 +0000 Received: from localhost ([127.0.0.1]:57534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTKi1-0004uY-F5 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 04:03:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTKhz-0004uQ-LT for submit@debbugs.gnu.org; Fri, 16 Oct 2020 04:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTKhz-0001QT-9u for bug-guix@gnu.org; Fri, 16 Oct 2020 04:03:27 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:19112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kTKhv-0000lp-49; Fri, 16 Oct 2020 04:03:26 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4CCJYc2rQDzKm6T; Fri, 16 Oct 2020 10:03:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1602835394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=MmBe8ZUaNSGsi8ks46lMjs10OqnAKKNirwlf3wdYag8=; b=0NIesJUasUjAOQ18Ve304kWhofLuNKVxVJ6mon9fHxRKbwTLShAphZ3yxHWXbv0HHB//VB D4gFuvKssS3W7XHAcb39MtLNMcE8q52XlycoEAqePlC0nID5gbGgX2bgI5yryt6phu2w95 Ey8wE+vFuD4RqjxVr+xazQM7BL89SPELhdfA5qb7kfqQu6XlzJwpRXq6kyEmBG2T+mevXY GmqD8fphOOhgbvXYHx4qXtAD21PAC29NhYVgjLq/jsV1fWN3kMO9oNjGtGzJYf9TfHJc2n LShu5MDgOmbjBFajQPbJQ7jjBMsTFT9D0B4M9AUItR+LcpOWs1iw/kd9omAh0Q== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id ju8ottBZHrsL; Fri, 16 Oct 2020 10:03:12 +0200 (CEST) To: bug-guix@gnu.org From: Brendan Tildesley Subject: 1.2-29a2eb3 Installer fails at final stage installing GRUB. Message-ID: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> Date: Fri, 16 Oct 2020 19:03:07 +1100 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------E92C130E283EF9A85A93044B" Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -1.85 / 15.00 / 15.00 X-Rspamd-Queue-Id: 2D0EF16FE X-Rspamd-UID: 7d401e Received-SPF: pass client-ip=80.241.56.161; envelope-from=mail@brendan.scot; helo=mout-p-103.mailbox.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/16 04:03:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: Mathieu Othacehe , =?UTF-8?Q?Ludovic_Court=c3=a8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------E92C130E283EF9A85A93044B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit |Going through the GUI installer selecting all the defaults, and install with LVM and ecryption, AND for the normal option without encryption I get these errors on TWO different laptops, both ~10 years old with BIOS. Encrypted: Installing for i386-pc platform. grub-install: warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible. grub-install: error: embedding is not possible, but this is required for RAID and LVM install. Unencrypted: ||Installing for i386-pc platform. grub-install: warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible. grub-install: warning: Embedding is not possible. GRUB can only be installed in this setup by using blocklists. However, blocklists are UNRELIABLE and their use is discouraged.. grub-install: error: will not proceed with blocklists.| || --------------E92C130E283EF9A85A93044B Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit 
Going through the GUI installer selecting all the defaults, and install with LVM and ecryption, AND for the normal option without encryption I get these errors on TWO different laptops, both ~10 years old with BIOS.

Encrypted:

Installing for i386-pc  platform.
grub-install: warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible.
grub-install: error: embedding is not possible, but this is required for RAID and LVM install.

Unencrypted:

Installing for i386-pc  platform.
grub-install: warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible.
grub-install: warning: Embedding is not possible. GRUB can only be installed in this setup by using blocklists. However, blocklists are UNRELIABLE and their use is discouraged..
grub-install: error: will not proceed with blocklists.
--------------E92C130E283EF9A85A93044B-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 10:33:01 2020 Received: (at submit) by debbugs.gnu.org; 16 Oct 2020 14:33:01 +0000 Received: from localhost ([127.0.0.1]:60395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQmz-0005IP-01 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 10:33:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:36162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQmx-0005II-6J for submit@debbugs.gnu.org; Fri, 16 Oct 2020 10:32:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTQmw-0003Y4-Vm for bug-guix@gnu.org; Fri, 16 Oct 2020 10:32:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTQmv-0000ld-Tx; Fri, 16 Oct 2020 10:32:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37580 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTQmr-0006sw-Bg; Fri, 16 Oct 2020 10:32:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brendan Tildesley Subject: Re: 1.2-29a2eb3 Installer fails at final stage installing GRUB. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 16 Oct 2020 16:32:51 +0200 In-Reply-To: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> (Brendan Tildesley's message of "Fri, 16 Oct 2020 19:03:07 +1100") Message-ID: <87lfg65jho.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Mathieu Othacehe , bug-guix@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Brendan, Brendan Tildesley skribis: > Going through the GUI installer selecting all the defaults, and install w= ith LVM and ecryption, AND for the normal option without encryption I get t= hese errors on TWO different laptops, both ~10 years old with BIOS. > > Encrypted: > > Installing for i386-pc platform. > grub-install: warning: this GPT partition label contains no BIOS Boot Par= tition; embedding won't be possible. > grub-install: error: embedding is not possible, but this is required for = RAID and LVM install. > > Unencrypted: > > Installing for i386-pc platform. > grub-install: warning: this GPT partition label contains no BIOS Boot Par= tition; embedding won't be possible. > grub-install: warning: Embedding is not possible. GRUB can only be instal= led in this setup by using blocklists. However, blocklists are UNRELIABLE a= nd their use is discouraged.. > grub-install: error: will not proceed with blocklists. Shouldn=E2=80=99t it create a =E2=80=9Clegacy=E2=80=9D partition table rath= er than GPT since we=E2=80=99re on an old, non-UEFI platform? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 18:55:23 2020 Received: (at 44027) by debbugs.gnu.org; 16 Oct 2020 22:55:23 +0000 Received: from localhost ([127.0.0.1]:32878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTYd9-0001Be-6b for submit@debbugs.gnu.org; Fri, 16 Oct 2020 18:55:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTYd8-0001BQ-0r for 44027@debbugs.gnu.org; Fri, 16 Oct 2020 18:55:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45482) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTYd1-00015r-3y; Fri, 16 Oct 2020 18:55:15 -0400 Received: from cpe-70-118-247-167.kc.res.rr.com ([70.118.247.167]:56828 helo=debian) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTYcy-0005fw-DK; Fri, 16 Oct 2020 18:55:13 -0400 From: Brett Gilio To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#44027: 1.2-29a2eb3 Installer fails at final stage installing GRUB. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> Date: Fri, 16 Oct 2020 17:55:10 -0500 In-Reply-To: <87lfg65jho.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 16 Oct 2020 16:32:51 +0200") Message-ID: <878sc5wzld.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44027 Cc: othacehe@gnu.org, Brendan Tildesley , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s writes: > > Shouldn=E2=80=99t it create a =E2=80=9Clegacy=E2=80=9D partition table ra= ther than GPT since > we=E2=80=99re on an old, non-UEFI platform? > > Ludo=E2=80=99. > That is my thinking as well, it should create a legacy MBR table. --=20 Brett M. Gilio brettg@gnu.org https://brettgilio.com/ E82A C026 95D6 FF02 43CA 1E5C F6C5 2DD1 BA27 CB87 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 09:10:33 2020 Received: (at 44027) by debbugs.gnu.org; 17 Oct 2020 13:10:33 +0000 Received: from localhost ([127.0.0.1]:33665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTlyj-0007fA-2z for submit@debbugs.gnu.org; Sat, 17 Oct 2020 09:10:33 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:40239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTlyi-0007ey-9n for 44027@debbugs.gnu.org; Sat, 17 Oct 2020 09:10:32 -0400 Received: by mail-wr1-f49.google.com with SMTP id h5so6482126wrv.7 for <44027@debbugs.gnu.org>; Sat, 17 Oct 2020 06:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DkEL3r9MxgZ717Mu1u4TvT0pvzubHuFG/kMlKcqIiAk=; b=moev4ndVXT3eGr58wtx4roeJwiAe/qSYlpaVQVaqb7N3IkaFfl4EHZalhJt9c5GSqw Spe8INxdaJmciRvWB4tQIJHiEkcC3Q9jfzMWczqXcL0UjM7F64YGyK//W1FVbtSwMGiC rMPPUhdjHrQtmpPfTls9SO+EWwyMEWsXbyiX0IV9+U1yEvbofqHsCBMSEwPmBxu3fxj/ bMlvJZDtSuuA1F66V3DZJuV3WNJprCJQhseP7RSAKn56DWxxtdbyLgZtGdw4PHkSqm+k 84fD4ARcDdFYlW6R8Bso4r0BMWPiMQCYOqSofbHhUMPxfrKs+BNNlwkNt0JLC/EvUc6n yjcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DkEL3r9MxgZ717Mu1u4TvT0pvzubHuFG/kMlKcqIiAk=; b=hLpd+qHOYTgC5JQDESpQ2VfO99NgQYL3tacAZOQ2wnTeWGgvXhFyOL4FS3F9BgrkY8 MJqSffTQa19+eW/quJfeU1xwAlMCPOp1/kVookouFLsNZwEBQvdynchEWK2ZWykYbzrz 4z9P6dBdwTsNQYwwuR4k5B1xx231J0DmgJutiEoXtuVJDx2xer66+v76KKzD1U4EC+lZ jtRb5bhyaN6VTovYMH0lCi+BJPQ4lNeY1vdv9/I+qEjyIesdgd4MbpuAfFMMYMhh+KUF aOdXDaG38g5yoBK9AhOAdAAQsOS98R1QqEwS6HG/6kpthOX7+DRA9lCfsSOPxXAYnGBO Sblw== X-Gm-Message-State: AOAM531QTIym3rvH5fIjLj1o0qdn0KUyIqwHHhdchb40Jp97Q/kLFw/s 0FiERrz909yNGW0BHWg4qz5rvMZF8hcpvfMi X-Google-Smtp-Source: ABdhPJw+UDnvS/R8VYU+IwYeIQ8fEjjOdQmfT01gU/pqcH1r3FKC7bsnhYxdyDC3Mnl+6QS9Lt4NLw== X-Received: by 2002:adf:fbc5:: with SMTP id d5mr9575932wrs.232.1602940226140; Sat, 17 Oct 2020 06:10:26 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id f6sm8207789wru.50.2020.10.17.06.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2020 06:10:25 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Brett Gilio Subject: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> Date: Sat, 17 Oct 2020 15:09:27 +0200 In-Reply-To: <878sc5wzld.fsf@debian> (Brett Gilio's message of "Fri, 16 Oct 2020 17:55:10 -0500") Message-ID: <87pn5hq9rs.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44027 Cc: othacehe@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Brendan Tildesley , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Brett Gilio writes: > Ludovic Court=C3=A8s writes: >> Shouldn=E2=80=99t it create a =E2=80=9Clegacy=E2=80=9D partition table r= ather than GPT since >> we=E2=80=99re on an old, non-UEFI platform? > > That is my thinking as well, it should create a legacy MBR table. IMHO the old format should be avoided completely when possible. Why should we enforce it? I think this problem involves having a previous ESP partition on the disk (at least identified as such by parted), because auto-partition! currently checks that before checking if the booted system has EFI support. When that's the case, it doesn't create the needed bios_grub partition that might have been removed previously. The attached patch solves that. What do you think? Happy hacking, Miguel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-installer-Create-bios_grub-partition-when-it-is-need.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001-installer-Create-bios_grub-partition-when-it-is-needed.patch From=20a2f13b21a631398689cc5471c1910af294454e80 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Sat, 17 Oct 2020 14:20:41 +0200 Subject: [PATCH] installer: Create bios_grub partition when it is needed. * gnu/installer/parted.scm (auto-partition!): Only check for ESP on EFI installations. =2D-- gnu/installer/parted.scm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index b0c73b837e..fffd5abf3b 100644 =2D-- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -911,13 +911,13 @@ exists." =20 (let* ((start-partition (and (not has-extended?) =2D (not esp-partition) (if (efi-installation?) =2D (user-partition =2D (fs-type 'fat32) =2D (esp? #t) =2D (size new-esp-size) =2D (mount-point (default-esp-mount-point))) + (and (not esp-partition) + (user-partition + (fs-type 'fat32) + (esp? #t) + (size new-esp-size) + (mount-point (default-esp-mount-point)))) (user-partition (fs-type 'ext4) (bootable? #t) =2D-=20 2.28.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+K7QcACgkQY0xuiXn6 vsKyOQv+JjVmfFSf5ckupfrSBkgAsN7NSic/Q4bk8Ybku6LH61mgvzZJDvwZVv1y aufvLFtsSVLJDQ5WHAlKmXEnlWpt5t+CR4/Nd3XGZ/kuD5t2guw8X06TuI2BDkpE Uly0Y8sB89JFN6boKqU1UO1TKdW2MBexmAA9t8jg5eHkBnqLcyLD1ePJRR0v9dw8 g/gT217NznksJ6XZK4SfiNxcPHSfM4thGAJqy3pxQqTH34XVNPFGBAC89qBPc0DE lYk1rFD4XhNsgE+1BeugAaGM8kzqjkSjlzEu7kDaPJSNDwYkmbfJxQjq+z1TMUIz NdyddtWq1yzJVWhEaqNz+iZz7ElFHwbcJxMVkE8CI2JZVUahBZIz/xiZgfPlrkMT XcCmKV4bpBcL22qWa4GltoXqZroc0EBBt6klRfaNaLev5kHr06pF7J/YrdP4ne2v Z4f02nUcOizw0CFef1FFdfQnDMnJD1TlsrDkrwDPZJDAetDB4wcKh6jrdSbQri/7 KA7Hy4tB =hsTi -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 22:02:41 2020 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 02:02:41 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTy1x-0003QK-Ck for submit@debbugs.gnu.org; Sat, 17 Oct 2020 22:02:41 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:24354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTy1v-0003Q5-IV for 44027@debbugs.gnu.org; Sat, 17 Oct 2020 22:02:40 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CDNST3mSnzQlWB; Sun, 18 Oct 2020 04:02:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1602986551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a+qtRf3TeXUWx87UloWNn1B5qxdp53mkoiCqi23YlWA=; b=nmXOWp8ein6Qr1P8BQYcFCOUHpm4/0j3mHBRJ522wntdsYNLvIYzOFeprnLMKTGk4TgFZE rCJF5y6UiF+l/sp1kHH9RUqpgU0ohIMAdZffHw3mx7cRazVQn572rLm0Urr3vgjkfAmYQ0 hFGWr0w618vXQ4J0juUaKxc+qmfFQdueKh/iERSwAYW/v6ZYm7mjANARXC8wW8FwlmW1pb WFGn+g01axclF9F53VEmZKGsPdFjG7JcwcfLGX0u2rl/0/zpVfjtXRwuBnMzB4KN5+uMbu ouZWZ/CBrCiYdq1cixO6ts3f/13cDjr303+Bx6yDe63NbBpJpF0La6+UGeWf5w== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id OIvzC8LGYmIX; Sun, 18 Oct 2020 04:02:29 +0200 (CEST) Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. To: =?UTF-8?Q?Miguel_=c3=81ngel_Arruga_Vivas?= , Brett Gilio References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> From: Brendan Tildesley Message-ID: <418d612d-ef7c-ea58-2df2-80e4bb73ed4b@brendan.scot> Date: Sun, 18 Oct 2020 13:02:20 +1100 MIME-Version: 1.0 In-Reply-To: <87pn5hq9rs.fsf_-_@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -6.26 / 15.00 / 15.00 X-Rspamd-Queue-Id: 3CB9B16FE X-Rspamd-UID: f852fa X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44027 Cc: othacehe@gnu.org, =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 17/10/20 11:09 pm, Miguel Ángel Arruga Vivas wrote: > Hi, > > Brett Gilio writes: >> Ludovic Courtès writes: >>> Shouldn’t it create a “legacy” partition table rather than GPT since >>> we’re on an old, non-UEFI platform? >> That is my thinking as well, it should create a legacy MBR table. > IMHO the old format should be avoided completely when possible. Why > should we enforce it? > > I think this problem involves having a previous ESP partition on the > disk (at least identified as such by parted), because auto-partition! > currently checks that before checking if the booted system has EFI > support. When that's the case, it doesn't create the needed bios_grub > partition that might have been removed previously. > > The attached patch solves that. What do you think? > > Happy hacking, > Miguel I'm about to give it a test run. Unrelated to the patch, but, I'm building the installer (gnu/system/install.scm) on latest master and I get the following warnings/errors, although it doesn't stop the build from completing. is it a bug? https://paste.debian.net/plain/1167398 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 18 00:07:22 2020 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 04:07:22 +0000 Received: from localhost ([127.0.0.1]:36017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTzyc-0006OF-9k for submit@debbugs.gnu.org; Sun, 18 Oct 2020 00:07:22 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:41368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTzya-0006O3-9q for 44027@debbugs.gnu.org; Sun, 18 Oct 2020 00:07:20 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4CDRDL3vNFzKmbR; Sun, 18 Oct 2020 06:07:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1602994032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3kV6RAIwSQxwmdARL5NRpq7Mkf3prQduCx+B93+XumQ=; b=GqhYzrtNiaRc1G7on4/mqR8olDLAhMx+C7GnKhdCNaxDIEKczYaPFCUiyjUVpjx5UvUPdb DEOurg3RfSBg55omsHbYUMHe+oGYCseRroiMZJA8ViBIPyZlIQ/l+HKKXbWl6qOp6dzNs1 FPL5sFU1Cv6f33wQ82nPuwhl+mVZw1ksZiIXT7zMzxIKysyBxPzBYzLJGNzrMNs0PHFyQM DGr0almgv1GAijXGk1uGOVmBlFNTKbpvMerxDsNFeu+5ynFDoyEh1A4Li02cG3CSgO9Ogj PT4sB24lrV9nOoxOSRB36gIQw2iNTos8tD4uvRP32uZveeGUXkEej/6dkeiiIA== Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id gJaDQmu5wM4W; Sun, 18 Oct 2020 06:07:10 +0200 (CEST) Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. To: =?UTF-8?Q?Miguel_=c3=81ngel_Arruga_Vivas?= , Brett Gilio References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> From: Brendan Tildesley Message-ID: Date: Sun, 18 Oct 2020 15:07:05 +1100 MIME-Version: 1.0 In-Reply-To: <87pn5hq9rs.fsf_-_@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -5.48 / 15.00 / 15.00 X-Rspamd-Queue-Id: 44B3AEF7 X-Rspamd-UID: 71da84 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44027 Cc: othacehe@gnu.org, =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 17/10/20 11:09 pm, Miguel Ángel Arruga Vivas wrote: > [...] > The attached patch solves that. What do you think? > > Happy hacking, > Miguel I have tested the patch and the Installer mostly worked. One thing I noticed is that the partition scheme I was given automatically looks like this: 1 537MB fat32 boot,esp /boot/efi EFI System Partition 2 3146Kb ext4 bios_grub 3 2001MB linux-swap 4 37.5GB ext4 / It is creating the bios_grub partition, but the EFI is still being made also. Is that necessary? --- After completing the install, I was able to make it to the next bug!: https://issues.guix.gnu.org/44054 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 18 11:53:03 2020 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 15:53:03 +0000 Received: from localhost ([127.0.0.1]:38922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAzX-0001KW-0T for submit@debbugs.gnu.org; Sun, 18 Oct 2020 11:53:03 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAzV-0001Jz-Ll for 44027@debbugs.gnu.org; Sun, 18 Oct 2020 11:53:02 -0400 Received: by mail-wm1-f67.google.com with SMTP id j136so10277992wmj.2 for <44027@debbugs.gnu.org>; Sun, 18 Oct 2020 08:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=F0tC+P25p0yEpf+e0lIUKYS6YUrpKOxWr9zk2WQ7kVI=; b=J1ExnkDo0z+SVE/uEw5wxEWsqdRVyU4MxiO2t/J7o0OVcOnF6FIvhwOHFA2O0XH9GJ vYAuaNi67koB2JzHM63kDgy1au4d3gkVdYf4yvndzLiDTIVuqOSnX8gAe4/5n+UOXIMs N3a4X1vYS2ARXGKi0yqGU/dT0nkWLyazHqOlvqDgnwLZ6Eq0V9NWbhfT/6Je4fOg235D sf98dSArImRqH2Qb6PAmcoxWJgEO6OoieTufKQA7UPi5AJ5GvInHm0v9PzRH0TJIhNiE gpcu3X4/8ORw531WpIsoedSueOePYfUCYHQ6uTrdssj/mbV4MPj001Z/4/JhuK9xfO/j BFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=F0tC+P25p0yEpf+e0lIUKYS6YUrpKOxWr9zk2WQ7kVI=; b=VN8aWYbwqRvKO/Jp09AzFNePoUtExC/zQyfiEOKX/xg7Sbwku5a7nAyi96Mb7gMyeH VxNdyfJ/d93ptEydWP0juODe1tNc/BoUQMTQ8xl6R5PbwvGle2pqS3XQWapCn0MgTXFo BMyjgjBuf6mpBjrfg6pFhdcalf05ozddaKtrkiYlcbqcDo7wTeyE1AepAVn2qK9SJefh sHH/5fSTFTyp7DZcxFIFYtOohY1bReMZQjIQ0qQTy/0iqBekZLGEZp8O0X4KmjfXdab4 1Q6uXXVZE/sIsf+dlpXkn1fFuF/1QbR2w8k/zJM+JWVKciWuZLWnoNdiG8OkWRIl6DWk cT/Q== X-Gm-Message-State: AOAM532IoQWf/OOaemJMvfmWeGwtlN84bdzzF6LM9PMiKYrZsRYMpuPc dzEHNM+PwdZba21Vr+B8BFcFO0+gYR7C6kCO X-Google-Smtp-Source: ABdhPJzBa9+Qb4joRCYFTgAXrj2AkKooGGqReKTmTjf1fjYBYX/VDI3NVjeop5JUZNOiWQgJ1SsKQg== X-Received: by 2002:a1c:2d8f:: with SMTP id t137mr13214373wmt.26.1603036375442; Sun, 18 Oct 2020 08:52:55 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id p13sm13161277wmb.5.2020.10.18.08.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2020 08:52:54 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Brendan Tildesley Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> Date: Sun, 18 Oct 2020 17:52:00 +0200 In-Reply-To: (Brendan Tildesley's message of "Sun, 18 Oct 2020 15:07:05 +1100") Message-ID: <87mu0jpm5b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44027 Cc: othacehe@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , 44027@debbugs.gnu.org, Brett Gilio X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi! Brendan Tildesley writes: > On 17/10/20 11:09 pm, Miguel =C3=81ngel Arruga Vivas wrote: >> [...] >> The attached patch solves that. What do you think? >> >> Happy hacking, >> Miguel > > I have tested the patch and the Installer mostly worked. One thing I > noticed is that the partition scheme I was given automatically looks=20 > like this: > > 1 537MB fat32 boot,esp /boot/efi EFI System Partition > 2 3146Kb ext4 bios_grub > 3 2001MB linux-swap > 4 37.5GB ext4 / > > It is creating the bios_grub partition, but the EFI is still being > made also. Is that necessary? AFAIU from the code, the first partition should not be created by the installer but it won't be removed if it was found on the disk beforehand. Tomorrow I'll give a try at the full installation process, I must have overlooked something if it still being created in that case... Happy hacking! Miguel From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 18 13:03:39 2020 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 17:03:39 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUC5r-0005Ao-3B for submit@debbugs.gnu.org; Sun, 18 Oct 2020 13:03:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUC5p-0005Aa-Ix for 44027@debbugs.gnu.org; Sun, 18 Oct 2020 13:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46508) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUC5i-0003HL-E1; Sun, 18 Oct 2020 13:03:30 -0400 Received: from 2a01cb000492e90010138f9af686d929.ipv6.abo.wanadoo.fr ([2a01:cb00:492:e900:1013:8f9a:f686:d929]:56022 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUC5h-0003yt-Uv; Sun, 18 Oct 2020 13:03:30 -0400 From: Mathieu Othacehe To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> Date: Sun, 18 Oct 2020 19:03:27 +0200 In-Reply-To: <87mu0jpm5b.fsf@gmail.com> ("Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sun, 18 Oct 2020 17:52:00 +0200") Message-ID: <87imb7zctc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44027 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 44027@debbugs.gnu.org, Brendan Tildesley , Brett Gilio X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Miguel & Brendan, > AFAIU from the code, the first partition should not be created by the > installer but it won't be removed if it was found on the disk > beforehand. Tomorrow I'll give a try at the full installation process, > I must have overlooked something if it still being created in that > case... Thanks for your help on this topic! Brendan is probably using a GPT partitionned disk on a non-UEFI compatible machine. Hence, as you noticed, the installer does not create a bios_grub partition. This is a problem as this partition is necessary for GRUB and I think that your patch is fixing the problem. The "auto-partition!" procedure is also leaving a probably pre-existing ESP partition, but I don't really understand how it appeared in the first place. Brendan, did you use "manual partitioning" to create an ESP partition? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 01:58:07 2020 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 05:58:07 +0000 Received: from localhost ([127.0.0.1]:39618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUOBL-0007h1-D6 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 01:58:07 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:30264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUOBJ-0007gW-2I for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 01:58:05 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4CF5dg010XzQlBM; Mon, 19 Oct 2020 07:57:59 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1603087077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69XAYxC+DhViaOqCLFtTcoZUdGEsbaFs1qspj0Be5Qs=; b=1t1JNeQYCcqvW03lUsRXeUrDcLGziZLwKmAfGfKUF1pS20NmXylQELxqdAKh3rrHYaetO8 vpZ3Hem9q1H6WBmIWaapzAhocxfKDpH3rgWiNZZlIrki9H0vo2u82iGzoUORTUiR+SqBl5 RK2GLPviqfyhLaaJCt1MEiFlNiXcImZHDwEdJqmQjhmHimhAXVqXvNNRL84tul4mP7/n/4 g9uqjx65RFblCD497g2RaensilLSW1Tr7QOlgRZtQwZCcARpBlqo6fz4sqBv5+T8pQ84jJ Er/Ao6pUkuHI61wkK1xB/MtyKpDGDw07uysnzkAUT88YQt4YyTPcrJ8U0oJpCQ== Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id U3JAJwipljPx; Mon, 19 Oct 2020 07:57:55 +0200 (CEST) Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. To: Mathieu Othacehe , =?UTF-8?Q?Miguel_=c3=81ngel_Arruga_Vivas?= References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> From: Brendan Tildesley Message-ID: Date: Mon, 19 Oct 2020 16:57:49 +1100 MIME-Version: 1.0 In-Reply-To: <87imb7zctc.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-MBO-SPAM-Probability: X-Rspamd-Score: -3.81 / 15.00 / 15.00 X-Rspamd-Queue-Id: DF30117EA X-Rspamd-UID: 330e5c X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44027 Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 44027@debbugs.gnu.org, Brett Gilio X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 19/10/20 3:03 am, Mathieu Othacehe wrote: > Hello Miguel & Brendan, > >> AFAIU from the code, the first partition should not be created by the >> installer but it won't be removed if it was found on the disk >> beforehand. Tomorrow I'll give a try at the full installation process, >> I must have overlooked something if it still being created in that >> case... > Thanks for your help on this topic! Brendan is probably using a GPT > partitionned disk on a non-UEFI compatible machine. Hence, as you > noticed, the installer does not create a bios_grub partition. > > This is a problem as this partition is necessary for GRUB and I think > that your patch is fixing the problem. The "auto-partition!" procedure > is also leaving a probably pre-existing ESP partition, but I don't > really understand how it appeared in the first place. > > Brendan, did you use "manual partitioning" to create an ESP partition? Hmm I forget what was on this drive. I used to have Windows 10 on it, then I can't remember. I may have installed Arch Linux on it. What ever was on it, I just ran the installer letting it do it's thing selecting Encrypted root with LVM because I wanted to see if that worked. it didn't, then I tried the default, before posting the bug report. Finally I went though with Miguel's patch selecting all the defaults and that was the result. I feel the installer should not care what was on the drive to begin with, it should just format the drive how it sees fit. Why should the existing contents of the drive affect the outcome when we are reformatting everything anyway? > > Thanks, > > Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 06:48:20 2020 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 10:48:20 +0000 Received: from localhost ([127.0.0.1]:40099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUSiC-0007ON-IG for submit@debbugs.gnu.org; Mon, 19 Oct 2020 06:48:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUSiB-0007O8-Ib for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 06:48:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59955) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUSi4-0001Id-Ih; Mon, 19 Oct 2020 06:48:12 -0400 Received: from [109.190.253.14] (port=33416 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUSi3-0003qs-Ri; Mon, 19 Oct 2020 06:48:12 -0400 From: Mathieu Othacehe To: Brendan Tildesley Subject: Re: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> Date: Mon, 19 Oct 2020 12:48:07 +0200 In-Reply-To: (Brendan Tildesley's message of "Mon, 19 Oct 2020 16:57:49 +1100") Message-ID: <87pn5emqzc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44027 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 44027@debbugs.gnu.org, Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas , Brett Gilio X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Brendan, > I feel the installer should not care what was on the drive to begin with, it > should just > format the drive how it sees fit. Why should the existing contents of the > drive > affect the outcome when we are reformatting everything anyway? That's the case except for the ESP partition that is preserved by the installer because it could contain vendor / operating system specific files that should not be wiped. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 09:22:30 2020 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 13:22:30 +0000 Received: from localhost ([127.0.0.1]:40243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV7O-0005Im-72 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 09:22:30 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:39454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV7M-0005IV-ST for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 09:22:29 -0400 Received: by mail-wr1-f51.google.com with SMTP id y12so11426984wrp.6 for <44027@debbugs.gnu.org>; Mon, 19 Oct 2020 06:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MHMgGSF4nDEZpZxzfw26GfN3k5u15mA+SFFt6/zM8NU=; b=NZ2QqiYuL5W+Ny8CqMor9NV8lziadaQzC3X3JKwX8ahCA62QOQ5B4cgWHvixCJeCe/ OAdes9A1CHTDWhWtmgwSg01vAksTHJ7u+Qv48UtPjmQBjx4pCYTWKa9JFixYvYyJ+W5X BmOM16/oGS+kBxIPryUI2FUDLdBu5mP1Lmn6wiQxDu5Uu5C+lOuibAoNxLhtG/6LNt6Z jzPGegqMwfl0azC3jKtzqt8BCm2Vo2I2AYYzanCIq95pJAjaG4vpWY/HuC2ORweecVrB BdBaUryCBzRUDU+zr2HHdeRfbJQdZFCWqMBeEq5xZMWTNZMrzueILEs6uLS8NB3pxrnz x0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MHMgGSF4nDEZpZxzfw26GfN3k5u15mA+SFFt6/zM8NU=; b=oQiEz+CrOEbcSYet4IMzncCZ0FKnQ1dOkn9zOYe9P1D3Y4QOHtO5Rut4JD0wMxhY63 mwIbPke41hA7YXwl1Ok1rj/DzRaKTvT7S+u2v+XSN5tdIEWlcmUVlioywOUBDmgLkcRy kt0jOJYuLo+gEoOf/Pba5UKQbGBSiWog5SO5DThZ8Drn/MsTH2UsOeJdGiEOiMKd75J6 UDAL8lT8nZxJnJ2xlJqphhojllARsp99aw83iHTKhlY94983M+r93iqMmHr5z66M1hm9 nR9s3+rp+aXWgR/KXLVPb7pjeAEaQ9Z3kJWlQiz0SpVloNxSKauJESSPnDy75XfEADJM 41Fw== X-Gm-Message-State: AOAM531PXv9qsdFtTKUEId4kkMG1BUvB2hm2u7pMIUE3I+0R0cqWVBu8 np3DtXz5pWEPVnesi4FwXD9a/VMyWt5TQ3pg X-Google-Smtp-Source: ABdhPJwyE8isx6ud8YLFmEHNZVis7myIv/s/YASWkgQvK1lT7MJ7DVK6wFPJQtGIYDe+39PA6Ii8yQ== X-Received: by 2002:adf:fc08:: with SMTP id i8mr21025619wrr.116.1603113743338; Mon, 19 Oct 2020 06:22:23 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id a15sm17775118wro.3.2020.10.19.06.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 06:22:22 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Mathieu Othacehe Subject: Re: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> Date: Mon, 19 Oct 2020 15:21:18 +0200 In-Reply-To: <87pn5emqzc.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Oct 2020 12:48:07 +0200") Message-ID: <87pn5enygh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44027 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Brett Gilio , Brendan Tildesley , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Hi Mathieu, Mathieu Othacehe writes: > Hello Brendan, > >> I feel the installer should not care what was on the drive to begin with, it >> should just >> format the drive how it sees fit. Why should the existing contents of the >> drive >> affect the outcome when we are reformatting everything anyway? > > That's the case except for the ESP partition that is preserved by the > installer because it could contain vendor / operating system specific > files that should not be wiped. Is there any other issue remaining? It doesn't modify this logic at all. Should I apply this patch to master then? Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+Nks4ACgkQY0xuiXn6 vsJ5/Av/RNphssqvyhjqIpVQ2Qs3hunXsmrJUvHJBd6+tZ0EhQRbbW8WqcBFP292 8u0/xfBgS+5dwUuZnweRYEnTy1swNWpFQFfgfdP3WQNznnWgcYlhzlAQR/iG/GUp Zs2FeUBoQj5IjlSRQIh4NvQP9wlkTsFk/nTQhPFA1F+ywM5pwrFxKY1+cPkPdSGi gWDsLzs/h1ZSfKMAXvFKWX5KwSTnHPDUXHQIVE9mFF6PP/rWwquQoFwNQCsUAKXf Oo3R5nzZ7MJYDpeY/5ob7VUio79TaCgJuX6O+1RLeu8/beWbI9twk08JEvYW1Vc+ vGUeW4P9Z8Yd8C43Ibbjup46sYOk2eyO8SBNAuGWY/Zijr8GPNZPB82YmHEzXzV2 /thV+9l1HwARQlI+9dPp2g7ha6WjzlkFrn//Pa6/S+f8QuaKGyz9o9ZFx9VUtIS1 3R9j8unf2UkfgOrEUa+9krnGEhpXqyb9oB3kgROESbLqKImBPrx8xx05JgBP2cgo lENndUzt =KYap -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 11:52:07 2020 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 15:52:07 +0000 Received: from localhost ([127.0.0.1]:42065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUXSB-0005Nr-4K for submit@debbugs.gnu.org; Mon, 19 Oct 2020 11:52:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUXS8-0005NN-F9 for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 11:52:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36432) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUXRz-00085N-VX; Mon, 19 Oct 2020 11:51:56 -0400 Received: from [2a01:e0a:19b:d9a0:6d9b:8bf5:86c1:cec2] (port=38612 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUXRz-00010c-J9; Mon, 19 Oct 2020 11:51:55 -0400 From: Mathieu Othacehe To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas Subject: Re: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. In-Reply-To: <87pn5enygh.fsf@gmail.com> ("Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Mon, 19 Oct 2020 15:21:18 +0200") References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> <87pn5enygh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Mon, 19 Oct 2020 17:51:54 +0200 Message-ID: <871rhukycl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44027 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Brett Gilio , Brendan Tildesley , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Miguel, > Is there any other issue remaining? It doesn't modify this logic at > all. Should I apply this patch to master then? Yes, your patch LGTM. Please make sure that system tests are still working by running: --8<---------------cut here---------------start------------->8--- make check-system TESTS="gui-installed-os gui-installed-os-encrypted gui-installed-desktop-os-encrypted" --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 16:00:47 2020 Received: (at 44027-done) by debbugs.gnu.org; 19 Oct 2020 20:00:47 +0000 Received: from localhost ([127.0.0.1]:42547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUbKp-0001Dq-3F for submit@debbugs.gnu.org; Mon, 19 Oct 2020 16:00:47 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUbKn-0001Da-D9 for 44027-done@debbugs.gnu.org; Mon, 19 Oct 2020 16:00:45 -0400 Received: by mail-wr1-f65.google.com with SMTP id e17so1044970wru.12 for <44027-done@debbugs.gnu.org>; Mon, 19 Oct 2020 13:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ih8gg5zo0scoUNUvL+BcY2tZX2kEPv1o9+5seyQAmaE=; b=DdQhkt73K+pZ+XfzorcuQSxJZnc5HgvTOrk/n+nRk7mfAZqo8yxYhfegARu5wg4UpJ 3KNgfm+CGUwJBSWU2uovUR2P1e9DqjC/Beutw1z1WABYAmj8pC5mlTHm+fPpvHq4zLgb rrlhot3IULg5mWx179h6sOYV78uWaZImFfA9su+iGo1WXAqmDE+j43iB0p7ILMKUaGFH 8Ryjie32JpNFtq79UGi5cYyUy/PEQCjJM9/9Tu6vXsFVSo6KTK5G1libCv2xgF7VnXF5 xwI8W2wVtBXBi77jp2Fm9sDQyjryLYEeKU83cubz43ymoMtQy7V0g5wybL6tBtfjSI34 NXaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ih8gg5zo0scoUNUvL+BcY2tZX2kEPv1o9+5seyQAmaE=; b=JK+w15Dqpa4zb+chjnydg8vRbLuLxUqE5kxMJl1A51UdE8TKFr812axoR+Me6fH6aA DcIN47KZc5MC3hiYtsUwPf7ZmIeJvlJaW0U4oZY1EXEvbwUk36hcmpVvjLNaPfSFxX5f 0vgzpRFKGf4lgItwgf6Z4GiOGCzQgju73ZEmA+GbFEVuHNQ41R31OknFX6WyYCFMmU2v q6MsuJsgTNxCK2mCCcpPwSjYtB4hB71MHTDLxZ+hMVnpMFVpsrtEYawggfAth1GDOAnu ojqtnQh0qzgeNBYVXz1WizK0f0tm1dOZ9ihQ/D1saBbct8YMp9YQf0t3Xts46bwM/GeZ Q3tQ== X-Gm-Message-State: AOAM533tgG9xG7Yl63YQ74NYNRZqFRnKlcsneac3tazVw15LbSnPZnUG 7J0VCdrdVZ4LnZMgU7YgYjStVvTbzudeNZ0F X-Google-Smtp-Source: ABdhPJwPTGKUiEmoDLVsF4BdERSGlHVYUB9YP/1erbV4haikGY30k3IUEh/G5NFz+AYBLqLaJAGaiw== X-Received: by 2002:a5d:410a:: with SMTP id l10mr961285wrp.274.1603137638993; Mon, 19 Oct 2020 13:00:38 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id 1sm1146816wre.61.2020.10.19.13.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 13:00:37 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Mathieu Othacehe Subject: Re: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> <87pn5enygh.fsf@gmail.com> <871rhukycl.fsf@gnu.org> Date: Mon, 19 Oct 2020 21:59:30 +0200 In-Reply-To: <871rhukycl.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Oct 2020 17:51:54 +0200") Message-ID: <87v9f6kmvx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44027-done Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 44027-done@debbugs.gnu.org, Brendan Tildesley , Brett Gilio X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Hi, Mathieu Othacehe writes: > Hello Miguel, > >> Is there any other issue remaining? It doesn't modify this logic at >> all. Should I apply this patch to master then? > > Yes, your patch LGTM. Please make sure that system tests are still > working by running: > > make check-system TESTS="gui-installed-os gui-installed-os-encrypted > gui-installed-desktop-os-encrypted" I pushed it to master as 19c14d95b3 after running successfully these system tests. Thank you very much, and happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+N8CMACgkQY0xuiXn6 vsLjHwwAqGKUU3mWw6i+MuU8ie7iYBWDl+nWcSTZ0QU2a+gWKapdrywyx0Bv5YGt dVow6MXGjhoelnrG2yiotitcb2Qrduck39Uj1RnXbfkfT0nAl/sNjY3L4ui2aqos jBz/F2lVgwqOFHeL1H2dp63DWH31kV3gQ55R7zbRZ1kcNFBywclv88QkIiov6P0g 6r54YwNhABqzZGOOQEGnWRXZAnOaeu4HXTwlqWIv4nVbzMRS0oEbe+Of9asUGGj3 xeZRUYo7zkcdW1pVvHctdoFDzGc+7XmzGO0ALomQiPvAI3Q44+W0qP/iaGkvOVrY RqKShVa5BjXNFoHjGymYuNWfiavO0FkQQw0WAGe6dgY8n4lHp5Cj7GKLHMMgcuff cFbZUA51GjjCoQiAds/a9hQwZvXPhSon0sfrHzO5qA824FeSCHb65Rz67UONekoG uoqYHIQZcK8jydPR0j/B/+DjyShsFSQIiV0Nd8A14BDfZW9ht4IRTpOXlboSN+LO MNjw50zi =5ywC -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 01:33:37 2020 Received: (at 44027) by debbugs.gnu.org; 20 Oct 2020 05:33:37 +0000 Received: from localhost ([127.0.0.1]:43130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUkHB-00012x-El for submit@debbugs.gnu.org; Tue, 20 Oct 2020 01:33:37 -0400 Received: from imta-38.everyone.net ([216.200.145.38]:53990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUkH9-00012p-GS for 44027@debbugs.gnu.org; Tue, 20 Oct 2020 01:33:36 -0400 Received: from pps.filterd (omta003.sj2.proofpoint.com [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 09K5RO3Z000408; Mon, 19 Oct 2020 22:33:24 -0700 X-Eon-Originating-Account: NH4qd7BbqBsUhQZUsk95ZhiRD8TbowL7KidtJW4Qe7I X-Eon-Dm: m0116953.ppops.net Received: by m0116953.mta.everyone.net (EON-AUTHRELAY2 - 5a81d795) id m0116953.5f8a0276.3aa63; Mon, 19 Oct 2020 22:33:23 -0700 X-Eon-Sig: AQMHrIJfjnajsrG4MgIAAAAE,9bbb9fbe0f80653671d14bb34407afe0 X-Eip: ntbvHxrw-_yGV_V_miQgY9uAzxEnM__Ojq_bYNJ81p8 Date: Tue, 20 Oct 2020 07:33:13 +0200 From: Bengt Richter To: Brendan Tildesley Subject: Re: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Message-ID: <20201020053313.GA2516@LionPure> References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-20_03:2020-10-16, 2020-10-20 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1034 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010200037 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 44027 Cc: Mathieu Othacehe , Miguel =?utf-8?B?w4FuZ2Vs?= Arruga Vivas , 44027@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hi, On +2020-10-19 16:57:49 +1100, Brendan Tildesley wrote: > On 19/10/20 3:03 am, Mathieu Othacehe wrote: > > Hello Miguel & Brendan, > > > > > AFAIU from the code, the first partition should not be created by the > > > installer but it won't be removed if it was found on the disk > > > beforehand. Tomorrow I'll give a try at the full installation process, > > > I must have overlooked something if it still being created in that > > > case... > > Thanks for your help on this topic! Brendan is probably using a GPT > > partitionned disk on a non-UEFI compatible machine. Hence, as you > > noticed, the installer does not create a bios_grub partition. > > > > This is a problem as this partition is necessary for GRUB and I think > > that your patch is fixing the problem. The "auto-partition!" procedure > > is also leaving a probably pre-existing ESP partition, but I don't > > really understand how it appeared in the first place. > > > > Brendan, did you use "manual partitioning" to create an ESP partition? > Hmm I forget what was on this drive. I used to have Windows 10 on it, then I > can't > remember. I may have installed Arch Linux on it. What ever was on it, I just > ran the > installer letting it do it's thing selecting Encrypted root with LVM because > I wanted to > see if that worked. it didn't, then I tried the default, before posting the > bug report. > Finally I went though with Miguel's patch selecting all the defaults and > that was > the result. > I feel the installer should not care what was on the drive to begin with, it > should just > format the drive how it sees fit. Why should the existing contents of the > drive > affect the outcome when we are reformatting everything anyway? > > > > Thanks, > > > > Mathieu > I agree that existing contents should not matter, UNLESS: You are about to shoot yourself in the foot by overwriting the wrong disk. I think it is risky to target disks just by /dev/, so if doing that, with e.g. /dev/sdb, I would like a safe confirmation dialog displaying the output of $ lsblk -o mountpoint,type,kname,model,serial /dev/sdb MOUNTPOINT TYPE KNAME MODEL SERIAL disk sdb SanDisk_3.2Gen1 xxxxxx... with automatic verification that it is not mounted, is type disk, and asking me if the model and serial number look right. The nice thing about the serial number is (AFAIK) that it persists for selection even after zapping GPT/MBR UUIDs. Similar checks before overwriting any pre-existing disk or partition, please. Maybe also have a target-disk-serial parameter that can be part of my-system.scm to lock in the right target disk? Similary for partitions for /boot and / and any others. (Hm, BTW, how are stable disk type, model and serial number lsblk outputs above provided for virtual disks? ) [later] Hm, I decided to test the serial number persistence, and the brand new Sandisk_3.2Gen1 made lsblk show a whopping 120-character string for that xxxxxx... serial, but after zapping it fully with gdisk, the output was the first 39 characters, Presumably gdisk enforced a 40-byte buffer size with a null in the last byte. BUT: Waitaminit -- how could it do that if that buffer was manufactured read-only?? I'll try dd-ing zeroes over the front end, and seeing if there's a serial after that... So it that a bug in lsblk, or in SanDisk manufacturing? Well, the confirmation dialog would work either way, but the target-disk-serial parameter would have to do a prefix-match or something, until all parties get their acts together ;-) [later] zapped the first 1GiB of /dev/sdb with dd, and lsblk returned 39 chars like after gdisk zap, BUT: now it's back to the same long number, which also shows up at /dev/disk/by-id/* Meanwhile, did: apt install sdparm (mentioned at [1]), and then sdparm got me the first 20 characters of lsblk's version: --8<---------------cut here---------------start------------->8--- sudo sdparm --page=sn /dev/sdb [sudo] password for bokr: /dev/sdb: USB SanDisk 3.2Gen1 1.00 Unit serial number VPD page: xxxxxxxxxxxxxxxxxxxx --8<---------------cut here---------------end--------------->8--- and lsblk and /dev/disk/by-id both show the original long serial, which suggests they share some code, since they agree and both disagree with the 20-char version from sdparm. Per [1], the serial number isn't stored in the data writeable part, it's in the scsi controller innards, retrieved by saying the right thing to the controller, unlike other ways of serializing storage. But is sdparm right? 20 characters seems stingy. ┌──────────────────────────────────┐ │ ISTM there's a bug somewhere ;-) │ └──────────────────────────────────┘ I'm mCurrently running (per uname -a): Linux LionPure 4.19.0-9-amd64 #1 SMP Debian 4.19.118-2+deb10u1 (2020-06-07) x86_64 GNU/Linux ...without guix though, sorry, I like guix :/ (though there's lots of scraps around, until I can install one with absolute minimal use of sudo :) [1] https://stackoverflow.com/questions/2432759/usb-drive-serial-number-under-linux-c HTH make things better (at least with the confirmation dialog part :) And maybe a clue to a bug. -- Regards, Bengt Richter From unknown Mon Aug 18 11:17:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Nov 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator