From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 23:14:33 2020 Received: (at submit) by debbugs.gnu.org; 16 Oct 2020 03:14:33 +0000 Received: from localhost ([127.0.0.1]:57148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGCP-0007mB-ED for submit@debbugs.gnu.org; Thu, 15 Oct 2020 23:14:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:41734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGCN-0007m3-Bk for submit@debbugs.gnu.org; Thu, 15 Oct 2020 23:14:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTGCN-0001Gj-6f for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:14:31 -0400 Received: from mo-sw1510.iijmio.jp ([203.180.38.129]:37516 helo=mo-sw.iijmio.jp) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTGCK-0004aR-6T for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:14:30 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Subject:From:Mime-Version:Content-Type: Content-Transfer-Encoding;i=arakawa@pp.iij4u.or.jp;s=20200530.mm;t= 1602818058; x=1604027658; bh=lHBcqP4ups/+KKfRAJAcrVSarILTx4cr+KLvFzJBf4I=; b=kB1 resqWNLrOKlLXOgss67fhZGD/SSiaxudUbI/0M4hGPOV7QgKE/CTyDYC9TLxw2IsqcFN4Jkq75lUz A+KKD7Q3EXg+jj0JNfGuoFCLbInyHxU7ymNwSMZZwW2hTaW5zWVFEmKRPS1V5oIIefIfuhWL+tYZ7 Znk7UsH1oocZ/KiJwg6cm7uBrJPNHi6ncyknDSURt9qvsZkQz3XX8GmYcoJo9zEKL1fVCZ5tzLefT cTvV+ErS74WwRqFxA1NL+i68DOLCzwsI0OKUwBjjj/DFWfnVvynIlWRSFxwddj4Qo9WUb+DJjZ/v0 p4x+pV9op/G5wf9sEArz9h17JLekNJA==; Received: by mo-sw.iijmio.jp (mio-mo-sw1510) id 09G3EIjc002098; Fri, 16 Oct 2020 12:14:18 +0900 Received: from localhost (corsica.s2factory.co.jp [122.220.15.114]) by mbox.iij4u.or.jp (mio-4u-mbox1511) id 09G3EHMo000957 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Oct 2020 12:14:17 +0900 Date: Fri, 16 Oct 2020 12:14:15 +0900 =?iso-2022-jp?B?KBskQkVsNX4bKEIgKBskQkk4PWA7fhsoQikp?= Message-Id: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> To: bug-gnu-emacs@gnu.org Subject: [PATCH] vc.el: vc-revision-other-window does not select the buffer From: Koichi Arakawa X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=203.180.38.129; envelope-from=arakawa@pp.iij4u.or.jp; helo=mo-sw.iijmio.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/15 23:14:19 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, BUG6152_INVALID_DATE_TZ_ABSURD=0.1, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, INVALID_DATE=1.096, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Hi, The current version of vc-revision-other-window does not select a buffer which contains the specified revision. But ediff-vc-internal, for example, expects the buffer is selected as the current one. So I think the following patch is needed. Regards, Koichi Arakawa diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 46c44fa54b..f34bd0f2a1 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2058,13 +2058,12 @@ If `F.~REV~' already exists, use it instead of checking it out again." (list (vc-read-revision "Revision to visit (default is working revision): " (list buffer-file-name))))) - (with-current-buffer (or (buffer-base-buffer) (current-buffer)) - (vc-ensure-vc-buffer) - (let* ((file buffer-file-name) - (revision (if (string-equal rev "") - (vc-working-revision file) - rev))) - (switch-to-buffer-other-window (vc-find-revision file revision))))) + (vc-ensure-vc-buffer) + (let* ((file buffer-file-name) + (revision (if (string-equal rev "") + (vc-working-revision file) + rev))) + (switch-to-buffer-other-window (vc-find-revision file revision)))) (defun vc-find-revision (file revision &optional backend) "Read REVISION of FILE into a buffer and return the buffer. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 01:27:40 2020 Received: (at 44026) by debbugs.gnu.org; 16 Oct 2020 05:27:40 +0000 Received: from localhost ([127.0.0.1]:57277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTIHD-00070u-Uj for submit@debbugs.gnu.org; Fri, 16 Oct 2020 01:27:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTIHB-00070i-Je for 44026@debbugs.gnu.org; Fri, 16 Oct 2020 01:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rTfkQF6IdDMgaj9lNqoSI5okNnEczMQf3M7MaG24tdo=; b=KPPXrAuuLlCLCZ5JZQ266kcVfR 6CMUQR5+WyVPAyLWfS5o3sSFyxt/XMY+YR8Cgvs+o7sCQ3iqi4BjaoqQUxdS4IxSW9koYGOH2gauG v8wK6pRajOKT+Zb6y6UpIQfRL9D2VCKcB5Pyx8Y1hJzNCYtfm+UdoyoAjmC1C40yF4qk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTIGz-0007LS-H2; Fri, 16 Oct 2020 07:27:28 +0200 From: Lars Ingebrigtsen To: Koichi Arakawa Subject: Re: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer References: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> X-Now-Playing: Liaisons Dangereuses's _Liaisons Dangereuses_: "Dupont" Date: Fri, 16 Oct 2020 07:27:24 +0200 In-Reply-To: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> (Koichi Arakawa's message of "Fri, 16 Oct 2020 12:14:15 +0900 =?utf-8?B?KOadseS6rAko5qiZ5rqW5pmCKSki?=) Message-ID: <871rhysptv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Koichi Arakawa writes: > The current version of vc-revision-other-window does not select a > buffer which contains the specified revision. But ediff-vc-internal, > for example, expects the buffer is selected as the current [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44026 Cc: 44026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Koichi Arakawa writes: > The current version of vc-revision-other-window does not select a > buffer which contains the specified revision. But ediff-vc-internal, > for example, expects the buffer is selected as the current one. Do you have a recipe to reproduce this bug? When I use the `C-x v ~' command, I don't get any errors. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 02:26:20 2020 Received: (at 44026) by debbugs.gnu.org; 16 Oct 2020 06:26:20 +0000 Received: from localhost ([127.0.0.1]:57373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJC0-0004Lh-9E for submit@debbugs.gnu.org; Fri, 16 Oct 2020 02:26:20 -0400 Received: from mo-sw1511.iijmio.jp ([203.180.38.130]:41856 helo=mo-sw.iijmio.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJBy-0004LW-BC for 44026@debbugs.gnu.org; Fri, 16 Oct 2020 02:26:19 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Cc:Subject:From:In-Reply-To:References:Mime-Version: Content-Type:Content-Transfer-Encoding; i=arakawa@pp.iij4u.or.jp; s=20200530.mm ;t=1602829574;x=1604039174;bh=yTs4k+E81eNTbnXA6GdWqigWr8mo9oZIUfKvaJsqXSA=; b=dTSyWla1O2fqdHdrueb9hubEZPoAPFw+T6Lix0v68UBMW/SZVU0STHaXVX2rSofMeSb3Ucs5+42 Srgl6OfpF0E/bfJq6sB+3NhDA8tr8CQlVWpETDb7XxroDXXtqoZdAUWVqWOYTSVd+2EuOTDmUswlb mMybtzhPnKGXX9p19PK/b8ap1wbxmFvR/BeaEy1xgxSaiqLZe0NgwMpG7KYNC+AupKksykH0GmH7V OdgUw3snoRWbrQ0NnLTpfyNz+ckNAY5DGU4JL0fVbPqxRvzyZDRUOWmMtC88ih1w2LOCjtBi1WuCu 4J6OOGLynTJPd8jUft0y0zM62xXrBQRGjHwQ==; Received: by mo-sw.iijmio.jp (mio-mo-sw1511) id 09G6QEpO022199; Fri, 16 Oct 2020 15:26:14 +0900 Received: from localhost (corsica.s2factory.co.jp [122.220.15.114]) by mbox.iij4u.or.jp (mio-4u-mbox1511) id 09G6QDCP008969 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Oct 2020 15:26:14 +0900 Date: Fri, 16 Oct 2020 15:26:12 +0900 =?iso-2022-jp?B?KBskQkVsNX4bKEIgKBskQkk4PWA7fhsoQikp?= Message-Id: <20201016.152612.809851234789788464.arakawa@pp.iij4u.or.jp> To: larsi@gnus.org Subject: Re: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer From: Koichi Arakawa In-Reply-To: <871rhysptv.fsf@gnus.org> References: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> <871rhysptv.fsf@gnus.org> X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44026 Cc: 44026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen wrote: > Koichi Arakawa writes: > >> The current version of vc-revision-other-window does not select a >> buffer which contains the specified revision. But ediff-vc-internal, >> for example, expects the buffer is selected as the current one. > > Do you have a recipe to reproduce this bug? When I use the `C-x v ~' > command, I don't get any errors. Yes. * Open a version controlled file, * M-x ediff-revision, * accept defaults, you will see the identical two buffers in the window. And the file has been deleted. -- Koichi Arakawa From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 02:39:21 2020 Received: (at 44026) by debbugs.gnu.org; 16 Oct 2020 06:39:21 +0000 Received: from localhost ([127.0.0.1]:57382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJOa-0004hi-Qt for submit@debbugs.gnu.org; Fri, 16 Oct 2020 02:39:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJOZ-0004hS-2d for 44026@debbugs.gnu.org; Fri, 16 Oct 2020 02:39:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eRIEyiOqhnaodNon8F6HntXtiUiE9ZKlsaMGXc7+dos=; b=hYYAjADx0Q8e7HygrY5wlRrfYl RgIfSPzBGc+NP5HhJNy+Ki/H6lVrhr5Q4HTvROF+fgL0ZgnNB75Q3vlhEB3+Ld0znuHF7nQrDbP7H IzwgIZrUafAuoE5EqvsQY+Vs2pEggVSR6kogV6wsDvH144vlM9cjQD3SZXGsIc4PVWwE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTJOM-0007z3-B1; Fri, 16 Oct 2020 08:39:10 +0200 From: Lars Ingebrigtsen To: Koichi Arakawa Subject: Re: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer References: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> <871rhysptv.fsf@gnus.org> <20201016.152612.809851234789788464.arakawa@pp.iij4u.or.jp> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXn5OOzqa2HaXlA N0P///8pJ1P1AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKEAYYOYI70OkAAAGjSURBVDjLjVPRlcQg CJSkATANRGxgxf57uwE16+2+d+/4SAwDMkMgpT9Ndiv+GP7adzN/hP+w0lQNDlOrd66qdSQ05Jpq 761rI7lKjYyriKpYbb1a1USSJasDhnO5ZoGWmBDnwPFy9JwAJxZH3MVxX4Sr+RmXFXfxZGzwxhmI 69AlRe63Yg+weZXN8Mf6BNpnn34B9AWcveyAbAATP0CwspS18NVJkZQH1QA6gWq7jKR2Pl+HeWrQ JSD32Y6uABqpTj0KRsoHAGRcLRGkTgIinKhBfEvny4H2MIO1dKA5B0K0pB2w9Ckwr1KbuaQF5L2F JMtDKcuvOVtplwbHaMv6UWPqcgXnVNSfcNGblosB1TWw8eb5tQXJysDERFePe5RYAAapNzDDCJWn bKj14RPx4YrZGMWJ0aDuAGm18ujAlQiqXgTDXNIHAKc8m4QZHa/igLJMujLXgBgbIlox/zSp6wSk +joxjeXM2m0OGeWxGkhTD+k6iiM0h4ARAH+J9qDVyA/JeSy2Trr8dIc0gCLPX5sHGikbsPAcKfYF uE7Yd8Z/7AedJECXRgGmzAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0xNlQwNjoyNDo1Nysw MDowMMHpCZ8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMTZUMDY6MjQ6NTcrMDA6MDCwtLEj AAAAAElFTkSuQmCC X-Now-Playing: The Human League's _Secrets_: "The Snake" Date: Fri, 16 Oct 2020 08:39:04 +0200 In-Reply-To: <20201016.152612.809851234789788464.arakawa@pp.iij4u.or.jp> (Koichi Arakawa's message of "Fri, 16 Oct 2020 15:26:12 +0900 =?utf-8?B?KOadseS6rAko5qiZ5rqW5pmCKSki?=) Message-ID: <87362eptdj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Koichi Arakawa writes: > Yes. > * Open a version controlled file, > * M-x ediff-revision, > * accept defaults, > you will see the identical two buffers in the window. And the file has > been deleted. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44026 Cc: 44026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Koichi Arakawa writes: > Yes. > * Open a version controlled file, > * M-x ediff-revision, > * accept defaults, > you will see the identical two buffers in the window. And the file has > been deleted. Geez. The bug was introduced in the previous change for indirect buffers. I've now made a different change than your proposed patch and pushed to the trunk -- can you check whether this fixes the problem? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 02:54:21 2020 Received: (at 44026) by debbugs.gnu.org; 16 Oct 2020 06:54:22 +0000 Received: from localhost ([127.0.0.1]:57417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJd7-0005DN-MH for submit@debbugs.gnu.org; Fri, 16 Oct 2020 02:54:21 -0400 Received: from mo-sw1510.iijmio.jp ([203.180.38.129]:56742 helo=mo-sw.iijmio.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJd3-0005DA-RJ for 44026@debbugs.gnu.org; Fri, 16 Oct 2020 02:54:19 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Cc:Subject:From:In-Reply-To:References:Mime-Version: Content-Type:Content-Transfer-Encoding; i=arakawa@pp.iij4u.or.jp; s=20200530.mm ;t=1602831255;x=1604040855;bh=2HiTj6NivcgzH9MspakpMFNZ6PWItI9dPUbo5qBFQ9s=; b=bKbCUFlQo8peRZDyI0IwX6TSOev1Qu4u65TDg5E/SOtBgWnJel1K2Kl/78oeHHyaGb8bcg1yKcn Xq+dvtcbjiNN7DjrHeCKgAyBcWWBFA3prsyH+tnMe92FiP8jk19LeqXghfn+Y+MKLtYnF/DIKI3gp +Je6zi1hB+ni8n/tLfOq6S4833BK1w1sQWomD/jxNvqgXRiErQjeR1/kwn9ar8S9WYI+73Q25bgX+ W4nXIv/SO6wJljU9LF5OAG6Yp8+86oK3gIDS6YM7Js0RvB6K4pTFel816qjGBZC9prlMqV0fKN6ZJ mlQHvXDVS26fL9k5lq4RPwsnrz9rQxlq0g6A==; Received: by mo-sw.iijmio.jp (mio-mo-sw1510) id 09G6sFea025689; Fri, 16 Oct 2020 15:54:15 +0900 Received: from localhost (corsica.s2factory.co.jp [122.220.15.114]) by mbox.iij4u.or.jp (mio-4u-mbox1510) id 09G6sExm025044 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Oct 2020 15:54:14 +0900 Date: Fri, 16 Oct 2020 15:54:14 +0900 =?iso-2022-jp?B?KBskQkVsNX4bKEIgKBskQkk4PWA7fhsoQikp?= Message-Id: <20201016.155414.1556126869948358895.arakawa@pp.iij4u.or.jp> To: larsi@gnus.org Subject: Re: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer From: Koichi Arakawa In-Reply-To: <87362eptdj.fsf@gnus.org> References: <871rhysptv.fsf@gnus.org> <20201016.152612.809851234789788464.arakawa@pp.iij4u.or.jp> <87362eptdj.fsf@gnus.org> X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44026 Cc: 44026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen wrote: > Koichi Arakawa writes: > >> Yes. >> * Open a version controlled file, >> * M-x ediff-revision, >> * accept defaults, >> you will see the identical two buffers in the window. And the file has >> been deleted. > > Geez. The bug was introduced in the previous change for indirect > buffers. I've now made a different change than your proposed patch and > pushed to the trunk -- can you check whether this fixes the problem? Sure. I've confirmed the fixes work properly. Thanks a lot. -- Koichi Arakawa From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 03:13:27 2020 Received: (at 44026) by debbugs.gnu.org; 16 Oct 2020 07:13:27 +0000 Received: from localhost ([127.0.0.1]:57454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJva-0007ra-T2 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 03:13:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJvY-0007rH-S1 for 44026@debbugs.gnu.org; Fri, 16 Oct 2020 03:13:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j7ruFGkgs2XRh8aj+rBDA2Ma5SX09/HKDzxjkqq/86o=; b=SEoBaTwOFjBFpu1+cCxzlTbGVe YEOm0EGw8lQ9YdVKGrpv0hqk2cMAmvLX+eFhXL1gMpmQQ9cRjy0HksTa/mQvZ7M5PSopvqaYoTOG5 9s5QMzvQ0+f0IGl9Z351z3aJLfqdW+lk/J04I/P1cklDPN4YYXdj6JHHXNorj3/TTwJI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTJvN-0008NJ-3y; Fri, 16 Oct 2020 09:13:16 +0200 From: Lars Ingebrigtsen To: Koichi Arakawa Subject: Re: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer References: <871rhysptv.fsf@gnus.org> <20201016.152612.809851234789788464.arakawa@pp.iij4u.or.jp> <87362eptdj.fsf@gnus.org> <20201016.155414.1556126869948358895.arakawa@pp.iij4u.or.jp> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEXi4d5/gX7DvryZ kY8TExFzamoxLS5YUVJDQDuEenr///+gyxzkAAAAAWJLR0QKaND0VgAAAAd0SU1FB+QKEAcNAOtJ 1MIAAAGdSURBVDjLdZNLTsMwEIaH9AgI2FapKrYgU1D2xqwRMiFLJGNygLbOAcD1FkVZ+LaMH3HS Jv0jRfF8/zxiywBRF7DCF03q47CGS8g3YgpW+Q7WTzqGRQ+yu83mFx5l72cigoVRn4eFSZVkBNmH lF/qlm0pO+mRX1Oqb2rRFxqaP8haGy2oRyxlLD6k+W6GFglk+V4Ko41gP35WTArx13IvqJQ1a+Rx xjt2FmIYKYHVRjCmGZPbAWSekC19vqoFex9AnufYRAn6so2DDiDDZ0VO5IBPmiiA5SiyzLx1PmGZ wYn9qBScActzYD4OZ/y4GWQmBwcGtw+yPvCK/5E3wtt7y1UjGXVASqWqruQoZYwJRwK0VnxQZdui K90RwsEopz5uW0J42WgKyepjQQXnJQR31R5vuuUIdgja0+MoYFciqMIKOVbpvC2AlNHhNykssRZC 56G4n6FIIE5krVsi5BZUmtbabvSrcaqpQKnRn5fOtcOHqx5MBMZJHaag1rXppRqTHCCjRtwrgV6+ gp4BUSYc7YwgXOxzwN0YXIhR8j/lcioMhqyxAgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0x NlQwNzoxMzowMCswMDowMOoGnYgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMTZUMDc6MTM6 MDArMDA6MDCbWyU0AAAAAElFTkSuQmCC X-Now-Playing: Brokeback's _Illinois River Valley Blues_: "Cairo Levee" Date: Fri, 16 Oct 2020 09:13:11 +0200 In-Reply-To: <20201016.155414.1556126869948358895.arakawa@pp.iij4u.or.jp> (Koichi Arakawa's message of "Fri, 16 Oct 2020 15:54:14 +0900 =?utf-8?B?KOadseS6rAko5qiZ5rqW5pmCKSki?=) Message-ID: <87d01iod88.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Koichi Arakawa writes: > Sure. I've confirmed the fixes work properly. Thanks a lot. Thanks for checking. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44026 Cc: 44026@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Koichi Arakawa writes: > Sure. I've confirmed the fixes work properly. Thanks a lot. Thanks for checking. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 03:13:34 2020 Received: (at control) by debbugs.gnu.org; 16 Oct 2020 07:13:34 +0000 Received: from localhost ([127.0.0.1]:57457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJvi-0007rw-4e for submit@debbugs.gnu.org; Fri, 16 Oct 2020 03:13:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTJvg-0007rc-9l for control@debbugs.gnu.org; Fri, 16 Oct 2020 03:13:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ISHCYn3mHF0JzKJMzvOfUIQDulRTY3H9rMrOQFRtTOw=; b=cCbTDltQ/IosYRYe5SjFN20vez StKOQmSve5kNM0QcHzRfFnbY+suYOzoK6ZulMwqs2r8TZXzLB9pRnORa9L6xapXkIk/pRam04w2us CBGfHnysnenavyEk488JJjLBd5Y2ZrD3qOymNQ7ZEneN9/niT44PvN9RIAyE5geUgY9M=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTJvY-0008NY-J8 for control@debbugs.gnu.org; Fri, 16 Oct 2020 09:13:26 +0200 Date: Fri, 16 Oct 2020 09:13:23 +0200 Message-Id: <87blh2od7w.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44026 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44026 fixed close 44026 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44026 fixed close 44026 28.1 quit From unknown Fri Aug 15 17:19:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Nov 2020 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator