GNU bug report logs - #44021
delete-non-matching-lines optional arg REND not really optional

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44021 in the body.
You can then email your comments to 44021 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Emacs Bug Reporting <bug-gnu-emacs <at> gnu.org>
Subject: delete-non-matching-lines optional arg REND not really optional
Date: Thu, 15 Oct 2020 14:57:49 -0400

Unlike other functions with optional BEG and END args, where END is
presumed to be (point-max) if not supplied, function
delete-non-matching-lines returns an error when only RBEG is supplied.

Error: (wrong-type-argument number-or-marker-p nil)

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Message #8 received at 44021 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 44021 <at> debbugs.gnu.org
Subject: Re: bug#44021: delete-non-matching-lines optional arg REND not
 really optional
Date: Fri, 16 Oct 2020 07:36:26 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

> Unlike other functions with optional BEG and END args, where END is
> presumed to be (point-max) if not supplied, function
> delete-non-matching-lines returns an error when only RBEG is supplied.
>
> Error: (wrong-type-argument number-or-marker-p nil)

I've now mentioned this in the doc string.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 44021 <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44021 <at> debbugs.gnu.org
Subject: Re: bug#44021: delete-non-matching-lines optional arg REND not
 really optional
Date: Fri, 16 Oct 2020 02:42:51 -0400

On 2020-10-16 07:36, Lars Ingebrigtsen wrote:
> I've now mentioned this in the doc string.

Not the solution I was expecting. I was expecting the ARG to really
become optional, to be consistent with similar END arguments in other
emacs functions. Something like:

  (setq rend (or rend (point-max)))

Also, as a quibble, for consistency the args should be renamed START and
END, instead of RSTART and REND. See, for instance,

  (delete-trailing-whitespace &optional START END)
  (narrow-to-region START END)

This is true even in the same elisp file replace.el:

  (replace-regexp regexp to-string &optional delimited start end backward)
  (replace-string from-string to-string &optional delimited start end backward)

and many other functions in the same file, so it seems to have been an
oversight in integrating the function. The standard seems to be that the
args are named START and END and really are optional.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.