Subject: Re: [bug#44006] [PATCH] doc: Fix typo

From: Aniket Patil <[email-masked]>
Date: Thu, 15 Oct 2020 18:45:11 +0530

Thanks for the feedback sir!
But I didn’t get

>>  2. Idem inside the commit message.

What does Idem means?

I will do new changes As well.

Aniket.

On Thu, 15 Oct 2020 at 6:39 PM, zimoun <[email-masked]> wrote:

> Dear,
>
> Thank you for your contribution.  It is almost fine.  Three things are
> not “correct“.
>
>  1. The commit subject must end with a dot.  Like:
>
>     doc: Fix typo.
>
>  2. Idem inside the commit message.
>  3. It is “star space path/to/file”, see below.
>
>
> And last, about the message itself:
>
> > *doc/guix.texi (section 7.5): Fix typo
>
> Usually, the section numbering does not appear.  It does not make sense
> since it is a moving target.  Instead, it seems better to provide the
> node name, e.g.,
>
> * doc/guix.texi (Invoking guix import): Fix typo.
>
>
> Does it make sense?
>
>
> Now, you should send an updated patch.  To do so, you should
> ‘interactively rebase’.  Using Emacs and Magit , it looks like:
>
>      r i
>      edit C-c C-c
>      # do your tweaks
>      r r
>      W c C-m b origin/master C-m v 2 c
>      ! git send-email --to= [email-masked] v2-0001-blabla.patch
>
> How does it sound for you?
>
>
> All the best,
> simon
>
>