GNU bug report logs - #43990
[PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Wed, 14 Oct 2020 12:42:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43990: closed ([PATCH] gnu: emacs-with-editor: Update to
 2.9.4-1.c4768f51.)
Date: Thu, 15 Oct 2020 22:00:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 15 Oct 2020 23:59:33 +0200
with message-id <87blh3b16i.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#43990] [PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.
has caused the debbugs.gnu.org bug report #43990,
regarding [PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43990: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43990
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.
Date: Wed, 14 Oct 2020 14:40:56 +0200
[Message part 3 (text/plain, inline)]
Testing an updated version of emacs-next with lot's of packages.  Looks
very good, except magit, where one can't commit anything.

[0001-gnu-emacs-with-editor-Update-to-2.9.4-1.c4768f51.patch (text/x-patch, inline)]
>From ea4cca33d754dd4679cb8bc9ad46a700805f62fe Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Wed, 14 Oct 2020 11:57:32 +0200
Subject: [PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.

* gnu/packages/emacs-xyz.scm (emacs-with-editor): Update to 2.9.4-1.c4768f51.
---
 gnu/packages/emacs-xyz.scm | 44 +++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 20 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cc97e051d0..284ecf8f25 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -383,29 +383,33 @@ configuration files, such as .gitattributes, .gitignore, and .git/config.")
     (license license:gpl3+)))
 
 (define-public emacs-with-editor
-  (package
-    (name "emacs-with-editor")
-    (version "2.9.4")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/magit/with-editor")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1z3214zjf3dassb31k14gq4nbr3q8g5x87ydfah28hm4j08v0wb3"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-dash" ,emacs-dash)))
-    (home-page "https://github.com/magit/with-editor")
-    (synopsis "Emacs library for using Emacsclient as EDITOR")
-    (description
-     "This package provides an Emacs library to use the Emacsclient as
+  ;; This commit fixes an (magit) issue with emacs 28, see
+  ;; https://lists.gnu.org/archive/html/help-gnu-emacs/2020-10/msg00211.html
+  (let ((commit "c4768f51c7415119519b4626d8643d60e584098c")
+        (revision "1"))
+    (package
+      (name "emacs-with-editor")
+      (version (git-version "2.9.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/magit/with-editor")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "01ysb9pnscpmingay6njdywkqgj4hn5l5d9igsg3x7p7061jwwix"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-dash" ,emacs-dash)))
+      (home-page "https://github.com/magit/with-editor")
+      (synopsis "Emacs library for using Emacsclient as EDITOR")
+      (description
+       "This package provides an Emacs library to use the Emacsclient as
 @code{$EDITOR} of child processes, making sure they know how to call home.
 For remote processes a substitute is provided, which communicates with Emacs
 on stdout instead of using a socket as the Emacsclient does.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-libgit
   (let ((commit "0ef8b13aef011a98b7da756e4f1ce3bb18e4d55a")
-- 
2.28.0

[Message part 5 (text/plain, inline)]
-- 
Leben, das Sinn hätte, fragte nicht danach.
    Adorno
[signature.asc (application/pgp-signature, inline)]
[Message part 7 (message/rfc822, inline)]
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43990-done <at> debbugs.gnu.org
Subject: Re: [bug#43990] [PATCH] gnu: emacs-with-editor: Update to
 2.9.4-1.c4768f51.
Date: Thu, 15 Oct 2020 23:59:33 +0200
Hello,

Michael Rohleder <mike <at> rohleder.de> writes:

> Subject: [PATCH] gnu: emacs-with-editor: Update to 2.9.4-1.c4768f51.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou


This bug report was last modified 4 years and 297 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.