From unknown Fri Jun 13 10:08:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43984 <43984@debbugs.gnu.org> To: bug#43984 <43984@debbugs.gnu.org> Subject: Status: `--with-graft=...` doesn't work with packages of different length name/version Reply-To: bug#43984 <43984@debbugs.gnu.org> Date: Fri, 13 Jun 2025 17:08:06 +0000 retitle 43984 `--with-graft=3D...` doesn't work with packages of different = length name/version reassign 43984 guix submitter 43984 pkill9 severity 43984 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 20:56:33 2020 Received: (at submit) by debbugs.gnu.org; 14 Oct 2020 00:56:33 +0000 Received: from localhost ([127.0.0.1]:49225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSV5k-0000VO-W1 for submit@debbugs.gnu.org; Tue, 13 Oct 2020 20:56:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:42202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSV5j-0000VF-TL for submit@debbugs.gnu.org; Tue, 13 Oct 2020 20:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSV5j-0003us-Ko for bug-guix@gnu.org; Tue, 13 Oct 2020 20:56:31 -0400 Received: from aibo.runbox.com ([91.220.196.211]:40410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSV5g-00073o-Ma for bug-guix@gnu.org; Tue, 13 Oct 2020 20:56:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Subject:To:From:Date; bh=lnFHXEN22EdEiZVZEC3oPIlgXsLT1W8j0vqrNA8u3h0=; b=hyHkJzLBEAopJPVntNSHV2CGxj 2mQJfOCF23IguBoTHQbZLa7TTLhZeYZRcVTm4wpdLIv/jHOZw6I5FvZJZjkZbBjGV/VlWBYBa1e6F f1PpUO7IPUMubn+sMBtPSEj7DgsPJjM/ww7bs9dnEN6CuSXRTiLYYXTj/h0L6C9+30/0caGQOhWnt W2FLQLCU1u+A68IZWl69efdaxT6Ec1o+Ioattw4FBjfLp5Uv7Zg21vZwbjBpxD7MHZDqOmfT6cCsW vwtlqS5jldv3QLvKgQjRy4LjVjrb1uXXlRlnNZl2/x8NCl4wt3R0gPhCIeWfE7rSICbmqr3ZjVBHo moowvD8Q==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kSV5b-0005QE-Tg for bug-guix@gnu.org; Wed, 14 Oct 2020 02:56:24 +0200 Received: by submission03.runbox with esmtpsa [Authenticated alias (780724)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kSV5I-0008H2-2G for bug-guix@gnu.org; Wed, 14 Oct 2020 02:56:04 +0200 Date: Wed, 14 Oct 2020 01:55:58 +0100 From: pkill9 To: bug-guix@gnu.org Subject: `--with-graft=...` doesn't work with packages of different length name/version Message-ID: <20201014015558.09d6702a@runbox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=91.220.196.211; envelope-from=pkill9@runbox.com; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/13 20:56:24 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) As expected, if you attempt to graft a package's dependency, and it's name + version is different length to the original dependency, then it will fail to graft. Maybe if the length/version is different, then a symlink could be created in the store pointing to the new dependency, with a name/version that matches the length of the original dependency's store name? Perhaps this new name/version could be something like /gnu/store/...-original-dependency-name-gggggg, where 'g..' matches the length of the version of the original dependency. The many 'g's would make it clear that it is a graft. Then if someone looks in the store, they would see it's a symlink too. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 03:51:03 2020 Received: (at 43984) by debbugs.gnu.org; 15 Oct 2020 07:51:03 +0000 Received: from localhost ([127.0.0.1]:54091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy2R-0007eF-8V for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:51:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy2Q-0007dV-Er for 43984@debbugs.gnu.org; Thu, 15 Oct 2020 03:51:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45861) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSy2K-00085H-Nd; Thu, 15 Oct 2020 03:50:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51812 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSy2K-0000yd-2i; Thu, 15 Oct 2020 03:50:56 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: pkill9 Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version References: <20201014015558.09d6702a@runbox.com> Date: Thu, 15 Oct 2020 09:50:54 +0200 In-Reply-To: <20201014015558.09d6702a@runbox.com> (pkill9@runbox.com's message of "Wed, 14 Oct 2020 01:55:58 +0100") Message-ID: <87wnzsapwh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, pkill9 skribis: > As expected, if you attempt to graft a package's dependency, and it's > name + version is different length to the original dependency, then it > will fail to graft. Yes, that=E2=80=99s expected, but perhaps the manual could state it more prominently? > Maybe if the length/version is different, then a symlink could be > created in the store pointing to the new dependency, with a > name/version that matches the length of the original dependency's store > name? Perhaps this new name/version could be something like > /gnu/store/...-original-dependency-name-gggggg, where 'g..' matches the > length of the version of the original dependency. The many 'g's would > make it clear that it is a graft. Then if someone looks in the store, > they would see it's a symlink too. That only works if the new name is shorter than the old name though. When the new name is longer (which is a more common case in our experience when introducing package replacements, typically because the new version string is longer), nothing can be done. I=E2=80=99m tempting to keep things as is. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 14:50:31 2020 Received: (at 43984) by debbugs.gnu.org; 15 Oct 2020 18:50:31 +0000 Received: from localhost ([127.0.0.1]:56542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT8Kd-0005y6-EZ for submit@debbugs.gnu.org; Thu, 15 Oct 2020 14:50:31 -0400 Received: from aibo.runbox.com ([91.220.196.211]:43060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT8Ka-0005xx-QX for 43984@debbugs.gnu.org; Thu, 15 Oct 2020 14:50:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=OEE7aLlaAFZ8jHnRENRWAbZJMYIH1jTi2qy7mPzILPM=; b=ZwM5u8R4pFLBEt5120bjFwmxls ncqkYkh6OLmaiNL1/tU/7fimMJxO7HftWcACw09WZDGq8+OB3Ujs9KmZH5gY9bwHP/xKY0T0jWKTx /aqOW5iQLJM48C9gM9p4vjdsDZY//CP4PIlfVFRPidnfWNClEtVqZ0jdZF48kUVzE/PCO3WQDpmrL aAYUFBd33ZgAzy0JwBVP6LKLS5TYO8le2AVBPtxVvylg1GFzoEduN/li12jD7LnEmN0BOP8Gje12s GF6Pr7dN4gtBot/tW2ONGNNg6PJsyff0Qj38JZA2HjXGqZPdLFOyqUzew2pbnT88xo0iqzlumOTeP NlaNEDRQ==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kT8KZ-0004xk-6D; Thu, 15 Oct 2020 20:50:27 +0200 Received: by submission01.runbox with esmtpsa [Authenticated alias (780724)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kT8KN-00048a-Io; Thu, 15 Oct 2020 20:50:15 +0200 Date: Thu, 15 Oct 2020 19:50:13 +0100 From: pkill9 To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version Message-ID: <20201015195013.335eaefd@runbox.com> In-Reply-To: <87wnzsapwh.fsf@gnu.org> References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > > Maybe if the length/version is different, then a symlink could be > > created in the store pointing to the new dependency, with a > > name/version that matches the length of the original dependency's > > store name? Perhaps this new name/version could be something like > > /gnu/store/...-original-dependency-name-gggggg, where 'g..' matches > > the length of the version of the original dependency. The many 'g's > > would make it clear that it is a graft. Then if someone looks in > > the store, they would see it's a symlink too. > > That only works if the new name is shorter than the old name though. > When the new name is longer (which is a more common case in our > experience when introducing package replacements, typically because > the new version string is longer), nothing can be done. I'm confused about what you mean. Why would it matter if the new name is longer than the old name? From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 05:31:23 2020 Received: (at 43984) by debbugs.gnu.org; 16 Oct 2020 09:31:23 +0000 Received: from localhost ([127.0.0.1]:57677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTM55-00055n-Em for submit@debbugs.gnu.org; Fri, 16 Oct 2020 05:31:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTM54-00055a-6x for 43984@debbugs.gnu.org; Fri, 16 Oct 2020 05:31:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46085) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTM4u-00051e-AA; Fri, 16 Oct 2020 05:31:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34684 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kTM4q-00048u-8w; Fri, 16 Oct 2020 05:31:10 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: pkill9 Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 16 Oct 2020 11:31:06 +0200 In-Reply-To: <20201015195013.335eaefd@runbox.com> (pkill9@runbox.com's message of "Thu, 15 Oct 2020 19:50:13 +0100") Message-ID: <87sgae8qlh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) pkill9 skribis: >> > Maybe if the length/version is different, then a symlink could be >> > created in the store pointing to the new dependency, with a >> > name/version that matches the length of the original dependency's >> > store name? Perhaps this new name/version could be something like >> > /gnu/store/...-original-dependency-name-gggggg, where 'g..' matches >> > the length of the version of the original dependency. The many 'g's >> > would make it clear that it is a graft. Then if someone looks in >> > the store, they would see it's a symlink too.=20=20 >>=20 >> That only works if the new name is shorter than the old name though. >> When the new name is longer (which is a more common case in our >> experience when introducing package replacements, typically because >> the new version string is longer), nothing can be done. > > I'm confused about what you mean. Why would it matter if the new > name is longer than the old name? All I=E2=80=99m saying is that nothing can be done when the new name is lon= ger than the old one: we just cannot graft. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 16 21:03:19 2020 Received: (at 43984) by debbugs.gnu.org; 17 Oct 2020 01:03:19 +0000 Received: from localhost ([127.0.0.1]:32987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTacx-0004FK-90 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 21:03:19 -0400 Received: from aibo.runbox.com ([91.220.196.211]:55466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTacv-0004FB-47 for 43984@debbugs.gnu.org; Fri, 16 Oct 2020 21:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=bOoQiqYtOSQWEeV/O221WWYhFynPrRD1Lw+qhvhmbm0=; b=bz3KhpmBRU3L6bdmbXh2fLNyL1 Gt6fhgry9iOSWUqiKn/ZjL5izvJDqmXKr14C+CeDq/+K585QOipV1gzoyrZa8yWkoldVosQnuMD0q yrLi1VwH2Z/r7EmYWCWwCRWQeaOdYmyIcwa19WhHPsUABI227pK8DmBJDwObVWg8wFLUsIaz2pphl eVSBPu2iM5GuzgKEYgJUpMdxR3ZwB0OqrZ+5i0qjfTqLQwnYl3V2kNDfF8b30iwAn/VvVcRzeXC4d 0RLGIaCcvoHjN9YCX4j8WfN3ak5YJvrtpm5yPQoNs9oKhdDX5qQg9S7ZFuoVSEYk10IXzmJt6qL4d yenRCMFw==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kTacs-00039N-Rk; Sat, 17 Oct 2020 03:03:15 +0200 Received: by submission03.runbox with esmtpsa [Authenticated alias (780724)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kTacs-0004yM-8O; Sat, 17 Oct 2020 03:03:14 +0200 Date: Sat, 17 Oct 2020 02:03:11 +0100 From: pkill9 To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version Message-ID: <20201017020311.0c68f3d5@runbox.com> In-Reply-To: <87sgae8qlh.fsf@gnu.org> References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> <87sgae8qlh.fsf@gnu.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > All I=E2=80=99m saying is that nothing can be done when the new name is l= onger > than the old one: we just cannot graft. If a symlink is used though, it wouldn't matter if the new name is longer, the symlink would point to the new package, and the name of the symlink would match the length of the old package. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 17:30:07 2020 Received: (at 43984) by debbugs.gnu.org; 20 Oct 2020 21:30:07 +0000 Received: from localhost ([127.0.0.1]:47045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUzCp-0007hG-HD for submit@debbugs.gnu.org; Tue, 20 Oct 2020 17:30:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUzCo-0007fe-Do for 43984@debbugs.gnu.org; Tue, 20 Oct 2020 17:30:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35877) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUzCi-0006Qh-El; Tue, 20 Oct 2020 17:30:00 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40476 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUzCg-0006tX-UW; Tue, 20 Oct 2020 17:29:59 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: pkill9 Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> <87sgae8qlh.fsf@gnu.org> <20201017020311.0c68f3d5@runbox.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 20 Oct 2020 23:29:57 +0200 In-Reply-To: <20201017020311.0c68f3d5@runbox.com> (pkill9@runbox.com's message of "Sat, 17 Oct 2020 02:03:11 +0100") Message-ID: <87h7qobn6y.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, pkill9 skribis: >> All I=E2=80=99m saying is that nothing can be done when the new name is = longer >> than the old one: we just cannot graft. > > If a symlink is used though, it wouldn't matter if the new name is > longer, the symlink would point to the new package, and the name of the > symlink would match the length of the old package. But who would refer to that symlink? The thing on which the graft is applied can only refer to the store item that has the right length. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 18:35:56 2020 Received: (at 43984) by debbugs.gnu.org; 20 Oct 2020 22:35:56 +0000 Received: from localhost ([127.0.0.1]:47119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV0EW-0000th-DL for submit@debbugs.gnu.org; Tue, 20 Oct 2020 18:35:56 -0400 Received: from world.peace.net ([64.112.178.59]:57350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV0EU-0000tT-0i for 43984@debbugs.gnu.org; Tue, 20 Oct 2020 18:35:54 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kV0EO-0003ja-8H; Tue, 20 Oct 2020 18:35:48 -0400 From: Mark H Weaver To: Ludovic =?utf-8?Q?Court=C3=A8s?= , pkill9 Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version In-Reply-To: <87h7qobn6y.fsf@gnu.org> References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> <87sgae8qlh.fsf@gnu.org> <20201017020311.0c68f3d5@runbox.com> <87h7qobn6y.fsf@gnu.org> Date: Tue, 20 Oct 2020 18:34:00 -0400 Message-ID: <87d01c8r2k.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43984 Cc: 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > pkill9 skribis: > >>> All I=E2=80=99m saying is that nothing can be done when the new name is= longer >>> than the old one: we just cannot graft. >> >> If a symlink is used though, it wouldn't matter if the new name is >> longer, the symlink would point to the new package, and the name of the >> symlink would match the length of the old package. > > But who would refer to that symlink? The thing on which the graft is > applied can only refer to the store item that has the right length. If I understand correctly, pkill9's idea is that intermediate symlink(s) (presumably one for each output of the replacement package) would have the same length as the original store item, but could point to a replacement store item of greater length. For example, whereas now we must *build* our replacement libx11 with munged version number "1.6.A", under pkill9's approach we could instead build it with normal version number "1.6.10", and only the intermediate symlink(s) would have their names munged to fit within the original length limit. The grafting process would then rewrite the original store references to point to the symlink(s). An advantage to this approach is that the replacement packages would no longer need to have their version numbers munged, which would be more aesthetically pleasing and perhaps less confusing for users. The lack of munging might also make the replacement package more attractive for _direct_ usage as a package input by non-core packages that need the newer version of the replaced package for other reasons. Disadvantages include potentially slower file system lookups in the replaced packages, and added complexity in Guix. I don't have an opinion on this, but I wanted to at least try to clarify the idea that pkill9 is proposing. Regards, Mark From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 21 04:45:34 2020 Received: (at 43984) by debbugs.gnu.org; 21 Oct 2020 08:45:34 +0000 Received: from localhost ([127.0.0.1]:47891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV9kU-0004Ki-32 for submit@debbugs.gnu.org; Wed, 21 Oct 2020 04:45:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV9kT-0004KV-1J for 43984@debbugs.gnu.org; Wed, 21 Oct 2020 04:45:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44808) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kV9kL-0005es-Hf; Wed, 21 Oct 2020 04:45:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43026 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kV9kH-0001h9-5n; Wed, 21 Oct 2020 04:45:24 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mark H Weaver Subject: Re: bug#43984: `--with-graft=...` doesn't work with packages of different length name/version References: <20201014015558.09d6702a@runbox.com> <87wnzsapwh.fsf@gnu.org> <20201015195013.335eaefd@runbox.com> <87sgae8qlh.fsf@gnu.org> <20201017020311.0c68f3d5@runbox.com> <87h7qobn6y.fsf@gnu.org> <87d01c8r2k.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 21 Oct 2020 10:45:19 +0200 In-Reply-To: <87d01c8r2k.fsf@netris.org> (Mark H. Weaver's message of "Tue, 20 Oct 2020 18:34:00 -0400") Message-ID: <87sga89dcw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43984 Cc: pkill9 , 43984@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mark, Mark H Weaver skribis: > Ludovic Court=C3=A8s writes: > >> pkill9 skribis: >> >>>> All I=E2=80=99m saying is that nothing can be done when the new name i= s longer >>>> than the old one: we just cannot graft. >>> >>> If a symlink is used though, it wouldn't matter if the new name is >>> longer, the symlink would point to the new package, and the name of the >>> symlink would match the length of the old package. >> >> But who would refer to that symlink? The thing on which the graft is >> applied can only refer to the store item that has the right length. > > If I understand correctly, pkill9's idea is that intermediate symlink(s) > (presumably one for each output of the replacement package) would have > the same length as the original store item, but could point to a > replacement store item of greater length. > > For example, whereas now we must *build* our replacement libx11 with > munged version number "1.6.A", under pkill9's approach we could instead > build it with normal version number "1.6.10", and only the intermediate > symlink(s) would have their names munged to fit within the original > length limit. The grafting process would then rewrite the original > store references to point to the symlink(s). > > An advantage to this approach is that the replacement packages would no > longer need to have their version numbers munged, which would be more > aesthetically pleasing and perhaps less confusing for users. The lack > of munging might also make the replacement package more attractive for > _direct_ usage as a package input by non-core packages that need the > newer version of the replaced package for other reasons. Oh that makes sense, thanks for explaining. It could be useful to implement this; it would make =E2=80=98--with-graft= =E2=80=99 more generally applicable, which was pkill9=E2=80=99s initial goal. Package replacements often have the same length as the original, so for those we wouldn=E2=80=99t change anything; it would make a difference in ot= her cases though. > Disadvantages include potentially slower file system lookups in the > replaced packages, and added complexity in Guix. Yes, though that=E2=80=99s probably reasonable. Thanks, Ludo=E2=80=99.