GNU bug report logs - #43961
read carefully: dired-file-name-at-point vs dired-filename-at-point

Previous Next

Package: emacs;

Reported by: Boruch Baum <boruch_baum <at> gmx.com>

Date: Mon, 12 Oct 2020 14:28:02 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Richard Stallman <rms <at> gnu.org>
Cc: 43961 <at> debbugs.gnu.org, Boruch Baum <boruch_baum <at> gmx.com>
Subject: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point
Date: Wed, 14 Oct 2020 06:58:07 +0200
Richard Stallman <rms <at> gnu.org> writes:

>   > As I think I mentioned, once (if) the patch is approved, a next step is
>   > to grep the emacs core code-base and replace the function names.
>
> I just did that.  dired-filename-at-point is not used anywhere except
> dired-x.el.
>
> I expect that none of the published Lisp packages uses
> dired-filename-at-point.

And I looked at the code now, and it seems the bug reporter
misunderstood the point of the function: It's used to guess a file name
in non-dired buffers, while dired-file-name-at-point is a dired function
that just returns the file name in a dired buffer.

So they're totally unrelated functions, but dired-filename-at-point has
an unfortunate name.  I've now renamed it (but kept
dired-filename-at-point as an obsolete alias).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 220 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.