From unknown Thu Jun 19 12:31:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43961 <43961@debbugs.gnu.org> To: bug#43961 <43961@debbugs.gnu.org> Subject: Status: read carefully: dired-file-name-at-point vs dired-filename-at-point Reply-To: bug#43961 <43961@debbugs.gnu.org> Date: Thu, 19 Jun 2025 19:31:22 +0000 retitle 43961 read carefully: dired-file-name-at-point vs dired-filename-at= -point reassign 43961 emacs submitter 43961 Boruch Baum severity 43961 minor tag 43961 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 12 10:27:29 2020 Received: (at submit) by debbugs.gnu.org; 12 Oct 2020 14:27:29 +0000 Received: from localhost ([127.0.0.1]:43614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRynQ-0001wi-LO for submit@debbugs.gnu.org; Mon, 12 Oct 2020 10:27:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:38498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRynO-0001wW-Qs for submit@debbugs.gnu.org; Mon, 12 Oct 2020 10:27:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRynO-00040H-Ju for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 10:27:26 -0400 Received: from mout.gmx.net ([212.227.17.20]:43605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRymi-00063Y-Pn for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 10:27:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602512801; bh=aQjdN0oOpNe/GzJK/yY5MyAsuRLmyQUFMU8/c+i11m0=; h=X-UI-Sender-Class:Date:From:To:Subject; b=W+Pvc8W5ThHdJDLnfv+5B0KLRenzr2Ri7zDXLOHQ6unyy/ckKqdzT37w/lx8uNHPP eqqVy2NxhROvEV/gyep1G/OQF/bPjg2BQ2nu9rG9rMIFWC8/b2c9uhk2MslGMauepj zLRHxbdlCzVJlvQvtLn+iV0OLJTgOh0/t7t6tI9E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MEV3C-1khux82Vz8-00G15X for ; Mon, 12 Oct 2020 16:26:40 +0200 Date: Mon, 12 Oct 2020 10:26:38 -0400 From: Boruch Baum To: Emacs Bug Reporting Subject: read carefully: dired-file-name-at-point vs dired-filename-at-point Message-ID: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="aftfgvqp76s5o6ko" Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:OZsUNsq2VtieMYs+o6ZZJ1PUHabt//1pU3g1MFenQrem7C9YbuB QkZfRYnjLTSX7gyaOo/PtvOCfJ00EMoXJ5zqTP7JEW6N/swUBM66TgakL4oef2pvi7r8RAz 4eJClzSNzc/dJsABv9+1dRcOlmWHJQB1y/MrChE5Sxdzv1lEA997xcoFfvnU1LIBtQtpCkl AGLKFDOiQTX7ldnlg+Raw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:GaCoZ7zg4yY=:5TP+YPKIohvcj3ACLheNgF lbcCOJND6xwA9DZAyQgkAgBbBITs/mHuP/SXN0E6NBhwtcq+/eymHiL+Qi6KmC3gM7DaBRyS5 hmQrxXGxf6XusjG27k+hzhIDkOxHbV4Dp+EhmRLCCdQo857O2FYxt1tV0GrZGIJNR63RGzmwQ +uRptnMjT+LMUsx6+5P8KugaHe0KIXgbrXlxpQg36nSJ6Xc/jS6iMmNtL8wcpyus/vhGHrvvc 33YvoRMpu6td4yZ0i3enwzv2b96nVwvKhC7PfME74EBdJu67Z657iEWtuiHAcQZJV2kWyZaGs u+T09IhxjDj5tdKqtFxzFJ8yE7IjRnDd7zYTTzr3BOIyVWFya+mVNq5eDrNz48PWdBHKZLWLe F77kq7UFGus5qxrMtAJALXcgt6xrjDAs91gzOiQVaWvtaq66+9B93vOtsvKDp6WUUDFVFDU8p ArW0pqdcNN0OdfjULIfN8NhWJtczMiXGahmzJ/+fCk0fzAm8K6tCWDC9iL/8oEpqtYUKJTFKW vGul8KlzOudGdGNFKBbgEGDcfprReBtfL4sOFdPXaWQk6ULjuqEwCLPEKXlamDEmHV6VhQtdB NtB+0aZp2bOP442wdzbg5tzV6Ey8s0S3cUZiogmFNaeHoRgZ6/RieSesXhWxuQUnPEIngQRhZ ToC9eGsy64E8OATSVKp3Ht2PLqfWT97x2LlNfKRQkeQB6b1k4gezI7VreG03rpgVMRxntQYwx 7LCOHH9xRGyhDcsznQpNpoGqYDtiWqmOfvvwQRRuDlhIhRa9IJ8ZIEruRMRpSiIvqyN+WpUHY pqRam5FrNoOL8IZ54NiWUoAJBjoKgml0n6byGzYoZvpi4WeMs1hewy9Dwg1qEK/sBN1FScogh +gOPfR2yzES6cAV7kTXXju7viFtLnJOxKFCNxKJ/d5zbPf6BsSjuJB5A1bwZf7wAIn/tmgNEJ 4DWzCImTfl1rOFTcxeU1gpqHIVSnoTh4SEVAaeac5vnqOw0l4H99sACAoJKIWGwHGDaN3whRX cjhJ5vz8saigynQG1MY5/SMxUrbBwU5T7gbeFopvRfeoWtqAvBZguIxfWZPmklz7YxDwBf8IC lqeFcvZax+SRNouhtovBZ5Q5cG6tnHgvt1xWwmjXDjtjh3wdOIF2TOxumet1jQObSLZSWPusP oEbsYgIn9b9VoGpoZ6OH71T5xZfPA5Un5YRisTbMkj+7uDDUiS3aZhd0d/O7LVrsM3fCeFGG0 8SCOMe6WNwa4+pexnh8QlloUTn5P5+J59sk+OrA== Received-SPF: pass client-ip=212.227.17.20; envelope-from=boruch_baum@gmx.com; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/12 09:35:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --aftfgvqp76s5o6ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The attached patch takes a step to remove confusion surrounding two unfortunately named functions, fixes bugs in one of them, and makes them more user-friendly. If this is all acceptable, let me know and I'll add a NEWS entry. + dired-filename-at-point is moved from dired-x.el to a position alongside its sister function dired-file-name-at-point. + The code for dired-filename-at-point is simplified to an almost carbon copy of its sister function. + This also fixes bugs for cases of filenames with embedded spaces + This also suppresses errors, due to use of dired-get-filename with its arg NOERROR. + Both get a small style tweak to remove duplicated function calls to abbrev- or expand- file-name. + Both get aliases to make them distinguishable. A follow-up to the attached patch, if accepted, would be to refactor all the occurrences within dired.el / dired-x.el. It would probably be a good idea to also add a deprecation notice to the docstrings for the original names. I came across this while developing the diredc package I've been mentioning a lot lately, and presenting this as a separate patch removes it from being snagged as part of discussion about that other proposal. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --aftfgvqp76s5o6ko Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="dired-name-confusion.patch" Content-Transfer-Encoding: quoted-printable diff --git a/dired-x.el b/dired-x.el index b09ef90..d3b9dc9 100644 =2D-- a/dired-x.el +++ b/dired-x.el @@ -1482,37 +1482,6 @@ a prefix argument, when it offers the filename near= point as a default." ;;; Internal functions. -;; Fixme: This should probably use `thing-at-point'. -- fx -(defun dired-filename-at-point () - "Return the filename closest to point, expanded. -Point should be in or after a filename." - (save-excursion - ;; First see if just past a filename. - (or (eobp) ; why? - (when (looking-at-p "[] \t\n[{}()]") ; whitespace or some parens - (skip-chars-backward " \n\t\r({[]})") - (or (bobp) (backward-char 1)))) - (let ((filename-chars "-.[:alnum:]_/:$+@") - start prefix) - (if (looking-at-p (format "[%s]" filename-chars)) - (progn - (skip-chars-backward filename-chars) - (setq start (point) - prefix - ;; This is something to do with ange-ftp filenames. - ;; It convert foo@bar to /foo@bar. - ;; But when does the former occur in dired buffers? - (and (string-match-p - "^\\w+@" - (buffer-substring start (line-end-position))) - "/")) - (if (string-match-p "[/~]" (char-to-string (preceding-char))) - (setq start (1- start))) - (skip-chars-forward filename-chars)) - (error "No file found around point!")) - ;; Return string. - (expand-file-name (concat prefix (buffer-substring start (point))))= ))) - (defun dired-x-read-filename-at-point (prompt) "Return filename prompting with PROMPT with completion. If `current-prefix-arg' is non-nil, uses name at point as guess." diff --git a/dired.el b/dired.el index 2ecd6bd..69aa41d 100644 =2D-- a/dired.el +++ b/dired.el @@ -958,16 +958,31 @@ ERROR can be a string with the error message." ;; (read-file-name (format "Dired %s(directory): " str) ;; nil default-directory nil)))))))) -(defun dired-file-name-at-point () - "Try to get a file name at point in the current dired buffer. -This hook is intended to be put in `file-name-at-point-functions'. -Note that it returns an abbreviated name that can't be used -as an argument to `dired-goto-file'." +(defun dired-filename-at-point-abbrev () + "Return the filename closest to point, abbreviated. +Point should be in or after a filename. Do not confuse this +function with `dired-filename-at-point', which expands +the file name." (let ((filename (dired-get-filename nil t))) (when filename - (if (file-directory-p filename) - (file-name-as-directory (abbreviate-file-name filename)) - (abbreviate-file-name filename))))) + (abbreviate-file-name + (if (file-directory-p filename) + (file-name-as-directory filename) + filename))))) +(defalias 'dired-file-name-at-point 'dired-filename-at-point-abbrev) + +(defun dired-filename-at-point-expand () + "Return the filename closest to point, expanded. +Point should be in or after a filename. Do not confuse this +function with `dired-file-name-at-point', which abbreviates +the file name." + (let ((filename (dired-get-filename nil t))) + (when filename + (expand-file-name + (if (file-directory-p filename) + (file-name-as-directory filename) + filename))))) +(defalias 'dired-filename-at-point 'dired-filename-at-point-expand) (defun dired-grep-read-files () "Use file at point as the file for grep's default file-name pattern sug= gestion. --aftfgvqp76s5o6ko-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 12 23:49:42 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 03:49:42 +0000 Received: from localhost ([127.0.0.1]:44784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSBJm-0007sW-8z for submit@debbugs.gnu.org; Mon, 12 Oct 2020 23:49:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSBJl-0007sK-7k for 43961@debbugs.gnu.org; Mon, 12 Oct 2020 23:49:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55951) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSBJf-0002ay-Ue; Mon, 12 Oct 2020 23:49:35 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kSBJd-00046B-Uz; Mon, 12 Oct 2020 23:49:34 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Boruch Baum In-Reply-To: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> (message from Boruch Baum on Mon, 12 Oct 2020 10:26:38 -0400) Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> Message-Id: Date: Mon, 12 Oct 2020 23:49:33 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > + dired-filename-at-point is moved from dired-x.el to a position > alongside its sister function What is the reason for keeping that function at all? What makes it usefully different from dired-file-name-at-point? -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 00:08:20 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 04:08:20 +0000 Received: from localhost ([127.0.0.1]:44826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSBbn-00026B-Q9 for submit@debbugs.gnu.org; Tue, 13 Oct 2020 00:08:20 -0400 Received: from mout.gmx.net ([212.227.17.21]:45621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSBbk-00025s-Mr for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 00:08:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602562090; bh=Svl+Z/TqPsgxyZoonaIRFhey3xQGkkr3CV5g/BzKaYo=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=Curpf7OGL3WAXOtG56xnhSzGGTjz8iBCcYgH9CUSZjlnzGG9lah99497RcPDAbGpA Yj6ECVuixDvOXTAkV7dO8n2TRT+QeeW3GlpHZLnhbUErOsHUiZvdzUWGnjc1qw1Rnt LfckQKfzMxSKqXaa332wTlD4IjFlvlHne18o9OlU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MtfNf-1kCAUQ3c1H-00v5aZ; Tue, 13 Oct 2020 06:08:10 +0200 Date: Tue, 13 Oct 2020 00:08:07 -0400 From: Boruch Baum To: Richard Stallman Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Message-ID: <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:chUAHXKv4u+nFxho3u4KPpmcjDFVBzrcLtxKm/VHGicTjzCObaQ heioRh1W1PVyFP7BMi6rRDZWeCCe5e8OQoOglsNVdcqY5kqCbMUIbhbIDRaub5F+rFJz4/+ 2WqybeCSYNskeihpl7XqmzG1cgkK8uO0FPDwGZPxS3rv//3jCKaQamLIUMpeMgkf+jN8HuL 8j3j67xrA3FCXFj1uVAYQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UN60/RJq2vY=:1tUeVBtb7kTt1UBZ6ezjAA i3zzgMgL2hW9TNDU+0S1pGu+aFe7xz5OJdHxwv4I7OIopj/kIiqqiGEU3WlYMzAOEYXy16+Pu hjrRQnDLcVIM4nBmQWn8QMnajxErlhXEIOtVlpHlWKH5/ETpf01Q3Z0I+znhIxUNHzG8U5Hqs 930DameHjEmhVFavj0jA2lnYX3V89aXThFHV+lQwL4PK+uDpMYJTZveQalB0t0exIMuuPL0oN ClISVWyavuxAqf43ncHjmWO+UpsE6G7lAt4JHwQTCpzc5Ep47pH6CoAbOwKaIrSzTfM//W6Co S5ObGhWtUvJ5cA6+hDCbvpItWE+Ql/TNf+0BCpPMy5eqo4VCK8cUvBo5ggCQ/2zpXPBq4Z8DT BuEzeUbst1uzQVR/rCQ3wcdQPJ6AUuXfT2aTBkmAoyTkAQperIGofxJ0Xtl4AAJkR6JaaxPLy zw/fur4mdXgPjbUIRtI/w65hIkBMstKfw1Xnnkeb/AbcAnBY/LN5e946m8XFipw2RLRJMupJc TFhKLUovpvr3URPzP8VvTrENJQYjAXNcv1juxmq63nzpQ90fdvxIwwtT5BMtGtLqKVb2VEnJV ckfD/5LWxNvx3QyjUD1MU/yflDVAWwNCqjNi1QKbjKyqaPRhY5SPONWoH4OJnhrmbK1ZrZKsn Rmr+/bjQu5ms+sM1ZCZdhLdr5y2TvLS8vloPQs6fZ1N5nI+6SvFxZIvfgTS5RxLAJ4rykngRU PzgNxb0A88BttLw/XjoEYCVPdebTnN3EIY86omxDylKd+irAgfyHCD2y4Q51R3G5/mfv+jM0t Ncxdpq654762LGvff5SHyAw4KL/KiJgVILfREzBnd72SKLeTtPRMh0lHWOOMbjbpY656q59Qh 64KK8IR3e6PRn6L0x56KHK4MA6DOLZUOrnZmv7JAgS3ioviv8BBD6jpU3lbMYmViQ2oCPYfgB FYX0vqdxSPLvMWugU+tyUBFdtKoATzlDrdxWNLLhKQodaSGXWrzN6ng7c53tF6vV5lbI9sA+N wCVbeeA2owiAe9VjT9wv/48D2pb5Uy7ckUTdzSMBMi7eMWng98kSyCZLFmKj5jaKMvnrivznY EUOjLBVR7w16wy5uGC9YvLS9EAc7UFBykS1XQIaluVhVfEv9A0fz8uhVUsq00SQ2fDiq6yIID SROpUU4JwVhwsoAquVuXL30S2IigF5GG7geY+3rOfyilO+GubTC3Is9KYSbg4UbzLkt59q0Jj qDwyr4qyOJ3swZn9XxhN1Pn5Fm07SyyF+9aETDg== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-10-12 23:49, Richard Stallman wrote: > > + dired-filename-at-point is moved from dired-x.el to a position > > alongside its sister function > > What is the reason for keeping that function at all? I couldn't possibly account for all the possible emacs users who may have written private extensions over the years using one or the other of the two functions, so in order to be courteous and not break anyone's personal emacs I left both original symbol names extant and suggested a deprecation warning that could be followed in a later version with an EOL. As I think I mentioned, once (if) the patch is approved, a next step is to grep the emacs core code-base and replace the function names. > What makes it usefully different from dired-file-name-at-point? They return different values. One returns an expanded (canonical) path-name, and the other an abbreviated one. This quickly becomes an emacs history/archaeology exercise (not my PhD): the functions were written by different people at different times for different packages. One function entered emacs core when package dired-x (1993-, Sebastian Kremer) was integrated. My hunch is that modifications and bug fixes over time were only applied the dired.el version. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 00:54:44 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 04:54:44 +0000 Received: from localhost ([127.0.0.1]:44893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSCKi-0003G1-1L for submit@debbugs.gnu.org; Tue, 13 Oct 2020 00:54:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSCKf-0003Fn-Qo for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 00:54:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oXUMEJlla5rN+To1Dmf1Uv+4vQkOmAWj5koOF8pRuZA=; b=ABR56V3ZvtjzQV1yXxSTR4caBz KOTW8EXDxzvtfEsXneNKQNtQj52ti+ZcKyyMDFdywah8sVrmnDKszFI8YKVtjguu7ORc+UTafFOzT 3gzUWGL9gNSYtHmxSnwfWDaX2qiEZQae8eDlI0IljGlQiOTzpv+cfFcfnzf7T9x6mbMo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSCKW-0002Vy-Gs; Tue, 13 Oct 2020 06:54:35 +0200 From: Lars Ingebrigtsen To: Boruch Baum Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEX92yn+4TL00R/H rjssKSYmIxuCdUJYTSQhHRobGRhhXlmvq53Z1s/9/f3///+qUd0VAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+QKDQQ1MpQ0CKIAAAGDSURBVDjLxZI/T8JAGMbvyuB6/QZYBmfAhIH1qi2OXmO7STRxNtFI dJSLV1epCKs1So2bE61fwJTVBe67WCqU9kqjm89yyf3yPO+fvAAgBFKSAJBjAQhAFsAFAHLWsfiP AAIFQM5mrQAoAnA9yQFUULycRMFsnXKqXVQEhOIrIBcAYVWFAP7uQH+KUtD6XVWqtbWOknp0uFpi ShsaOUAgD6QznewgmO9qmw52W6ljSAya1h8P2vmoRlftvzt3SGxX6hCTaIxAuHQsSMkg6q1mG7XE gZZDENwybMdoC12VOhRjMmD0Wii+dU6xajBK+wJoRAAbJqNmVQAdB1PDtB6sUxEwEhlsne5nu4qi iEnZzbFzL9ZgkcE8OHG6mz+XGA8oKQ2V2Yx1vQvLbs/Pcw4lpVIPPl0d69bQ93X8WJ/HK0q9GU44 n7pqb+QEnjdyh3wWgmYQ8lhfWCXPr3yMLz3tg3PAl5r5T/gtev2XPa01SQHO3av4mXpaLwvCxBzw DMjoX8E3ceIkZf4kWUYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMTNUMDQ6NTM6NDkrMDA6 MDCMnhT7AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTEzVDA0OjUzOjQ5KzAwOjAw/cOsRwAA AABJRU5ErkJggg== X-Now-Playing: Dizzee Rascal's _Boy In Da Corner_: "Jezebel" Date: Tue, 13 Oct 2020 06:54:31 +0200 In-Reply-To: <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 13 Oct 2020 00:08:07 -0400") Message-ID: <87blh667zs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: > They return different values. One returns an expanded (canonical) > path-name, and the other an abbreviated one. Why not just have one call the other, and wrap the results in abbreviate-file-name? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > They return different values. One returns an expanded (canonical) > path-name, and the other an abbreviated one. Why not just have one call the other, and wrap the results in abbreviate-file-name? (And then mark it as obsolete, since it doesn't seem very useful.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 06:25:25 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 10:25:25 +0000 Received: from localhost ([127.0.0.1]:45296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSHUi-0005SF-UH for submit@debbugs.gnu.org; Tue, 13 Oct 2020 06:25:25 -0400 Received: from mout.gmx.net ([212.227.17.22]:60769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSHUg-0005Rx-Oz for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 06:25:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602584715; bh=J47ds7wNj/AKjC4W0CN9zi02ZDbn7z202FlHwSzol38=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=cMZJqZIpIiRipwuZzQZUbdoUeXIlLt8su7OgZeuI6+ei2gO0/YYJbQ4wGQ3B/uJkZ d0oxcO7r3jRWMLu9BSAsjvKDTbdbVtRPFm/qmC7gezTH6/ZR5Sok8T60ITVx6OiGXA 20rwF0DF2VIHA0GPlBKM31inBmcJ+JxWZE9vZ6f4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MTAFb-1kuAqa1dSJ-00UaNZ; Tue, 13 Oct 2020 12:25:15 +0200 Date: Tue, 13 Oct 2020 06:25:12 -0400 From: Boruch Baum To: Lars Ingebrigtsen Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Message-ID: <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blh667zs.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:BqO+uOtgaTz62KBU+j/NGlDmNgVIKG34yV0ASK7e25UDPLAgKoA QfFsMoAtig9+rUpGEoVhhkQzGR0AuR+C/UFjU+8bsu1asIHLEcfppeLkzThWPUCwHrfZF8A RqxbwF3sNtvuPVR39bdHT9s01BPzSD/1Q4rfU5x2FT0UnIottFKlC1ILIoAJfAviwpiPyGI 8Fec6nuJk9ACBFS0/1/Lg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ix726s/X2+4=:Wn6vrZ2DFjN0ZNZZ4uzkfw gOTa/6lhkFBzxsiWYio5rRj3QzWZwmJlsFR520BitAHwqSVcSONXDGKAF1tbT02Cdo6OeoAZI 943Vb1m2XhzWb4ZodIDwMNf8OBueMIP4azQ3P5oQMmMa8OvNt1kPqc2bSWAiLh5+ogoClRuJ3 stVBOP5p+ElSkp/uvMQEmYDv9ti4OHqMX2bNrw0UC7r38ImI5fIN3Nr/MvMs5ASPqJ1TzTSN/ XBuzCPbgqvHdGn9dNismktSsJFjXgb8xVlsixVKpekWbx2GOvtpIA3mEcW8bLFG8QYh7z6pzT 2iq4oo3kRo4JrjVhGbUTFhLtoJq5CQXNVgAqwFnAvwe0+FUm+mHjSG4k56mwb5/CRAmfmrE1k 72i/TYjEu+auMUW5/UQlZj+0p6E2++n8nNaORU5htGmUC4VTcl5nUxzMT69OFRIlZK4MMoluc tTzc7pMirhOQSLdDwTX8be0KSrgYZfenbkib1KLmTmFGSpYl7qQs2zYBgN7RQdJVleVcq7ciZ B6ERkvcw8u4ERaSbgLstJRQ1d3Kfy7afpH8ebgyMNciSKR61jcwPTb7053o6ul8B+kn8hm5op sZm0FPqFNQduMFABsQSlEjEmZelDm/xWqOn/JnZBf/gv+xpLdQVXDXHU4prT0GwrWomsYXVmd Vc5ikUn94qsF/S9cOAOHyV1I0x08djVcEjhq4il8NZZOPTbdDOonRE9MzMvP723937RLAgfFp k6/rxWA23ScRM9EBSa9BvrZYaORP8udBa83jlbF6dHIKgF/K4vQHG/gcLJVkAndueY/l99Ffz nJmWdJBHlzBosnDMxiVL1JC3/XlTmen1S6OD/aVwMsumOfIPsyLd431Z/gSEk+UyqaRgEbMTA Q/xhyjHZl/kT4fy2ato7z/M4Y0eeOPxRj9V3DaUfVtu45ofbtkCdjyrH9+GNchyolTCzi3ETB 9ei6+veQPLW7Jxa2m7a4+HZi0t2bLT3djYFK3e+WWy/nkdOCXkOqOgtzxCw+ViG35IAN8XeuP wndbhkptgJupubmdRQZcz4+L3nYgHfxWVYumGNyBmASeaikn3V80NppayGsPBjzPBaMyNBPy/ /F9BOdKu4bXws1dsHHmGYwZa3izztZ+scUsgCFRvRWbGhYqVWZRNF+ynWfpqt3V5eH/KFDgs5 1UaCP/1C48jGmbObdQCZdDWhStJGxcD0kaJBXAzy/1abBS9NBMatXQU5SNnApM4PGEBBvzq1w eFWfxFRh9JYzaIg48TnIJs5HzznsfQSf1pMIqa8S7A139l63APRzUeuAICQX0WNLRpo+HUIRD TJpruVGa Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-10-13 06:54, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > They return different values. One returns an expanded (canonical) > > path-name, and the other an abbreviated one. > > Why not just have one call the other, and wrap the results in > abbreviate-file-name? You could, but you wouldn't be saving anything since the inner function would still need to perform the expansion, so for the abbreviated function you end up in effect with an inefficient (abbrev (expand file)) instead of a choice between (abbrev file) or (expand file). Also, much of the change ends up being defaliases, docstrings and deprecation notices, so its more clearly presented without nesting functions. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 06:58:24 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 10:58:24 +0000 Received: from localhost ([127.0.0.1]:45321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSI0d-0006Di-Ok for submit@debbugs.gnu.org; Tue, 13 Oct 2020 06:58:24 -0400 Received: from mail-db8eur06olkn2013.outbound.protection.outlook.com ([40.92.51.13]:60525 helo=EUR06-DB8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSI0Y-0006DR-EE for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 06:58:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cC4SXLQ1BwDwPKorTyNFIqtuDlW2Q6ZDGr+B7tb1AUJVwuBBUVH7YabaYBAhDp3eswQsYNpg9e4NS8X7SxAypKcYTVcy/HglY33x/TC+azdEsujNH5OZs5oIOwGHpC0aXeVuF4cAl/zQgsZ9aMtBKUtmtBNI1FP4Rf62C3edID7mR1AxPseqC/y3FER3+iL3hPjERYQ7ODWNqXE4Kpu9t5FIQ6fYOl5aIJiJufj3HAmzkVq+tjWMp7j28CuFA3RKQpFSqlFAjyytjSLuZQWei4oQ4vN6doB3+DIveCS6b9pOO0bu71jIie3irneuwqmDU/kjq8fEJx5dAPY2eapaOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pNR6/62nrY00VynwRTBynuglqnmf+uw2g5z+YEvtL0=; b=NisW8uJKnU8GHOBTaCpFUkReeACUr83dFRgcbSQY7WIyXSQVGrYNqFGePFT9rgfQ17Pvjn9JXYxtXVLkjNYE5TawEpozCbuxCVMWVbCQxSCYG1IJ0OQk57KkLm9ChniZC5EXZI2IA4krywOLau3/YAE5lcLbqK2SQC5HWrfwFIM98AgLWbPx2x2YViebpsjeSp/VsvVvcYaQblRjwPIbZXj0Pystm9Pa6SDY62D7jmE4dEhkOOYxP4e/uOsv149zoo1HleVLWB9+gNUvf4hygPLVg/2Zb9SY5Nvs3AcOITF9VthA9vPvG00aoTcThuTKji8duF8CeWIvAnXP7ds4tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pNR6/62nrY00VynwRTBynuglqnmf+uw2g5z+YEvtL0=; b=Grym2c1uWX2ck6tVLXZ54RtS/N5P3XV5YRaxwmSCRY1byx1WK7pJJI0QYs3fI/7T9CyO/Bo1wya9Yo1RzhP8p+E92BBfKq3H09vezagN+FjrHEMmse+kawObEDjyJhYNRR3WxFjggrZWIHPGGKP1hNmT7Pfo4Jmyks1/1WWo0tWbVyBuK7/Xm5+YfV9FoPNZDlZitkOtpzcU31QndYLTr3lEEXMeRp5rBsTOTjjyLphsoJh0tgXKgdfacRMjvZERgp2KVL1PRrCfT0nHmdXm2fObNuC/MMaKRyLxvfFeNDKROqJShUEsVD6KywEgCDmKTslzcjC3dOdZYjhxOlXfBg== Received: from AM7EUR06FT049.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::4d) by AM7EUR06HT107.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Tue, 13 Oct 2020 10:58:11 +0000 Received: from VI1PR06MB4526.eurprd06.prod.outlook.com (2a01:111:e400:fc36::45) by AM7EUR06FT049.mail.protection.outlook.com (2a01:111:e400:fc36::457) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Tue, 13 Oct 2020 10:58:11 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:1EFB3571C9D87A96B4577D9C2F4772B26B06183C69569622D9F29CF5B3073019; UpperCasedChecksum:31062AE4E042B2CC2469188622079468320C72D9763346657E1D392CD470C923; SizeAsReceived:7715; Count:46 Received: from VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::b547:51cd:16c5:4487]) by VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::b547:51cd:16c5:4487%7]) with mapi id 15.20.3455.031; Tue, 13 Oct 2020 10:58:11 +0000 From: Arthur Miller To: Boruch Baum Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> Date: Tue, 13 Oct 2020 12:58:10 +0200 In-Reply-To: <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 13 Oct 2020 06:25:12 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-TMN: [wOqAL8/e8nIRNho+MpM438N/0JcgEx8I] X-ClientProxiedBy: AM6P193CA0037.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::14) To VI1PR06MB4526.eurprd06.prod.outlook.com (2603:10a6:803:ac::17) X-Microsoft-Original-Message-ID: <87k0vubdfh.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (90.230.29.56) by AM6P193CA0037.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20 via Frontend Transport; Tue, 13 Oct 2020 10:58:11 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 03d8d181-77bf-4e53-2c42-08d86f66e053 X-MS-TrafficTypeDiagnostic: AM7EUR06HT107: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M4ue2E8ttY63CnToD94os6vemLAr3Ep5Dvua4YObZF6CrhxWPbBdJJP3bRQsecvsgC3TJk+Hft7oGCovtoIJtxDAIhellctYufZNiWJHc/9/awhjK+1QMMSfQK9bbWkWvWwZDOJskrm40sJwizeBEgmNDA+6vOQtz+Qm8O7CjoXSnxjY7tPP49m6mqdYtr6+d/HIaIG7TsqjIrimNcpXgQ== X-MS-Exchange-AntiSpam-MessageData: OPt3IYlPYKmh4N1wC/CnFNj8BSrcFChPsThekwHnsfYLLAURK7DpSeCxbHALkR+snX7rnQ6lDZsRH6xu+XzZd69LdL2Bkn3GAuCsW4E7kNUR/fT4zwkCOFrefhW9wzWbiGiJDRmKl69SLRWxXCfb7w== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03d8d181-77bf-4e53-2c42-08d86f66e053 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2020 10:58:11.8457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM7EUR06FT049.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7EUR06HT107 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Lars Ingebrigtsen , Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: > On 2020-10-13 06:54, Lars Ingebrigtsen wrote: >> Boruch Baum writes: >> >> > They return different values. One returns an expanded (canonical) >> > path-name, and the other an abbreviated one. >> >> Why not just have one call the other, and wrap the results in >> abbreviate-file-name? > > You could, but you wouldn't be saving anything since the inner function > would still need to perform the expansion, so for the abbreviated > function you end up in effect with an inefficient (abbrev (expand file)) > instead of a choice between (abbrev file) or (expand file). > > Also, much of the change ends up being defaliases, docstrings and > deprecation notices, so its more clearly presented without nesting > functions. > > -- > hkp://keys.gnupg.net > CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 Boruch you are mind reader! At least I thought so when I saw your mail yesterday. I was playing with Dired myself on Monday and I actually wrote a mail about those two functions + file-name-directory and directory-file-name, I just never send it. dired-filename-at-point is supposed to return a filename closest to the point, according to docs. For me it didn't work at all. But I mostly disliked the name. Why are there two almost identical name for different functionality? I like self-documented names for variables but if there are names like directory-file-name and file-name-directory or something like dired-file-name-at-point and dired-filename-at-point; then I have to remember and actively think about which one was that I want? Usually ends up with unnecessary look-up into docs, because I don't remember which one was that I want. Not that I hate so much to think :-), but it does interrupt the flow of thoughts. I understand that logic was 'objectoworkon-followed-by-operation' but I still find it unnecessary convoluted. It is just so much more straightforward if each function has unique descriptive name, and yes I am aware that such names are sometimes hard to get by. I have seen also discussion about string-replace and replace-string, can we plase not? For the reason above. And for the new APIs added, please don't use naming patterns like word1-word2 and word2-word1 or similar where same words are used just with some slight variation. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 07:28:01 2020 Received: (at 43961) by debbugs.gnu.org; 13 Oct 2020 11:28:01 +0000 Received: from localhost ([127.0.0.1]:45391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSITJ-0006y3-3M for submit@debbugs.gnu.org; Tue, 13 Oct 2020 07:28:01 -0400 Received: from mout.gmx.net ([212.227.17.21]:55239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSITH-0006xi-Bp for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 07:28:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602588472; bh=n7RObjC6QejjmSF3zNg/ToSo3RBWLE1Spur2GGk0kh4=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=X31QOxblK3KmyqygTc5TduVedFBojtdTQ0WhetDHGi4Cs98VpW3PCl/K6V95ckSj5 mJfqncT/20Mquyz0dLnZt0/0Weg3Oh7s+uaN8jke0FdZWWXr5vSSLbj5d3W7Yr/ZRH o6xFU1Wtlz3Bvjg/27BIdMbnKRnoldzsdPw6EAOI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Ma20q-1kw6wl35Uq-00Vxe2; Tue, 13 Oct 2020 13:27:52 +0200 Date: Tue, 13 Oct 2020 07:27:46 -0400 From: Boruch Baum To: Arthur Miller Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Message-ID: <20201013112746.o5rc3rloylt33tbe@E15-2016.optimum.net> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:gVH6CRKQhOV/VNpijb3uij2PqAGy3cehKfpa2jRH3uOm58aKuE9 Y+N1Gh6QNDNXMh1mXhSEQ/ixmmhflcQr8xYR1W3QtfN1LkPJ60TntkyGrJb4+xlEgRTyQQ8 Z08pBorZAy+jD8LaiXK5nI4N+avUl2x+qPlNVU04RagYxPhuB2npBovKfeveF48I6E4Zn8k fsL0+TLudrYqOG+2c5ywg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/z8WT4lfaR8=:icb2jXrZgVT32XeDKB1/tn XHdAaDzRnQ4BL7HfGzeRZG+02SuT0xXmMGeN+lTSsMsebHzwDQH9nCPl/0OkxEOjWgEIBh3Pv 6An43+0JLnCQe36W6lczd+Sk1Sxb4zqRT8GxfKR8ld052Wu+I1lURjvk0aHvtuJOGUQqQBJGL L99wxr6LW4IuPzVMBxLO2t3xUkayBlqq9ADhEEuOGCu1CdaxmuW3W2d994ZSd5061hTPKN+im mK9eMmYxZgnR7+SFa9wqpKDYsw5IxqPL5uJXoQUOIDfqHu3pubOZT21OfE6zZlMKfbPTlW+mn cqPRlHw1gh388KKMKWd+lJSAll0AUKZjSa0VtZ4+SjQTTwDEgwlvwo7tfSRTfmo1PMrxnTbcA hAIbP2FwZvhzowB8/4aczNdf6pED2tFJq9ncMFhTUJtFNaPLEW8wQWjtFkdteHs12HIn5NmQI /dtVCZVD+pYAWHHYnOv3Ido0fYAQEcYfICLaP2t1xj4OzjKABDQty3sS7hnk5TID9o/w5v2O8 znP6b+TPNgTVlE2jTiETvgaPfr9nz9UnCH19g/kqCyXt/hFGWaS46toVhvUe68PfgN84s5Tmi +mEw8ZUTC/R8mSIdM0BNqubxTL708/fA91fZK38LRN2tNSr2SRi9cHdw8Rp74BAEo/sxzT7lu +xq8C7JRH1+Rxv90Jqw4Bg2MxdqO1WBod/n0ixiqA913feaHh5aiAZOPskJD3FL5oIuc9Lb3E WYVvYUCLa1E2+35ycnjhbP+NzIXgwSDKfnAh6iaH1vqCITXIKoK1lN1nVvdXTYz53s3fKQ4Y6 zcv0APRIy5qqGRmrkC/rUW4RMBBh7X83X2Lm+X2Dv+5VZVTZ5VlANJy+P/fJR9kX0UKUKijZj NrGiA6Eikz7btp+7zb6GKg5zu7xdJlKWDzOJDClAI+8jGz6O6UEhOsuboqdAtthYTK94YivtP JoZWGSztaZilyD2ZDTtxITFgWnAFoR/eN79sBx+Rk2zRC58cm2SlLRfyHy/7c6jwqZoRe5bmJ vegSFbsWi+JTMOaHmdRPPTsb/oozHcggWBwBH+l/+GH/06Gy3JQ3/Z5W0TblLSaDmFaiADj3c ZondWD2YMAosBkNUgOnbDoaSEVDqg/E/TMlvev3oW/yWiO6brRtnZtiaeOQFuR0uFuk2qyDk1 guNUO+saZ2oeBlm6SD90zpDogeEntps+iMW+VC2sCdp8+RNOVfCfUvRd03XL9GPsuPPtAPnVs vdF7Ne98HnZeScL7GRpKnarqBd/Mg+OtqoYYdpednKslkL2q7dLXLFmvDVBM/pe6TaO7gyNny SLHieDec Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Lars Ingebrigtsen , Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-10-13 12:58, Arthur Miller wrote: > ... > + file-name-directory and directory-file-name, Another excellent example that I always find confusing, even after much dired programming. > dired-filename-at-point is supposed to return a filename closest to the > point, according to docs. For me it didn't work at all. I seems to not have been as well-maintained as its sister function, possibly because they've been in separate files and the maintainer forgot about one. One of its bugs is that it truncates file names at the first embedded space. > But I mostly disliked the name. Why are there two almost identical name > for different functionality? So annoying, and not limited to dired. I recently posted another in bug report 43294 [1]. It's been languishing for ~6 weeks without a decision for action, so your vote might be helpful there. > I have seen also discussion about string-replace and replace-string, can > we plase not? For the reason above. And for the new APIs added, please > don't use naming patterns like word1-word2 and word2-word1 or similar > where same words are used just with some slight variation. +1 Also, match-string and string-match. IMO, match-string should be aliased and to something like 'match-result' and deprecate the original name with a long-horizon EOL to account for its ubiquity. @Lars: Should I open a bug report separately for this? [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg00872.html =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 13 23:46:03 2020 Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 03:46:03 +0000 Received: from localhost ([127.0.0.1]:49569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSXjn-0004j7-0o for submit@debbugs.gnu.org; Tue, 13 Oct 2020 23:46:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSXjm-0004ib-1A for 43961@debbugs.gnu.org; Tue, 13 Oct 2020 23:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SbTrkgp5j6/DxvQJHwjBxyymYIbURuU4t6qnNS5kQFE=; b=u0QJoe9hwH2W9YFCK3xH6Ew9sR Tm/VnDfXoh2NfHjHKdyX/sDuBMtRE5OlKGFYahaQKU9YvlXtFNu+rV4B4bZNdcnAXgRUHVvbwxLf7 sZbfQyi7BijRhObm75HHYr3RMnSb4tVHinCa6sA5pfPPefX76xN+PeKu4E9mxI0Hbrns=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSXjd-0004Lr-2N; Wed, 14 Oct 2020 05:45:55 +0200 From: Lars Ingebrigtsen To: Boruch Baum Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEX4mS/9qC/cZTXE OjnNjDGaajBCMTHJjTJrTDH8ukb7zmv8xFb23Y3///8dEh2UAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKDgMqCmaWB8kAAAFJSURBVDjLvZM/T4QwGIdbjIlj30vJiS7YjyBfQAYS3e4SazpqornVG/wz OmhkZXDQmxwvTDdSvoHxQ0lBaAslRgffjT78nr59KQhVBWYRpAt6NQo6hseItod44oWM4Qa0AcLY Yci2WNQC0sY9FHoeQt4RVwAPdtjmlzUw+1cPd8m9M7HzLFJRgy5zzB8JTW4fUk5NVeXw51wIcROT uAKmSPhXqbiGhM9Vgmiw2H3ygfLT5uR6nZ5PZ9X6SV6ArZpewJJwXAayUEATsnhZ+jOQq/LdVsEZ hyCXZb6X9bqiMWRyvd7kYKtUZSCL/Q3YB/wuGdQADz9spiKDGb4Wb8Wqd8BG9PlR1ioYKecNAZfq 58R/7PFbFakS5nUwgLrU2Kly/1F/BM6OEbE3p3qICKx227cQiXqmFnhR6Fgegs6LJtGBe4hj33B0 7F+qim5HHhx/gQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0xNFQwMzo0MjoxMCswMDowMP8g FZ8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMTRUMDM6NDI6MTArMDA6MDCOfa0jAAAAAElF TkSuQmCC X-Now-Playing: B. Fleischmann's _Welcome Tourist (1)_: "Guided by Beats" Date: Wed, 14 Oct 2020 05:45:51 +0200 In-Reply-To: <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 13 Oct 2020 06:25:12 -0400") Message-ID: <87blh531xs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Boruch Baum writes: >> Why not just have one call the other, and wrap the results in >> abbreviate-file-name? > > You could, but you wouldn't be saving anything since the inner function > would still need to perform the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Boruch Baum writes: >> Why not just have one call the other, and wrap the results in >> abbreviate-file-name? > > You could, but you wouldn't be saving anything since the inner function > would still need to perform the expansion, so for the abbreviated > function you end up in effect with an inefficient (abbrev (expand file)) > instead of a choice between (abbrev file) or (expand file). It's not about code efficiency -- whether this function is efficient or not doesn't make any difference, since we'd deprecate it, and change the callers. > Also, much of the change ends up being defaliases, docstrings and > deprecation notices, so its more clearly presented without nesting > functions. Sorry, I don't think this is a good change. Renaming these functions just because we have two almost identical ones (when we should just remove one of them) doesn't make much sense. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 00:19:23 2020 Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 04:19:23 +0000 Received: from localhost ([127.0.0.1]:49665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYG3-0001SD-JI for submit@debbugs.gnu.org; Wed, 14 Oct 2020 00:19:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:36689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYG0-0001Rv-Mr for 43961@debbugs.gnu.org; Wed, 14 Oct 2020 00:19:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602649154; bh=Er2t4DeMoNHbTkDDVQY+/88ggLCY2YVG3YwjD0/iRS0=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=L7N0rzMLdHYqnpfkr+q7AYXPsToAEwxAHv52KyobBIhGj7BHGOZwj2NtaoP274KyX mcGsFHFClGo2nw7dzM9UQXHIMHODGPneXzCqcqEPxjC+MWq4ZtPr4fJt/uZe4U3Qlk LQoFqswt3cxLAMeBHwOmMH9geu7WjlqTuHRCvYRw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N5VD8-1kPoSp418c-016veN; Wed, 14 Oct 2020 06:19:14 +0200 Date: Wed, 14 Oct 2020 00:19:11 -0400 From: Boruch Baum To: Lars Ingebrigtsen Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point Message-ID: <20201014041910.s26b2w2yksgbtwqo@E15-2016.optimum.net> References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87blh667zs.fsf@gnus.org> <20201013102511.5nuu3p3dcyr6poft@E15-2016.optimum.net> <87blh531xs.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blh531xs.fsf@gnus.org> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:5eQz+u3iV49ynfgmF8GxfP+9Mr1JxS3PJ2rMKYMer7wLYNpKERo uEpq8QwX0NQmoS/ZkXgduO0ESHkBW0V2pcUiT5IF/+HQ5ycftPW6uqcyrGQR8cSXZ4lC2z8 urQdSPvDXgNnJZNOpm50xblJGwMN2DebYkcW1ZnLQ2cZArdY0OM8HlMAmvcCW8oO4YWoI+L QRV+BF8El4hY2dlf4rkyg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AGD8KhrK/vI=:R+QWLu9ZniBPVt8AZ2JqZG 7zj6x3zlSJ4XJntzk6eBe66fRfLPAzQ5x2gZ2iCf9X7b5WiCBmrswe9XipIAiFagb+7gauJhx hIJqV9gd1lEBMTp219uXHmF78ELsMgwMQ5tvvGxzYArdOSnCWeplL1cFNZG64XEj3P6jtIicc JUR2GWjO4a2RcT2E/PFZOdE3dWM23hn/VBJB+RNN0+5Ume/PO1BmZXH1AbeSeTsjt5B2YeL6K ZtS3i9o0khV6XGvgtJGm4LjyvAal8l1ALGWnjXN4dLdl5Akru8B8ssHFWVIlteZLaRHxp9SPc 0xtkom350bbu8othgATH1pnUUk0dmgK7XK/D+tY4MS/EVArV9YevIc+4HmXLj8GkJuKDd7zUY GF21eVR4PM+1pWzRODViBCenibaf5W0nVDOhv4kUmU2npO4EQndunN7dTSw/zB0W6LLD1OHgG 6Hs9AHiYOLG8lulIvZnuNXRMV3ALwc+nltvmTsHfx+ZztRP/RSHzxT8qfRkHjFUGM3rD5UE1w YExEWCPRY+ieKXxIrqutDEB1yHOMUDo5AE1ebhLd3ynRmYC9npP4clZspyQLTlqMMBEqZhAXE dEIsbUfflQXAxJzRgZp0WrcXyL/LxxHLmz/g1DISGkC658TktKbSilV1+Q+WiqU79t5ym9y72 PMXdu8eNBCyx40KJ0zWA40UG1Y303TLjPkcYRTKzQaeciywhgNIoJe3uO8h5c7qCpylkfzuTo j8hzI3GLV+I3lKkL6tahwTuaTq5ATbr3UxDeJpS11WTrajcwurtFGZb/moV95l2AIGqjpQj3u 1kNMX89eYo6LfL4HUzsO5CNVplqMcfDiZvJZ53JCFuuSbTqXwbCS2Qhj6Nv1KXnAEY79tbvwD g+bXGTH5JMMbUVv8E+Rg== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-10-14 05:45, Lars Ingebrigtsen wrote: > It's not about code efficiency -- whether this function is efficient or > not doesn't make any difference, since we'd deprecate it, and change the > callers. > Sorry, I don't think this is a good change. Renaming these functions > just because we have two almost identical ones (when we should just > remove one of them) doesn't make much sense. Maybe you're catching me on a bad day, but I don't have the patience to continue this discussion. IMO, you're making a glaringly bad call. If my presentation was inadequate, that's on me; I can't present any clearer than I have already done previously on this thread, so someone else is going to need to carry the ball on this, or maybe you'll re-read the thread more carefully and change your mind. I'm moving on to other issues. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 00:43:55 2020 Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 04:43:55 +0000 Received: from localhost ([127.0.0.1]:49711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYdn-0004FQ-82 for submit@debbugs.gnu.org; Wed, 14 Oct 2020 00:43:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYdm-0004FD-1z for 43961@debbugs.gnu.org; Wed, 14 Oct 2020 00:43:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51992) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSYdg-0006rA-OP; Wed, 14 Oct 2020 00:43:48 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kSYdf-0001Ed-OE; Wed, 14 Oct 2020 00:43:47 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Boruch Baum In-Reply-To: <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> (message from Boruch Baum on Tue, 13 Oct 2020 00:08:07 -0400) Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> Message-Id: Date: Wed, 14 Oct 2020 00:43:47 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > As I think I mentioned, once (if) the patch is approved, a next step is > to grep the emacs core code-base and replace the function names. I just did that. dired-filename-at-point is not used anywhere except dired-x.el. I expect that none of the published Lisp packages uses dired-filename-at-point. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 00:58:19 2020 Received: (at 43961) by debbugs.gnu.org; 14 Oct 2020 04:58:19 +0000 Received: from localhost ([127.0.0.1]:49725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYrj-0004cH-6R for submit@debbugs.gnu.org; Wed, 14 Oct 2020 00:58:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYrh-0004c5-VP for 43961@debbugs.gnu.org; Wed, 14 Oct 2020 00:58:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n5jiJ/UxA8LG4U/xD89WnwKoAVKKVC6+iqcC/5SFu4g=; b=aZGcyRl4aqJZqPiF/BhH2aYf76 9d8BsPHAdIeuhvQ7gaDu0PbihRaaGXcE7nvPbaMyqraGcAUeUt4EnTsXjjDTVBkRVJ7smehqD5kWz SA0nnrSZGZCQTxSi1vCv9DRkT6kf8miP5r0T0qYdnTcCJQ4PiVeI6681E69aRzEfv1dw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYrY-0005qy-Mr; Wed, 14 Oct 2020 06:58:11 +0200 From: Lars Ingebrigtsen To: Richard Stallman Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> X-Now-Playing: The Remote Viewer's _You're Going to Love Our Defeatist Attitude_: "The Gambler and the Captain" Date: Wed, 14 Oct 2020 06:58:07 +0200 In-Reply-To: (Richard Stallman's message of "Wed, 14 Oct 2020 00:43:47 -0400") Message-ID: <87k0vtz9nk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Richard Stallman writes: > > As I think I mentioned, once (if) the patch is approved, a next step is > > to grep the emacs core code-base and replace the function names. > > I just did that. dired-filename-at-point is not use [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, Boruch Baum X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Richard Stallman writes: > > As I think I mentioned, once (if) the patch is approved, a next step is > > to grep the emacs core code-base and replace the function names. > > I just did that. dired-filename-at-point is not used anywhere except > dired-x.el. > > I expect that none of the published Lisp packages uses > dired-filename-at-point. And I looked at the code now, and it seems the bug reporter misunderstood the point of the function: It's used to guess a file name in non-dired buffers, while dired-file-name-at-point is a dired function that just returns the file name in a dired buffer. So they're totally unrelated functions, but dired-filename-at-point has an unfortunate name. I've now renamed it (but kept dired-filename-at-point as an obsolete alias). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 01:02:06 2020 Received: (at control) by debbugs.gnu.org; 14 Oct 2020 05:02:06 +0000 Received: from localhost ([127.0.0.1]:49729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYvN-0004jM-Oi for submit@debbugs.gnu.org; Wed, 14 Oct 2020 01:02:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSYvL-0004ip-Lk for control@debbugs.gnu.org; Wed, 14 Oct 2020 01:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SJsOZtms90OikIRzQBYbarW6ERmmGBl6KYNAkJl+h1k=; b=Vo6IV+ZFLld2s5+GvBKUYAjzdI UEbVjYYlTmW8pvbjZgg+6DNIMhTGTLyZi4Zq7rC8dA1voy8aNdvd51Nk2YB0rGPF2FBKLwrW7ba0q t/h8mkhZoaGToNfiwIKUAgQpyZGq5+JJnexbiP/jL0jBtD7WscbObNzAnVfVQoqepy3g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSYvD-00066g-H2 for control@debbugs.gnu.org; Wed, 14 Oct 2020 07:01:58 +0200 Date: Wed, 14 Oct 2020 07:01:54 +0200 Message-Id: <87imbdz9h9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #43961 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 43961 fixed close 43961 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 43961 fixed close 43961 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 14 23:57:22 2020 Received: (at 43961) by debbugs.gnu.org; 15 Oct 2020 03:57:22 +0000 Received: from localhost ([127.0.0.1]:53772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSuOI-0005uU-4d for submit@debbugs.gnu.org; Wed, 14 Oct 2020 23:57:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSuOF-0005uI-Ug for 43961@debbugs.gnu.org; Wed, 14 Oct 2020 23:57:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42563) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSuOA-0008T5-BI; Wed, 14 Oct 2020 23:57:14 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kSuO8-0005BQ-Qh; Wed, 14 Oct 2020 23:57:13 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Lars Ingebrigtsen In-Reply-To: <87k0vtz9nk.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 14 Oct 2020 06:58:07 +0200) Subject: Re: bug#43961: read carefully: dired-file-name-at-point vs dired-filename-at-point References: <20201012142522.m24zmrzzuiiao4ck@E15-2016.optimum.net> <20201013040807.xk2q54jnquthda7y@E15-2016.optimum.net> <87k0vtz9nk.fsf@gnus.org> Message-Id: Date: Wed, 14 Oct 2020 23:57:12 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43961 Cc: 43961@debbugs.gnu.org, boruch_baum@gmx.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > So they're totally unrelated functions, but dired-filename-at-point has > an unfortunate name. I've now renamed it (but kept > dired-filename-at-point as an obsolete alias). Thanks for cleaning up that confusion. -- Dr Richard Stallman Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From unknown Thu Jun 19 12:31:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator