GNU bug report logs - #43946
[PATCH] doc: Add item to "Submitting Patches" section.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: zimoun <zimon.toutoune <at> gmail.com>
Subject: bug#43946: closed (Re: bug#43946: [PATCH] doc: Add item to
 "Submitting Patches" section.)
Date: Wed, 22 Sep 2021 13:04:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#43946: [PATCH] doc: Add item to "Submitting Patches" section.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43946 <at> debbugs.gnu.org.

-- 
43946: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43946
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 43946-done <at> debbugs.gnu.org
Subject: Re: bug#43946: [PATCH] doc: Add item to "Submitting Patches" section.
Date: Wed, 22 Sep 2021 15:02:57 +0200

Hi,

zimoun <zimon.toutoune <at> gmail.com> skribis:

> Seeing the number of patches in the patch tracker, most of them does not
> apply anymore.  It is not encouraging to review and decrease the queue
> when first the reviewer has to guess onto which commit the patch
> applies.

Yeah in hindsight I think I agree with you.  I went ahead and (finally!)
applied the patch.

Thanks for persevering, and apologies for my stubbornness!  :-)

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH] doc: Add item to "Submitting Patches" section.
Date: Mon, 12 Oct 2020 10:20:03 +0200

* doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
--base'.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index af3601442e..5ea3cb1899 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
 please run through this check list:
 
 @enumerate
+@cindex @code{git format-patch}
+@cindex @code{git-format-patch}
+@item
+We recommend to use the command @code{git format-patch --base} to
+include the commit where your patch applies.
+
 @item
 If the authors of the packaged software provide a cryptographic
 signature for the release tarball, make an effort to verify the

base-commit: e746d30ec15852ec50e4247ea0a07ab2a9a69aa8
-- 
2.28.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.