GNU bug report logs - #43946
[PATCH] doc: Add item to "Submitting Patches" section.

Previous Next

Full log

View this message in rfc822 format

From: zimoun <zimon.toutoune <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 43946-done <at> debbugs.gnu.org
Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
Date: Sat, 24 Oct 2020 11:17:03 +0200

Dear,

Thank you for the review.

On Sat, 24 Oct 2020 at 11:01, Oleg Pykhalov <go.wigust <at> gmail.com> wrote:
> zimoun <zimon.toutoune <at> gmail.com> writes:
>
> > * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> > --base'.
> > ---
> >  doc/contributing.texi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/contributing.texi b/doc/contributing.texi
> > index af3601442e..5ea3cb1899 100644
> > --- a/doc/contributing.texi
> > +++ b/doc/contributing.texi
> > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
> >  please run through this check list:
> >
> >  @enumerate
> > +@cindex @code{git format-patch}
> > +@cindex @code{git-format-patch}
> > +@item
> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> “git format-patch” already mentioned in the documentation in the first
> paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

The point of the patch is:
 - the addition of the cindex
 - the addition of the option --base
and AFAITC it is not already in the manual.  If it is the wrong place,
please let me know where it could be better.

All the best,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.