GNU bug report logs - #43946
[PATCH] doc: Add item to "Submitting Patches" section.

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Mon, 12 Oct 2020 08:21:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 43946-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 43946-done <at> debbugs.gnu.org
Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
Date: Sat, 24 Oct 2020 12:01:51 +0300
[Message part 1 (text/plain, inline)]
Hi,

zimoun <zimon.toutoune <at> gmail.com> writes:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>  please run through this check list:
>  
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

“git format-patch” already mentioned in the documentation in the first
paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Do I miss something?  Fill free to reopen the issue ;-)

Oleg.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 303 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.