GNU bug report logs - #43892
[PATCH] Native-comp: fix compilation warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43892 in the body.
You can then email your comments to 43892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Native-comp: fix compilation warnings
Date: Fri, 9 Oct 2020 23:44:52 +0200 (CEST)

[Message part 1 (text/plain, inline)]

This is for the native-comp branch.

I also attached my FSF papers from when I contributed to an external Emacs package. Not sure if I need separate forms right now.

-- 
Sent with https://mailfence.com
Secure and private email

[leung.tar.gz (application/x-gzip, attachment)]

[0001-Fix-some-compilation-warnings.patch (text/x-diff, attachment)]

Message #8 received at 43892 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: 43892 <at> debbugs.gnu.org
Subject: [PATCH] Native comp: fix compilation warnings
Date: Sat, 10 Oct 2020 00:35:58 +0200 (CEST)

[Message part 1 (text/plain, inline)]

I found another warning, so please look at this patch instead, which supersedes the other one I sent.

-- 
Sent with https://mailfence.com
Secure and private email

[0001-Fix-some-compilation-warnings.patch (text/x-diff, attachment)]

Message #11 received at 43892 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: 43892 <at> debbugs.gnu.org
Subject: Re: [PATCH] Native comp: fix compilation warnings
Date: Sat, 10 Oct 2020 03:19:58 +0200 (CEST)

[Message part 1 (text/plain, inline)]

Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.

> ----------------------------------------
> From: Brian Leung <leungbk <at> mailfence.com>
> Sent: Sat Oct 10 00:35:58 CEST 2020
> To: <43892 <at> debbugs.gnu.org>
> Subject: [PATCH] Native comp: fix compilation warnings
> 
> 
> I found another warning, so please look at this patch instead, which supersedes the other one I sent.
> 
> -- 
> Sent with https://mailfence.com
> Secure and private email


-- 
Sent with https://mailfence.com
Secure and private email

[0001-Fix-some-compilation-warnings.patch (text/x-diff, attachment)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
 editors" <bug-gnu-emacs <at> gnu.org>
Cc: Brian Leung <leungbk <at> mailfence.com>, 43892 <at> debbugs.gnu.org
Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings
Date: Mon, 12 Oct 2020 07:05:31 +0000

Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.
>

Hi Brian,

could you double check the patch applies and re-send it with a ChangeLog
entry (see ** Commit messages in the CONTRIBUTE file)?

Thanks

  Andrea

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Andrea Corallo <akrl <at> sdf.org>,
 "Brian Leung via \"Bug reports for GNU Emacs, the Swiss army knife of text
 editors\"" <bug-gnu-emacs <at> gnu.org>
Cc: 43892 <at> debbugs.gnu.org
Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings
Date: Mon, 12 Oct 2020 19:40:22 +0200 (CEST)

[Message part 1 (text/plain, inline)]

Hi Andrea,

I have rebased the patch and attached. I looked at the CONTRIBUTE file, which says that minor commits with "; " in front do not need Changelog entries. I feel like this patch is pretty minor, so I'm not sure if it warrants a Changelog entry. Let me know what you think.

Thanks,
Brian

> ----------------------------------------
> From: Andrea Corallo <akrl <at> sdf.org>
> Sent: Mon Oct 12 09:05:31 CEST 2020
> To: Brian Leung via "Bug reports for GNU Emacs the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> Cc: <43892 <at> debbugs.gnu.org>, Brian Leung <leungbk <at> mailfence.com>
> Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings
> 
> 
> Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.
> >
> 
> Hi Brian,
> 
> could you double check the patch applies and re-send it with a ChangeLog
> entry (see ** Commit messages in the CONTRIBUTE file)?
> 
> Thanks
> 
>   Andrea


-- 
Sent with https://mailfence.com
Secure and private email

[0001-Fix-some-compilation-warnings.patch (text/x-diff, attachment)]

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
 editors" <bug-gnu-emacs <at> gnu.org>
Cc: 43892-done <at> debbugs.gnu.org, Brian Leung <leungbk <at> mailfence.com>
Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings
Date: Mon, 12 Oct 2020 19:28:31 +0000

Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> Hi Andrea,
>
> I have rebased the patch and attached. I looked at the CONTRIBUTE
> file, which says that minor commits with "; " in front do not need
> Changelog entries. I feel like this patch is pretty minor, so I'm not
> sure if it warrants a Changelog entry. Let me know what you think.

Hi Brian,

I don't think this has to be considered minor.  I've just improved a bit
commit message and Changelog entry and pushed it as 237fd33aef.

Thanks for the patch, closing.

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.