Subject: bug#43883: closed (Re: [bug#43883] [PATCH] gnu: Add libebur128.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 18 Oct 2020 22:00:02 +0000

Your bug report

#43883: [PATCH] gnu: Add libebur128.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
43883: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43883
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#43883] [PATCH] gnu: Add libebur128.
From: Marius Bakke <[email-masked]>
To: Vinicius Monego <[email-masked]>
Cc: [email-masked]
Date: Sun, 18 Oct 2020 23:59:38 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Vinicius Monego <[email-masked]> writes:

> Marius Bakke writes:
>
>> Vinicius Monego <[email-masked]> writes:
>>
>>> * gnu/packages/audio.scm (libebur128): New variable.
>>
>> [...]
>>   
>>> +    (arguments
>>> +     `(;; Tests require .wav files that are not distributed with the code.
>>> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
>>> +       #:tests? #f
>>
>> It is easy to provide these data files using an (origin ...) in
>> native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
>> the terms of use first, as the data set is unrelated to this package.
>>
>> (I don't really have a strong opinion here, just sayin')
>>
>
> I had a look at the terms (link provided in the issue referenced above)
> and commercial usage is forbidden, making the audio files nonfree. Also, the
> zip file weighs 87 MB.

Oh, thanks for checking, too bad.

>>> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>>
>> Note: you can use #:build-type "Release" instead.  The default is
>> "RelWithDebInfo", so it's customary to add a comment when changing it.
>> Is there a particular reason to not provide debugging information here?
>
> Oh, I wasn't aware of #:build-type. Thanks.
>
> I remove debugging information to save space. The ideal case is to move
> it to a separate output as in
>
> https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html
>
> , but that is something I have yet to take a look at.
>
> I will enable it again in the v2 and add a comment about the data.

Excellent, applied!

Subject: [PATCH] gnu: Add libebur128.
From: Vinicius Monego <[email-masked]>
To: [email-masked]
Cc: Vinicius Monego <[email-masked]>
Date: Fri, 9 Oct 2020 12:12:56 -0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/audio.scm (libebur128): New variable.
---
 gnu/packages/audio.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0e93a7263e..bd88987e13 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3060,6 +3060,33 @@ that toolkit will work in all hosts that use Suil automatically.
 Suil currently supports every combination of Gtk, Qt, and X11.")
     (license license:isc)))
 
+(define-public libebur128
+  (package
+    (name "libebur128")
+    (version "1.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jiixyj/libebur128")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(;; Tests require .wav files that are not distributed with the code.
+       ;; See https://github.com/jiixyj/libebur128/issues/82.
+       #:tests? #f
+       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
+                           "-DBUILD_STATIC_LIBS=OFF")))
+    (home-page "https://github.com/jiixyj/libebur128")
+    (synopsis "Library implementing the EBU R 128 loudness standard")
+    (description
+     "@code{libebur128} is a C library that implements the EBU R 128 standard
+for loudness normalisation.")
+    (license license:expat)))
+
 (define-public timidity++
   (package
     (name "timidity++")
-- 
2.20.1