From unknown Mon Jun 23 04:12:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH] gnu: Add libebur128. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Oct 2020 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43883@debbugs.gnu.org Cc: Vinicius Monego X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160225642427681 (code B ref -1); Fri, 09 Oct 2020 15:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Oct 2020 15:13:44 +0000 Received: from localhost ([127.0.0.1]:36051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQu5Y-0007CP-AV for submit@debbugs.gnu.org; Fri, 09 Oct 2020 11:13:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:37134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQu5V-0007CG-5r for submit@debbugs.gnu.org; Fri, 09 Oct 2020 11:13:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQu5U-00045e-Mz for guix-patches@gnu.org; Fri, 09 Oct 2020 11:13:41 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQu5S-0003ZP-3P for guix-patches@gnu.org; Fri, 09 Oct 2020 11:13:40 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id CC123160060 for ; Fri, 9 Oct 2020 17:13:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1602256414; bh=vhe5vB/yjaPpi6XF/q3A8qQclbzlMroRuDLUAhx/pS4=; h=From:To:Cc:Subject:Date:From; b=W/IagYtTF2vTD4EmdCubM5Y0EaU7kvSV10YTxvIaZyg4VbaIemZQmqQJepo4+SJk4 Q184ql1M09pA4WRqc5xs/YjEDcf4qWzgtQNLp0y6w6ETFGJQGPSXNUVJPIoU4NsoNO /nvNsDltmz+m28FcODoD0VCdx2zwejDiZ1Dn21Kva2h3Fq0ol+mA6BfQyvtKgw+9fO NPtNgZnSQTHw6cTZhdw/4Hk20qsc04osg1r8Jd15UFlbUgHO1qqSpabXwwjAo81TLx sAedClxZ8f/VAc/LLdHxOfN+2DNjYay8SsNznMFRsLSgVbDo3Jh0UfrBC5ZA1jTdce it7ZcUu69DW7Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C7BRK1RSXz6tmF; Fri, 9 Oct 2020 17:13:32 +0200 (CEST) From: Vinicius Monego Date: Fri, 9 Oct 2020 12:12:56 -0300 Message-Id: <20201009151256.7949-1-monego@posteo.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=monego@posteo.net; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 11:13:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/audio.scm (libebur128): New variable. --- gnu/packages/audio.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 0e93a7263e..bd88987e13 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3060,6 +3060,33 @@ that toolkit will work in all hosts that use Suil automatically. Suil currently supports every combination of Gtk, Qt, and X11.") (license license:isc))) +(define-public libebur128 + (package + (name "libebur128") + (version "1.2.4") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jiixyj/libebur128") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g")))) + (build-system cmake-build-system) + (arguments + `(;; Tests require .wav files that are not distributed with the code. + ;; See https://github.com/jiixyj/libebur128/issues/82. + #:tests? #f + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release" + "-DBUILD_STATIC_LIBS=OFF"))) + (home-page "https://github.com/jiixyj/libebur128") + (synopsis "Library implementing the EBU R 128 loudness standard") + (description + "@code{libebur128} is a C library that implements the EBU R 128 standard +for loudness normalisation.") + (license license:expat))) + (define-public timidity++ (package (name "timidity++") -- 2.20.1 From unknown Mon Jun 23 04:12:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH] gnu: Add libebur128. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Oct 2020 21:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego , 43883@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 43883-submit@debbugs.gnu.org id=B43883.160262373213864 (code B ref 43883); Tue, 13 Oct 2020 21:16:01 +0000 Received: (at 43883) by debbugs.gnu.org; 13 Oct 2020 21:15:32 +0000 Received: from localhost ([127.0.0.1]:49085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRdr-0003bY-PA for submit@debbugs.gnu.org; Tue, 13 Oct 2020 17:15:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRdp-0003bL-TA for 43883@debbugs.gnu.org; Tue, 13 Oct 2020 17:15:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44318) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSRdk-0006Dw-Ec; Tue, 13 Oct 2020 17:15:24 -0400 Received: from ti0006q161-1594.bb.online.no ([46.9.75.77]:51842 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSRdj-000201-NR; Tue, 13 Oct 2020 17:15:24 -0400 From: Marius Bakke In-Reply-To: <20201009151256.7949-1-monego@posteo.net> References: <20201009151256.7949-1-monego@posteo.net> Date: Tue, 13 Oct 2020 23:15:20 +0200 Message-ID: <87imbdrfo7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > * gnu/packages/audio.scm (libebur128): New variable. [...] =20=20 > + (arguments > + `(;; Tests require .wav files that are not distributed with the cod= e. > + ;; See https://github.com/jiixyj/libebur128/issues/82. > + #:tests? #f It is easy to provide these data files using an (origin ...) in native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check the terms of use first, as the data set is unrelated to this package. (I don't really have a strong opinion here, just sayin') > + #:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease" Note: you can use #:build-type "Release" instead. The default is "RelWithDebInfo", so it's customary to add a comment when changing it. Is there a particular reason to not provide debugging information here? Otherwise the patch LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+GGOgPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT6NrsH/RwUpkDiUk6TiwHL7Ed/pXJfVscTmVp/3CvU HOGiHctftsyf9c/8pEAkMnQO7df4QudJ2v4P4s71JrOD9xytUP9sL+bRIAbBEqba NADmW+cppqU2Iu5BkNzWvkExjuftZSjoeYg7EL4XIsVOM4otxwRzBrx47dyQ4F4N tYy06kF5lI48gAnf/CaFNktJHjHw1Hv0NMyTM1KW5iarbjePI0GuPhbXkalUq0Jl VX9jZTLqJZSH++ZIewww2a0CEQQ8nVCs4gWMf+MjvPd7Jgt3ZJhojDDI8V2XaU9y 9jDWNCarpBamoVjK6jEv8gvClHS9FU6Wb+/pVgpHtAm9bSn//tY= =35UP -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 04:12:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH] gnu: Add libebur128. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Oct 2020 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 43883@debbugs.gnu.org Received: via spool by 43883-submit@debbugs.gnu.org id=B43883.160280624511970 (code B ref 43883); Thu, 15 Oct 2020 23:58:01 +0000 Received: (at 43883) by debbugs.gnu.org; 15 Oct 2020 23:57:25 +0000 Received: from localhost ([127.0.0.1]:57021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTD7d-000370-HS for submit@debbugs.gnu.org; Thu, 15 Oct 2020 19:57:25 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTD7b-00036n-Pq for 43883@debbugs.gnu.org; Thu, 15 Oct 2020 19:57:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 840862400FB for <43883@debbugs.gnu.org>; Fri, 16 Oct 2020 01:57:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1602806237; bh=gZaeR/jPLL1Gbrvvl7TLgPy1LGaoKRKuBkqJWKLW8jU=; h=From:To:Cc:Subject:Date:From; b=XQIb5ZEpJLmSC6wyiQC+TMARkEf3o/lElW7SfdnStjWdK83RP8gXAmkWAKA/yYO6q eJQCMUeLMqHb/KWxqtZrMra865yf8vrBkpIdGCI6GGTub7P6ncjkzuNUDmSfoWoQ9l +iHZFzLU5Uw9NT/phIi7/Q+WpNY7dt3QZNgA73qjvr7Zr+Nk8ZjYxGGh8Jpinq7t0H aeMdH5a6YguUDoHhMyUptXOw1eE6Hw0bQzvHtGpY7fIsiH0gnntZzO+5Qbulf1FsX3 IV1i+zN2MJMsR1nLLSIKATYpXN5vskKqYt0Q28i7MjSdMdcjr4u3GVgxBCU0I09htg Q5CJhr7Ti600w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CC5mq5HSTz9rxM; Fri, 16 Oct 2020 01:57:15 +0200 (CEST) References: <20201009151256.7949-1-monego@posteo.net> <87imbdrfo7.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Vinicius Monego In-reply-to: <87imbdrfo7.fsf@gnu.org> Date: Thu, 15 Oct 2020 20:56:44 -0300 Message-ID: <87imbb11s3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Marius Bakke writes: > Vinicius Monego writes: > >> * gnu/packages/audio.scm (libebur128): New variable. > > [...] > >> + (arguments >> + `(;; Tests require .wav files that are not distributed with the code. >> + ;; See https://github.com/jiixyj/libebur128/issues/82. >> + #:tests? #f > > It is easy to provide these data files using an (origin ...) in > native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check > the terms of use first, as the data set is unrelated to this package. > > (I don't really have a strong opinion here, just sayin') > I had a look at the terms (link provided in the issue referenced above) and commercial usage is forbidden, making the audio files nonfree. Also, the zip file weighs 87 MB. >> + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release" > > Note: you can use #:build-type "Release" instead. The default is > "RelWithDebInfo", so it's customary to add a comment when changing it. > Is there a particular reason to not provide debugging information here? Oh, I wasn't aware of #:build-type. Thanks. I remove debugging information to save space. The ideal case is to move it to a separate output as in https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html , but that is something I have yet to take a look at. I will enable it again in the v2 and add a comment about the data. From unknown Mon Jun 23 04:12:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43883] [PATCH v2] gnu: Add libebur128. References: <20201009151256.7949-1-monego@posteo.net> In-Reply-To: <20201009151256.7949-1-monego@posteo.net> Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Oct 2020 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43883 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43883@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 43883-submit@debbugs.gnu.org id=B43883.160285815119271 (code B ref 43883); Fri, 16 Oct 2020 14:23:02 +0000 Received: (at 43883) by debbugs.gnu.org; 16 Oct 2020 14:22:31 +0000 Received: from localhost ([127.0.0.1]:60381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQcp-00050l-EF for submit@debbugs.gnu.org; Fri, 16 Oct 2020 10:22:31 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTQcm-00050U-RZ for 43883@debbugs.gnu.org; Fri, 16 Oct 2020 10:22:30 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 611AF2400FB for <43883@debbugs.gnu.org>; Fri, 16 Oct 2020 16:22:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1602858142; bh=cDmM9rrsWZu0WLJyOadm33fVwMLOZOTQm5tavo4GE7U=; h=From:To:Cc:Subject:Date:From; b=du4knIokreiGonZ5+CGtHx/VYEY4j9325zf4JD5odlZtoEIkA8sE9AVnjtHDJkfsP TLFMXQUpGlNxRKN7qh1oRYJ4Q2IDyjLWh/wDNbbHme1a8yyN5+rtOwvgt8HgOGLYPq S+YWB/Gi+s4RhZOES2d53CwkrRlNLUObL0KTNPcm/bMlWc9fZflssGJZbGg8qCBPUx o/mpGDkbFrKjDxFGNAPl0xKWpU4OKS3jkjX/gsTo84i/yszu8iBoIRAGMXkuOrIEpk wjMwF15/Aj3FCvAjyVBiRi62HdvxK8ir5V/uwamTtZOWF1Ayrsf5aUtrsW6kMv+7W3 7X3QrpZQciMTg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CCSz04lYnz9rxg; Fri, 16 Oct 2020 16:22:20 +0200 (CEST) From: Vinicius Monego Date: Fri, 16 Oct 2020 11:21:43 -0300 Message-Id: <20201016142143.46684-1-monego@posteo.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/audio.scm (libebur128): New variable. --- Changed comment about why tests are disabled and build with debug information. gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 0e93a7263e..5bdbec40a2 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3060,6 +3060,32 @@ that toolkit will work in all hosts that use Suil automatically. Suil currently supports every combination of Gtk, Qt, and X11.") (license license:isc))) +(define-public libebur128 + (package + (name "libebur128") + (version "1.2.4") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jiixyj/libebur128") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g")))) + (build-system cmake-build-system) + (arguments + `(;; Tests require proprietary .wav files. See + ;; https://github.com/jiixyj/libebur128/issues/82. + #:tests? #f + #:configure-flags '("-DBUILD_STATIC_LIBS=OFF"))) + (home-page "https://github.com/jiixyj/libebur128") + (synopsis "Library implementing the EBU R 128 loudness standard") + (description + "@code{libebur128} is a C library that implements the EBU R 128 standard +for loudness normalisation.") + (license license:expat))) + (define-public timidity++ (package (name "timidity++") -- 2.20.1 From unknown Mon Jun 23 04:12:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vinicius Monego Subject: bug#43883: closed (Re: [bug#43883] [PATCH] gnu: Add libebur128.) Message-ID: References: <87wnznjiut.fsf@gnu.org> <20201009151256.7949-1-monego@posteo.net> X-Gnu-PR-Message: they-closed 43883 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43883@debbugs.gnu.org Date: Sun, 18 Oct 2020 22:00:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1603058402-23901-1" This is a multi-part message in MIME format... ------------=_1603058402-23901-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43883: [PATCH] gnu: Add libebur128. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43883@debbugs.gnu.org. --=20 43883: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43883 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1603058402-23901-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43883-done) by debbugs.gnu.org; 18 Oct 2020 21:59:53 +0000 Received: from localhost ([127.0.0.1]:39228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGiS-0006Ck-TJ for submit@debbugs.gnu.org; Sun, 18 Oct 2020 17:59:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUGiR-0006CY-CP for 43883-done@debbugs.gnu.org; Sun, 18 Oct 2020 17:59:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50592) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUGiM-0002WV-1s; Sun, 18 Oct 2020 17:59:42 -0400 Received: from ti0006q161-1594.bb.online.no ([46.9.75.77]:36556 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUGiK-0006uL-Fr; Sun, 18 Oct 2020 17:59:41 -0400 From: Marius Bakke To: Vinicius Monego Subject: Re: [bug#43883] [PATCH] gnu: Add libebur128. In-Reply-To: <87imbb11s3.fsf@posteo.net> References: <20201009151256.7949-1-monego@posteo.net> <87imbdrfo7.fsf@gnu.org> <87imbb11s3.fsf@posteo.net> Date: Sun, 18 Oct 2020 23:59:38 +0200 Message-ID: <87wnznjiut.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43883-done Cc: 43883-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > Marius Bakke writes: > >> Vinicius Monego writes: >> >>> * gnu/packages/audio.scm (libebur128): New variable. >> >> [...] >>=20=20=20 >>> + (arguments >>> + `(;; Tests require .wav files that are not distributed with the c= ode. >>> + ;; See https://github.com/jiixyj/libebur128/issues/82. >>> + #:tests? #f >> >> It is easy to provide these data files using an (origin ...) in >> native-inputs, like e.g. 'json-modern-cxx'. Obviously we should check >> the terms of use first, as the data set is unrelated to this package. >> >> (I don't really have a strong opinion here, just sayin') >> > > I had a look at the terms (link provided in the issue referenced above) > and commercial usage is forbidden, making the audio files nonfree. Also, = the > zip file weighs 87 MB. Oh, thanks for checking, too bad. >>> + #:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease" >> >> Note: you can use #:build-type "Release" instead. The default is >> "RelWithDebInfo", so it's customary to add a comment when changing it. >> Is there a particular reason to not provide debugging information here? > > Oh, I wasn't aware of #:build-type. Thanks. > > I remove debugging information to save space. The ideal case is to move > it to a separate output as in > > https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html > > , but that is something I have yet to take a look at. > > I will enable it again in the v2 and add a comment about the data. Excellent, applied! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+MusoPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT65sgH/2ZKf2VYiif1LjicjLlaTELTDZojHS5CyOIS 1UNsj/6X94NcgqGiroF3N0SuVGNIRy7kfnar11YBZNu+T0qB9F7TdAXNURJ8G7Y4 SlCMxSOxpzTaZyT2iov8dYhdPZwkKtJCcsXFW0xO9kmeLXhwS89a6zUKxbefSihU JKl4IWSlVl71dJJt7k+w8XuONv1QJPmdosRYPCSQcWrDhtVPz7xceNGonyfgp8am 5g7vyt15qDjkKfumCYTmE64HK110EbBfX8jwJ/OCYfeIBMZQSi137ZFv4l6jEBOF JdL8OyzZD88TOXeUAD5oexVeqOLqWqEwZyHaNdn21GIdaEucD0o= =naON -----END PGP SIGNATURE----- --=-=-=-- ------------=_1603058402-23901-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Oct 2020 15:13:44 +0000 Received: from localhost ([127.0.0.1]:36051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQu5Y-0007CP-AV for submit@debbugs.gnu.org; Fri, 09 Oct 2020 11:13:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:37134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQu5V-0007CG-5r for submit@debbugs.gnu.org; Fri, 09 Oct 2020 11:13:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQu5U-00045e-Mz for guix-patches@gnu.org; Fri, 09 Oct 2020 11:13:41 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQu5S-0003ZP-3P for guix-patches@gnu.org; Fri, 09 Oct 2020 11:13:40 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id CC123160060 for ; Fri, 9 Oct 2020 17:13:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1602256414; bh=vhe5vB/yjaPpi6XF/q3A8qQclbzlMroRuDLUAhx/pS4=; h=From:To:Cc:Subject:Date:From; b=W/IagYtTF2vTD4EmdCubM5Y0EaU7kvSV10YTxvIaZyg4VbaIemZQmqQJepo4+SJk4 Q184ql1M09pA4WRqc5xs/YjEDcf4qWzgtQNLp0y6w6ETFGJQGPSXNUVJPIoU4NsoNO /nvNsDltmz+m28FcODoD0VCdx2zwejDiZ1Dn21Kva2h3Fq0ol+mA6BfQyvtKgw+9fO NPtNgZnSQTHw6cTZhdw/4Hk20qsc04osg1r8Jd15UFlbUgHO1qqSpabXwwjAo81TLx sAedClxZ8f/VAc/LLdHxOfN+2DNjYay8SsNznMFRsLSgVbDo3Jh0UfrBC5ZA1jTdce it7ZcUu69DW7Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C7BRK1RSXz6tmF; Fri, 9 Oct 2020 17:13:32 +0200 (CEST) From: Vinicius Monego To: guix-patches@gnu.org Subject: [PATCH] gnu: Add libebur128. Date: Fri, 9 Oct 2020 12:12:56 -0300 Message-Id: <20201009151256.7949-1-monego@posteo.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=monego@posteo.net; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 11:13:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Vinicius Monego X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/audio.scm (libebur128): New variable. --- gnu/packages/audio.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 0e93a7263e..bd88987e13 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3060,6 +3060,33 @@ that toolkit will work in all hosts that use Suil automatically. Suil currently supports every combination of Gtk, Qt, and X11.") (license license:isc))) +(define-public libebur128 + (package + (name "libebur128") + (version "1.2.4") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jiixyj/libebur128") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g")))) + (build-system cmake-build-system) + (arguments + `(;; Tests require .wav files that are not distributed with the code. + ;; See https://github.com/jiixyj/libebur128/issues/82. + #:tests? #f + #:configure-flags '("-DCMAKE_BUILD_TYPE=Release" + "-DBUILD_STATIC_LIBS=OFF"))) + (home-page "https://github.com/jiixyj/libebur128") + (synopsis "Library implementing the EBU R 128 loudness standard") + (description + "@code{libebur128} is a C library that implements the EBU R 128 standard +for loudness normalisation.") + (license license:expat))) + (define-public timidity++ (package (name "timidity++") -- 2.20.1 ------------=_1603058402-23901-1--