GNU bug report logs - #43883
[PATCH] gnu: Add libebur128.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43883 in the body.
You can then email your comments to 43883 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH] gnu: Add libebur128.
Date: Fri,  9 Oct 2020 12:12:56 -0300

* gnu/packages/audio.scm (libebur128): New variable.
---
 gnu/packages/audio.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0e93a7263e..bd88987e13 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3060,6 +3060,33 @@ that toolkit will work in all hosts that use Suil automatically.
 Suil currently supports every combination of Gtk, Qt, and X11.")
     (license license:isc)))
 
+(define-public libebur128
+  (package
+    (name "libebur128")
+    (version "1.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jiixyj/libebur128")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(;; Tests require .wav files that are not distributed with the code.
+       ;; See https://github.com/jiixyj/libebur128/issues/82.
+       #:tests? #f
+       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
+                           "-DBUILD_STATIC_LIBS=OFF")))
+    (home-page "https://github.com/jiixyj/libebur128")
+    (synopsis "Library implementing the EBU R 128 loudness standard")
+    (description
+     "@code{libebur128} is a C library that implements the EBU R 128 standard
+for loudness normalisation.")
+    (license license:expat)))
+
 (define-public timidity++
   (package
     (name "timidity++")
-- 
2.20.1

Message #8 received at 43883 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>, 43883 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: Re: [bug#43883] [PATCH] gnu: Add libebur128.
Date: Tue, 13 Oct 2020 23:15:20 +0200

[Message part 1 (text/plain, inline)]

Vinicius Monego <monego <at> posteo.net> writes:

> * gnu/packages/audio.scm (libebur128): New variable.

[...]
  
> +    (arguments
> +     `(;; Tests require .wav files that are not distributed with the code.
> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
> +       #:tests? #f

It is easy to provide these data files using an (origin ...) in
native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
the terms of use first, as the data set is unrelated to this package.

(I don't really have a strong opinion here, just sayin')

> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"

Note: you can use #:build-type "Release" instead.  The default is
"RelWithDebInfo", so it's customary to add a comment when changing it.
Is there a particular reason to not provide debugging information here?

Otherwise the patch LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 43883 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Marius Bakke <marius <at> gnu.org>
Cc: 43883 <at> debbugs.gnu.org
Subject: Re: [bug#43883] [PATCH] gnu: Add libebur128.
Date: Thu, 15 Oct 2020 20:56:44 -0300

Marius Bakke writes:

> Vinicius Monego <monego <at> posteo.net> writes:
>
>> * gnu/packages/audio.scm (libebur128): New variable.
>
> [...]
>   
>> +    (arguments
>> +     `(;; Tests require .wav files that are not distributed with the code.
>> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
>> +       #:tests? #f
>
> It is easy to provide these data files using an (origin ...) in
> native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
> the terms of use first, as the data set is unrelated to this package.
>
> (I don't really have a strong opinion here, just sayin')
>

I had a look at the terms (link provided in the issue referenced above)
and commercial usage is forbidden, making the audio files nonfree. Also, the
zip file weighs 87 MB.

>> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>
> Note: you can use #:build-type "Release" instead.  The default is
> "RelWithDebInfo", so it's customary to add a comment when changing it.
> Is there a particular reason to not provide debugging information here?

Oh, I wasn't aware of #:build-type. Thanks.

I remove debugging information to save space. The ideal case is to move
it to a separate output as in

https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html

, but that is something I have yet to take a look at.

I will enable it again in the v2 and add a comment about the data.

Message #14 received at 43883 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 43883 <at> debbugs.gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH v2] gnu: Add libebur128.
Date: Fri, 16 Oct 2020 11:21:43 -0300

* gnu/packages/audio.scm (libebur128): New variable.
---
Changed comment about why tests are disabled and build with debug information.

 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 0e93a7263e..5bdbec40a2 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3060,6 +3060,32 @@ that toolkit will work in all hosts that use Suil automatically.
 Suil currently supports every combination of Gtk, Qt, and X11.")
     (license license:isc)))
 
+(define-public libebur128
+  (package
+    (name "libebur128")
+    (version "1.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jiixyj/libebur128")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0n81rnm8dm1zmibkr2v3q79rsd609y0dbbsrbay18njcjva88p0g"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(;; Tests require proprietary .wav files. See
+       ;; https://github.com/jiixyj/libebur128/issues/82.
+       #:tests? #f
+       #:configure-flags '("-DBUILD_STATIC_LIBS=OFF")))
+    (home-page "https://github.com/jiixyj/libebur128")
+    (synopsis "Library implementing the EBU R 128 loudness standard")
+    (description
+     "@code{libebur128} is a C library that implements the EBU R 128 standard
+for loudness normalisation.")
+    (license license:expat)))
+
 (define-public timidity++
   (package
     (name "timidity++")
-- 
2.20.1

Message #19 received at 43883-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 43883-done <at> debbugs.gnu.org
Subject: Re: [bug#43883] [PATCH] gnu: Add libebur128.
Date: Sun, 18 Oct 2020 23:59:38 +0200

[Message part 1 (text/plain, inline)]

Vinicius Monego <monego <at> posteo.net> writes:

> Marius Bakke writes:
>
>> Vinicius Monego <monego <at> posteo.net> writes:
>>
>>> * gnu/packages/audio.scm (libebur128): New variable.
>>
>> [...]
>>   
>>> +    (arguments
>>> +     `(;; Tests require .wav files that are not distributed with the code.
>>> +       ;; See https://github.com/jiixyj/libebur128/issues/82.
>>> +       #:tests? #f
>>
>> It is easy to provide these data files using an (origin ...) in
>> native-inputs, like e.g. 'json-modern-cxx'.  Obviously we should check
>> the terms of use first, as the data set is unrelated to this package.
>>
>> (I don't really have a strong opinion here, just sayin')
>>
>
> I had a look at the terms (link provided in the issue referenced above)
> and commercial usage is forbidden, making the audio files nonfree. Also, the
> zip file weighs 87 MB.

Oh, thanks for checking, too bad.

>>> +       #:configure-flags '("-DCMAKE_BUILD_TYPE=Release"
>>
>> Note: you can use #:build-type "Release" instead.  The default is
>> "RelWithDebInfo", so it's customary to add a comment when changing it.
>> Is there a particular reason to not provide debugging information here?
>
> Oh, I wasn't aware of #:build-type. Thanks.
>
> I remove debugging information to save space. The ideal case is to move
> it to a separate output as in
>
> https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html
>
> , but that is something I have yet to take a look at.
>
> I will enable it again in the v2 and add a comment about the data.

Excellent, applied!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.