From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 0/2] Deduplicate package sets Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Oct 2020 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43881@debbugs.gnu.org Cc: Efraim Flashner X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160225083617189 (code B ref -1); Fri, 09 Oct 2020 13:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Oct 2020 13:40:36 +0000 Received: from localhost ([127.0.0.1]:34394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsdQ-0004TA-Cv for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:40:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:35248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsdN-0004T2-R9 for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:40:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQsdN-0001xs-JQ for guix-patches@gnu.org; Fri, 09 Oct 2020 09:40:33 -0400 Received: from flashner.co.il ([178.62.234.194]:40560) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQsdL-0000Zb-Qq for guix-patches@gnu.org; Fri, 09 Oct 2020 09:40:33 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id 484234014A; Fri, 9 Oct 2020 13:39:59 +0000 (UTC) From: Efraim Flashner Date: Fri, 9 Oct 2020 16:39:17 +0300 Message-Id: <20201009133917.26124-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 09:39:59 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I noticed that the installer has nano, zile and nvi, but %base-packages has nano and zile. I also saw that the installer also pulls in %base-packages and I figured it was a good time to do something about it. I moved nvi from the installer to %base-packages-interactive. I created %base-packages-disk-utils to work with disks/partitions/file-systems. Of the packages I removed from the installer which weren't already part of %base-packages: wpa-supplicant-minimal: wpa-supplicant already provided by the wpa-supplicant-service-type. openssh: Already provided by the openssh-service-type. I figure it's worth asking: should we be using wpa-supplicant-minimal and openssh-sans-x for their services in the installer? Actually, looking at the openssh-service-type I don't see it documented in the manual a field to use a different openssh package. Efraim Flashner (2): system: Add %base-packages-disk-utils. install: Deduplicate packages with %base-package sets. gnu/system.scm | 38 +++++++++++++++++++++++++++++--------- gnu/system/install.scm | 37 ++++++++++--------------------------- 2 files changed, 39 insertions(+), 36 deletions(-) -- 2.28.0 From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils. References: <20201009133917.26124-1-efraim@flashner.co.il> In-Reply-To: <20201009133917.26124-1-efraim@flashner.co.il> Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Oct 2020 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43881@debbugs.gnu.org Cc: Efraim Flashner Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.160225101517482 (code B ref 43881); Fri, 09 Oct 2020 13:44:01 +0000 Received: (at 43881) by debbugs.gnu.org; 9 Oct 2020 13:43:35 +0000 Received: from localhost ([127.0.0.1]:34399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsgI-0004Xu-Qy for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:43:35 -0400 Received: from flashner.co.il ([178.62.234.194]:41752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsgH-0004Xg-14 for 43881@debbugs.gnu.org; Fri, 09 Oct 2020 09:43:33 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id C19134014A; Fri, 9 Oct 2020 13:43:26 +0000 (UTC) From: Efraim Flashner Date: Fri, 9 Oct 2020 16:42:52 +0300 Message-Id: <20201009134253.26375-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system.scm (%base-packages-disk-utils): New variable. --- gnu/system.scm | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index 3f4a0065d0..b10e94b95b 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2020 Florian Pelz ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright © 2020 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -38,24 +39,27 @@ #:use-module ((guix utils) #:select (substitute-keyword-arguments)) #:use-module (guix i18n) #:use-module (guix diagnostics) + #:use-module (gnu packages admin) #:use-module (gnu packages base) #:use-module (gnu packages bash) + #:use-module (gnu packages compression) #:use-module (gnu packages cross-base) + #:use-module (gnu packages cryptsetup) + #:use-module (gnu packages disk) + #:use-module (gnu packages file-systems) + #:use-module (gnu packages firmware) + #:use-module (gnu packages gawk) #:use-module (gnu packages guile) #:use-module (gnu packages guile-xyz) - #:use-module (gnu packages admin) #:use-module (gnu packages hurd) - #:use-module (gnu packages linux) - #:use-module (gnu packages pciutils) - #:use-module (gnu packages package-management) #:use-module (gnu packages less) - #:use-module (gnu packages zile) - #:use-module (gnu packages nano) - #:use-module (gnu packages gawk) + #:use-module (gnu packages linux) #:use-module (gnu packages man) + #:use-module (gnu packages nano) + #:use-module (gnu packages package-management) + #:use-module (gnu packages pciutils) #:use-module (gnu packages texinfo) - #:use-module (gnu packages compression) - #:use-module (gnu packages firmware) + #:use-module (gnu packages zile) #:use-module (gnu services) #:use-module (gnu services shepherd) #:use-module (gnu services base) @@ -159,6 +163,7 @@ %base-packages-interactive %base-packages-linux %base-packages-networking + %base-packages-disk-utils %base-packages-utils %base-firmware %default-kernel-arguments)) @@ -726,6 +731,19 @@ of PROVENANCE-SERVICE-TYPE to its services." ;; many people are familiar with, so keep it around. iw wireless-tools)) +(define %base-packages-disk-utils + ;; A well-rounded set of packages for interacting with disks, partitions + ;; and filesystems. + (list parted gptfdisk ddrescue + ;; We used to provide fdisk from GNU fdisk, but as of version 2.0.0a + ;; it pulls Guile 1.8, which takes unreasonable space; furthermore + ;; util-linux's fdisk is already available, in %base-packages-linux. + cryptsetup mdadm + dosfstools + btrfs-progs + f2fs-tools + jfsutils)) + (define %base-packages ;; Default set of packages globally visible. It should include anything ;; required for basic administrator tasks. -- 2.28.0 From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Oct 2020 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43881@debbugs.gnu.org Cc: Efraim Flashner Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.160225112617686 (code B ref 43881); Fri, 09 Oct 2020 13:46:02 +0000 Received: (at 43881) by debbugs.gnu.org; 9 Oct 2020 13:45:26 +0000 Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsi6-0004bC-Bl for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:45:26 -0400 Received: from flashner.co.il ([178.62.234.194]:41762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsi2-0004au-Id for 43881@debbugs.gnu.org; Fri, 09 Oct 2020 09:45:24 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id B0BF2403D2; Fri, 9 Oct 2020 13:45:16 +0000 (UTC) From: Efraim Flashner Date: Fri, 9 Oct 2020 16:42:53 +0300 Message-Id: <20201009134253.26375-2-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201009134253.26375-1-efraim@flashner.co.il> References: <20201009134253.26375-1-efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system.scm (%base-packages-interactive): Add nvi. * gnu/system/install.scm (installation-os)[packages]: Remove parted, gptfdisk, ddrescue, cryptsetup, mdadm, dosfstools, btrfs-progs, f2fs-tools, jfstools, openssh, wireless-tools, iw, wpa-supplicant-minimal, iproute, bash-completion, nvi. Replace glibc with the canonical-package of glibc. Add %base-packages-disk-utils. remove wpa-supplicant-minimal replace glibc with canonical-pacakge glibc --- gnu/system.scm | 2 ++ gnu/system/install.scm | 37 ++++++++++--------------------------- 2 files changed, 12 insertions(+), 27 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index b10e94b95b..3bc89e0a31 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -56,6 +56,7 @@ #:use-module (gnu packages linux) #:use-module (gnu packages man) #:use-module (gnu packages nano) + #:use-module (gnu packages nvi) #:use-module (gnu packages package-management) #:use-module (gnu packages pciutils) #:use-module (gnu packages texinfo) @@ -713,6 +714,7 @@ of PROVENANCE-SERVICE-TYPE to its services." (define %base-packages-interactive ;; Default set of common interactive packages. (list less zile nano + nvi man-db info-reader ;the standalone Info reader (no Perl) bash-completion diff --git a/gnu/system/install.scm b/gnu/system/install.scm index be5a678cec..0af9e2993d 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2017 Marius Bakke ;;; Copyright © 2017, 2019 Tobias Geerinckx-Rice ;;; Copyright © 2020 Florian Pelz +;;; Copyright © 2020 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -41,18 +42,13 @@ #:use-module (gnu packages bash) #:use-module (gnu packages bootloaders) #:use-module (gnu packages certs) - #:use-module (gnu packages file-systems) + #:use-module (gnu packages compression) #:use-module (gnu packages fonts) #:use-module (gnu packages fontutils) #:use-module (gnu packages guile) #:use-module (gnu packages linux) - #:use-module (gnu packages ssh) - #:use-module (gnu packages cryptsetup) #:use-module (gnu packages package-management) - #:use-module (gnu packages disk) #:use-module (gnu packages texinfo) - #:use-module (gnu packages compression) - #:use-module (gnu packages nvi) #:use-module (gnu packages xorg) #:use-module (ice-9 match) #:use-module (srfi srfi-26) @@ -490,27 +486,14 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m ;; Explicitly allow for empty passwords. (base-pam-services #:allow-empty-passwords? #t)) - (packages (cons* glibc ;for 'tzselect' & co. - parted gptfdisk ddrescue - fontconfig - font-dejavu font-gnu-unifont - grub ;mostly so xrefs to its manual work - cryptsetup - mdadm - dosfstools ;mkfs.fat, for the UEFI boot partition - btrfs-progs - f2fs-tools - jfsutils - openssh ;we already have sshd, having ssh/scp can help - wireless-tools iw wpa-supplicant-minimal iproute - ;; XXX: We used to have GNU fdisk here, but as of version - ;; 2.0.0a, that pulls Guile 1.8, which takes unreasonable - ;; space; furthermore util-linux's fdisk is already - ;; available here, so we keep that. - bash-completion - nvi ;:wq! - nss-certs ; To access HTTPS, use git, etc. - %base-packages)))) + (packages (append + (list (canonical-package glibc) ; for 'tzselect' & co. + fontconfig + font-dejavu font-gnu-unifont + grub ; mostly so xrefs to its manual work + nss-certs) ; To access HTTPS, use git, etc. + %base-packages-disk-utils + %base-packages)))) (define* (os-with-u-boot os board #:key (bootloader-target "/dev/mmcblk0") (triplet "arm-linux-gnueabihf")) -- 2.28.0 From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026670402751 (code B ref 43881); Wed, 14 Oct 2020 09:18:01 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:17:20 +0000 Received: from localhost ([127.0.0.1]:50060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScuO-0000iJ-83 for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:17:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScuK-0000i0-P8 for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:17:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54892) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kScuF-0006A1-7d; Wed, 14 Oct 2020 05:17:11 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60214 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kScuE-0007ZC-My; Wed, 14 Oct 2020 05:17:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201009133917.26124-1-efraim@flashner.co.il> <20201009134253.26375-1-efraim@flashner.co.il> Date: Wed, 14 Oct 2020 11:17:08 +0200 In-Reply-To: <20201009134253.26375-1-efraim@flashner.co.il> (Efraim Flashner's message of "Fri, 9 Oct 2020 16:42:52 +0300") Message-ID: <87lfg9f9pn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Efraim Flashner skribis: > * gnu/system.scm (%base-packages-disk-utils): New variable. [...] > #:use-module (guix diagnostics) > + #:use-module (gnu packages admin) > #:use-module (gnu packages base) > #:use-module (gnu packages bash) > + #:use-module (gnu packages compression) > #:use-module (gnu packages cross-base) > + #:use-module (gnu packages cryptsetup) > + #:use-module (gnu packages disk) > + #:use-module (gnu packages file-systems) > + #:use-module (gnu packages firmware) > + #:use-module (gnu packages gawk) > #:use-module (gnu packages guile) > #:use-module (gnu packages guile-xyz) > - #:use-module (gnu packages admin) > #:use-module (gnu packages hurd) > - #:use-module (gnu packages linux) > - #:use-module (gnu packages pciutils) > - #:use-module (gnu packages package-management) > #:use-module (gnu packages less) > - #:use-module (gnu packages zile) > - #:use-module (gnu packages nano) > - #:use-module (gnu packages gawk) > + #:use-module (gnu packages linux) > #:use-module (gnu packages man) > + #:use-module (gnu packages nano) > + #:use-module (gnu packages package-management) > + #:use-module (gnu packages pciutils) > #:use-module (gnu packages texinfo) > - #:use-module (gnu packages compression) > - #:use-module (gnu packages firmware) > + #:use-module (gnu packages zile) > #:use-module (gnu services) > #:use-module (gnu services shepherd) > #:use-module (gnu services base) Does it pull new modules or just reorder them? If the latter, fine with me! > @@ -159,6 +163,7 @@ > %base-packages-interactive > %base-packages-linux > %base-packages-networking > + %base-packages-disk-utils > %base-packages-utils Now there=E2=80=99s a precedent but I think we should have written =E2=80= =9Cutilities=E2=80=9D for consistency with the rest of the code base. Maybe you can do that here and then we can deprecate =E2=80=98%base-packages-utils=E2=80=99 in favor of =E2=80=98%base-package-u= tilities=E2=80=99. Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026671552930 (code B ref 43881); Wed, 14 Oct 2020 09:20:02 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:19:15 +0000 Received: from localhost ([127.0.0.1]:50064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScwE-0000lB-Ks for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:19:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScwC-0000ky-V1 for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:19:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54910) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kScw7-0006KQ-On; Wed, 14 Oct 2020 05:19:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kScw6-0007hG-Bh; Wed, 14 Oct 2020 05:19:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201009134253.26375-1-efraim@flashner.co.il> <20201009134253.26375-2-efraim@flashner.co.il> Date: Wed, 14 Oct 2020 11:19:05 +0200 In-Reply-To: <20201009134253.26375-2-efraim@flashner.co.il> (Efraim Flashner's message of "Fri, 9 Oct 2020 16:42:53 +0300") Message-ID: <87ft6hf9me.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner skribis: > * gnu/system.scm (%base-packages-interactive): Add nvi. > * gnu/system/install.scm (installation-os)[packages]: Remove parted, > gptfdisk, ddrescue, cryptsetup, mdadm, dosfstools, btrfs-progs, > f2fs-tools, jfstools, openssh, wireless-tools, iw, > wpa-supplicant-minimal, iproute, bash-completion, nvi. Replace glibc > with the canonical-package of glibc. Add %base-packages-disk-utils. > > remove wpa-supplicant-minimal > replace glibc with canonical-pacakge glibc These two lines are a leftover? I think we want to keep =E2=80=98wpa-supplicant-minimal=E2=80=99 and keep = =E2=80=98glibc=E2=80=99, not the canonical-package variant (it would prevent cross-compilation). Apart from that, if that leaves the package set unchanged, LGTM! Ludo=E2=80=99. From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026673343230 (code B ref 43881); Wed, 14 Oct 2020 09:23:01 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:22:14 +0000 Received: from localhost ([127.0.0.1]:50069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScz7-0000q1-4U for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:22:14 -0400 Received: from flashner.co.il ([178.62.234.194]:54866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScz5-0000po-EI for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:22:12 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id A39A940300; Wed, 14 Oct 2020 09:22:05 +0000 (UTC) Date: Wed, 14 Oct 2020 12:21:33 +0300 From: Efraim Flashner Message-ID: <20201014092133.GB16635@E5400> References: <20201009133917.26124-1-efraim@flashner.co.il> <20201009134253.26375-1-efraim@flashner.co.il> <87lfg9f9pn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <87lfg9f9pn.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 11:17:08AM +0200, Ludovic Court=C3=A8s wrote: > Hi! >=20 > Efraim Flashner skribis: >=20 > > * gnu/system.scm (%base-packages-disk-utils): New variable. >=20 >=20 > [...] >=20 > > #:use-module (guix diagnostics) > > + #:use-module (gnu packages admin) > > #:use-module (gnu packages base) > > #:use-module (gnu packages bash) > > + #:use-module (gnu packages compression) > > #:use-module (gnu packages cross-base) > > + #:use-module (gnu packages cryptsetup) > > + #:use-module (gnu packages disk) > > + #:use-module (gnu packages file-systems) > > + #:use-module (gnu packages firmware) > > + #:use-module (gnu packages gawk) > > #:use-module (gnu packages guile) > > #:use-module (gnu packages guile-xyz) > > - #:use-module (gnu packages admin) > > #:use-module (gnu packages hurd) > > - #:use-module (gnu packages linux) > > - #:use-module (gnu packages pciutils) > > - #:use-module (gnu packages package-management) > > #:use-module (gnu packages less) > > - #:use-module (gnu packages zile) > > - #:use-module (gnu packages nano) > > - #:use-module (gnu packages gawk) > > + #:use-module (gnu packages linux) > > #:use-module (gnu packages man) > > + #:use-module (gnu packages nano) > > + #:use-module (gnu packages package-management) > > + #:use-module (gnu packages pciutils) > > #:use-module (gnu packages texinfo) > > - #:use-module (gnu packages compression) > > - #:use-module (gnu packages firmware) > > + #:use-module (gnu packages zile) > > #:use-module (gnu services) > > #:use-module (gnu services shepherd) > > #:use-module (gnu services base) >=20 > Does it pull new modules or just reorder them? If the latter, fine with = me! It reorders them and adds cryptsetup, disk and file-systems. > > @@ -159,6 +163,7 @@ > > %base-packages-interactive > > %base-packages-linux > > %base-packages-networking > > + %base-packages-disk-utils > > %base-packages-utils >=20 > Now there=E2=80=99s a precedent but I think we should have written =E2=80= =9Cutilities=E2=80=9D > for consistency with the rest of the code base. >=20 > Maybe you can do that here and then we can deprecate > =E2=80=98%base-packages-utils=E2=80=99 in favor of =E2=80=98%base-package= -utilities=E2=80=99. +1 for utilities over utils > Thanks, > Ludo=E2=80=99. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+GwxoACgkQQarn3Mo9 g1GNQw/8Ce0YM/Z98WFaHdocFayfsOwEsCUVZGoWXJ4EZmlONk9HHm9GHXgHmOcE SqTYRcxMPffyBml2XyWcqZriuViKD6DS2WaLslDUUhZOxPFlQPxcYZnomai6Zl9Y 6T+gIDEmw7awkiYRe8r+0xzevjCZBsNX8bqB6+zt7pT4fmSDh+x4MOzbWjwtEk65 bdE6aAzTtlWI7f2Rpl9wcYI/dkMJ41mrGPn7hJm4Jd5nlHUpobB+qXA7tzPuZfv5 jwbXeNPDB0wzp1KaYpBWnIyyTmC2VktdBRGkVGPTm/uuk1JB8CKGLCVKvyhoG/PV vDtnZI9bfJuC6Ymo8ZwrpD99RVqA5KH5mv6vg+kVDupxU8Xn4S7hEofDmwEiif+j /1iZMVyaKGXzjbTywc5ZPhyotFx46keFFNSvoycQSRj05G31cYqmp8zLLQSZHU9s 1trWWAX+4pard7lcjQCgZjJ1P3wJJ8BUEqkThyu4aFkkFc3BvGorckjDOk7fOQGk NCppVqBJiuStyvL4m3aWHYlxyIKl+dmvRVhp5pNUi0ql6gixICZAq4pdwOgCQgiJ sXX0QgIhHi5Gw/pGquA3YLLqirxSuSQWLntye2a1deUPq/xBWAomvlPy279+Wkgp IEP0Lnq+vgNAWTYHOIYSo0fwDqIE/GYs9WUmC4Lf3V4Jq2A62eQ= =sZid -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML-- From unknown Sun Jun 22 17:17:49 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026675253564 (code B ref 43881); Wed, 14 Oct 2020 09:26:01 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:25:25 +0000 Received: from localhost ([127.0.0.1]:50079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSd2C-0000vQ-Jf for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:25:24 -0400 Received: from flashner.co.il ([178.62.234.194]:54894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSd2B-0000vD-6D for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:25:23 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id 4D0954014A; Wed, 14 Oct 2020 09:25:17 +0000 (UTC) Date: Wed, 14 Oct 2020 12:24:44 +0300 From: Efraim Flashner Message-ID: <20201014092444.GC16635@E5400> References: <20201009134253.26375-1-efraim@flashner.co.il> <20201009134253.26375-2-efraim@flashner.co.il> <87ft6hf9me.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <87ft6hf9me.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 11:19:05AM +0200, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > * gnu/system.scm (%base-packages-interactive): Add nvi. > > * gnu/system/install.scm (installation-os)[packages]: Remove parted, > > gptfdisk, ddrescue, cryptsetup, mdadm, dosfstools, btrfs-progs, > > f2fs-tools, jfstools, openssh, wireless-tools, iw, > > wpa-supplicant-minimal, iproute, bash-completion, nvi. Replace glibc > > with the canonical-package of glibc. Add %base-packages-disk-utils. > > > > remove wpa-supplicant-minimal > > replace glibc with canonical-pacakge glibc >=20 > These two lines are a leftover? Looks like they're a leftover from squashing two commits. Especially looking at my typo for package. > I think we want to keep =E2=80=98wpa-supplicant-minimal=E2=80=99 and keep= =E2=80=98glibc=E2=80=99, not > the canonical-package variant (it would prevent cross-compilation). We should already have wpa-supplicant available from the wpa-supplicant-service-type. Understood about the canonical-package bit. > Apart from that, if that leaves the package set unchanged, LGTM! >=20 > Ludo=E2=80=99. Thanks for the review. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+Gw9wACgkQQarn3Mo9 g1Gx7xAAiQD4Cpri1d1WE0d6z4eMrBmFUIkLz12EipOlGsBCi/ZJj72SNB1yomzA rUxqMktwXLlLsqSDL7XkP4HkkYYeRlBEuzIhiCD7pEq+Z4hy0EoIBCA5CTCi0cox loicW20AL7ZnCQOgbOlgp/tsybdsKVtj9pHxllauGGK8DriC/PD07dLafP2nNw7C bF28ahyjThBCvQYVx6qX/jJQ3MGg1slhBLRXcmJYzXAqstE/MLXj6LoN7VaGJwEV NlF89MoVdNJesFKL/y4sH4mwfRXf1gIVZ0RyC1S3Wx9utmZl/IZ4RqEWNUG6B4ZE oHURZKpmwnrqNWL5lVPx+9nOH14idCy480aptQFAwhecNjRpaPxN/5CFcwQR1MtT UiXYAYg4eupMqFh/EClWyfGX7sz0pHQ/R6Jb8a7+Z1M8g9zV1jtgC7z7YzvlbQM2 iaweyouxHFz96J2jEH6eKPEAt/j5jmj6Qp+UA8JTA64HCPoGjRz+tgxf7VqX4uqJ aZrGPVNo68+Jwqr6Xkt+XYTdW4M6PXBClRFrvpLCJLsZwXil4+5WtW0SEB4R4kTG pDf73+TaDKzV/iuCnyUJ17bTu8ms4zpLHVDAohuyyjevvmTJWA7s9bxgdjYDEHyj rAuHvWUmoTaBK4jvAEml9Ncj47GY0FlGxk7CfJStWK8QevyicbY= =hP3l -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn-- From unknown Sun Jun 22 17:17:49 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Efraim Flashner Subject: bug#43881: closed (Re: [PATCH 1/2] system: Add %base-packages-disk-utils.) Message-ID: References: <20201015075551.GE1237@E5400> <20201009133917.26124-1-efraim@flashner.co.il> X-Gnu-PR-Message: they-closed 43881 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43881@debbugs.gnu.org Date: Thu, 15 Oct 2020 07:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1602748622-30021-1" This is a multi-part message in MIME format... ------------=_1602748622-30021-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43881: [PATCH 0/2] Deduplicate package sets which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43881@debbugs.gnu.org. --=20 43881: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43881 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1602748622-30021-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43881-done) by debbugs.gnu.org; 15 Oct 2020 07:56:34 +0000 Received: from localhost ([127.0.0.1]:54106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy7l-0007n1-Tj for submit@debbugs.gnu.org; Thu, 15 Oct 2020 03:56:34 -0400 Received: from flashner.co.il ([178.62.234.194]:35278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSy7k-0007mn-UN for 43881-done@debbugs.gnu.org; Thu, 15 Oct 2020 03:56:33 -0400 Received: from localhost (unknown [141.226.13.8]) by flashner.co.il (Postfix) with ESMTPSA id 2A9FB401E5 for <43881-done@debbugs.gnu.org>; Thu, 15 Oct 2020 07:56:25 +0000 (UTC) Date: Thu, 15 Oct 2020 10:55:51 +0300 From: Efraim Flashner To: 43881-done@debbugs.gnu.org Subject: Re: [PATCH 1/2] system: Add %base-packages-disk-utils. Message-ID: <20201015075551.GE1237@E5400> References: <20201009134253.26375-1-efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n+lFg1Zro7sl44OB" Content-Disposition: inline In-Reply-To: <20201009134253.26375-1-efraim@flashner.co.il> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43881-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --n+lFg1Zro7sl44OB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patches pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --n+lFg1Zro7sl44OB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+IAIYACgkQQarn3Mo9 g1F/ZRAAw0GOAN4rDuFClAzKaUyYK2vj787wLrCMtSIB3NYpp43HBaJT3pG4IfeS kyT0YcgGl86Fa9nTPrluRyLSH+r5WUGLG89/S4ZLR7yiYGaC1k3/T+Loon98BqUB ibvNN8HZ6gG1fwfXsRbd3IY0SZvyYf6S4HiU5TIywQb81N0a/B2fo1QxI+c3T9Ga Zl8pGklMgiqCFNensA8Q3x0cq6VfZsiNAho8xBAkbtpLesLEK6ICLuG9pT0aWDee tYKHJ0+pe12GZNeWWA3+ADcrRmFhQdxpwT5Dcbn1YoDD4xKWgKZuylzqklod2pyi 3HpIvkexKRchy48l/C34hZMUDENbLoD7XtwIdQUqPjHK8mknOT7FWOomKjMxfvPf YdghJjMJwkWMKd159jT9mRGMUJcagXXp0xyRl9RvpX0tZU+w8i6bmKey/Osbd5Sc 4X119BEriI79cl+Uag9fMTFL8X74s9vDgoIBLNwMFmgrXRykPvhJweo9hUxLo8mO zdzXKsZo+pA5yBjBE5E9c665H9vvm9eVcl0rvojU4eYjINHtmpCCE34hyBTHA9yL 9SanEapA2G0viLq+teu+hEyIif0/Rd3bYL1KgaJkzaZsUx/1fUFBcHEdIh/Ettjz rdyZBgXLiz7Xjj3CfAnp+uSH9YEi8wPYmq7RqBfIV1v1xnzGfmU= =WBgR -----END PGP SIGNATURE----- --n+lFg1Zro7sl44OB-- ------------=_1602748622-30021-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Oct 2020 13:40:36 +0000 Received: from localhost ([127.0.0.1]:34394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsdQ-0004TA-Cv for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:40:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:35248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQsdN-0004T2-R9 for submit@debbugs.gnu.org; Fri, 09 Oct 2020 09:40:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQsdN-0001xs-JQ for guix-patches@gnu.org; Fri, 09 Oct 2020 09:40:33 -0400 Received: from flashner.co.il ([178.62.234.194]:40560) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQsdL-0000Zb-Qq for guix-patches@gnu.org; Fri, 09 Oct 2020 09:40:33 -0400 Received: from localhost (unknown [141.226.15.20]) by flashner.co.il (Postfix) with ESMTPSA id 484234014A; Fri, 9 Oct 2020 13:39:59 +0000 (UTC) From: Efraim Flashner To: guix-patches@gnu.org Subject: [PATCH 0/2] Deduplicate package sets Date: Fri, 9 Oct 2020 16:39:17 +0300 Message-Id: <20201009133917.26124-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/09 09:39:59 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I noticed that the installer has nano, zile and nvi, but %base-packages has nano and zile. I also saw that the installer also pulls in %base-packages and I figured it was a good time to do something about it. I moved nvi from the installer to %base-packages-interactive. I created %base-packages-disk-utils to work with disks/partitions/file-systems. Of the packages I removed from the installer which weren't already part of %base-packages: wpa-supplicant-minimal: wpa-supplicant already provided by the wpa-supplicant-service-type. openssh: Already provided by the openssh-service-type. I figure it's worth asking: should we be using wpa-supplicant-minimal and openssh-sans-x for their services in the installer? Actually, looking at the openssh-service-type I don't see it documented in the manual a field to use a different openssh package. Efraim Flashner (2): system: Add %base-packages-disk-utils. install: Deduplicate packages with %base-package sets. gnu/system.scm | 38 +++++++++++++++++++++++++++++--------- gnu/system/install.scm | 37 ++++++++++--------------------------- 2 files changed, 39 insertions(+), 36 deletions(-) -- 2.28.0 ------------=_1602748622-30021-1--