From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 08 21:40:09 2020 Received: (at submit) by debbugs.gnu.org; 9 Oct 2020 01:40:09 +0000 Received: from localhost ([127.0.0.1]:33548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQhOD-0000rE-8G for submit@debbugs.gnu.org; Thu, 08 Oct 2020 21:40:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:45350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQhOB-0000r7-Hq for submit@debbugs.gnu.org; Thu, 08 Oct 2020 21:40:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQhOB-000893-95 for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2020 21:40:07 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:35730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQhO9-0002q9-BE for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2020 21:40:07 -0400 Received: by mail-pg1-x52d.google.com with SMTP id g29so5880245pgl.2 for ; Thu, 08 Oct 2020 18:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0kq0IYQ7sC5UlzDUUSZphSmo8UBRvw32jkrqZ8uBTXA=; b=hZSvhfyd6dgFe66iJ6niA9uaCpcBQ2pY653OAlmd3HF3ciydrX0Jx+I2oVtjJXtqgS I7eUp87bgpCumhoVp5qlB0uUVbwpfLTcAZlE7NtnL3LujVJOlpPe9/yMKziYiI+qcClR VoKvaYSSOlWkF4JPofX2hQDQtBrNs0nrTi8FJruoZiOyX/nRmyq+UGLUnpntfG4GCA3m CKKaoizCrp7wu0/a+CbVFj6KtRNp9bUIHorjhd2PZoVfHoH4e4gbzXocI2V1svO7j2zu 4WHYpkbajEDF+hhRg7Spg+Ziey4i0+dsOTJfms3rr+K1TN1PZbsTMROmfLkg32SDhcGd /GEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0kq0IYQ7sC5UlzDUUSZphSmo8UBRvw32jkrqZ8uBTXA=; b=hvaB7kX/1otwFkE0q996AJFVa2DzZeAOQPaFahWs9nAEBBLJUxi5M/r+PrIsvc7v7/ 9xA/dr1/ZocoKgcWTJFjDxoZ1m0iSx3jIEEtma6G4Ze2ncmss46Muv39KsCg76b1vJ3+ untivEKk8ZmQaiBeGTGysBmA8fYbxrtq3iEWs4arZ9WN2Aa7x6Sz/FJfXTj4ZP1YLDrJ zaABMYZT2EhoQNKUVARHFyBf8mb4e22SQRnLpEP7RPY9wZcj7wqj+nDG2skXrrAa11C9 eieOtJxCCnD10qeu79uTQo3aUy6m9H/fMgGmQnkwQMZuco5n5S3WG32e045Sfm6Rab8q KNRQ== X-Gm-Message-State: AOAM530KKnwaOWa0J3WVtvulX8aA6SvXdGRlE2c0EuhOveclOSv/uv5c fQcJhJncb9WDGgEo/82f0D+Bs1rDmtQ= X-Google-Smtp-Source: ABdhPJyDCsfPkrFMh/zGHhgDFp0cQ4lDkON7rtIMc/owiUxKBMu1YiRTNKiMmslKxpHgHcbkk28+Sg== X-Received: by 2002:a17:90a:9505:: with SMTP id t5mr1830188pjo.121.1602207601404; Thu, 08 Oct 2020 18:40:01 -0700 (PDT) Received: from muon.fritz.box (61-68-62-152.tpgi.com.au. [61.68.62.152]) by smtp.gmail.com with ESMTPSA id g4sm8812881pgg.75.2020.10.08.18.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 18:40:00 -0700 (PDT) From: Andrew Whatson To: bug-gnu-emacs@gnu.org Subject: feature/native-comp; Fix another failure when eln-cache is removed Date: Fri, 9 Oct 2020 11:38:09 +1000 Message-Id: <20201009013808.3450325-1-whatson@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=whatson@gmail.com; helo=mail-pg1-x52d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Andrew Whatson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * lisp/emacs-lisp/comp.el (comp-trampoline-compile): Fix typo in name. Attempt to create eln-cache directory before failing with writability error. Change error to be consistent. --- lisp/emacs-lisp/comp.el | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 763d44a23e..78f2ca696c 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -2580,7 +2580,7 @@ comp-search-trampoline when (file-exists-p filename) do (cl-return filename))) -(defun comp-tampoline-compile (subr-name) +(defun comp-trampoline-compile (subr-name) "Synthesize and compile a trampoline for SUBR-NAME and return its filename." (let ((trampoline-sym (comp-trampoline-sym subr-name)) (lambda-list (comp-make-lambda-list-from-subr @@ -2608,9 +2608,13 @@ comp-tampoline-compile (comp-trampoline-filename subr-name) (concat dir comp-native-version-dir)) - when (file-writable-p f) + when (or (file-writable-p f) + (unwind-protect + (progn + (make-directory (file-name-directory f) t) + t))) do (cl-return f) - finally (error "Can't find a writable directory in \ + finally (error "Cannot find suitable directory for output in \ `comp-eln-load-path'"))))) ;;;###autoload @@ -2621,7 +2625,7 @@ comp-subr-trampoline-install (let ((trampoline-sym (comp-trampoline-sym subr-name))) (cl-assert (subr-primitive-p (symbol-function subr-name))) (load (or (comp-search-trampoline subr-name) - (comp-tampoline-compile subr-name)) + (comp-trampoline-compile subr-name)) nil t) (cl-assert (subr-native-elisp-p (symbol-function trampoline-sym))) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 09 02:39:14 2020 Received: (at 43875) by debbugs.gnu.org; 9 Oct 2020 06:39:14 +0000 Received: from localhost ([127.0.0.1]:33978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQm3e-0006cv-J3 for submit@debbugs.gnu.org; Fri, 09 Oct 2020 02:39:14 -0400 Received: from mab.sdf.org ([205.166.94.33]:59780 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQm3d-0006cn-1S for 43875@debbugs.gnu.org; Fri, 09 Oct 2020 02:39:13 -0400 Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kQm3b-0004JS-M4; Fri, 09 Oct 2020 06:39:11 +0000 From: Andrea Corallo To: Andrew Whatson Subject: Re: bug#43875: feature/native-comp; Fix another failure when eln-cache is removed References: <20201009013808.3450325-1-whatson@gmail.com> Date: Fri, 09 Oct 2020 06:39:11 +0000 In-Reply-To: <20201009013808.3450325-1-whatson@gmail.com> (Andrew Whatson's message of "Fri, 9 Oct 2020 11:38:09 +1000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43875 Cc: 43875@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew Whatson writes: > * lisp/emacs-lisp/comp.el (comp-trampoline-compile): Fix typo in > name. Attempt to create eln-cache directory before failing > with writability error. Change error to be consistent. Hi Andrew, thanks for the patch! Could you remind me if your copyright paperwork was already done? Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 09 03:51:50 2020 Received: (at 43875) by debbugs.gnu.org; 9 Oct 2020 07:51:50 +0000 Received: from localhost ([127.0.0.1]:34025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQnBt-000285-SP for submit@debbugs.gnu.org; Fri, 09 Oct 2020 03:51:50 -0400 Received: from mail-ua1-f54.google.com ([209.85.222.54]:43135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQnBp-00027o-No for 43875@debbugs.gnu.org; Fri, 09 Oct 2020 03:51:48 -0400 Received: by mail-ua1-f54.google.com with SMTP id r21so2766431uaw.10 for <43875@debbugs.gnu.org>; Fri, 09 Oct 2020 00:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QpRZWr1ZxQuChAX74GSfl2ea6tALCA2HEmo6mfCaJP0=; b=MaqNfghiqF1uNPg6A2ZTzkdagerCfdEaQ4ptdjjLcxQgvHONMTTdfceRh/QrCo0QKd RM86hT/4DQgpxabpynCL3/ijRGdm0tRvuaSRere4kQJnn+I2bvMrjv6t4k6prz35xBgH muqatf4UnOZa3+NPUEWkZ1vIwTnIoNhsns6+UFivrmPds1+1hgNIhS+1yWRk6AFPKtp4 BsDwTb8ji7jnMXCB/0VsuCGdQEXJMP5ZEG8s65DNeObonuolUK+1+P5L2O0p5SNT4yj4 zSVGcgeUaz31GMB1Jc7P2D7Rj8q/3Fikt6KiISwy8MGntBJsKOpfcPQMTUrhi+G96k/U V6JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QpRZWr1ZxQuChAX74GSfl2ea6tALCA2HEmo6mfCaJP0=; b=e0bH2An9jdJz6gdNV+pOUE9utU+9AZX7wNGas/s0faM0UFuyY6EyqupzHbIrhppDuK yBo9jq/VnY/LY8PLhsaUS89GhfFgqkK3MEcJ5QufEj/24un4FI8fS8Ny95F6liMkSIPd Kpl8Ss0vJEkGq09bqcflfnQmawxHsGounqi7wKFGjJJ4Q8HaOvJJ+hvaCFAc0T8fUVhH 3/iPRu/06a1/KqosumRqekK1fX46XYWBk4sYSNgsq0VG53mcfJsGFkJYM3AGSHcGLYZq LonMFEYI1LZ9yTbIDYZFjHX6LNl6SsNCS+VpPdyrs7wW0YZxSz+l7eqkGqwT4N/PI1jT 54vQ== X-Gm-Message-State: AOAM532FGKt5SoWfanKb+oCtjaaFZ2fexPrP8BXTES/LK3O/clQLe32o n75L0LjkNQn0ek15+o4V/89bw7/dot6Fbdevq5I1zmPP X-Google-Smtp-Source: ABdhPJxQZcoMZceN6mjVxGnVvt31+VpuuBSltR5GVlyubjB1lQM0sN1xIZ48wAA8WdsoiJMyBhlFfqkOgOr4Oc9CbkI= X-Received: by 2002:ab0:5b86:: with SMTP id y6mr7241035uae.101.1602229900130; Fri, 09 Oct 2020 00:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20201009013808.3450325-1-whatson@gmail.com> In-Reply-To: From: Andrew Whatson Date: Fri, 9 Oct 2020 17:51:29 +1000 Message-ID: Subject: Re: bug#43875: feature/native-comp; Fix another failure when eln-cache is removed To: Andrea Corallo Content-Type: multipart/alternative; boundary="0000000000000bbb1805b1383843" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43875 Cc: 43875@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000bbb1805b1383843 Content-Type: text/plain; charset="UTF-8" Yep it's all sorted! On Fri, 9 Oct 2020, 4:39 pm Andrea Corallo, wrote: > Andrew Whatson writes: > > > * lisp/emacs-lisp/comp.el (comp-trampoline-compile): Fix typo in > > name. Attempt to create eln-cache directory before failing > > with writability error. Change error to be consistent. > > Hi Andrew, > > thanks for the patch! > > Could you remind me if your copyright paperwork was already done? > > Thanks > > Andrea > --0000000000000bbb1805b1383843 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yep it's all sorted!

On Fri, 9 Oct 2020, 4:39 pm Andre= a Corallo, <akrl@sdf.org> wrote:<= br>
Andrew Whatson <whatson@gmail.com= > writes:

>=C2=A0 =C2=A0 =C2=A0 =C2=A0* lisp/emacs-lisp/comp.el (comp-trampoline-c= ompile): Fix typo in
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0name.=C2=A0 Attempt to create eln-cac= he directory before failing
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0with writability error.=C2=A0 Change = error to be consistent.

Hi Andrew,

thanks for the patch!

Could you remind me if your copyright paperwork was already done?

Thanks

=C2=A0 Andrea
--0000000000000bbb1805b1383843-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 10 04:45:15 2020 Received: (at 43875-done) by debbugs.gnu.org; 10 Oct 2020 08:45:15 +0000 Received: from localhost ([127.0.0.1]:36868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRAV8-0003Eb-Q3 for submit@debbugs.gnu.org; Sat, 10 Oct 2020 04:45:14 -0400 Received: from mab.sdf.org ([205.166.94.33]:41834 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRAV5-0003ER-Ok for 43875-done@debbugs.gnu.org; Sat, 10 Oct 2020 04:45:13 -0400 Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kRAV3-0001Gc-Lf; Sat, 10 Oct 2020 08:45:09 +0000 From: Andrea Corallo To: Andrew Whatson Subject: Re: bug#43875: feature/native-comp; Fix another failure when eln-cache is removed References: <20201009013808.3450325-1-whatson@gmail.com> Date: Sat, 10 Oct 2020 08:45:09 +0000 In-Reply-To: (Andrew Whatson's message of "Fri, 9 Oct 2020 17:51:29 +1000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43875-done Cc: 43875-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew Whatson writes: > Yep it's all sorted! Wonderful! I've applied the patch as for the part related to the typo fix and making the error homogeneous (85450f03be). I've made a slightly different one (138990bbda) to address the problem of the missing directory as it looks more correct to me (unwind-protect would have not prevented the error to be catch-ed). I've test it, as it works for me I'm closing. Thanks for looking into this and submitting the patch! Andrea From unknown Sun Jun 22 08:10:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator