GNU bug report logs - #43873
[PATCH 0/3] gnu: Add rust-dialoguer.

Previous Next

Package: guix-patches;

Reported by: André Batista <nandre <at> riseup.net>

Date: Thu, 8 Oct 2020 22:47:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43873 in the body.
You can then email your comments to 43873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#43873; Package guix-patches. (Thu, 08 Oct 2020 22:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to André Batista <nandre <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 08 Oct 2020 22:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] gnu: Add rust-dialoguer.
Date: Thu, 8 Oct 2020 19:45:45 -0300
[Message part 1 (text/plain, inline)]
Hello,

This patch series adds rust-dialoguer-0.3 which is a dependency for
wasm-pack. Unfortunately, one test is failing for this version and
I couldn't figure how to disable it without the hammer. Attached are
the logs for the test failures. It is missing a trait implementation
before usage, but src/prompts.rs appears to implement it. Maybe it
is the default impl that is lacking.

----

For more information about this error, try `rustc --explain E0277`.
Couldn't compile the test.

failures:
    src/prompts.rs - prompts::Input (line 35)

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--doc'
command "cargo" "test" "--release" failed with status 101

----
[dsrw5179q6ssf1lhvybm979c1wgb98-rust-dialoguer-0.3.0.drv.bz2 (application/octet-stream, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#43873; Package guix-patches. (Thu, 08 Oct 2020 22:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 43873 <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: 43873 <at> debbugs.gnu.org
Subject: Re: [bug#43873] [PATCH 1/3] gnu: Add rust-tempfile-2.
Date: Thu, 8 Oct 2020 19:57:16 -0300
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-rust-tempfile-2.patch (text/plain, inline)]
From 07cc5de055b6e19aef61ed889d4f1aa467db9ac9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre <at> riseup.net>
Date: Thu, 8 Oct 2020 18:33:28 -0300
Subject: [PATCH] gnu: Add rust-tempfile-2.
To: guix-patches <at> gnu.org

* gnu/packages/crates-io.scm (rust-tempfile-2): New variable.
---
 gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 48b70137da..542c397e8b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -24254,6 +24254,29 @@ directories.")
     (license (list license:asl2.0
                    license:expat))))
 
+(define-public rust-tempfile-2
+  (package
+    (inherit rust-tempfile-3)
+    (name "rust-tempfile")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "tempfile" version))
+        (file-name (string-append name "-" version ".crate"))
+         (sha256
+          (base32
+           "1q61byf232rra0vqxp4qp10wwwqsqqd45qjj80ql5f34vgljzkhi"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:skip-build? #t
+       #:cargo-inputs
+       (("rust-kernel32-sys" ,rust-kernel32-sys-0.2)
+        ("rust-libc" ,rust-libc-0.2)
+        ("rust-rand" ,rust-rand-0.3)
+        ("rust-redox-syscall" ,rust-redox-syscall-0.1)
+        ("rust-winapi" ,rust-winapi-0.2))))))
+
 (define-public rust-tendril-0.4
   (package
     (name "rust-tendril")
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#43873; Package guix-patches. (Thu, 08 Oct 2020 23:00:02 GMT) Full text and rfc822 format available.

Message #11 received at 43873 <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: 43873 <at> debbugs.gnu.org
Subject: Re: [bug#43873] [PATCH 2/3] gnu: Add rust-dialoguer-0.6.
Date: Thu, 8 Oct 2020 19:59:27 -0300
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-rust-dialoguer-0.6.patch (text/plain, inline)]
From aa042ce1360e7c15653e9021c5b916135d3d9842 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre <at> riseup.net>
Date: Thu, 8 Oct 2020 18:43:52 -0300
Subject: [PATCH] gnu: Add rust-dialoguer-0.6.
To: guix-patches <at> gnu.org

* gnu/packages/crates-io.scm (rust-dialoguer-0.6): New variable.
---
 gnu/packages/crates-io.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 542c397e8b..7cdf5262fa 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5374,6 +5374,31 @@ traits for both structs and enums.")
 structs and enums.")
   (license license:expat)))
 
+(define-public rust-dialoguer-0.6
+  (package
+    (name "rust-dialoguer")
+    (version "0.6.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "dialoguer" version))
+        (file-name
+         (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32
+          "0f31ahy6myg2vz9xrdmp0vx0m7x427a1wxpgrgwhxd0rgfpqdapl"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:cargo-inputs
+       (("rust-console" ,rust-console-0.11)
+        ("rust-lazy-static" ,rust-lazy-static-1)
+        ("rust-tempfile" ,rust-tempfile-3))))
+    (home-page "https://github.com/mitsuhiko/dialoguer")
+    (synopsis "Library for command line prompts")
+    (description
+     "This package provides a library for command line prompts and the like.")
+    (license license:expat)))
+
 (define-public rust-diff-0.1
   (package
     (name "rust-diff")
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#43873; Package guix-patches. (Thu, 08 Oct 2020 23:01:02 GMT) Full text and rfc822 format available.

Message #14 received at 43873 <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: 43873 <at> debbugs.gnu.org
Subject: Re: [bug#43873] [PATCH 3/3] gnu: Add rust-dialoguer-0.3.
Date: Thu, 8 Oct 2020 20:00:17 -0300
[Message part 1 (text/plain, inline)]

[0001-gnu-Add-rust-dialoguer-0.3.patch (text/plain, inline)]
From d670811b5b0f648c4b58f69f21e01bcac6d42795 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre <at> riseup.net>
Date: Thu, 8 Oct 2020 18:49:44 -0300
Subject: [PATCH] gnu: Add rust-dialoguer-0.3.
To: guix-patches <at> gnu.org

* gnu/packages/crates-io.scm (rust-dialoguer-0.3): New variable.
---
 gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 7cdf5262fa..ecbd9dae50 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -5399,6 +5399,29 @@ structs and enums.")
      "This package provides a library for command line prompts and the like.")
     (license license:expat)))
 
+(define-public rust-dialoguer-0.3
+  (package
+    (inherit rust-dialoguer-0.6)
+    (name "rust-dialoguer")
+    (version "0.3.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "dialoguer" version))
+        (file-name
+         (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32
+          "1a9gqvqp83gg4jbm286q5ab3l44zyyzlsdaiqmw8x4k80fdc5l8s"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(;; One prompt test is failing on lacking default prompt impl.
+       #:tests? #f
+       #:cargo-inputs
+       (("rust-console" ,rust-console-0.7)
+        ("rust-lazy-static" ,rust-lazy-static-1)
+        ("rust-tempfile" ,rust-tempfile-2))))))
+
 (define-public rust-diff-0.1
   (package
     (name "rust-diff")
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Sun, 11 Oct 2020 11:00:01 GMT) Full text and rfc822 format available.

Notification sent to André Batista <nandre <at> riseup.net>:
bug acknowledged by developer. (Sun, 11 Oct 2020 11:00:02 GMT) Full text and rfc822 format available.

Message #19 received at 43873-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: André Batista <nandre <at> riseup.net>
Cc: 43873-done <at> debbugs.gnu.org
Subject: Re: [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer.
Date: Sun, 11 Oct 2020 13:58:34 +0300
[Message part 1 (text/plain, inline)]
On Thu, Oct 08, 2020 at 07:45:45PM -0300, André Batista wrote:
> Hello,
> 
> This patch series adds rust-dialoguer-0.3 which is a dependency for
> wasm-pack. Unfortunately, one test is failing for this version and
> I couldn't figure how to disable it without the hammer. Attached are
> the logs for the test failures. It is missing a trait implementation
> before usage, but src/prompts.rs appears to implement it. Maybe it
> is the default impl that is lacking.
> 
> ----
> 
> For more information about this error, try `rustc --explain E0277`.
> Couldn't compile the test.
> 
> failures:
>     src/prompts.rs - prompts::Input (line 35)
> 
> test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
> 
> error: test failed, to rerun pass '--doc'
> command "cargo" "test" "--release" failed with status 101
> 
> ----

I'm not sure how you managed to build it, when I tried I got an error
about parking-lot-core <at> 0.5 having the wrong inputs. Luckily it was
looking for <1.0.0 so I put in 0.11 and that one was more happy.

Looking at the .travis.yml it looks like they only test with the --lib
flag, so I removed skip-build and added cargo-test-flags '("--lib").

I was able to build rust-tempfile-2 without any problems, so I took out
the skip-build option.

Patches pushed! Thanks.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#43873; Package guix-patches. (Fri, 23 Oct 2020 01:28:02 GMT) Full text and rfc822 format available.

Message #22 received at 43873-done <at> debbugs.gnu.org (full text, mbox):

From: André Batista <nandre <at> riseup.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 43873-done <at> debbugs.gnu.org
Subject: Re: [bug#43873] [PATCH 0/3] gnu: Add rust-dialoguer.
Date: Thu, 22 Oct 2020 22:26:21 -0300
[Message part 1 (text/plain, inline)]
Hello Efraim,

dom 11 out 2020 às 13:58:34 (1602435514), efraim <at> flashner.co.il enviou:
> I'm not sure how you managed to build it, when I tried I got an error
> about parking-lot-core <at> 0.5 having the wrong inputs. Luckily it was
> looking for <1.0.0 so I put in 0.11 and that one was more happy.

I was building from a different local working tree, where I had defined
other packages, including parking-lot-core, so I guess I did not remember
every change I had made and I did not test on the master tree but on my
local tree.

From now on, I'll be sure to move those definitions one at a time when
trying to build to avoid further problems.

> Looking at the .travis.yml it looks like they only test with the --lib
> flag, so I removed skip-build and added cargo-test-flags '("--lib").
> 
> I was able to build rust-tempfile-2 without any problems, so I took out
> the skip-build option.
> 
> Patches pushed! Thanks.

Nice, thank you for pointing that out.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 20 Nov 2020 12:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.