From unknown Thu Aug 21 14:53:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#43841] [PATCH] build-system/go: Install license files. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Oct 2020 07:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43841 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43841@debbugs.gnu.org Cc: Efraim Flashner X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160205476615851 (code B ref -1); Wed, 07 Oct 2020 07:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2020 07:12:46 +0000 Received: from localhost ([127.0.0.1]:54951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3cz-00047a-R3 for submit@debbugs.gnu.org; Wed, 07 Oct 2020 03:12:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:40008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3cx-00047R-HY for submit@debbugs.gnu.org; Wed, 07 Oct 2020 03:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ3cx-0001C9-CR for guix-patches@gnu.org; Wed, 07 Oct 2020 03:12:43 -0400 Received: from flashner.co.il ([178.62.234.194]:34604) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ3cv-0008RV-CM for guix-patches@gnu.org; Wed, 07 Oct 2020 03:12:43 -0400 Received: from localhost (unknown [147.161.9.74]) by flashner.co.il (Postfix) with ESMTPSA id C0C5E40148; Wed, 7 Oct 2020 07:12:39 +0000 (UTC) From: Efraim Flashner Date: Wed, 7 Oct 2020 10:11:56 +0300 Message-Id: <20201007071156.12765-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 03:12:40 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/build/go-build-system.scm (install-license-files): New procedure. (%standard-phases): Replace inherited 'install-license-files phase. --- guix/build/go-build-system.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index b9cb2bfd7b..227df820db 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2019 Maxim Cournoyer ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2020 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -254,6 +255,17 @@ XXX We can't make use of compiled libraries (Go \"packages\")." (copy-recursively source dest #:keep-mtime? #t))) #t) +(define* (install-license-files #:key unpack-path + import-path + #:allow-other-keys + #:rest args) + "Install license files matching LICENSE-FILE-REGEXP to 'share/doc'. Adjust +the standard install-license-files phase to first enter the correct directory." + (with-directory-excursion (string-append "src/" (if (string-null? unpack-path) + import-path + unpack-path)) + (apply (assoc-ref gnu:%standard-phases 'install-license-files) args))) + (define* (remove-store-reference file file-name #:optional (store (%store-directory))) "Remove from FILE occurrences of FILE-NAME in STORE; return #t when FILE-NAME @@ -317,6 +329,7 @@ files in OUTPUTS." (replace 'build build) (replace 'check check) (replace 'install install) + (replace 'install-license-files install-license-files) (add-after 'install 'remove-go-references remove-go-references))) (define* (go-build #:key inputs (phases %standard-phases) -- 2.28.0 From unknown Thu Aug 21 14:53:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Efraim Flashner Subject: bug#43841: closed (Re: bug#43841: Acknowledgement ([PATCH] build-system/go: Install license files.)) Message-ID: References: <20201015081331.GG1237@E5400> <20201007071156.12765-1-efraim@flashner.co.il> X-Gnu-PR-Message: they-closed 43841 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 43841@debbugs.gnu.org Date: Thu, 15 Oct 2020 08:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1602749702-7606-1" This is a multi-part message in MIME format... ------------=_1602749702-7606-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43841: [PATCH] build-system/go: Install license files. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43841@debbugs.gnu.org. --=20 43841: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43841 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1602749702-7606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43841-done) by debbugs.gnu.org; 15 Oct 2020 08:14:15 +0000 Received: from localhost ([127.0.0.1]:54169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSyOt-0001xX-69 for submit@debbugs.gnu.org; Thu, 15 Oct 2020 04:14:15 -0400 Received: from flashner.co.il ([178.62.234.194]:35384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSyOr-0001xK-JV for 43841-done@debbugs.gnu.org; Thu, 15 Oct 2020 04:14:14 -0400 Received: from localhost (unknown [141.226.13.8]) by flashner.co.il (Postfix) with ESMTPSA id 473D0401E5 for <43841-done@debbugs.gnu.org>; Thu, 15 Oct 2020 08:14:06 +0000 (UTC) Date: Thu, 15 Oct 2020 11:13:31 +0300 From: Efraim Flashner To: 43841-done@debbugs.gnu.org Subject: Re: bug#43841: Acknowledgement ([PATCH] build-system/go: Install license files.) Message-ID: <20201015081331.GG1237@E5400> References: <20201007071156.12765-1-efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="reI/iBAAp9kzkmX4" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43841-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --reI/iBAAp9kzkmX4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patch pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --reI/iBAAp9kzkmX4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl+IBKsACgkQQarn3Mo9 g1HQ/w/8CVh5CUHQgRwK0280kNBn7mT8AA19D2rxiNfEO9lJTLFMQxtSI8QVrVJ/ DvhoyKX/N3ncTYhPErl+EEDkr3IBNLEXGjcmms26dNWjqYNmqGOFRPfzUFNQV7u5 Ra/jtsUxIHtmBpJ9DKCRjYJ78jcVcRdhw9fCxZu0e55Y8ZhwROCb4NSTkxdcMt8v yNL+hoxQ63sN14sEYNBI9T59u5eHYgduRA95dcFfiVb7qJaCEIM0sMTyR7a/mtfE URvBlyFbZ4YEut5GQh4XK2GG/X6lYcjiq2kvBJ91Q+E17lxFKozoKIJYH78wbSVc OKnh1X6deY1ZuwU+4i8FIgd2s+UQnQX8e0+F5k1UE/OP8wG7zZmZMAviO3L+97CU OkolIMSjUpqWK+Gw8kxYUF9K/0HxXd/3dON5ACYRFCnfWxH3JsTh73oM7862TAj0 LpUhdStbg5GiD6r8Mkij7QfsRPv2UInD0//fPe0GhAbdxQganoi93/2mL6mDTI3p xp2PmhwiyWfWoS+K0EySK5SAVDOSRmsjnqPSlqLje5ltxkgCg25P7qpf/1szTR4H A6696ZsSfkfGJouw9WXXmn4bKEY0VdVSCaKK1U5qEmGM5QqCa0Aw0iAKoWuJYQZP h9IsO0t4WrBjb4aKMq9n7pfbOgAPBAF99k1C3PjQjkmrBN76Ouk= =g1PU -----END PGP SIGNATURE----- --reI/iBAAp9kzkmX4-- ------------=_1602749702-7606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Oct 2020 07:12:46 +0000 Received: from localhost ([127.0.0.1]:54951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3cz-00047a-R3 for submit@debbugs.gnu.org; Wed, 07 Oct 2020 03:12:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:40008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ3cx-00047R-HY for submit@debbugs.gnu.org; Wed, 07 Oct 2020 03:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ3cx-0001C9-CR for guix-patches@gnu.org; Wed, 07 Oct 2020 03:12:43 -0400 Received: from flashner.co.il ([178.62.234.194]:34604) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ3cv-0008RV-CM for guix-patches@gnu.org; Wed, 07 Oct 2020 03:12:43 -0400 Received: from localhost (unknown [147.161.9.74]) by flashner.co.il (Postfix) with ESMTPSA id C0C5E40148; Wed, 7 Oct 2020 07:12:39 +0000 (UTC) From: Efraim Flashner To: guix-patches@gnu.org Subject: [PATCH] build-system/go: Install license files. Date: Wed, 7 Oct 2020 10:11:56 +0300 Message-Id: <20201007071156.12765-1-efraim@flashner.co.il> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 03:12:40 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * guix/build/go-build-system.scm (install-license-files): New procedure. (%standard-phases): Replace inherited 'install-license-files phase. --- guix/build/go-build-system.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index b9cb2bfd7b..227df820db 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2019 Maxim Cournoyer ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka +;;; Copyright © 2020 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -254,6 +255,17 @@ XXX We can't make use of compiled libraries (Go \"packages\")." (copy-recursively source dest #:keep-mtime? #t))) #t) +(define* (install-license-files #:key unpack-path + import-path + #:allow-other-keys + #:rest args) + "Install license files matching LICENSE-FILE-REGEXP to 'share/doc'. Adjust +the standard install-license-files phase to first enter the correct directory." + (with-directory-excursion (string-append "src/" (if (string-null? unpack-path) + import-path + unpack-path)) + (apply (assoc-ref gnu:%standard-phases 'install-license-files) args))) + (define* (remove-store-reference file file-name #:optional (store (%store-directory))) "Remove from FILE occurrences of FILE-NAME in STORE; return #t when FILE-NAME @@ -317,6 +329,7 @@ files in OUTPUTS." (replace 'build build) (replace 'check check) (replace 'install install) + (replace 'install-license-files install-license-files) (add-after 'install 'remove-go-references remove-go-references))) (define* (go-build #:key inputs (phases %standard-phases) -- 2.28.0 ------------=_1602749702-7606-1--