GNU bug report logs - #43827
#42223 patch

Previous Next

Full log

View this message in rfc822 format

From: Ruthra Kumar <ruthrab <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43827 <at> debbugs.gnu.org
Subject: bug#43827: #42223 patch
Date: Fri, 9 Oct 2020 10:55:07 +0530

[Message part 1 (text/plain, inline)]

attached latest diff.

On Fri, Oct 9, 2020 at 9:49 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>
> Ruthra Kumar <ruthrab <at> gmail.com> writes:
>
> > Fixed the bug. It's now able to list and extract files from archive.
>
> Thanks; I was unable to try it because it seems like the patch was
> mangled during transport again.  Can you re-send it as an attachment?
>
> > There is 1 edge case. If you press 'e' or 'RET' on a directory, the
> > expected behaviour is the message 'Entry is not a regular member of
> > archive'. Here, it tries to extract it as a file, cause
> > 'archive-get-descr' fails to determine the type of the entry using
> > 'mode' attribute. I face similar issues on RAR archive files as well.
> >
> > I suspect the 'mode' is not an exact integer representation of file
> > permissions. Need more details on the 'mode' attribute of class
> >
> > Currently, the 'mode' value for squashfs is calculated from the file
> > permissions outputted by 'unsquashfs -ll'.
> > Ex: "-rwxrwxr-x" -> #o775
>
> Right.  That should be fixed, but if the same issue is present in .rar
> files, too, then doing so before integrating probably isn't necessary.
>
> > Yes, i'm willing to assign copyright to Free Software Foundation. Let
> > me know the procedure.
>
> Sent off-list.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

[patch43827_01.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.