Subject: Re: bug#43827: #42223 patch

From: Lars Ingebrigtsen <[email-masked]>
Date: Wed, 07 Oct 2020 05:53:06 +0200

Ruthra Kumar <[email-masked]> writes:

> Bug #42223. Added support for squashfs archive files. arc-mode can now show a
> dired like listing of squashfs files.

I tried applying your patch to Emacs 28, and then opened a .snap file
(which is supposed to be a squashfs file system), but it failed with
the backtrace included below.

But it sounds like a useful addition (if the bugs can be fixed), but for
such a big addition, we'd need to have the copyright on the code
assigned to the FSF.  Would you be willing to do so?

---
Backtrace:

Debugger entered--Lisp error: (wrong-type-argument archive--file-summary [" -rw-r--r--    0/0 android.img" 19 30])
  signal(wrong-type-argument (archive--file-summary [" -rw-r--r--    0/0 android.img" 19 30]))
  archive-summarize-files(([" -rw-r--r--    0/0 android.img" 19 30] [" -rw-r--r--    0/0 apparmor/anbox-container.aa" 19 46] [" -rwxr-xr-x    0/0 bin/anbox-bridge.sh" 19 38] [" -rwxr-xr-x    0/0 bin/anbox-shell.sh" 19 37] [" -rwxr-xr-x    0/0 bin/anbox-wrapper.sh" 19 39] [" -rwxr-xr-x    0/0 bin/app-android-settings.sh" 19 46] [" -rwxr-xr-x    0/0 bin/app-appmgr.sh" 19 36] [" -rwxr-xr-x    0/0 bin/collect-bug-info.sh" 19 42] [" -rwxr-xr-x    0/0 bin/container-manager.sh" 19 43] [" -rwxr-xr-x    0/0 bin/desktop-launch" 19 37] [" -rwxr-xr-x    0/0 bin/lxc-attach" 19 33] [" -rwxr-xr-x    0/0 bin/lxc-info" 19 31] [" -rwxr-xr-x    0/0 bin/lxc-ls" 19 29] [" -rwxr-xr-x    0/0 bin/lxc-start" 19 32] [" -rwxr-xr-x    0/0 bin/lxc-stop" 19 31] [" -rwxr-xr-x    0/0 bin/lxc-top" 19 30] [" -rwxr-xr-x    0/0 command-anbox.wrapper" 19 40] [" -rwxr-xr-x    0/0 command-android-settings.wrappe..." 19 51] [" -rwxr-xr-x    0/0 command-appmgr.wrapper" 19 41] [" -rwxr-xr-x    0/0 command-collect-bug-info.wrappe..." 19 51] [" -rwxr-xr-x    0/0 command-container-manager.wrapp..." 19 52] [" -rwxr-xr-x    0/0 command-shell.wrapper" 19 40] [" -rw-r--r--    0/0 desktop/android-settings.deskto..." 19 51] [" -rw-r--r--    0/0 desktop/appmgr.desktop" 19 41] [" -rw-r--r--    0/0 etc/apparmor/parser.conf" 19 43] [" -rw-r--r--    0/0 etc/apparmor/subdomain.conf" 19 46] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/X" 19 48] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/apa..." 19 61] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/app..." 19 74] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/app..." 19 67] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/app..." 19 75] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/app..." 19 70] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/app..." 19 70] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/asp..." 19 53] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/aud..." 19 52] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/aut..." 19 61] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/bas..." 19 51] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/bas..." 19 51] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/con..." 19 55] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/cup..." 19 58] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 51] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 65] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 72] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 59] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 66] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dbu..." 19 58] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dco..." 19 52] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/dov..." 19 61] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/enc..." 19 54] [" -rw-r--r--    0/0 etc/apparmor.d/abstractions/fon..." 19 52] ...))
  archive-squashfs-summarize()
  archive-summarize(nil)
  archive-mode()
  set-auto-mode-0(archive-mode nil)
  set-auto-mode()
  normal-mode(t)
  after-find-file(nil t)
  find-file-noselect-1(#<buffer Nr9K6UJaIOD8wHpDEQl16nabFFt9LLEQ_185.squashfs> "~/Downloads/Nr9K6UJaIOD8wHpDEQl16nabFFt9LLEQ_185.s..." nil nil "~/Downloads/Nr9K6UJaIOD8wHpDEQl16nabFFt9LLEQ_185.s..." (24380717 66306))
  find-file-noselect("/home/larsi/Downloads/Nr9K6UJaIOD8wHpDEQl16nabFFt9..." nil nil nil)
  find-file("/home/larsi/Downloads/Nr9K6UJaIOD8wHpDEQl16nabFFt9...")
  dired-find-file()
  funcall-interactively(dired-find-file)
  call-interactively(dired-find-file nil nil)
  command-execute(dired-find-file)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no