GNU bug report logs - #43825
[PATCH] bioinformatics: htslib: Enable support for custom URI schemes.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43825 in the body.
You can then email your comments to 43825 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] bioinformatics: htslib: Enable support for custom URI schemes.
Date: Tue, 06 Oct 2020 10:48:31 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

I'd like to apply this patch to enable accessing files stored in
certain "cloud" systems.  I added "--enable-libcurl" although it is not
strictly necessary. Both "--enable-gcs" and "--enable-s3" require
libcurl to be enabled, so this just seems reassuringly clear to me. 

Kind regards,
Roel Janssen

[0001-bioinformatics-htslib-Enable-support-for-custom-URI-.patch (text/x-patch, attachment)]

Message #8 received at 43825 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Roel Janssen <roel <at> gnu.org>
Cc: 43825 <at> debbugs.gnu.org
Subject: Re: [bug#43825] [PATCH] bioinformatics: htslib: Enable support for
 custom URI schemes.
Date: Tue, 6 Oct 2020 22:23:59 +0300

[Message part 1 (text/plain, inline)]

On Tue, Oct 06, 2020 at 10:48:31AM +0200, Roel Janssen wrote:
> Dear Guix,
> 
> I'd like to apply this patch to enable accessing files stored in
> certain "cloud" systems.  I added "--enable-libcurl" although it is not
> strictly necessary. Both "--enable-gcs" and "--enable-s3" require
> libcurl to be enabled, so this just seems reassuringly clear to me. 
> 
> Kind regards,
> Roel Janssen
> 

That sounds fine to me.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 43825 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Roel Janssen <roel <at> gnu.org>
Cc: 43825 <at> debbugs.gnu.org
Subject: Re: [bug#43825] [PATCH] bioinformatics: htslib: Enable support for
 custom URI schemes.
Date: Tue, 06 Oct 2020 22:56:01 +0200

Hi Roel,

> I'd like to apply this patch to enable accessing files stored in
> certain "cloud" systems.

Sounds good to me.  Please move the explanation from the commit message
to the code as a comment.

As commit message please use:

* gnu/packages/bioinformatics.scm (htslib)[arguments]: Enable support for custom URIs.

-- 
Ricardo

Message #16 received at 43825-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 43825-done <at> debbugs.gnu.org
Subject: Re: [bug#43825] [PATCH] bioinformatics: htslib: Enable support for
 custom URI schemes.
Date: Wed, 07 Oct 2020 15:37:14 +0200

On Tue, 2020-10-06 at 22:56 +0200, Ricardo Wurmus wrote:
> Hi Roel,
> 
> > I'd like to apply this patch to enable accessing files stored in
> > certain "cloud" systems.
> 
> Sounds good to me.  Please move the explanation from the commit
> message
> to the code as a comment.
> 
> As commit message please use:
> 
> * gnu/packages/bioinformatics.scm (htslib)[arguments]: Enable support
> for custom URIs.
> 

Thank you! I've committed this patch at fb0037a.

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.