GNU bug report logs - #43823
[PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarch64-linux

Previous Next

Full log

Message #20 received at 43823 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Simon South <simon <at> simonsouth.net>
Cc: 43823 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/3] gnu: knot: Build the Info manual.
Date: Tue, 06 Oct 2020 03:10:17 +0200

[Message part 1 (text/plain, inline)]

Simon,

Simon South 写道：
> This also silences a configure warning about the "sphinx-build"
> command being unavailable.

./configure is a noisy boy; not every ‘warning’ warrants action. 
A GNU info manual is definitely nice to have though!

> +       ("makeinfo" ,texinfo)
>         ("pkg-config" ,pkg-config)
> -       ("ragel" ,ragel)))
> +       ("ragel" ,ragel)
> +       ("sphinx-build" ,python-sphinx)))

It's a subjective line but I'd prefer the labels match the package 
here.  Nitpick, can be fixed up in post.

Otherwise LGTM,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.