From unknown Sat Jun 21 03:12:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#43823 <43823@debbugs.gnu.org> To: bug#43823 <43823@debbugs.gnu.org> Subject: Status: [PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarch64-linux Reply-To: bug#43823 <43823@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:12:34 +0000 retitle 43823 [PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarc= h64-linux reassign 43823 guix-patches submitter 43823 Simon South severity 43823 normal tag 43823 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 20:30:11 2020 Received: (at submit) by debbugs.gnu.org; 6 Oct 2020 00:30:11 +0000 Received: from localhost ([127.0.0.1]:50817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kParq-00022l-Kr for submit@debbugs.gnu.org; Mon, 05 Oct 2020 20:30:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:43778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kParm-00021e-EY for submit@debbugs.gnu.org; Mon, 05 Oct 2020 20:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPark-0004Ex-UK for guix-patches@gnu.org; Mon, 05 Oct 2020 20:30:06 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:40352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPare-0004pV-QN for guix-patches@gnu.org; Mon, 05 Oct 2020 20:30:02 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 5D0ABA0149; Tue, 6 Oct 2020 00:29:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6oE42OvBZJUh; Tue, 6 Oct 2020 00:29:55 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id C4F00A0137; Tue, 6 Oct 2020 00:29:51 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: [PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarch64-linux Date: Mon, 5 Oct 2020 20:25:28 -0400 Message-Id: X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/05 20:29:55 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) These changes to the Knot package complement work done today by Tobias[0] by silencing the remaining warnings from configure while adding a bit of new functionality. The patches - Enable DNS-over-HTTPS support in the kdig utility, by adding the nghttp2 library as a native input; - Cause the Info manual to be built and included in the output; and - Fix a test[1] that prevented the package from building on aarch64-linux systems. [0] Now that everyone's finished building commit 2eb0585. [1] See https://gitlab.nic.cz/knot/knot-dns/-/issues/693 -- Simon South simon@simonsouth.net Simon South (3): gnu: knot: Enable DNS-over-HTTPS support in kdig. gnu: knot: Build the Info manual. gnu: knot: Fix test failure on aarch64-linux. gnu/packages/dns.scm | 16 ++++++++++++-- ...est_net_shortwrite-ensure-connection.patch | 21 +++++++++++++++++++ 2 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 20:32:27 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 00:32:27 +0000 Received: from localhost ([127.0.0.1]:50823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPau3-000269-5A for submit@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:27 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:45982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPau1-00025w-E1 for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:25 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 27CB620A1E; Tue, 6 Oct 2020 00:32:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo06-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo06-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XvZ8ArszqEv1; Tue, 6 Oct 2020 00:32:20 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 09D0C209FB; Tue, 6 Oct 2020 00:32:16 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH 1/3] gnu: knot: Enable DNS-over-HTTPS support in kdig. Date: Mon, 5 Oct 2020 20:27:46 -0400 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This also silences a configure warning regarding the missing "libnghttp2" library. * gnu/packages/dns.scm (knot)[inputs]: Add nghttp2:lib. --- gnu/packages/dns.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 0cb8df94df..d791c45f69 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -862,6 +862,7 @@ Extensions} (DNSSEC).") ("libcap-ng" ,libcap-ng) ("libedit" ,libedit) ("libidn" ,libidn) + ("libnghttp2" ,nghttp2 "lib") ("liburcu" ,liburcu) ("lmdb" ,lmdb) ("ncurses" ,ncurses) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 20:32:33 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 00:32:33 +0000 Received: from localhost ([127.0.0.1]:50826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPau9-00026S-Dh for submit@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:33 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:46948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPau8-000268-7g for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:32 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 033D820B2A; Tue, 6 Oct 2020 00:32:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo06-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo06-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id seFAxGGu9Uny; Tue, 6 Oct 2020 00:32:26 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B24E7209FB; Tue, 6 Oct 2020 00:32:22 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH 2/3] gnu: knot: Build the Info manual. Date: Mon, 5 Oct 2020 20:27:47 -0400 Message-Id: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This also silences a configure warning about the "sphinx-build" command being unavailable. * gnu/packages/dns.scm (knot)[arguments]: Add "build-info" and "install-info" phases. [native-inputs]: Add texinfo and python-sphinx. --- gnu/packages/dns.scm | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index d791c45f69..0eab03fbbd 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -69,6 +69,7 @@ #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages swig) + #:use-module (gnu packages texinfo) #:use-module (gnu packages tls) #:use-module (gnu packages web) #:use-module (gnu packages xml) @@ -841,6 +842,9 @@ Extensions} (DNSSEC).") ;; This is needed even when using ‘make config_dir=... install’. (substitute* "src/Makefile.in" (("\\$\\(INSTALL\\) -d") "true")) #t)) + (add-after 'build 'build-info + (lambda _ + (invoke "make" "info"))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -848,13 +852,18 @@ Extensions} (DNSSEC).") (etc (string-append doc "/examples/etc"))) (invoke "make" (string-append "config_dir=" etc) - "install"))))))) + "install")))) + (add-after 'install 'install-info + (lambda _ + (invoke "make" "install-info")))))) (native-inputs `(("autoconf" ,autoconf) ("automake" ,automake) ("libtool" ,libtool) + ("makeinfo" ,texinfo) ("pkg-config" ,pkg-config) - ("ragel" ,ragel))) + ("ragel" ,ragel) + ("sphinx-build" ,python-sphinx))) (inputs `(("fstrm" ,fstrm) ("gnutls" ,gnutls) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 20:32:41 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 00:32:41 +0000 Received: from localhost ([127.0.0.1]:50829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPauG-00026l-MY for submit@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:40 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:47686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPauE-00026Z-Vh for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 20:32:39 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id BACFD20B2A; Tue, 6 Oct 2020 00:32:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo06-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo06-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fRNB4_HHZB-m; Tue, 6 Oct 2020 00:32:33 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 5F3ED209FB; Tue, 6 Oct 2020 00:32:29 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH 3/3] gnu: knot: Fix test failure on aarch64-linux. Date: Mon, 5 Oct 2020 20:27:48 -0400 Message-Id: X-Mailer: git-send-email 2.25.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/dns.scm (knot)[source]: Apply patch from upstream that helps ensure the "test_net_shortwrite" test suite can complete regardless of platform or configuration. * gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch: New file. --- gnu/packages/dns.scm | 2 ++ ...est_net_shortwrite-ensure-connection.patch | 21 +++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 0eab03fbbd..40739b2dfa 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -815,6 +815,8 @@ Extensions} (DNSSEC).") (file-name (git-file-name name version)) (sha256 (base32 "0fkvip7n5ihjfwnnivdc3jf44y8p85ifglvq7b0anxvj9cg1m78f")) + (patches + (search-patches "knot-test_net_shortwrite-ensure-connection.patch")) (modules '((guix build utils))) (snippet '(begin diff --git a/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch b/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch new file mode 100644 index 0000000000..63b949e576 --- /dev/null +++ b/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch @@ -0,0 +1,21 @@ +commit 4144d1e9b73ce18d919d980e803e935ba4e7c109 +Author: Simon South +Date: Tue Sep 29 14:53:30 2020 -0400 + + test_net_shortwrite: ensure connection can succeed + + closes #693 + +diff --git a/tests/contrib/test_net_shortwrite.c b/tests/contrib/test_net_shortwrite.c +index 8c8cf92ec..69bab7155 100644 +--- a/tests/contrib/test_net_shortwrite.c ++++ b/tests/contrib/test_net_shortwrite.c +@@ -88,7 +88,7 @@ int main(int argc, char *argv[]) + int server = net_bound_socket(SOCK_STREAM, &addr, 0); + ok(server >= 0, "server: bind socket"); + +- r = listen(server, 0); ++ r = listen(server, 1); + ok(r == 0, "server: start listening"); + + struct sockaddr *sa = (struct sockaddr *)&addr; -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:09:00 2020 Received: (at submit) by debbugs.gnu.org; 6 Oct 2020 01:09:00 +0000 Received: from localhost ([127.0.0.1]:50870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbTQ-0002wt-2d for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:09:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:51088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbTN-0002wl-T0 for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:08:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPbTJ-0002YD-Fy for guix-patches@gnu.org; Mon, 05 Oct 2020 21:08:55 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:39412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPbTH-00011O-85 for guix-patches@gnu.org; Mon, 05 Oct 2020 21:08:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=xVWOHtkbUrdcVPpjP27kva51LXz3DabxJlB1c60gVZA=; h=date:in-reply-to: references:subject:cc:to:from; b=mumXKOTzvpa7PMlZRwl3ye2KqimKq/ZoScYne NgIIrkMJYb/4Xf18WXiY8yaRYvjVUPthlMlf1+fUvcsaRA1X+QJ95qozYn0BSQYDXGJeMk nyYWWNs4s+FqY8YTAIKZstxUi99bdXr4m8ByaTO7WGk/M6peU0Jhrc9ZtPZgDA9hrhmW4u 4gA0X5JaSHQ51V5IuukDWowj/mdY84mEK0PlfDgpJeIabNeks17GE2GkUhtdeBnS/7NPTF 6FtaMVL5ZHzHjC9m03YHdimJqrQwRtb3YsamBiyeO76lCL4/kjxqvwPDbNtM6LFh2Riarb NwRDn+E85amSEIfbnjfSzxlNg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 6bbd1740 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 01:08:56 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Simon South Subject: Re: [PATCH 0/3] Knot: Enable DoH; build Info manual; work on aarch64-linux References: In-reply-to: Date: Tue, 06 Oct 2020 03:08:46 +0200 Message-ID: <87h7r888kh.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon, Simon South =E5=86=99=E9=81=93=EF=BC=9A > These changes to the Knot package complement work done today by > Tobias[0] by silencing the remaining warnings from configure=20 > while > adding a bit of new functionality. The patches Neatness! Thank you. I would like to take another stab at enabling the new XDP support=20 and sneak it into your series before pushing the lot. Everyone's=20 built quite enough knots for a while. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3vDng0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15aEEBAIJ5mnPDC3Pxb8+ALIs4qiPYwcYqW3KkCbkhCMoq ZbnAAQDtevIUuPKgHPusj1QadYYbIZHGo9h6IdPht/LwDnS3DQ== =HT89 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:10:22 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 01:10:22 +0000 Received: from localhost ([127.0.0.1]:50875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbUk-0002zS-GU for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:10:22 -0400 Received: from tobias.gr ([80.241.217.52]:57716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbUh-0002zJ-Ve for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 21:10:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=Cw28hN9Z/tz5k54NHsF22uT9BGPB0orgwjqwHjVb3UA=; h=date:in-reply-to: references:subject:cc:to:from; b=T5bSI9skKIE+kNy1HHhm5wm8Mt2SjnpnskuhF gu0F8g+II6npFJiRq18g79+4Kjp+TIeYuWc4YWCc8ehE7u4Z0AtGEGJH9kUpjxmUYz1Gmz J9tho7qwlO2B1Kh2V7ZHjq23tfGEz7hExTyDMi2zBb/wpqv4ODwKWvC8EVn0C5Bmh5PULX 3GVDnScBP7YXIJ+PHS+4jHor/U1vlc77jvB42Zox7AVsT5Pb8iRjnwpfv/baWNLjGAq5Wc nMLgSxDyAHB7lrHgjJl5b/sEtSxcBur7aib0VDhmLBLAvrJ3MacG58A6j1xYKacef01i04 CvHCxPsoheGabztcmnQ9AZQzA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 33a69591 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 01:10:27 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Simon South Subject: Re: [PATCH 2/3] gnu: knot: Build the Info manual. References: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net> In-reply-to: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net> Date: Tue, 06 Oct 2020 03:10:17 +0200 Message-ID: <87eemc88hy.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: 43823@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon, Simon South =E5=86=99=E9=81=93=EF=BC=9A > This also silences a configure warning about the "sphinx-build" > command being unavailable. ./configure is a noisy boy; not every =E2=80=98warning=E2=80=99 warrants ac= tion.=20 A GNU info manual is definitely nice to have though! > + ("makeinfo" ,texinfo) > ("pkg-config" ,pkg-config) > - ("ragel" ,ragel))) > + ("ragel" ,ragel) > + ("sphinx-build" ,python-sphinx))) It's a subjective line but I'd prefer the labels match the package=20 here. Nitpick, can be fixed up in post. Otherwise LGTM, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3vD+Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15lw8BAPT6pMXV1Fw2suVDVGexDqQLHdw/FUmlrflpxaWF gxS9AQCwRfvoYxlKuBBznKUnFUgpGGaEeg7lBHElHF2Hu7hNBQ== =W/6M -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:11:16 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 01:11:16 +0000 Received: from localhost ([127.0.0.1]:50882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbVb-000313-Rf for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:11:16 -0400 Received: from tobias.gr ([80.241.217.52]:57774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbVa-00030w-R5 for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 21:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=47/6CRGPiA3dX4r5Ud4X0Jo4BOAmc8DrN9BC8TZeePc=; h=date:in-reply-to: references:subject:cc:to:from; b=I7rqQQrqGDkqe4v7URpj8yJw/t84tRtdbjzbm E2NLKv8xHSH9CPWqor6He2Hs8HRis46BSB9Z6uw2NwiJSCroJ7j/1j8ITKTEn6WnQKqjl4 pyClTh0FSwtZ0Wc1FmCT2bQtUcA/7eOfySVoWBJHhXFAhS9yWjMBFaYre4B8q1eFUZ2+Sc OYINmK73KTq/4NNoUyhvIKgLwvbu9MxaeIAMdyx9hXz9UziEJ8rS9RruO2jrFkRjvLr7uQ HYtf26GcXQ9ED/g/BJjSdJ/6x6EMLtTWmgGyArl2WPaNSxXTWc4CyW2v7HtgEiR5zTlAmT d2qRhr//A+Ds6m9dFKbPbpg7A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id faf95f25 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 01:11:23 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Simon South Subject: Re: [PATCH 1/3] gnu: knot: Enable DNS-over-HTTPS support in kdig. References: In-reply-to: Date: Tue, 06 Oct 2020 03:11:13 +0200 Message-ID: <87blhg88ge.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: 43823@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon South =E5=86=99=E9=81=93=EF=BC=9A > @@ -862,6 +862,7 @@ Extensions} (DNSSEC).") > ("libcap-ng" ,libcap-ng) > ("libedit" ,libedit) > ("libidn" ,libidn) > + ("libnghttp2" ,nghttp2 "lib") LGTM. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3vEMQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15xK4A/0tk9UIeh7+vRLcxIQzs4coiQ+LhUPZ6sEtgBcVD EYQ9AP4h2N17AU7Kg21OaYVOGJ7tUXNf9dv2mIKWR7NVoV8EBw== =TDhW -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 21:15:32 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 01:15:32 +0000 Received: from localhost ([127.0.0.1]:50887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbZg-00037Z-CR for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:15:32 -0400 Received: from tobias.gr ([80.241.217.52]:57968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbZa-00037M-N8 for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 21:15:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=V+zcS2b57dTy0QKpUo360xrTCsvO7b+c9pW7ouKJYQ8=; h=date:in-reply-to: references:subject:cc:to:from; b=ND7MpGID9L/wy2wKECJByS13MF/8KYCP+xtHW Nh9ja2o40neqCPuHkdtyr2KY4K1qbZjHhGg2iMfNRXBRcHuE1RyR9iJZPcAVc4FuAuoSWA aC9YMBJZAhDcnqnqAGf2hkPAHjXywyhjQW7L2q1asR7AS6gRbjjX9NPgvWSKiO02zHdSV1 Z8KaN6CKLqejqKPAUxorcoTChrknxQi1dl/j1ocV2Xp6BKpTx/WhFeAvE3kY1fPL9o33k4 Ifom3xeOYWRezfFAEuWse12RSoKy99xmlehZPB+dMl61nPpp4ekelP2nV9SMlVz5b71+kG CZfNj3cDnVrE4wbVGLqXF6IpQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 8bf8d407 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 01:15:30 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Simon South Subject: Re: [PATCH 3/3] gnu: knot: Fix test failure on aarch64-linux. References: In-reply-to: Date: Tue, 06 Oct 2020 03:15:20 +0200 Message-ID: <878sck889j.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: 43823@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon, Simon South =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/dns.scm (knot)[source]: Apply patch from upstream=20 > that > helps ensure the "test_net_shortwrite" test suite can complete > regardless of platform or configuration. [...] > +++=20 > b/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch > @@ -0,0 +1,21 @@ > +commit 4144d1e9b73ce18d919d980e803e935ba4e7c109 > +Author: Simon South You're upstream? More neatness. > + closes #693 Can we include a Web link to the upstream patch or bug report? Each new patch file must also be added to dist_patch_DATA in=20 gnu/local.mk and the commit message. Otherwise LGTM. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3vFKA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15cJoA/1hzn//ihQedxR/ckozc/CVd8uws2LJGSuoy8z0O 96ZzAP4uxiyMGZ4BFe65C5C38s5inYknVrMbWUUOun7n42HiAA== =I4ou -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 09:57:19 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 13:57:19 +0000 Received: from localhost ([127.0.0.1]:53785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnSx-0001Ya-2D for submit@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:19 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:42816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnSv-0001YH-G5 for 43823@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:17 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 2E6E0C10A7; Tue, 6 Oct 2020 13:57:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo04-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo04-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rQZdaqsmUjCa; Tue, 6 Oct 2020 13:57:12 +0000 (UTC) Received: from mercury.simonsouth.net (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 1BCB4BFA14; Tue, 6 Oct 2020 13:57:07 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH v2 1/3] gnu: knot: Enable DNS-over-HTTPS support in kdig. Date: Tue, 6 Oct 2020 09:56:43 -0400 Message-Id: X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/dns.scm (knot)[inputs]: Add nghttp2:lib. --- gnu/packages/dns.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 0cb8df94df..d791c45f69 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -862,6 +862,7 @@ Extensions} (DNSSEC).") ("libcap-ng" ,libcap-ng) ("libedit" ,libedit) ("libidn" ,libidn) + ("libnghttp2" ,nghttp2 "lib") ("liburcu" ,liburcu) ("lmdb" ,lmdb) ("ncurses" ,ncurses) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 09:57:19 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 13:57:19 +0000 Received: from localhost ([127.0.0.1]:53787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnSx-0001Yc-Aj for submit@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:19 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:42452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnSs-0001YD-1L for 43823@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:17 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 25316BFA85; Tue, 6 Oct 2020 13:57:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo04-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo04-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RAuhlqj432En; Tue, 6 Oct 2020 13:57:07 +0000 (UTC) Received: from mercury.simonsouth.net (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id C4513BFA14; Tue, 6 Oct 2020 13:57:04 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH v2 0/3] Knot: Enable DoH; build Info Manual; work on aarch64-linux Date: Tue, 6 Oct 2020 09:56:42 -0400 Message-Id: X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This updated set of patches incorporates feedback from Tobias Geerinckx-Rice (thank you!) and improves on the original by - Using input packages' own name as their label; - Removing mention in the commit descriptions of silencing warnings from configure (he's right, it's a bit silly to worry about this); - Replacing the description in the patch file with something more informative that includes a link to the original issue; and - Registering the patch file in gnu/local.mk. For convenience, here's my original cover letter: These changes to the Knot package complement work done today by Tobias[0] by silencing the remaining warnings from configure while adding a bit of new functionality. The patches - Enable DNS-over-HTTPS support in the kdig utility, by adding the nghttp2 library as a native [actually regular] input; - Cause the Info manual to be built and included in the output; and - Fix a test[1] that prevented the package from building on aarch64-linux systems. [0] Now that everyone's finished building commit 2eb0585. [1] See https://gitlab.nic.cz/knot/knot-dns/-/issues/693 -- Simon South simon@simonsouth.net Simon South (3): gnu: knot: Enable DNS-over-HTTPS support in kdig. gnu: knot: Build the Info manual. gnu: knot: Fix test failure on aarch64-linux. gnu/local.mk | 1 + gnu/packages/dns.scm | 16 ++++++++++++++-- ...est_net_shortwrite-ensure-connection.patch | 19 +++++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 09:57:25 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 13:57:25 +0000 Received: from localhost ([127.0.0.1]:53791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnT2-0001Z4-Mk for submit@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:24 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:43258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnT0-0001YN-5T for 43823@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:22 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id D78B4C08E4; Tue, 6 Oct 2020 13:57:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo04-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo04-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sb4_G9PoreTY; Tue, 6 Oct 2020 13:57:16 +0000 (UTC) Received: from mercury.simonsouth.net (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 8E322BFA14; Tue, 6 Oct 2020 13:57:12 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH v2 2/3] gnu: knot: Build the Info manual. Date: Tue, 6 Oct 2020 09:56:44 -0400 Message-Id: X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/dns.scm (knot)[arguments]: Add "build-info" and "install-info" phases. [native-inputs]: Add texinfo and python-sphinx. --- gnu/packages/dns.scm | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index d791c45f69..b3dd68ccbd 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -69,6 +69,7 @@ #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages swig) + #:use-module (gnu packages texinfo) #:use-module (gnu packages tls) #:use-module (gnu packages web) #:use-module (gnu packages xml) @@ -841,6 +842,9 @@ Extensions} (DNSSEC).") ;; This is needed even when using ‘make config_dir=... install’. (substitute* "src/Makefile.in" (("\\$\\(INSTALL\\) -d") "true")) #t)) + (add-after 'build 'build-info + (lambda _ + (invoke "make" "info"))) (replace 'install (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -848,13 +852,18 @@ Extensions} (DNSSEC).") (etc (string-append doc "/examples/etc"))) (invoke "make" (string-append "config_dir=" etc) - "install"))))))) + "install")))) + (add-after 'install 'install-info + (lambda _ + (invoke "make" "install-info")))))) (native-inputs `(("autoconf" ,autoconf) ("automake" ,automake) ("libtool" ,libtool) ("pkg-config" ,pkg-config) - ("ragel" ,ragel))) + ("python-sphinx" ,python-sphinx) + ("ragel" ,ragel) + ("texinfo" ,texinfo))) (inputs `(("fstrm" ,fstrm) ("gnutls" ,gnutls) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 09:57:30 2020 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 13:57:30 +0000 Received: from localhost ([127.0.0.1]:53794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnT8-0001ZM-1c for submit@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:30 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:43632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPnT4-0001Yw-TI for 43823@debbugs.gnu.org; Tue, 06 Oct 2020 09:57:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 979C6BFA85; Tue, 6 Oct 2020 13:57:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo04-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo04-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id suWcjKg8mBLz; Tue, 6 Oct 2020 13:57:21 +0000 (UTC) Received: from mercury.simonsouth.net (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 28297BFA14; Tue, 6 Oct 2020 13:57:16 +0000 (UTC) From: Simon South To: 43823@debbugs.gnu.org Subject: [PATCH v2 3/3] gnu: knot: Fix test failure on aarch64-linux. Date: Tue, 6 Oct 2020 09:56:45 -0400 Message-Id: <11f47227ef927f18f0c8d77a26173247360128d9.1601991615.git.simon@simonsouth.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823 Cc: me@tobias.gr, simon@simonsouth.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/dns.scm (knot)[source]: Apply patch from upstream that helps ensure the "test_net_shortwrite" test suite can complete regardless of platform or configuration. * gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch: New file. * gnu/local.mk: Add it. --- gnu/local.mk | 1 + gnu/packages/dns.scm | 2 ++ ...est_net_shortwrite-ensure-connection.patch | 19 +++++++++++++++++++ 3 files changed, 22 insertions(+) create mode 100644 gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch diff --git a/gnu/local.mk b/gnu/local.mk index 59cad38504..83d2d72ab1 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1198,6 +1198,7 @@ dist_patch_DATA = \ %D%/packages/patches/kpackage-allow-external-paths.patch \ %D%/packages/patches/kmplayer-aarch64.patch \ %D%/packages/patches/kmplayer-upstream_Fix-build-with-Qt-5.9.patch \ + %D%/packages/patches/knot-test_net_shortwrite-ensure-connection.patch \ %D%/packages/patches/kobodeluxe-paths.patch \ %D%/packages/patches/kobodeluxe-enemies-pipe-decl.patch \ %D%/packages/patches/kobodeluxe-const-charp-conversion.patch \ diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index b3dd68ccbd..97e919517c 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -815,6 +815,8 @@ Extensions} (DNSSEC).") (file-name (git-file-name name version)) (sha256 (base32 "0fkvip7n5ihjfwnnivdc3jf44y8p85ifglvq7b0anxvj9cg1m78f")) + (patches + (search-patches "knot-test_net_shortwrite-ensure-connection.patch")) (modules '((guix build utils))) (snippet '(begin diff --git a/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch b/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch new file mode 100644 index 0000000000..9e86fbdb58 --- /dev/null +++ b/gnu/packages/patches/knot-test_net_shortwrite-ensure-connection.patch @@ -0,0 +1,19 @@ +This patch duplicates upstream commit 4144d1e, which helps ensure the +"test_net_shortwrite" test suite can succeed across all platforms by +deepening the pending-connection queue of the server it creates from 0 +to 1. + +See the original report at +https://gitlab.nic.cz/knot/knot-dns/-/issues/693 + +--- a/tests/contrib/test_net_shortwrite.c ++++ b/tests/contrib/test_net_shortwrite.c +@@ -88,7 +88,7 @@ int main(int argc, char *argv[]) + int server = net_bound_socket(SOCK_STREAM, &addr, 0); + ok(server >= 0, "server: bind socket"); + +- r = listen(server, 0); ++ r = listen(server, 1); + ok(r == 0, "server: start listening"); + + struct sockaddr *sa = (struct sockaddr *)&addr; -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 10:41:40 2020 Received: (at 43823-done) by debbugs.gnu.org; 6 Oct 2020 14:41:40 +0000 Received: from localhost ([127.0.0.1]:53861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPo9o-0004xt-0b for submit@debbugs.gnu.org; Tue, 06 Oct 2020 10:41:40 -0400 Received: from tobias.gr ([80.241.217.52]:47774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPo9h-0004xc-On for 43823-done@debbugs.gnu.org; Tue, 06 Oct 2020 10:41:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=797YxQ3Cg5zVZ7TSU5259PbcdsAJu8kndoY2b1RTyZ0=; h=date:in-reply-to: references:subject:cc:to:from; b=PvF7xG37PRsDYIU18KYEVBTcTVutQyCRhS6DE HO0Wok3supLR+E0Fg2fUBy413c6cYkWbR17BtkG522epEjARu9wnJSLSSpZc/sgkIVgOBS zazCuFVN8+UG8ogOJ3rRutf/ySHQcIIVgqOPY5XJ3eZXzDfO39yn8PHByF9LgfBNeOrP76 OGgOepLcBQAWijnjFkZ0I103ElxZekKomHr4x9FJ5nxz/WmCoilsFScp5ZffesWixl8LcS cbbCII2c/3FQm9mHowD9Db7toLMXwAdKr8T3dK4R19NnzkelrSy2tGJJ+ITWWopOCf4MWE sbTU7Bvp8mcRF8uvQXvbfMvOQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id be1b8c81 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 14:41:36 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Simon South Subject: Re: [PATCH v2 0/3] Knot: Enable DoH; build Info Manual; work on aarch64-linux References: In-reply-to: Date: Tue, 06 Oct 2020 16:41:24 +0200 Message-ID: <87mu0zzaaz.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43823-done Cc: 43823-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon, Thank you for this series. I really like the way our Knot package=20 looks now. Pushed to master as 4e869b180a94aa5bf5ae70ca48e0527e8e8db8db=20 together with XDP support, and some insignificant changes: Simon South =E5=86=99=E9=81=93=EF=BC=9A > - Removing mention in the commit descriptions of silencing=20 > warnings > from configure (he's right, it's a bit silly to worry about=20 > this); These warnings weren't worth it but it's certainly not silly to=20 pay attention to ./configure output. Good habit. ./configure=20 can't know if we're regressing, after all. > - Replacing the description in the patch file with something=20 > more > informative that includes a link to the original issue; and Thanks. > - Registering the patch file in gnu/local.mk. Perfect. I added =E2=80=98(dist_patch_DATA)=E2=80=99 to the commit message. Closing, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3yCFA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15MQoBANiHQTh99UuEXMr6i5lPnc+HJjpUKpsu1Hmy6dYF 0WDTAP9BWafp87o27W0hV0zTx6qzsElXuOaAdvmFv1W8uYsrBQ== =gPqI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 10:49:57 2020 Received: (at submit) by debbugs.gnu.org; 6 Oct 2020 14:49:57 +0000 Received: from localhost ([127.0.0.1]:53881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPoHt-0005Bn-IB for submit@debbugs.gnu.org; Tue, 06 Oct 2020 10:49:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:56970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPoHr-0005BY-5I for submit@debbugs.gnu.org; Tue, 06 Oct 2020 10:49:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPoHq-0001Ox-QQ for guix-patches@gnu.org; Tue, 06 Oct 2020 10:49:54 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:59262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPoHo-0007wc-Jz for guix-patches@gnu.org; Tue, 06 Oct 2020 10:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=1I0iO2xp8uGCW8sqz770FQoKweJrqhxuCSZUb6YDpy4=; h=date:in-reply-to: references:subject:cc:to:from; b=FnA14rFiXPyWy7cXgGgkE9n7e6Y4qxblHRTAA PHXuqU1UP/7cGhLNTyG012YteV3u3DHoUkkZWCoTqQtZoSYzR3xj2OWu+kpgThNSFr57dN Ln0LhD438T9xBTGS7O6EPcIPk2+wG3el3N37eyO/tWgWN82lnVmIUMOM+tW6LekGKdd3Ju TejUYu4NmOo3B6ZnsXju3oH9QI5m16LyVrKlGrgfqm8NOjS+TaX+2dY8wR3UpHhiyYw7mg EyV40PpR+otdmfsbkKKWTIHc5VNQl+2hrzkR6QKeHkcFhEVHZ+6jHcbJ8/3ViCakW0FEnr zHl+w2/Y0CLiRVrGGVRlTfJlw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 0b4a89c0 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 14:49:57 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; From: Tobias Geerinckx-Rice To: Tobias Geerinckx-Rice via Guix-patches Subject: Re: bug#43823: [PATCH v2 0/3] Knot: Enable DoH; build Info Manual; work on aarch64-linux References: <87mu0zzaaz.fsf@nckx> In-reply-to: <87mu0zzaaz.fsf@nckx> Date: Tue, 06 Oct 2020 16:49:47 +0200 Message-ID: <87k0w3z9x0.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Simon South , 43823-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > Pushed to master as 4e869b180a94aa5bf5ae70ca48e0527e8e8db8db=20 > together > with XDP support, and some insignificant changes: Oh, and of course a copyright line for you in (gnu packages dns). Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3yECw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15u00BAMMyLHN1xc/esXRo8GtUNEHNQOtyQzSJVg8nRSRc qo1pAP9frLe/irnFa67hoHhRf+EdcM9FQ762fU6RDUGPRIFoAA== =CoLM -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:12:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator