GNU bug report logs - #4381
23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: Erik Charlebois <erikcharlebois <at> gmail.com>,
        4381 <at> debbugs.gnu.org
Subject: bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs
Date: Thu, 24 Sep 2009 13:35:03 -0400

>>> --- faces.el.~1.446.~	2009-09-05 15:33:48.000000000 -0400
>>> +++ faces.el	2009-09-23 23:06:19.000000000 -0400
>>> @@ -2281,6 +2281,8 @@ terminal type to a different value."
>>> (defface region
>>> '((((class color) (min-colors 88) (background dark))
>>> :background "blue3")
>>> +    (((class color) (min-colors 88) (background light) (type ns))
>>> +     :background "ns_selection_color")
>>> (((class color) (min-colors 88) (background light))
>>> :background "lightgoldenrod2")
>>> (((class color) (min-colors 16) (background dark))
>> 
>> Could you add a comment explaining why you put (background light) in
>> the specs?  I guess it's because the ns_selection_color is (almost)
>> always defined with the assumption that it will be used on text
>> displayed on a light background., right?

> Something like:

> ;; Region face: under NS, use the system-defined selection color
> ;; (optimized for the system-fixed white background of other apps),
> ;; if background is light.

Looks good, please install it,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.