GNU bug report logs - #43792
[PATCH] Add ert macros to get resource file names

Previous Next

Full log

Message #8 received at 43792 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 43792 <at> debbugs.gnu.org
Subject: Re: bug#43792: [PATCH] Add ert macros to get resource file names
Date: Sun, 04 Oct 2020 19:25:50 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

Hi Stefan,

> There's a lot of repetitive code to get at the resource directories for
> tests.  That's obviously boring, so I'd propose something like the
> following two macros to make it easier:
>
> (ert-resource-directory)
> (ert-resource-file NAME)
>
> Please see the attached patch, the second of which uses the macros in
> our test suite.  Not sure if they should be in ert.el, so I put them in
> ert-x.el for now to play it safe.
>
> Any comments?

Nice idea. Have you tested, that it also works for GNU ELPA packages?
And no, pls change the tests in GNU ELPA yet, unless they require Emacs 28.

I miss a patch for dbus-tests.el.

For Tramp, I would need to adapt your change due to backward
compatibility. But don't worry, your patch could go as it is into master before.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.