GNU bug report logs - #43792
[PATCH] Add ert macros to get resource file names

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Sun, 4 Oct 2020 12:41:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #19 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 43792 <at> debbugs.gnu.org
Subject: Re: bug#43792: [PATCH] Add ert macros to get resource file names
Date: Fri, 16 Oct 2020 02:47:45 -0700
close 43792 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> There's a lot of repetitive code to get at the resource directories for
>> tests.  That's obviously boring, so I'd propose something like the
>> following two macros to make it easier:
>>
>> (ert-resource-directory)
>> (ert-resource-file NAME)
>>
>> Please see the attached patch, the second of which uses the macros in
>> our test suite.  Not sure if they should be in ert.el, so I put them in
>> ert-x.el for now to play it safe.
>
> Looks good to me.

Thanks for reviewing; pushed to master as commit f52a775ae2 and
1f44a77672.




This bug report was last modified 4 years and 217 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.