GNU bug report logs - #43772
27.1; (describe-variable) breaks eshell

Previous Next

Full log

Message #16 received at 43772 <at> debbugs.gnu.org (full text, mbox):

From: Ruthra Kumar <ruthrab <at> gmail.com>
To: 43772 <at> debbugs.gnu.org
Subject: Fix for bug#43772
Date: Sun, 15 Nov 2020 19:43:14 +0530

[Message part 1 (text/plain, inline)]

Hello Lars,

As you've mentioned, parsing ( and prompting ) is not done, when
command is sent directly to shell. But, i think
'eshell-invoke-directly' should not have returned true for sudo and
su. Comment section in 'eshell-find-alias-function' best describes it,

(defun eshell-find-alias-function (name)
 ...
    ;; If the function exists, but is defined in an eshell module
    ;; that's not currently enabled, don't report it as found.

eshell-tramp is disabled by default. So, eshell-invoke-directly should
return nil for su and sudo ( I'm new to eshell as well. So, I might be
wrong here ). Replacing fboundp with 'eshell-find-alias-function'
should fix this. So far, I've tested locally and it is working fine.

Patch attached.

Regards
Ruthra Kumar

[0001-eshell-invoke-directly-use-eshell-find-alias-functio.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.