From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:36:55 2020 Received: (at submit) by debbugs.gnu.org; 2 Oct 2020 18:36:55 +0000 Received: from localhost ([127.0.0.1]:42554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPvL-0002e7-5e for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:36:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:53744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPvI-0002dy-OG for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:36:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOPvI-0008AC-HP for guix-patches@gnu.org; Fri, 02 Oct 2020 14:36:52 -0400 Received: from mira.cbaines.net ([212.71.252.8]:46578) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOPvG-0001hw-Gk for guix-patches@gnu.org; Fri, 02 Oct 2020 14:36:52 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id 2C11E27BBE8 for ; Fri, 2 Oct 2020 19:36:47 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 7eda0819 for ; Fri, 2 Oct 2020 18:36:44 +0000 (UTC) User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH 0/5] PostgreSQL service improvements Date: Fri, 02 Oct 2020 19:36:44 +0100 Message-ID: <87lfgo1nlv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 14:36:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Christopher Baines (5): Replace (postgresql-service) with (service postgresql-service-type) Add some subheadings in to the Databases section of the docs Remove the postgresql-service procedure Define postgresql-10 Don't specify a default postgresql version to use for the service doc/guix.texi | 52 +++++++++++++++++++++++++++++++------- gnu/packages/databases.scm | 2 ++ gnu/services/databases.scm | 25 ++---------------- gnu/tests/databases.scm | 4 ++- gnu/tests/guix.scm | 1 + gnu/tests/monitoring.scm | 4 ++- gnu/tests/web.scm | 4 ++- 7 files changed, 57 insertions(+), 35 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:41:04 2020 Received: (at 43771) by debbugs.gnu.org; 2 Oct 2020 18:41:05 +0000 Received: from localhost ([127.0.0.1]:42564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzM-0002lN-M9 for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:04 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzK-0002kp-RW for 43771@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:03 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id 4104727BBEB for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 19:41:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d8151417 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 18:40:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH 4/5] Define postgresql-10 Date: Fri, 2 Oct 2020 19:40:58 +0100 Message-Id: <20201002184059.29033-4-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201002184059.29033-1-mail@cbaines.net> References: <20201002184059.29033-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) So that it can be used, rather than postgresql. Because the major version of the package is important, as it relates to the compatability with the data files used by the service, it's useful to have a stable name to refer to a package for version 10 of PostgreSQL. --- gnu/packages/databases.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index ece4580c36..8cab3eb115 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -1038,6 +1038,8 @@ TIMESTAMP. It also supports storage of binary large objects, including pictures, sounds, or video.") (license (license:x11-style "file://COPYRIGHT")))) +(define-public postgresql-10 postgresql) + (define-public postgresql-11 (package (inherit postgresql) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:41:05 2020 Received: (at 43771) by debbugs.gnu.org; 2 Oct 2020 18:41:05 +0000 Received: from localhost ([127.0.0.1]:42566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzM-0002lQ-T4 for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzK-0002kr-RQ for 43771@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:03 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id 19F2B27BBE9 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 19:41:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 1253e086 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 18:40:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH 2/5] Add some subheadings in to the Databases section of the docs Date: Fri, 2 Oct 2020 19:40:56 +0100 Message-Id: <20201002184059.29033-2-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201002184059.29033-1-mail@cbaines.net> References: <20201002184059.29033-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) To make it clearer where the relevant documentation for a particular service starts and ends. --- doc/guix.texi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 79c79b6a96..4197cd562a 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17736,6 +17736,8 @@ details. @cindex SQL The @code{(gnu services databases)} module provides the following services. +@subsubheading PostgreSQL + @deffn {Scheme Procedure} postgresql-service [#:postgresql postgresql] @ [#:config-file] [#:data-directory ``/var/lib/postgresql/data''] @ [#:port 5432] [#:locale ``en_US.utf8''] [#:extension-packages '()] @@ -17801,6 +17803,8 @@ dblink as they are already loadable by postgresql. This field is only required to add extensions provided by other packages. @end deffn +@subsubheading MariaDB/MySQL + @deffn {Scheme Procedure} mysql-service [#:config (mysql-configuration)] Return a service that runs @command{mysqld}, the MySQL or MariaDB database server. @@ -17825,6 +17829,8 @@ TCP port on which the database server listens for incoming connections. @end table @end deftp +@subsubheading Memcached + @defvr {Scheme Variable} memcached-service-type This is the service type for the @uref{https://memcached.org/, Memcached} service, which provides a distributed in memory cache. The @@ -17857,6 +17863,8 @@ Additional command line options to pass to @code{memcached}. @end table @end deftp +@subsubheading MongoDB + @defvr {Scheme Variable} mongodb-service-type This is the service type for @uref{https://www.mongodb.com/, MongoDB}. The value for the service type is a @code{mongodb-configuration} object. @@ -17883,6 +17891,8 @@ MongoDB is configured to use through the configuration file. @end table @end deftp +@subsubheading Redis + @defvr {Scheme Variable} redis-service-type This is the service type for the @uref{https://redis.io/, Redis} key/value store, whose value is a @code{redis-configuration} object. -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:41:05 2020 Received: (at 43771) by debbugs.gnu.org; 2 Oct 2020 18:41:05 +0000 Received: from localhost ([127.0.0.1]:42568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzN-0002lX-8G for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzK-0002ko-Rx for 43771@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:03 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id 2B24C27BBEA for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 19:41:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 61143908 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 18:40:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH 3/5] Remove the postgresql-service procedure Date: Fri, 2 Oct 2020 19:40:57 +0100 Message-Id: <20201002184059.29033-3-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201002184059.29033-1-mail@cbaines.net> References: <20201002184059.29033-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It's unnecessary, using the service type directly is a better approach. While this is unfortunately a breaking change, I'm also looking at making breaking changes to the service type configuration, so I don't think this can be avoided. --- doc/guix.texi | 40 +++++++++++++++++++++++++++++--------- gnu/services/databases.scm | 19 ------------------ 2 files changed, 31 insertions(+), 28 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 4197cd562a..641b410acf 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17738,15 +17738,12 @@ The @code{(gnu services databases)} module provides the following services. @subsubheading PostgreSQL -@deffn {Scheme Procedure} postgresql-service [#:postgresql postgresql] @ - [#:config-file] [#:data-directory ``/var/lib/postgresql/data''] @ - [#:port 5432] [#:locale ``en_US.utf8''] [#:extension-packages '()] -Return a service that runs @var{postgresql}, the PostgreSQL database -server. +The following example describes a PostgreSQL service with the default +configuration. -The PostgreSQL daemon loads its runtime configuration from @var{config-file}, -creates a database cluster with @var{locale} as the default -locale, stored in @var{data-directory}. It then listens on @var{port}. +@lisp +(service postgresql-service-type) +@end lisp If the services fails to start, it may be due to an incompatible cluster already present in @var{data-directory}. Adjust it (or, if you @@ -17766,6 +17763,29 @@ createuser --interactive createdb $MY_USER_LOGIN # Replace appropriately. @end example +@deftp {Data Type} postgresql-configuration +Data type representing the configuration for the +@code{postgresql-service-type}. + +@table @asis +@item @var{postgresql} (default: @code{postgresql}) +PostgreSQL package to use for the service. + +@item @var{port} (default: @code{5432}) +Port on which PostgreSQL should listen. + +@item @var{locale} (default: @code{"en_US.utf8"}) +Locale to use as the default when creating the database cluster. + +@item @var{config-file} (default: @code{(postgresql-config-file)}) +The configuration file to use when running PostgreSQL. The default +behaviour uses the postgresql-config-file record with the default values +for the fields. + +@item @var{data-directory} (default: @code{"/var/lib/postgresql/data"}) +Directory in which to store the data. + +@item @var{extension-packages} (default: @code{'()}) @cindex postgresql extension-packages Additional extensions are loaded from packages listed in @var{extension-packages}. Extensions are available at runtime. For instance, @@ -17801,7 +17821,9 @@ psql -U postgres There is no need to add this field for contrib extensions such as hstore or dblink as they are already loadable by postgresql. This field is only required to add extensions provided by other packages. -@end deffn + +@end table +@end deftp @subsubheading MariaDB/MySQL diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index 2bddf70f71..efad182a68 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -281,25 +281,6 @@ host all all ::1/128 md5")) (compose list postgresql-configuration-postgresql)))) (default-value (postgresql-configuration)))) -(define* (postgresql-service #:key (postgresql postgresql) - (port 5432) - (locale "en_US.utf8") - (config-file (postgresql-config-file)) - (data-directory "/var/lib/postgresql/data") - (extension-packages '())) - "Return a service that runs @var{postgresql}, the PostgreSQL database server. - -The PostgreSQL daemon loads its runtime configuration from @var{config-file} -and stores the database cluster in @var{data-directory}." - (service postgresql-service-type - (postgresql-configuration - (postgresql postgresql) - (port port) - (locale locale) - (config-file config-file) - (data-directory data-directory) - (extension-packages extension-packages)))) - ;;; ;;; Memcached -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:41:06 2020 Received: (at 43771) by debbugs.gnu.org; 2 Oct 2020 18:41:06 +0000 Received: from localhost ([127.0.0.1]:42570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzN-0002le-Ll for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzK-0002ks-S1 for 43771@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:04 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id 55D3027BBEC for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 19:41:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b89fd893 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 18:40:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH 5/5] Don't specify a default postgresql version to use for the service Date: Fri, 2 Oct 2020 19:40:59 +0100 Message-Id: <20201002184059.29033-5-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201002184059.29033-1-mail@cbaines.net> References: <20201002184059.29033-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Currently, if the postgresql package major version changes, this is going to break the service upon upgrade, because PostgreSQL will reject the data files from the differing major version of the service. Because it's important to either keep running a particular major version, or intentionally upgrade, I think the configuration would be better with no default. I think this is also going to be helpful when trying to assist users upgrading PostgreSQL. --- doc/guix.texi | 6 ++++-- gnu/services/databases.scm | 6 ++---- gnu/tests/databases.scm | 4 +++- gnu/tests/guix.scm | 1 + gnu/tests/monitoring.scm | 4 +++- gnu/tests/web.scm | 4 +++- 6 files changed, 16 insertions(+), 9 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 641b410acf..4ce0072ed4 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -17742,7 +17742,9 @@ The following example describes a PostgreSQL service with the default configuration. @lisp -(service postgresql-service-type) +(service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) @end lisp If the services fails to start, it may be due to an incompatible @@ -17768,7 +17770,7 @@ Data type representing the configuration for the @code{postgresql-service-type}. @table @asis -@item @var{postgresql} (default: @code{postgresql}) +@item @var{postgresql} PostgreSQL package to use for the service. @item @var{port} (default: @code{5432}) diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index efad182a68..96d2dc4935 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -146,8 +146,7 @@ host all all ::1/128 md5")) (define-record-type* postgresql-configuration make-postgresql-configuration postgresql-configuration? - (postgresql postgresql-configuration-postgresql ; - (default postgresql)) + (postgresql postgresql-configuration-postgresql) ; (port postgresql-configuration-port (default 5432)) (locale postgresql-configuration-locale @@ -278,8 +277,7 @@ host all all ::1/128 md5")) (service-extension account-service-type (const %postgresql-accounts)) (service-extension profile-service-type - (compose list postgresql-configuration-postgresql)))) - (default-value (postgresql-configuration)))) + (compose list postgresql-configuration-postgresql)))))) ;;; diff --git a/gnu/tests/databases.scm b/gnu/tests/databases.scm index e0544bbcd2..d3045cc3f7 100644 --- a/gnu/tests/databases.scm +++ b/gnu/tests/databases.scm @@ -215,7 +215,9 @@ (define %postgresql-os (simple-operating-system - (service postgresql-service-type))) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))))) (define (run-postgresql-test) "Run tests in %POSTGRESQL-OS." diff --git a/gnu/tests/guix.scm b/gnu/tests/guix.scm index 6139e31cf0..ebee8d43af 100644 --- a/gnu/tests/guix.scm +++ b/gnu/tests/guix.scm @@ -83,6 +83,7 @@ (service dhcp-client-service-type) (service postgresql-service-type (postgresql-configuration + (postgresql postgresql-10) (config-file (postgresql-config-file (hba-file diff --git a/gnu/tests/monitoring.scm b/gnu/tests/monitoring.scm index 17b9edc3ac..7371b02fe1 100644 --- a/gnu/tests/monitoring.scm +++ b/gnu/tests/monitoring.scm @@ -307,7 +307,9 @@ zabbix||{} (let ((base-os (simple-operating-system (service dhcp-client-service-type) - (service postgresql-service-type) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) (service zabbix-front-end-service-type (zabbix-front-end-configuration (db-password "zabbix"))) diff --git a/gnu/tests/web.scm b/gnu/tests/web.scm index 7513eab2e4..7f4518acd2 100644 --- a/gnu/tests/web.scm +++ b/gnu/tests/web.scm @@ -567,7 +567,9 @@ HTTP-PORT." (config (httpd-config-file (listen '("8080")))))) - (service postgresql-service-type) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) (service patchwork-service-type (patchwork-configuration (patchwork patchwork) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 02 14:41:07 2020 Received: (at 43771) by debbugs.gnu.org; 2 Oct 2020 18:41:07 +0000 Received: from localhost ([127.0.0.1]:42572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzP-0002lr-10 for submit@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:07 -0400 Received: from mira.cbaines.net ([212.71.252.8]:44620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOPzK-0002kn-SV for 43771@debbugs.gnu.org; Fri, 02 Oct 2020 14:41:04 -0400 Received: from localhost (188.28.111.33.threembb.co.uk [188.28.111.33]) by mira.cbaines.net (Postfix) with ESMTPSA id F1FCB27BBE8 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 19:41:01 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 367ef504 for <43771@debbugs.gnu.org>; Fri, 2 Oct 2020 18:40:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH 1/5] Replace (postgresql-service) with (service postgresql-service-type) Date: Fri, 2 Oct 2020 19:40:55 +0100 Message-Id: <20201002184059.29033-1-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) As I'm looking at removing the procedure, in favour of always using the service type. --- gnu/tests/monitoring.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/tests/monitoring.scm b/gnu/tests/monitoring.scm index d20b8ac59e..17b9edc3ac 100644 --- a/gnu/tests/monitoring.scm +++ b/gnu/tests/monitoring.scm @@ -307,7 +307,7 @@ zabbix||{} (let ((base-os (simple-operating-system (service dhcp-client-service-type) - (postgresql-service) + (service postgresql-service-type) (service zabbix-front-end-service-type (zabbix-front-end-configuration (db-password "zabbix"))) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 04:33:57 2020 Received: (at 43771) by debbugs.gnu.org; 5 Oct 2020 08:33:57 +0000 Received: from localhost ([127.0.0.1]:47850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLwT-0000gk-0o for submit@debbugs.gnu.org; Mon, 05 Oct 2020 04:33:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLwR-0000gX-9F for 43771@debbugs.gnu.org; Mon, 05 Oct 2020 04:33:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54779) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLwL-0000Cg-Lu; Mon, 05 Oct 2020 04:33:49 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=34198 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPLwL-00047z-2F; Mon, 05 Oct 2020 04:33:49 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure References: <20201002184059.29033-1-mail@cbaines.net> <20201002184059.29033-3-mail@cbaines.net> Date: Mon, 05 Oct 2020 10:33:47 +0200 In-Reply-To: <20201002184059.29033-3-mail@cbaines.net> (Christopher Baines's message of "Fri, 2 Oct 2020 19:40:57 +0100") Message-ID: <87pn5x3wd0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43771 Cc: 43771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > It's unnecessary, using the service type directly is a better approach. W= hile > this is unfortunately a breaking change, I'm also looking at making break= ing > changes to the service type configuration, so I don't think this can be > avoided. [...] > -(define* (postgresql-service #:key (postgresql postgresql) > - (port 5432) > - (locale "en_US.utf8") Here I=E2=80=99d suggest to keep it as =E2=80=98define-deprecated=E2=80=99,= like we did for other such procedures. Otherwise LGTM. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 04:35:01 2020 Received: (at 43771) by debbugs.gnu.org; 5 Oct 2020 08:35:01 +0000 Received: from localhost ([127.0.0.1]:47854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLxV-0000id-Cr for submit@debbugs.gnu.org; Mon, 05 Oct 2020 04:35:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPLxT-0000iJ-N3 for 43771@debbugs.gnu.org; Mon, 05 Oct 2020 04:35:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54782) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPLxN-0000Fw-W1; Mon, 05 Oct 2020 04:34:54 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=34200 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kPLxN-0004AW-FV; Mon, 05 Oct 2020 04:34:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#43771] [PATCH 0/5] PostgreSQL service improvements References: <87lfgo1nlv.fsf@cbaines.net> Date: Mon, 05 Oct 2020 10:34:52 +0200 In-Reply-To: <87lfgo1nlv.fsf@cbaines.net> (Christopher Baines's message of "Fri, 02 Oct 2020 19:36:44 +0100") Message-ID: <87lfgl3wb7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43771 Cc: 43771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Christopher Baines skribis: > Christopher Baines (5): > Replace (postgresql-service) with (service postgresql-service-type) > Add some subheadings in to the Databases section of the docs > Remove the postgresql-service procedure > Define postgresql-10 > Don't specify a default postgresql version to use for the service It all LGTM=E2=80=A6 except for commit logs. :-) Please add the conventio= nal subject line and ChangeLog-style entries. I=E2=80=99m sorry to spoil your Monday morning. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:01:18 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:01:18 +0000 Received: from localhost ([127.0.0.1]:42417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaPF-0008AF-R2 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:01:18 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaPD-0008A7-Mc for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:01:16 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id AB50E27BBED; Mon, 19 Oct 2020 20:01:14 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id cb320287; Mon, 19 Oct 2020 19:01:12 +0000 (UTC) References: <20201002184059.29033-1-mail@cbaines.net> <20201002184059.29033-3-mail@cbaines.net> <87pn5x3wd0.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure In-reply-to: <87pn5x3wd0.fsf@gnu.org> Date: Mon, 19 Oct 2020 20:01:12 +0100 Message-ID: <87a6wihwg7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 Cc: 43771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> It's unnecessary, using the service type directly is a better approach. = While >> this is unfortunately a breaking change, I'm also looking at making brea= king >> changes to the service type configuration, so I don't think this can be >> avoided. > > [...] > >> -(define* (postgresql-service #:key (postgresql postgresql) >> - (port 5432) >> - (locale "en_US.utf8") > > Here I=E2=80=99d suggest to keep it as =E2=80=98define-deprecated=E2=80= =99, like we did for > other such procedures. Ah, yeah, I discounted that initially, as I didn't see a way to adapt it to the new behaviour, but the deprecated procedure can just have the old behaviour. I'll send some updated patches with it deprecated. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+N4nhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd5iRAAqQcGqQQ10D0puIDptLEe6YDC13p+lSLh i/TniWEDyxqrQWik49nYyPubvqjG2mLmy/QAmn4kMghkmufzPIF+QNYzbSi3t13J y8jVFszDOd/d4roe4Ox0sP8epqsofIVDfZVQrQee/2gQNIko/RLehc9r/BgB6bxe nw21O03UNqkkgjZYxu8R8L7nYoo3Sntr/WDwd8BOiTm+NjSEZ/8OWIJz34Qpe53T QV346n78RH9Nzi7NVgImqX0uSxx6Xp1m3nQLWWsHtpQUmU6p/T7FMDTfOgAteJoG svn9oUXNtHM9tlWu6G8FbRkfRA3vNjKEpAu6w9dC1NpUpFawRq+WOnQZaKr6bMj0 v/NddxelIZIsrKXlTgCgIOBZ4adTDLMq9f0nuzExWi6IWdlvKL8ekQHCQeTK/ycY MuBwwimB61Q5w2cLeUuJ4W2bC7ezPDvZo0W7cftEw1MHIRHFwTrp8jFVGlJDSp72 3Obht/dcEcVgpupSzqHute1y4wmyP59B3DHbqjktfFqlI+fYOGVMDJvoGwlVIXgM WuEecpLU4mV0vlk5TcjFJJEOzEMK08LuvAXGMJYCUwgX6bKFQ7H4UpdY8ZMGp+U/ QLKGi9LycDjk7L31Cbz6Cisv6frPvqex2Hk+BZluBk9lKUKiL+81JedgHEZNcgVS fYdan5PPbfo= =sZ19 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:03:03 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:03:03 +0000 Received: from localhost ([127.0.0.1]:42429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQx-0008Da-FJ for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:03 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQw-0008D3-BC for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:02 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id D865927BBED for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 20:03:01 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 94c13bce for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 19:02:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH v2 1/5] tests: monitoring: Use (service postgresql-service-type). Date: Mon, 19 Oct 2020 20:02:55 +0100 Message-Id: <20201019190259.11356-1-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <87lfgl3wb7.fsf@gnu.org> References: <87lfgl3wb7.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) As I'm looking at removing the procedure, in favour of always using the service type. * gnu/tests/monitoring.scm (%zabbix-os): Use (service postgresql-service-type) rather than (postgresql-service). --- gnu/tests/monitoring.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/tests/monitoring.scm b/gnu/tests/monitoring.scm index d20b8ac59e..17b9edc3ac 100644 --- a/gnu/tests/monitoring.scm +++ b/gnu/tests/monitoring.scm @@ -307,7 +307,7 @@ zabbix||{} (let ((base-os (simple-operating-system (service dhcp-client-service-type) - (postgresql-service) + (service postgresql-service-type) (service zabbix-front-end-service-type (zabbix-front-end-configuration (db-password "zabbix"))) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:03:04 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:03:04 +0000 Received: from localhost ([127.0.0.1]:42431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQx-0008Do-RM for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:04 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQw-0008D5-Dk for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:03 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id EFD0427BBEE for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 20:03:01 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 67366954 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 19:02:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH v2 2/5] doc: Add subheadings in to the Databases section. Date: Mon, 19 Oct 2020 20:02:56 +0100 Message-Id: <20201019190259.11356-2-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201019190259.11356-1-mail@cbaines.net> References: <87lfgl3wb7.fsf@gnu.org> <20201019190259.11356-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) To make it clearer where the relevant documentation for a particular service starts and ends. * doc/guix.texi (Database Services): Add subheadings. --- doc/guix.texi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 130985d30f..d6d610acae 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18178,6 +18178,8 @@ details. @cindex SQL The @code{(gnu services databases)} module provides the following services. +@subsubheading PostgreSQL + @deffn {Scheme Procedure} postgresql-service [#:postgresql postgresql] @ [#:config-file] [#:data-directory ``/var/lib/postgresql/data''] @ [#:port 5432] [#:locale ``en_US.utf8''] [#:extension-packages '()] @@ -18243,6 +18245,8 @@ dblink as they are already loadable by postgresql. This field is only required to add extensions provided by other packages. @end deffn +@subsubheading MariaDB/MySQL + @deffn {Scheme Procedure} mysql-service [#:config (mysql-configuration)] Return a service that runs @command{mysqld}, the MySQL or MariaDB database server. @@ -18267,6 +18271,8 @@ TCP port on which the database server listens for incoming connections. @end table @end deftp +@subsubheading Memcached + @defvr {Scheme Variable} memcached-service-type This is the service type for the @uref{https://memcached.org/, Memcached} service, which provides a distributed in memory cache. The @@ -18299,6 +18305,8 @@ Additional command line options to pass to @code{memcached}. @end table @end deftp +@subsubheading MongoDB + @defvr {Scheme Variable} mongodb-service-type This is the service type for @uref{https://www.mongodb.com/, MongoDB}. The value for the service type is a @code{mongodb-configuration} object. @@ -18325,6 +18333,8 @@ MongoDB is configured to use through the configuration file. @end table @end deftp +@subsubheading Redis + @defvr {Scheme Variable} redis-service-type This is the service type for the @uref{https://redis.io/, Redis} key/value store, whose value is a @code{redis-configuration} object. -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:03:14 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:03:14 +0000 Received: from localhost ([127.0.0.1]:42433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaR8-0008EB-7t for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:14 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQw-0008DD-KC for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:03 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 2407E27BBF1 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 20:03:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 65b3ef86 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 19:02:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH v2 4/5] gnu: databases: Define postgresql-10. Date: Mon, 19 Oct 2020 20:02:58 +0100 Message-Id: <20201019190259.11356-4-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201019190259.11356-1-mail@cbaines.net> References: <87lfgl3wb7.fsf@gnu.org> <20201019190259.11356-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) So that it can be used, rather than postgresql. Because the major version of the package is important, as it relates to the compatability with the data files used by the service, it's useful to have a stable name to refer to a package for version 10 of PostgreSQL. * gnu/packages/databases.scm (postgresql-10): New variable. --- gnu/packages/databases.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 1236f57018..0d8342b04a 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -1040,6 +1040,8 @@ TIMESTAMP. It also supports storage of binary large objects, including pictures, sounds, or video.") (license (license:x11-style "file://COPYRIGHT")))) +(define-public postgresql-10 postgresql) + (define-public postgresql-11 (package (inherit postgresql) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:03:14 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:03:15 +0000 Received: from localhost ([127.0.0.1]:42435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaR8-0008ED-Ge for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:14 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQw-0008D6-Gh for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:03 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 0F30227BBF0 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 20:03:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 6fb2aa3d for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 19:02:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH v2 3/5] services: databases: Deprecate the postgresql-service procedure. Date: Mon, 19 Oct 2020 20:02:57 +0100 Message-Id: <20201019190259.11356-3-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201019190259.11356-1-mail@cbaines.net> References: <87lfgl3wb7.fsf@gnu.org> <20201019190259.11356-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Using the service type directly is a better approach, making it easier to configure the service. * gnu/services/databases.scm (postgresql-service): Deprecate this procedure. * doc/guix.texi (PostgreSQL): Update the documentation for the use of (service postgresql-service-type). --- doc/guix.texi | 40 +++++++++++++++++++++++++++++--------- gnu/services/databases.scm | 14 +++++++------ 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index d6d610acae..8aaa896c8d 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18180,15 +18180,12 @@ The @code{(gnu services databases)} module provides the following services. @subsubheading PostgreSQL -@deffn {Scheme Procedure} postgresql-service [#:postgresql postgresql] @ - [#:config-file] [#:data-directory ``/var/lib/postgresql/data''] @ - [#:port 5432] [#:locale ``en_US.utf8''] [#:extension-packages '()] -Return a service that runs @var{postgresql}, the PostgreSQL database -server. +The following example describes a PostgreSQL service with the default +configuration. -The PostgreSQL daemon loads its runtime configuration from @var{config-file}, -creates a database cluster with @var{locale} as the default -locale, stored in @var{data-directory}. It then listens on @var{port}. +@lisp +(service postgresql-service-type) +@end lisp If the services fails to start, it may be due to an incompatible cluster already present in @var{data-directory}. Adjust it (or, if you @@ -18208,6 +18205,29 @@ createuser --interactive createdb $MY_USER_LOGIN # Replace appropriately. @end example +@deftp {Data Type} postgresql-configuration +Data type representing the configuration for the +@code{postgresql-service-type}. + +@table @asis +@item @var{postgresql} (default: @code{postgresql}) +PostgreSQL package to use for the service. + +@item @var{port} (default: @code{5432}) +Port on which PostgreSQL should listen. + +@item @var{locale} (default: @code{"en_US.utf8"}) +Locale to use as the default when creating the database cluster. + +@item @var{config-file} (default: @code{(postgresql-config-file)}) +The configuration file to use when running PostgreSQL. The default +behaviour uses the postgresql-config-file record with the default values +for the fields. + +@item @var{data-directory} (default: @code{"/var/lib/postgresql/data"}) +Directory in which to store the data. + +@item @var{extension-packages} (default: @code{'()}) @cindex postgresql extension-packages Additional extensions are loaded from packages listed in @var{extension-packages}. Extensions are available at runtime. For instance, @@ -18243,7 +18263,9 @@ psql -U postgres There is no need to add this field for contrib extensions such as hstore or dblink as they are already loadable by postgresql. This field is only required to add extensions provided by other packages. -@end deffn + +@end table +@end deftp @subsubheading MariaDB/MySQL diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index 2bddf70f71..7908a3e0f6 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -30,6 +30,7 @@ #:use-module (gnu packages databases) #:use-module (guix build-system trivial) #:use-module (guix build union) + #:use-module (guix deprecation) #:use-module (guix modules) #:use-module (guix packages) #:use-module (guix records) @@ -281,12 +282,13 @@ host all all ::1/128 md5")) (compose list postgresql-configuration-postgresql)))) (default-value (postgresql-configuration)))) -(define* (postgresql-service #:key (postgresql postgresql) - (port 5432) - (locale "en_US.utf8") - (config-file (postgresql-config-file)) - (data-directory "/var/lib/postgresql/data") - (extension-packages '())) +(define-deprecated (postgresql-service #:key (postgresql postgresql) + (port 5432) + (locale "en_US.utf8") + (config-file (postgresql-config-file)) + (data-directory "/var/lib/postgresql/data") + (extension-packages '())) + postgresql-service-type "Return a service that runs @var{postgresql}, the PostgreSQL database server. The PostgreSQL daemon loads its runtime configuration from @var{config-file} -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 15:03:15 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:03:15 +0000 Received: from localhost ([127.0.0.1]:42437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaR8-0008EK-T6 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:15 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQw-0008DI-OA for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:03:03 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 427B427BBF2 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 20:03:02 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fc553e56 for <43771@debbugs.gnu.org>; Mon, 19 Oct 2020 19:02:59 +0000 (UTC) From: Christopher Baines To: 43771@debbugs.gnu.org Subject: [PATCH v2 5/5] services: databases: Don't specify a default postgresql version. Date: Mon, 19 Oct 2020 20:02:59 +0100 Message-Id: <20201019190259.11356-5-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201019190259.11356-1-mail@cbaines.net> References: <87lfgl3wb7.fsf@gnu.org> <20201019190259.11356-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Currently, if the postgresql package major version changes, this is going to break the service upon upgrade, because PostgreSQL will reject the data files from the differing major version of the service. Because it's important to either keep running a particular major version, or intentionally upgrade, I think the configuration would be better with no default. I think this is also going to be helpful when trying to assist users upgrading PostgreSQL. * gnu/services/databases.scm (): Remove default for postgresql. (postgresql-service-type): Remove the default value. * gnu/tests/databases.scm (%postgresql-os): Update accordingly. * gnu/tests/guix.scm (%guix-data-service-os): Update accordingly. * gnu/tests/monitoring.scm (%zabbix-os): Update accordingly. * gnu/tests/web.scm (patchwork-os): Update accordingly. * doc/guix.texi (PostgreSQL): Update accordingly. --- doc/guix.texi | 6 ++++-- gnu/services/databases.scm | 6 ++---- gnu/tests/databases.scm | 4 +++- gnu/tests/guix.scm | 1 + gnu/tests/monitoring.scm | 4 +++- gnu/tests/web.scm | 4 +++- 6 files changed, 16 insertions(+), 9 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 8aaa896c8d..bc62a1f797 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18184,7 +18184,9 @@ The following example describes a PostgreSQL service with the default configuration. @lisp -(service postgresql-service-type) +(service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) @end lisp If the services fails to start, it may be due to an incompatible @@ -18210,7 +18212,7 @@ Data type representing the configuration for the @code{postgresql-service-type}. @table @asis -@item @var{postgresql} (default: @code{postgresql}) +@item @var{postgresql} PostgreSQL package to use for the service. @item @var{port} (default: @code{5432}) diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index 7908a3e0f6..d7b4594b9e 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -147,8 +147,7 @@ host all all ::1/128 md5")) (define-record-type* postgresql-configuration make-postgresql-configuration postgresql-configuration? - (postgresql postgresql-configuration-postgresql ; - (default postgresql)) + (postgresql postgresql-configuration-postgresql) ; (port postgresql-configuration-port (default 5432)) (locale postgresql-configuration-locale @@ -279,8 +278,7 @@ host all all ::1/128 md5")) (service-extension account-service-type (const %postgresql-accounts)) (service-extension profile-service-type - (compose list postgresql-configuration-postgresql)))) - (default-value (postgresql-configuration)))) + (compose list postgresql-configuration-postgresql)))))) (define-deprecated (postgresql-service #:key (postgresql postgresql) (port 5432) diff --git a/gnu/tests/databases.scm b/gnu/tests/databases.scm index e0544bbcd2..d3045cc3f7 100644 --- a/gnu/tests/databases.scm +++ b/gnu/tests/databases.scm @@ -215,7 +215,9 @@ (define %postgresql-os (simple-operating-system - (service postgresql-service-type))) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))))) (define (run-postgresql-test) "Run tests in %POSTGRESQL-OS." diff --git a/gnu/tests/guix.scm b/gnu/tests/guix.scm index 20b67d55d3..af7d8f0b21 100644 --- a/gnu/tests/guix.scm +++ b/gnu/tests/guix.scm @@ -156,6 +156,7 @@ (service dhcp-client-service-type) (service postgresql-service-type (postgresql-configuration + (postgresql postgresql-10) (config-file (postgresql-config-file (hba-file diff --git a/gnu/tests/monitoring.scm b/gnu/tests/monitoring.scm index 17b9edc3ac..7371b02fe1 100644 --- a/gnu/tests/monitoring.scm +++ b/gnu/tests/monitoring.scm @@ -307,7 +307,9 @@ zabbix||{} (let ((base-os (simple-operating-system (service dhcp-client-service-type) - (service postgresql-service-type) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) (service zabbix-front-end-service-type (zabbix-front-end-configuration (db-password "zabbix"))) diff --git a/gnu/tests/web.scm b/gnu/tests/web.scm index 7513eab2e4..7f4518acd2 100644 --- a/gnu/tests/web.scm +++ b/gnu/tests/web.scm @@ -567,7 +567,9 @@ HTTP-PORT." (config (httpd-config-file (listen '("8080")))))) - (service postgresql-service-type) + (service postgresql-service-type + (postgresql-configuration + (postgresql postgresql-10))) (service patchwork-service-type (patchwork-configuration (patchwork patchwork) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 19 17:02:40 2020 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 21:02:40 +0000 Received: from localhost ([127.0.0.1]:42618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUcIi-0002is-Ij for submit@debbugs.gnu.org; Mon, 19 Oct 2020 17:02:40 -0400 Received: from mira.cbaines.net ([212.71.252.8]:35262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUcIg-0002ik-BJ for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 17:02:38 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 7E44927BBED; Mon, 19 Oct 2020 22:02:37 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 71984252; Mon, 19 Oct 2020 21:02:35 +0000 (UTC) References: <87lfgo1nlv.fsf@cbaines.net> <87lfgl3wb7.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#43771] [PATCH 0/5] PostgreSQL service improvements In-reply-to: <87lfgl3wb7.fsf@gnu.org> Date: Mon, 19 Oct 2020 22:02:34 +0100 Message-ID: <877drmhqtx.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771 Cc: 43771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> Christopher Baines (5): >> Replace (postgresql-service) with (service postgresql-service-type) >> Add some subheadings in to the Databases section of the docs >> Remove the postgresql-service procedure >> Define postgresql-10 >> Don't specify a default postgresql version to use for the service > > It all LGTM=E2=80=A6 except for commit logs. :-) Please add the convent= ional > subject line and ChangeLog-style entries. I=E2=80=99m sorry to spoil your > Monday morning. :-) I've finally got around now to revising the commit messages and sent some updated patches. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+N/upfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcU3RAArTCjtpRoucDIz5mrgIt8y9qzz3YPX549 WixSNwZP0OJAb6hoaRDB3dOUxYlKHgadU0maPFiD66Uz9tHbZNR7UW9oPx5d2Bh0 OBR9gNk95UMwZBRRojsmKvpvg8zdZu4gcERopjVOKnx/uPuq+oQFacbd8J4ERcGn RL/WBsm9gk9nyp5e7Q+u1RQMHWlREhfiXF/KziC1YsjohaSdgHbV0QI3acQRC2SW XjT5kGe+HZ4SYNmtfc8oAqTYxKS5PpJepa87EhlQOrj775WGJpvkdtPo0TRG8Fb6 6d7ms+XxPh8SRkIcLm7TkqaPf8NKjUjyCWg0I0rANTTfni5Ye/ZdIBW4SWELPGGk dNadEXVWMHLikcQ2w1w52dkOLDKIMMw3QIxlgJwNsIN3dE/XGsVkqzPKX3FPL4rJ zYSYNMPwkp2gBVpl1LuaM8jHnTrutZDx7KeambxFbj0pVbTtOsZr5uK+Yh/GbvgL 8iz6VhcGCQTqnR/mGhGSg0z8h33YudjWXySgnI9yq4gIzBpbnkXRXTARAtwM4o0U upcg6A7MXVW2zj85s1lfg55f7r6riC8tewzngBKi2asbh2lavkmiinQqkpUaRoXa ET0zv0GDA0clHigKGBOJxxlPWVrTLyHVU9iq8HI4qDNMjBtczcKfCKX4ZeeSOIB5 +qH0NuxSzB0= =TOYr -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 17:32:21 2020 Received: (at 43771) by debbugs.gnu.org; 20 Oct 2020 21:32:21 +0000 Received: from localhost ([127.0.0.1]:47055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUzEz-0007ks-8u for submit@debbugs.gnu.org; Tue, 20 Oct 2020 17:32:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUzEx-0007kg-QX for 43771@debbugs.gnu.org; Tue, 20 Oct 2020 17:32:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35913) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUzEs-0006pQ-C6; Tue, 20 Oct 2020 17:32:14 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40480 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUzEr-0004UE-Rk; Tue, 20 Oct 2020 17:32:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#43771] [PATCH 0/5] PostgreSQL service improvements References: <87lfgo1nlv.fsf@cbaines.net> <87lfgl3wb7.fsf@gnu.org> <877drmhqtx.fsf@cbaines.net> Date: Tue, 20 Oct 2020 23:32:12 +0200 In-Reply-To: <877drmhqtx.fsf@cbaines.net> (Christopher Baines's message of "Mon, 19 Oct 2020 22:02:34 +0100") Message-ID: <87d01cbn37.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43771 Cc: 43771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> Christopher Baines (5): >>> Replace (postgresql-service) with (service postgresql-service-type) >>> Add some subheadings in to the Databases section of the docs >>> Remove the postgresql-service procedure >>> Define postgresql-10 >>> Don't specify a default postgresql version to use for the service >> >> It all LGTM=E2=80=A6 except for commit logs. :-) Please add the conven= tional >> subject line and ChangeLog-style entries. I=E2=80=99m sorry to spoil yo= ur >> Monday morning. :-) > > I've finally got around now to revising the commit messages and sent > some updated patches. Perfect, go for it! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 18:41:10 2020 Received: (at 43771-done) by debbugs.gnu.org; 20 Oct 2020 22:41:10 +0000 Received: from localhost ([127.0.0.1]:47128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV0Ja-00011u-9f for submit@debbugs.gnu.org; Tue, 20 Oct 2020 18:41:10 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kV0JY-00011f-Qp for 43771-done@debbugs.gnu.org; Tue, 20 Oct 2020 18:41:09 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id 5A90727BBED; Tue, 20 Oct 2020 23:41:07 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 683df3c4; Tue, 20 Oct 2020 22:41:05 +0000 (UTC) References: <87lfgo1nlv.fsf@cbaines.net> <87lfgl3wb7.fsf@gnu.org> <877drmhqtx.fsf@cbaines.net> <87d01cbn37.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#43771] [PATCH 0/5] PostgreSQL service improvements In-reply-to: <87d01cbn37.fsf@gnu.org> Date: Tue, 20 Oct 2020 23:41:04 +0100 Message-ID: <87sga8h667.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43771-done Cc: 43771-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Christopher Baines skribis: >>> >>>> Christopher Baines (5): >>>> Replace (postgresql-service) with (service postgresql-service-type) >>>> Add some subheadings in to the Databases section of the docs >>>> Remove the postgresql-service procedure >>>> Define postgresql-10 >>>> Don't specify a default postgresql version to use for the service >>> >>> It all LGTM=E2=80=A6 except for commit logs. :-) Please add the conve= ntional >>> subject line and ChangeLog-style entries. I=E2=80=99m sorry to spoil y= our >>> Monday morning. :-) >> >> I've finally got around now to revising the commit messages and sent >> some updated patches. > > Perfect, go for it! Great, I've pushed these as bdcf4d88d58798eca7811c8b1fbd4638168d05c3 now. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+PZ4BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcfhxAAhORREKA8O0subiEo6IhvL7LVgwoxoJu2 9wBXl/R1E+SAGuLERHNrazK8TT3ng40flkM+PY7nvPm9xEZeV8S7O4QmhuyxfKHy b60P65tylO7hgPT7DlwFo9j6yuipzPuTaOp5iAAjGYbapRrA5KOwM+kTlHsHElH6 C/xKEMuEr1uQmsLEg3ZmYF05yj2BjSDMkMMT6k0y6E+0laHDfIqybgMmMWeZB7Hk ayBFoarQRXApiVMRT1MaRw2TCNIX4M4UbDsIBK8tBJd0glIoh4PKsx9vKIxdOZKe HALZAKzgiiaSZni8K/dCJfcRedW/7KTOxzhCPBSGR9AvklQo4gEIzmXC76cQ/2e7 HDr25XNusSJ+ju/VZAhiN9zVdoG66WQCOsDUL/148WijL6HckdS/bgKVIRglTsiC uD4i25LpClLu6AMT9KvBX3YfufDUeBHpVopQFog2BH0GHOx8fX7VYYjZSBTJ03qO ugpVFqA9PY5HLglJzQQy/VsJK/npYyPxLxcfwv99ydY95Bh5BLJ58bGJ9wj71fwt giJrkZA0ME49aOb+QwpceFAtZfqxU7MK7ZDsfz/URl3dORe02SIpk/4xavhgj2iB rQviOWKLlFmBx6WWOok0O5u6J2+NZVqhRIXLNXXwSFsxzhzehhcp0kRxb2MBfVY5 oCk1D18vWk4= =g8Pv -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 00:53:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator