GNU bug report logs - #43769
[PATCH 0/2] guix-install.sh: Minor first user-experience tweaks

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Fri, 2 Oct 2020 17:36:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 43769 <at> debbugs.gnu.org
Subject: [bug#43769] [PATCH v2 2/2] guix-install.sh: Check the service 'nscd' and suggest it.
Date: Sat, 03 Oct 2020 21:14:53 +0200
[Message part 1 (text/plain, inline)]
Zimoun,

zimoun 写道:
> * etc/guix-install.sh (chk_sys_nscd): New function to check if 
> the service
> 'nscd is running, otherwise suggest to install 
> distribution-wide.

If we must have a new interactive prompt in this series, this 
seems like the better place: we know enough about the host (init) 
system to auto-enable nscd on most of them, if the user so wishes.

>  main()
>  {
> -    local tmp_path
> -    welcome
> +    # local tmp_path
> +    # welcome
> +
> +    # _msg "Starting installation ($(date))"
>  
> -    _msg "Starting installation ($(date))"
> +    # chk_term
> +    # chk_require "${REQUIRE[@]}"
> +    # chk_gpg_keyring
> +    # chk_init_sys
> +    # chk_sys_arch
>  
> -    chk_term
> -    chk_require "${REQUIRE[@]}"
> -    chk_gpg_keyring
> -    chk_init_sys
> -    chk_sys_arch
> +    # _msg "${INF}system is ${ARCH_OS}"
>  
> -    _msg "${INF}system is ${ARCH_OS}"
> +    # umask 0022
> +    # tmp_path="$(mktemp -t -d guix.XXX)"
>  
> -    umask 0022
> -    tmp_path="$(mktemp -t -d guix.XXX)"
> +    # guix_get_bin_list "${GNU_URL}"
> +    # guix_get_bin "${GNU_URL}" "${BIN_VER}" "$tmp_path"
>  
> -    guix_get_bin_list "${GNU_URL}"
> -    guix_get_bin "${GNU_URL}" "${BIN_VER}" "$tmp_path"
> +    # sys_create_store "${BIN_VER}.tar.xz" "${tmp_path}"
> +    # sys_create_build_user
> +    # sys_enable_guix_daemon
> +    # sys_authorize_build_farms
> +    # sys_create_init_profile
> +    # sys_create_shell_completion
>  
> -    sys_create_store "${BIN_VER}.tar.xz" "${tmp_path}"
> -    sys_create_build_user
> -    sys_enable_guix_daemon
> -    sys_authorize_build_farms
> -    sys_create_init_profile
> -    sys_create_shell_completion
> +    # _msg "${INF}cleaning up ${tmp_path}"
> +    # rm -r "${tmp_path}"
>  
> -    _msg "${INF}cleaning up ${tmp_path}"
> -    rm -r "${tmp_path}"
> +    chk_sys_nscd
>  
> -    _msg "${PAS}Guix has successfully been installed!"
> -    _msg "${INF}Run 'info guix' to read the manual."
> +    # _msg "${PAS}Guix has successfully been installed!"
> +    # _msg "${INF}Run 'info guix' to read the manual."
>  
> -    # Required to source /etc/profile in desktop environments.
> -    _msg "${INF}Please log out and back in to complete the 
> installation."
> +    # # Required to source /etc/profile in desktop 
> environments.
> +    # _msg "${INF}Please log out and back in to complete the 
> installation."
>   }

?

Debugging left-overs?

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 278 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.