GNU bug report logs - #43769
[PATCH 0/2] guix-install.sh: Minor first user-experience tweaks

Previous Next

Full log

View this message in rfc822 format

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 43769 <at> debbugs.gnu.org
Subject: [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions.
Date: Sat, 03 Oct 2020 21:11:26 +0200

[Message part 1 (text/plain, inline)]

Zimoun,

Thanks!  Shell code always looks ugly to me, so LGTM if it works 
:-)

Nitpick: s/create/install/

zimoun 写道：
> +            [Nn]*) _msg "${INF}Skipped shell completion 
> installation"
> +                   break;;
> +            *) _msg "Please answer yes or no.";

Why bother the user with this?  We don't ask before installing 
/etc/profile.d/guix.sh, or enabling the daemon, and we shouldn't 
offer similar meaningless choices just for the sake of it.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.