Subject: Re: [bug#43769] [PATCH v2 1/2] guix-install.sh: Add symbolic links for supported shell completions.

From: Tobias Geerinckx-Rice <[email-masked]>
Date: Sat, 03 Oct 2020 21:11:26 +0200

Zimoun,

Thanks!  Shell code always looks ugly to me, so LGTM if it works 
:-)

Nitpick: s/create/install/

zimoun 写道：
> +            [Nn]*) _msg "${INF}Skipped shell completion 
> installation"
> +                   break;;
> +            *) _msg "Please answer yes or no.";

Why bother the user with this?  We don't ask before installing 
/etc/profile.d/guix.sh, or enabling the daemon, and we shouldn't 
offer similar meaningless choices just for the sake of it.

Kind regards,

T G-R