From unknown Sun Jun 22 00:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Oct 2020 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 43746@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160156272114549 (code B ref -1); Thu, 01 Oct 2020 14:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Oct 2020 14:32:01 +0000 Received: from localhost ([127.0.0.1]:37864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcn-0003mX-2h for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:49176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcl-0003mO-6T for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzck-00023s-Vj for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.de ([5.45.111.108]:51966 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzcg-0000qn-U0 for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6999736057E for ; Thu, 1 Oct 2020 16:31:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601562709; bh=67taK1yvUJJUD/TrnTLVygm6DRSgh3egLmvFMUVftuM=; h=Date:From:To:Subject; b=MFi3/C7vjSWIFJQylyHoWSrVasQ/4yZOZ1CatZ3o8EjJDXhEhKg3FjS7wUrOV3q7c DUhM2xdT8rJP7QetHFLw5XSSbuOG7d7FDvhromt9xfgo8Y5gx0/FZKsABZuhhKw2FR AQMQjndcgr6zb2CHvuS9XMTpeTxItVX1CslP1x5U= Date: Thu, 1 Oct 2020 16:31:36 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="cub5r7pcqwkxe55n" Content-Disposition: inline Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 10:31:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The new package transformation option --without-tests works by setting #:tests? #f in the specified packages. But some packages replace their 'check phase and no longer honor #tests?. glib for example. Attached is an attempt to document this current behavior. Shall I push it? Alternatively, it should be documented to write a check phase that honors #:tests?. Or the package transformation should be changed to remove any check phase it finds. Regards, Florian --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-doc-Explain-why-without-tests-may-fail-with-modified.patch" >From b55e6ee01fe674b282e7ec75d0e4c8a839262261 Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Thu, 1 Oct 2020 15:35:52 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] doc: Explain why '--without-tests' may fail with modified 'check' phase. * doc/guix.texi (Package Transformation Options): Explain. --- doc/guix.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index e8458ad8d8..6a2bd629cb 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9350,6 +9350,12 @@ The command above installs @code{python-notebook} on top of rebuilds everything that depends on @code{python}, including @code{python-notebook} itself. +Internally, @code{--without-tests} relies on changing the +@code{#:tests?} option of a package's @code{check} phase (@pxref{Build +Systems}). Note that some packages use a customized @code{check} phase +that does not respect a @code{#:tests? #f} setting. Therefore there are +some packages for which @code{--without-tests} cannot disable tests. + @end table @node Additional Build Options -- 2.28.0 --cub5r7pcqwkxe55n-- From unknown Sun Jun 22 00:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 01 Oct 2020 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "pelzflorian (Florian Pelz)" Cc: 43746@debbugs.gnu.org Received: via spool by 43746-submit@debbugs.gnu.org id=B43746.16015864844944 (code B ref 43746); Thu, 01 Oct 2020 21:09:02 +0000 Received: (at 43746) by debbugs.gnu.org; 1 Oct 2020 21:08:04 +0000 Received: from localhost ([127.0.0.1]:38579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO5o3-0001Hg-Ph for submit@debbugs.gnu.org; Thu, 01 Oct 2020 17:08:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO5o1-0001HD-HG for 43746@debbugs.gnu.org; Thu, 01 Oct 2020 17:08:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO5nw-000651-8d; Thu, 01 Oct 2020 17:07:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52582 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kO5nv-00045I-Sk; Thu, 01 Oct 2020 17:07:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> Date: Thu, 01 Oct 2020 23:07:54 +0200 In-Reply-To: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Thu, 1 Oct 2020 16:31:36 +0200") Message-ID: <87d021mz85.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > The new package transformation option --without-tests works by setting > #:tests? #f in the specified packages. But some packages replace > their 'check phase and no longer honor #tests?. glib for example. Oh, we should fix =E2=80=98glib=E2=80=99 in =E2=80=98core-updates=E2=80=99. > Attached is an attempt to document this current behavior. Shall I > push it? Alternatively, it should be documented to write a check > phase that honors #:tests?. Or the package transformation should be > changed to remove any check phase it finds. Hmm not sure, I think fiddling with phases is more risky or at least could lead to more obscure errors for example with build systems that don=E2=80=99t support phases, like =E2=80=98trivial-build-system=E2=80=99. I=E2=80=99m inclined to apply the patch you propose and leaving phases unchanged. >>>From b55e6ee01fe674b282e7ec75d0e4c8a839262261 Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Thu, 1 Oct 2020 15:35:52 +0200 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > Subject: [PATCH] doc: Explain why '--without-tests' may fail with modified > 'check' phase. > > * doc/guix.texi (Package Transformation Options): Explain. [...] > +Internally, @code{--without-tests} relies on changing the > +@code{#:tests?} option of a package's @code{check} phase (@pxref{Build > +Systems}). Note that some packages use a customized @code{check} phase > +that does not respect a @code{#:tests? #f} setting. Therefore there are > +some packages for which @code{--without-tests} cannot disable tests. I=E2=80=99d change the last sentence to: Therefore, @option{--without-tests} has no effect on these packages. Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 00:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 02 Oct 2020 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43746@debbugs.gnu.org Received: via spool by 43746-submit@debbugs.gnu.org id=B43746.16016789168668 (code B ref 43746); Fri, 02 Oct 2020 22:49:01 +0000 Received: (at 43746) by debbugs.gnu.org; 2 Oct 2020 22:48:36 +0000 Received: from localhost ([127.0.0.1]:42713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOTqu-0002Fj-3e for submit@debbugs.gnu.org; Fri, 02 Oct 2020 18:48:36 -0400 Received: from pelzflorian.de ([5.45.111.108]:48452 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOTqq-0002Fa-RX for 43746@debbugs.gnu.org; Fri, 02 Oct 2020 18:48:35 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 374C736057E; Sat, 3 Oct 2020 00:48:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601678911; bh=RHgnNjWt3UfQoDiqIkvoyVNfxY/YcpwKuWrl2yXXYWE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=qwVNXZP3aOqlgWZrm21UgWQCvc+FYFT5C2ABPjYH0ziJTX9tWSx+MNYP7gK9A5ORO LVeO2vRFemMWM45NqQGezavqKAUsUoqIC8zqB3kzJLAxRB7QKHbEWLnkyeOxbz1IA0 5FwDZRcR6QGagmxL8Xa0FUn4YLtnT3B54831OScE= Date: Sat, 3 Oct 2020 00:48:21 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> <87d021mz85.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="4adkinx4atnqgcuo" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d021mz85.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --4adkinx4atnqgcuo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Oct 01, 2020 at 11:07:54PM +0200, Ludovic Courtès wrote: > Oh, we should fix ‘glib’ in ‘core-updates’. I verified the attached patch fixes glib on the ‘master’ branch. I’m not sure about adding a copyright. Anyway. Shall I push it to ‘core-updates’ or wait until I can test it on ‘core-updates’ without rebuilding the world? > I’m inclined to apply the patch you propose and leaving phases > unchanged. > […] > I’d change the last sentence to: > > Therefore, @option{--without-tests} has no effect on these packages. I changed it and pushed the patch to the documentation as 3c01fcc1bb9c086f487d9694cb91a57d7abd0880. Thank you! (I maybe should have written in the commit message “Fixes .” Oh well. I will leave the bug open though because glib is not fixed yet.) Regards, Florian --4adkinx4atnqgcuo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-glib-Adhere-to-without-tests-option.patch" Content-Transfer-Encoding: 8bit >From 505cfd0fa3411a21c8794ab84473dc1dd2b8754c Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sat, 3 Oct 2020 00:29:56 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] gnu: glib: Adhere to '--without-tests' option. * gnu/packages/glib.scm (glib)[arguments]<#:phases>[configure]: Only run tests if 'tests?' is true. --- gnu/packages/glib.scm | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm index ca037d3b24..c703894155 100644 --- a/gnu/packages/glib.scm +++ b/gnu/packages/glib.scm @@ -13,6 +13,7 @@ ;;; Copyright 2019 Giacomo Leidi ;;; Copyright 2019, 2020 Marius Bakke ;;; Copyright 2020 Nicol Balzarotti +;;; Copyright 2020 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -325,11 +326,14 @@ shared NFS home directories.") (for-each (lambda (x) (apply disable x)) failing-tests) #t))) (replace 'check - (lambda _ - (setenv "MESON_TESTTHREADS" - (number->string (parallel-job-count))) - ;; Do not run tests marked as "flaky". - (invoke "meson" "test" "--no-suite" "flaky"))) + (lambda* (#:key tests? #:allow-other-keys) + (if tests? + (begin + (setenv "MESON_TESTTHREADS" + (number->string (parallel-job-count))) + ;; Do not run tests marked as "flaky". + (invoke "meson" "test" "--no-suite" "flaky")) + #t))) ;; TODO: meson does not permit the bindir to be outside of prefix. ;; See https://github.com/mesonbuild/meson/issues/2561 ;; We can remove this once meson is patched. -- 2.28.0 --4adkinx4atnqgcuo-- From unknown Sun Jun 22 00:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 03 Oct 2020 10:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "pelzflorian (Florian Pelz)" Cc: 43746@debbugs.gnu.org Received: via spool by 43746-submit@debbugs.gnu.org id=B43746.160171948613774 (code B ref 43746); Sat, 03 Oct 2020 10:05:01 +0000 Received: (at 43746) by debbugs.gnu.org; 3 Oct 2020 10:04:46 +0000 Received: from localhost ([127.0.0.1]:43004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOePF-0003a6-Bz for submit@debbugs.gnu.org; Sat, 03 Oct 2020 06:04:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOePE-0003Zs-EN for 43746@debbugs.gnu.org; Sat, 03 Oct 2020 06:04:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52332) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOeP8-00038R-Sf; Sat, 03 Oct 2020 06:04:39 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43988 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kOeP8-0001mh-9Q; Sat, 03 Oct 2020 06:04:38 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> <87d021mz85.fsf@gnu.org> <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?UTF-8?Q?Vend=C3=A9miaire?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 03 Oct 2020 12:04:37 +0200 In-Reply-To: <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sat, 3 Oct 2020 00:48:21 +0200") Message-ID: <87y2knfwwa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > On Thu, Oct 01, 2020 at 11:07:54PM +0200, Ludovic Court=C3=A8s wrote: >> Oh, we should fix =E2=80=98glib=E2=80=99 in =E2=80=98core-updates=E2=80= =99. > > I verified the attached patch fixes glib on the =E2=80=98master=E2=80=99 = branch. I=E2=80=99m > not sure about adding a copyright. Anyway. Shall I push it to > =E2=80=98core-updates=E2=80=99 or wait until I can test it on =E2=80=98co= re-updates=E2=80=99 without > rebuilding the world? If you tested it on =E2=80=98master=E2=80=99, you can push it on =E2=80=98c= ore-updates=E2=80=99. > I changed it and pushed the patch to the documentation as > 3c01fcc1bb9c086f487d9694cb91a57d7abd0880. Thank you! Great! > (I maybe should have written in the commit message =E2=80=9CFixes > .=E2=80=9D Oh well. I will leave the bug op= en > though because glib is not fixed yet.) That=E2=80=99s OK. :-) > From 505cfd0fa3411a21c8794ab84473dc1dd2b8754c Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Sat, 3 Oct 2020 00:29:56 +0200 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > Subject: [PATCH] gnu: glib: Adhere to '--without-tests' option. > > * gnu/packages/glib.scm (glib)[arguments]<#:phases>[configure]: > Only run tests if 'tests?' is true. OK for =E2=80=98core-updates=E2=80=99, thank you! Ludo=E2=80=99. From unknown Sun Jun 22 00:53:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "pelzflorian (Florian Pelz)" Subject: bug#43746: closed (Re: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting) Message-ID: References: <20201003110347.w6ojpcjlui7okfyw@pelzflorian.localdomain> <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> X-Gnu-PR-Message: they-closed 43746 X-Gnu-PR-Package: guix Reply-To: 43746@debbugs.gnu.org Date: Sat, 03 Oct 2020 11:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1601723102-19828-1" This is a multi-part message in MIME format... ------------=_1601723102-19828-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #43746: What to do about packages that don't support --without-tests / #:te= sts? #f setting which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 43746@debbugs.gnu.org. --=20 43746: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43746 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1601723102-19828-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 43746-done) by debbugs.gnu.org; 3 Oct 2020 11:04:02 +0000 Received: from localhost ([127.0.0.1]:43055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOfKb-00058P-Nh for submit@debbugs.gnu.org; Sat, 03 Oct 2020 07:04:01 -0400 Received: from pelzflorian.de ([5.45.111.108]:49094 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOfKY-000584-6o for 43746-done@debbugs.gnu.org; Sat, 03 Oct 2020 07:03:59 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id DA11B3605A1; Sat, 3 Oct 2020 13:03:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601723036; bh=mXa59vq0xRxXgUbyO6/f2XB21+1FpQe5ARrlfJA0Zj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=nUlc4vf1poHzLdBo50GYq9rtMsOXcmjnqNGm+/vp1YegBqqEgroV2nkrnWvD0iniB WwAl2xrRp4KdjFACTNkbeWsGKNOt4baLPX/fu6SBCJlUj2IjZAhHRg/alfZRzN7l+9 gWGI5AZ4CBBNbS2V2xSN9pyxAykLLP6jv1ZvFqA8= Date: Sat, 3 Oct 2020 13:03:47 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting Message-ID: <20201003110347.w6ojpcjlui7okfyw@pelzflorian.localdomain> References: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> <87d021mz85.fsf@gnu.org> <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> <87y2knfwwa.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y2knfwwa.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43746-done Cc: 43746-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Oct 03, 2020 at 12:04:37PM +0200, Ludovic Courtès wrote: > > I verified the attached patch fixes glib on the ‘master’ branch. > If you tested it on ‘master’, you can push it on ‘core-updates’. Pushed as 0585a0d0d1fe6e334d36e2d851b42b47d6769546. Thank you! Closing, since the issue is documented now and fixing *all* other check phases is generally not worth it. Regards, Florian ------------=_1601723102-19828-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Oct 2020 14:32:01 +0000 Received: from localhost ([127.0.0.1]:37864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcn-0003mX-2h for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:49176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNzcl-0003mO-6T for submit@debbugs.gnu.org; Thu, 01 Oct 2020 10:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzck-00023s-Vj for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.de ([5.45.111.108]:51966 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNzcg-0000qn-U0 for bug-guix@gnu.org; Thu, 01 Oct 2020 10:31:58 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6999736057E for ; Thu, 1 Oct 2020 16:31:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1601562709; bh=67taK1yvUJJUD/TrnTLVygm6DRSgh3egLmvFMUVftuM=; h=Date:From:To:Subject; b=MFi3/C7vjSWIFJQylyHoWSrVasQ/4yZOZ1CatZ3o8EjJDXhEhKg3FjS7wUrOV3q7c DUhM2xdT8rJP7QetHFLw5XSSbuOG7d7FDvhromt9xfgo8Y5gx0/FZKsABZuhhKw2FR AQMQjndcgr6zb2CHvuS9XMTpeTxItVX1CslP1x5U= Date: Thu, 1 Oct 2020 16:31:36 +0200 From: "pelzflorian (Florian Pelz)" To: bug-guix@gnu.org Subject: What to do about packages that don't support --without-tests / #:tests? #f setting Message-ID: <20201001143136.mu224kslmtpj4std@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="cub5r7pcqwkxe55n" Content-Disposition: inline Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/01 10:31:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The new package transformation option --without-tests works by setting #:tests? #f in the specified packages. But some packages replace their 'check phase and no longer honor #tests?. glib for example. Attached is an attempt to document this current behavior. Shall I push it? Alternatively, it should be documented to write a check phase that honors #:tests?. Or the package transformation should be changed to remove any check phase it finds. Regards, Florian --cub5r7pcqwkxe55n Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-doc-Explain-why-without-tests-may-fail-with-modified.patch" >From b55e6ee01fe674b282e7ec75d0e4c8a839262261 Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Thu, 1 Oct 2020 15:35:52 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [PATCH] doc: Explain why '--without-tests' may fail with modified 'check' phase. * doc/guix.texi (Package Transformation Options): Explain. --- doc/guix.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index e8458ad8d8..6a2bd629cb 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9350,6 +9350,12 @@ The command above installs @code{python-notebook} on top of rebuilds everything that depends on @code{python}, including @code{python-notebook} itself. +Internally, @code{--without-tests} relies on changing the +@code{#:tests?} option of a package's @code{check} phase (@pxref{Build +Systems}). Note that some packages use a customized @code{check} phase +that does not respect a @code{#:tests? #f} setting. Therefore there are +some packages for which @code{--without-tests} cannot disable tests. + @end table @node Additional Build Options -- 2.28.0 --cub5r7pcqwkxe55n-- ------------=_1601723102-19828-1--