GNU bug report logs - #43743
[PATCH] Add package emacs-windsize

Previous Next

Package: guix-patches;

Reported by: Tomás Ortín Fernández <tomasortin <at> mailbox.org>

Date: Thu, 1 Oct 2020 12:35:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43743 in the body.
You can then email your comments to 43743 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#43743; Package guix-patches. (Thu, 01 Oct 2020 12:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tomás Ortín Fernández <tomasortin <at> mailbox.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 01 Oct 2020 12:35:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomás Ortín Fernández <tomasortin <at> mailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add package emacs-windsize
Date: Thu, 1 Oct 2020 14:23:11 +0200
Add windsize.el Emacs package

* gnu/packages/emacs-xyz.scm (emacs-windsize): Add package definition.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2b3247f763..e2397bdc85 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -80,6 +80,7 @@
 ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
 ;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24754,3 +24755,24 @@ web development.")
       ;; file and the header of the main elisp file which indicates
       ;; that it is licensed under the GPL version 3 or later.
       (license (list license:mpl2.0 license:gpl3+)))))
+
+(define-public emacs-windsize
+  (package
+    (name "emacs-windsize")
+    (version "20181029")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/grammati/windsize")
+                    (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa")))
+              (sha256
+               (base32
+                "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/grammati/windsize")
+    (synopsis "Easy resizing of emacs windows")
+    (description "Move the borders of the active window with the arrow
+keys (C-S-<dir> by default).  Always prefers to move the right or
+bottom border when possible, and falls back to moving the left or top
+border otherwise.")
+    (license license:gpl3+)))




Information forwarded to guix-patches <at> gnu.org:
bug#43743; Package guix-patches. (Sun, 04 Oct 2020 09:41:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tomás Ortín Fernández via Guix-patches via
 <guix-patches <at> gnu.org>
Cc: 43743 <at> debbugs.gnu.org,
 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
Subject: Re: [bug#43743] [PATCH] Add package emacs-windsize
Date: Sun, 04 Oct 2020 11:40:43 +0200
Hello,

Tomás Ortín Fernández via Guix-patches via <guix-patches <at> gnu.org>
writes:

> Add windsize.el Emacs package

Thank you. Somme comments follow.

> +    (version "20181029")

This is not the official release number. This should be "0.1", with an
appropriate revision number since you're not using the release tag. Also
there should be a comment explaining why you're not using that release
tag (almost 10 years old here).

See, for example, emacs-dhall-mode package.

> +    (source (origin

Please move origin below source.

> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/grammati/windsize")
> +                    (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa")))

The commit should be bound to a variable at the top of the package
definition.

> +              (sha256
> +               (base32
> +                "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))

Nitpick: Please move the hash on the same line as base32

> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/grammati/windsize")
> +    (synopsis "Easy resizing of emacs windows")

-> Emacs windows

> +    (description "Move the borders of the active window with the arrow
> +keys (C-S-<dir> by default).  Always prefers to move the right or
> +bottom border when possible, and falls back to moving the left or top
> +border otherwise.")

I suggest to use non-imperative wording, e.g., This package allows
moving... It always prefers…

I also suggest to remove the reference to (C-S-<dir> ...) since it
belongs to the documentation of the package, not to its description.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#43743; Package guix-patches. (Sun, 04 Oct 2020 09:42:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#43743; Package guix-patches. (Sun, 04 Oct 2020 15:00:02 GMT) Full text and rfc822 format available.

Message #14 received at 43743 <at> debbugs.gnu.org (full text, mbox):

From: Tomás Ortín Fernández <tomasortin <at> mailbox.org>
To: 43743 <at> debbugs.gnu.org
Subject: Re: [bug#43743] [PATCH] Add package emacs-windsize
Date: Sun, 4 Oct 2020 16:58:58 +0200
Thank you for the feedback. Here is the updated patch:

* gnu/packages/emacs-xyz.scm (emacs-windsize): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3ec431d94..c158aa22e5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -80,6 +80,7 @@
 ;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
 ;;; Copyright © 2020 Niklas Eklund <niklas.eklund <at> posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98 <at> protonmail.com>
+;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin <at> mailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24778,3 +24779,27 @@ web development.")
       ;; file and the header of the main elisp file which indicates
       ;; that it is licensed under the GPL version 3 or later.
       (license (list license:mpl2.0 license:gpl3+)))))
+
+(define-public emacs-windsize
+  ;; There is no proper release.  The base version is extracted from the
+  ;; "Version" keyword in the main file.
+  (let ((revision "1")
+	 (commit "62c2846bbe95b0a73e996c75e4a644d05f57aaaa"))
+    (package
+      (name "emacs-windsize")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/grammati/windsize")
+               (commit commit)))
+         (sha256
+          (base32 "13kfrmv3vmkfanxv9nym5v43hx5p7xkgqmx65zcxh4gcbaham1mi"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/grammati/windsize")
+      (synopsis "Easy resizing of Emacs windows")
+      (description "This package allows moving the borders of the active window
+with the arrow keys.  It prefers to move the right or bottom border when
+possible, and falls back to moving the left or top border otherwise.")
+      (license license:gpl3+))))




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Wed, 07 Oct 2020 19:56:02 GMT) Full text and rfc822 format available.

Notification sent to Tomás Ortín Fernández <tomasortin <at> mailbox.org>:
bug acknowledged by developer. (Wed, 07 Oct 2020 19:56:02 GMT) Full text and rfc822 format available.

Message #19 received at 43743-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tomás Ortín Fernández <tomasortin <at> mailbox.org>
Cc: 43743-done <at> debbugs.gnu.org
Subject: Re: [bug#43743] [PATCH] Add package emacs-windsize
Date: Wed, 07 Oct 2020 21:54:54 +0200
Hello,

Tomás Ortín Fernández <tomasortin <at> mailbox.org> writes:

> Thank you for the feedback. Here is the updated patch:
>
> * gnu/packages/emacs-xyz.scm (emacs-windsize): New variable.

I moved the package definition elsewhere (the bottom of the file can
lead to merge conflicts) and applied your patch.

Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 Nov 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 285 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.