GNU bug report logs - #4374
find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4374 in the body.
You can then email your comments to 4374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: hans bennekop <ylphcm <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: find-file-at-point doesn't recognize absolute file paths with trailing
 line numbers. (Patch included.)
Date: Tue, 08 Sep 2009 16:42:29 +0200

I frequently run across absolute file paths with a trailing line-number 
  specification, e.g. ~/foo.el:7.
Find-file-at-point fails to recognize the file part and falls back to 
opening the parent dir.
Here's the (trivial) fix:
--- emacs-23/lisp/ffap.el
+++ emacs-23/lisp/ffap-fix.el
@@ -1170,7 +1170,7 @@
          ;; remote, you probably already have a connection.
          ((and (not abs) (ffap-file-exists-string name)))
          ;; Try stripping off line numbers; good for compilation/grep 
output.
-         ((and (not abs) (string-match ":[0-9]" name)
+         ((and (string-match ":[0-9]" name)
                (ffap-file-exists-string (substring name 0 
(match-beginning 0)))))
          ;; Try stripping off prominent (non-root - #) shell prompts
 	 ;; if the ffap-shell-prompt-regexp is non-nil.

Message #10 received at 4374-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 4374-done <at> debbugs.gnu.org
Subject: Re: bug#4374: find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.)
Date: Tue, 08 Sep 2009 22:36:42 -0400

hans bennekop wrote:

> I frequently run across absolute file paths with a trailing line-number 
>   specification, e.g. ~/foo.el:7.
> Find-file-at-point fails to recognize the file part and falls back to 
> opening the parent dir.

(I guess path-separator is not ":" on your platform, since if it is
this seems to work for me.)

> Here's the (trivial) fix:

I installed something similar.

Message #15 received at 4374 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: hans bennekop <ylphcm <at> googlemail.com>
Cc: 4374 <at> debbugs.gnu.org
Subject: Re: bug#4374: find-file-at-point doesn't recognize absolute file paths with trailing line numbers. (Patch included.)
Date: Wed, 09 Sep 2009 03:54:17 +0300

> I frequently run across absolute file paths with a trailing line-number
> specification, e.g. ~/foo.el:7.
> Find-file-at-point fails to recognize the file part and falls back to
> opening the parent dir.

The part after the colon already gets removed by the following rule:

	 ;; If it contains a colon, get rid of it (and return if exists)
	 ((and (string-match path-separator name)
	       (setq name (ffap-string-at-point 'nocolon))
	       (ffap-file-exists-string name)))

I wonder what the value of `path-separator' do you have?  Is it a colon?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: hans bennekop <ylphcm <at> googlemail.com>
To: juri <at> jurta.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: bug#4374: find-file-at-point doesn't recognize absolute file paths
 with trailing line numbers. (Patch included.)
Date: Wed, 09 Sep 2009 08:24:20 +0200

> I wonder what the value of `path-separator' do you have?  Is it a colon?
Oh, I didn't see that part. It's a semicolon (Windows).
Since I don't know of any relevant OS where colons are permitted in a 
path, I'd vote for explicitly handling them to allow for compatibility 
with Unix style paths.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.