GNU bug report logs -
#43715
28.0.50; Duplicate results in project-find-regexp
Previous Next
Reported by: Pankaj Jangid <pankaj <at> codeisgreat.org>
Date: Wed, 30 Sep 2020 07:02:02 UTC
Severity: normal
Merged with 36967
Found in versions 27.0.50, 28.0.50
Fixed in version 28.1
Done: Dmitry Gutov <dgutov <at> yandex.ru>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
On 01.10.2020 04:15, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
>
>> The behavior is less than ideal, but the fix will have to satisfy
>> multiple constraints: the xref item creation (taking care of the
>> format being backward-compatible), the rendering of them in the
>> buffer, and the 'xref-query-replace-in-results' command, the
>> implementation of which relies on the one-line-per-match property of
>> an xref buffer.
>
> Right. I know next to nothing about xref internals... but... couldn't
> this function just squash the multiple-matches-on-a-single-line into one
> line? Preserving the text props from the multiple lines and whatnot?
> So a post-processing step?
Which function?
xref-query-replace-in-results works on an existing xref buffer. And it
uses the position of point (at the beginning of line) as both user
indicator and to persist the state of the replacement process.
Going back to xref buffers, if two matches are rendered on one line,
that leads to a question of how 'n' and 'p' should behave (whether they
would also jump between the matches on the same line).
This bug report was last modified 4 years and 211 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.